On Mon, 2010-10-18 at 17:46 +0800, tiejun.chen wrote:
>
> >>> Looks you always iounmap(fsl_lbc_ctrl_dev->regs) on position 'err' but
> >>> here
> >>> of_iomap() is already failed you should skip iounmap()
> >>> fsl_lbc_ctrl_dev->regs
> >>> again. So you should improve that as the following on 'e
bs.org; a...@linux-foundation.org;
> dw...@infradead.org; Gala Kumar-B11780
> Subject: Re: [PATCH 1/2] P4080/eLBC: Make Freescale elbc interrupt
common to
> elbc devices
>
>
> On Oct 20, 2010, at 12:12 AM, Zang Roy-R61911 wrote:
>
> >
> >
> >> -Original Message-
t-B07421;
> dedeki...@gmail.com; Lan
>> Chunhe-B25806; linuxppc-...@ozlabs.org; a...@linux-foundation.org;
>> dw...@infradead.org; Gala Kumar-B11780
>> Subject: Re: [PATCH 1/2] P4080/eLBC: Make Freescale elbc interrupt
> common to
>> elbc devices
>>
>>
nux-foundation.org;
> dw...@infradead.org; Gala Kumar-B11780
> Subject: Re: [PATCH 1/2] P4080/eLBC: Make Freescale elbc interrupt
common to
> elbc devices
>
>
> On Oct 18, 2010, at 2:22 AM, Roy Zang wrote:
>
> > Move Freescale elbc interrupt from nand dirver to elbc
On Oct 18, 2010, at 2:22 AM, Roy Zang wrote:
> Move Freescale elbc interrupt from nand dirver to elbc driver.
> Then all elbc devices can use the interrupt instead of ONLY nand.
>
> For former nand driver, it had the two functions:
>
> 1. detecting nand flash partitions;
> 2. registering elbc i
t; foundation.org; dw...@infradead.org; Gala Kumar-B11780
> Subject: Re: [PATCH 1/2] P4080/eLBC: Make Freescale elbc interrupt
common to
> elbc devices
>
> On Mon, 18 Oct 2010 16:55:49 +0800
> "tiejun.chen" wrote:
>
> > Looks you always iounmap(fsl_lbc_ctrl_dev->regs) o
Scott Wood wrote:
> On Mon, 18 Oct 2010 16:55:49 +0800
> "tiejun.chen" wrote:
>
>> Looks you always iounmap(fsl_lbc_ctrl_dev->regs) on position 'err' but here
>> of_iomap() is already failed you should skip iounmap() fsl_lbc_ctrl_dev->regs
>> again. So you should improve that as the following on
On Mon, 18 Oct 2010 16:55:49 +0800
"tiejun.chen" wrote:
> Looks you always iounmap(fsl_lbc_ctrl_dev->regs) on position 'err' but here
> of_iomap() is already failed you should skip iounmap() fsl_lbc_ctrl_dev->regs
> again. So you should improve that as the following on 'err', or layout 'err'
> i
B07421; dedeki...@gmail.com;
>>> Lan
>>> Chunhe-B25806; linuxppc-...@ozlabs.org; a...@linux-foundation.org;
>>> dw...@infradead.org; Gala Kumar-B11780
>>> Subject: Re: [PATCH 1/2] P4080/eLBC: Make Freescale elbc interrupt common to
>>> elbc devic
>> Lan
>> Chunhe-B25806; linuxppc-...@ozlabs.org; a...@linux-foundation.org;
>> dw...@infradead.org; Gala Kumar-B11780
>> Subject: Re: [PATCH 1/2] P4080/eLBC: Make Freescale elbc interrupt common to
>> elbc devices
>>
>> Roy Zang wrote:
>>> Move Freescale e
nux-foundation.org;
> dw...@infradead.org; Gala Kumar-B11780
> Subject: Re: [PATCH 1/2] P4080/eLBC: Make Freescale elbc interrupt common to
> elbc devices
>
> Roy Zang wrote:
> > Move Freescale elbc interrupt from nand dirver to elbc driver.
> > Then all elbc devic
Roy Zang wrote:
> Move Freescale elbc interrupt from nand dirver to elbc driver.
> Then all elbc devices can use the interrupt instead of ONLY nand.
>
> For former nand driver, it had the two functions:
>
> 1. detecting nand flash partitions;
> 2. registering elbc interrupt.
>
> Now, second func
Move Freescale elbc interrupt from nand dirver to elbc driver.
Then all elbc devices can use the interrupt instead of ONLY nand.
For former nand driver, it had the two functions:
1. detecting nand flash partitions;
2. registering elbc interrupt.
Now, second function is removed to fsl_lbc.c.
Sig
13 matches
Mail list logo
