> -----Original Message----- > From: Wood Scott-B07421 > Sent: Tuesday, October 19, 2010 0:07 AM > To: tiejun.chen > Cc: Zang Roy-R61911; linux-...@lists.infradead.org; Wood Scott-B07421; > dedeki...@gmail.com; Lan Chunhe-B25806; linuxppc-...@ozlabs.org; a...@linux- > foundation.org; dw...@infradead.org; Gala Kumar-B11780 > Subject: Re: [PATCH 1/2] P4080/eLBC: Make Freescale elbc interrupt common to > elbc devices > > On Mon, 18 Oct 2010 16:55:49 +0800 > "tiejun.chen" <tiejun.c...@windriver.com> wrote: > > > Looks you always iounmap(fsl_lbc_ctrl_dev->regs) on position 'err' but here > > of_iomap() is already failed you should skip iounmap() fsl_lbc_ctrl_dev- > >regs > > again. So you should improve that as the following on 'err', or layout 'err' > in > > gain. > > ------ > > if(fsl_lbc_ctrl_dev->regs) > > iounmap(fsl_lbc_ctrl_dev->regs); > > > > It looks like iounmap(NULL) is a no-op, just like kfree(NULL). Thanks for the reminder. I will keep original post, if there is no more comment. Roy
_______________________________________________ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev
