Scott Wood wrote: > On Mon, 18 Oct 2010 16:55:49 +0800 > "tiejun.chen" <tiejun.c...@windriver.com> wrote: > >> Looks you always iounmap(fsl_lbc_ctrl_dev->regs) on position 'err' but here >> of_iomap() is already failed you should skip iounmap() fsl_lbc_ctrl_dev->regs >> again. So you should improve that as the following on 'err', or layout 'err' >> in >> gain. >> ------ >> if(fsl_lbc_ctrl_dev->regs) >> iounmap(fsl_lbc_ctrl_dev->regs); >> > > It looks like iounmap(NULL) is a no-op, just like kfree(NULL). >
Absolutely, I know what you mean :) But I think we should take care of every line as one normal progress/rule. That will make us understand easily, and maybe we also would benefit a little good performance from those codes. Tiejun > -Scott > > _______________________________________________ > Linuxppc-dev mailing list > Linuxppc-dev@lists.ozlabs.org > https://lists.ozlabs.org/listinfo/linuxppc-dev > _______________________________________________ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev
