Re: [PATCH v2] sdhci: Add support for hosts that are only capable of 1-bit transfers

2009-06-19 Thread Pierre Ossman
on Vorontsov > --- Patch merged. Rgds -- -- Pierre Ossman WARNING: This correspondence is being monitored by the Swedish government. Make sure your server uses encryption for SMTP traffic and consider using PGP for end-to-end encryption.

Re: [PATCH] sdhci: Add support for hosts that are only capable of 1-bit transfers

2009-06-13 Thread Pierre Ossman
ade it mandatory though considering the embedded market) Rgds -- -- Pierre Ossman WARNING: This correspondence is being monitored by the Swedish government. Make sure your server uses encryption for SMTP traffic and consider using PGP for end-t

Re: [PATCH] mmc: Fix the wrong accessor to HOSTVER register

2009-06-03 Thread Pierre Ossman
STVER in spec is 0xFE, and > > we need use the in_be16(0xFE) to access it, not in_be16(0xFC). > > > > Signed-off-by: Dave Liu > > Sorry for the delay Dave. This patch is surely > > Acked-by: Anton Vorontsov > Queued. Rgds -- -- Pierre Ossman WARNI

Re: [PATCH] mmc: Add fsl,esdhc as a valid compatible to bind against

2009-05-22 Thread Pierre Ossman
On Fri, 8 May 2009 08:52:49 -0500 Kumar Gala wrote: > We plan to use fsl,esdhc going forward as the base compatible so update > the driver to bind against it. > > Signed-off-by: Kumar Gala > --- Applied. Rgds -- -- Pierre Ossman WARNING: This correspondence is bei

Re: [PATCH] mmc: Fix the wrong accessor to HOSTVER register

2009-05-13 Thread Pierre Ossman
not in_be16(0xFC). > > Signed-off-by: Dave Liu > --- Any objections, Anton? Rgds -- -- Pierre Ossman WARNING: This correspondence is being monitored by the Swedish government. Make sure your server uses encryption for SMTP traffic and consider using PGP for end-to-end e

Re: [PATCH v3 0/11] FSL eSDHC support

2009-03-22 Thread Pierre Ossman
On Tue, 17 Mar 2009 00:13:06 +0300 Anton Vorontsov wrote: > Hi all, > > Here comes another version, let's hope that one is final. ;-) > I think so. I've queued it all for 2.6.30. Thanks :) Rgds -- -- Pierre Ossman WARNING: This correspondence is being moni

Re: [PATCH 11/11] mmc: Add OpenFirmware bindings for SDHCI driver

2009-03-08 Thread Pierre Ossman
tions(-) > create mode 100644 drivers/mmc/host/sdhci-of.c > I'd like a MAINTAINERS entry for this (sub)driver. Rgds -- -- Pierre Ossman WARNING: This correspondence is being monitored by the Swedish government. Make sure your server uses encryption for SMTP traff

Re: [PATCH 12/13] sdhci: Add quirk for controllers with max. block size up to 4096 bytes

2009-03-08 Thread Pierre Ossman
gates to user space in a way that causes filesystems to behave differently, making cards incompatible with all other operating systems (i.e. if we don't use 512 byte blocks). So the only scenario where this might be used is SDIO, and I'm not sure such big blocks are a win there eithe

Re: [PATCH 07/13] sdhci: Add support for hosts with strict 32 bit addressing

2009-03-08 Thread Pierre Ossman
remote risk of breakage as people hacking on sdhci-core won't be aware of esdhc's, let's call it unique, behaviour. Some testing now and then on your part would be prudent. :) Rgds -- -- Pierre Ossman WARNING: This correspondence is being monitored by the Swedish gov

Re: [PATCH 05/13] sdhci: Add support for card-detection polling

2009-03-08 Thread Pierre Ossman
On Wed, 4 Mar 2009 20:49:17 +0300 Anton Vorontsov wrote: > On Sat, Feb 21, 2009 at 04:58:21PM +0100, Pierre Ossman wrote: > > Just modify the if-clause and > > things will work. > > That would look horrid... > > if ((!(host->quirks &

Re: [PATCH 02/11] sdhci: Add support for bus-specific IO memory accessors

2009-03-08 Thread Pierre Ossman
On Wed, 4 Mar 2009 20:46:58 +0300 Anton Vorontsov wrote: > On Sat, Feb 21, 2009 at 04:57:57PM +0100, Pierre Ossman wrote: > > > > We can most likely do some micro-optimisation do make the compare part > > cheaper, but the point was to avoid a function call for all the >

Re: [PATCH 01/13] sdhci: Add quirk for controllers with no end-of-busy IRQ

2009-02-21 Thread Pierre Ossman
> > Changes in e809517f6fa5803a5a1cd56026f0e2190fc13d5c to use the > new busy method are the cause of the behaviour change. > > Signed-off-by: Ben Dooks > Signed-off-by: Anton Vorontsov > --- Any objections to me merging this right away? It is needed for another controller. Rgds -- -- Pierre Ossma

Re: [PATCH 0/13] FSL eSDHC support

2009-02-21 Thread Pierre Ossman
ough, so I'd like it to stay there for one cycle and (hopefully) be merged for 2.6.31. Rgds -- -- Pierre Ossman WARNING: This correspondence is being monitored by the Swedish government. Make sure your server uses encryption for SMTP traffic and consider using PGP for end-to

Re: [PATCH 12/13] sdhci: Add quirk for controllers with max. block size up to 4096 bytes

2009-02-21 Thread Pierre Ossman
x27;m leaning more towards simply not supporting their extended block size. After all, is it ever used? Rgds -- -- Pierre Ossman WARNING: This correspondence is being monitored by the Swedish government. Make sure your server uses encryption for SMTP traffic and consider using P

Re: [PATCH 07/13] sdhci: Add support for hosts with strict 32 bit addressing

2009-02-21 Thread Pierre Ossman
pecified, > the sdhci driver will try to "pack" all dangerous writes into single > 32 bit write transaction. > > Signed-off-by: Anton Vorontsov > --- What about the other places where we have 16 and 8 bit registers? -- -- Pierre Ossman WARNING: This corresponden

Re: [PATCH 05/13] sdhci: Add support for card-detection polling

2009-02-21 Thread Pierre Ossman
:s seem unnecessary here, and your patch is even incorrect as it ignores the SDHCI_DEVICE_DEAD flag. Just modify the if-clause and things will work. Might want to add a comment also to make it more obvious what the if-clause does. Rgds -- -- Pierre Ossman WARNING: This correspondence is b

Re: [PATCH 03/13] sdhci: Split card-detection IRQs management from sdhci_init()

2009-02-21 Thread Pierre Ossman
t; + SDHCI_INT_CARD_INT | SDHCI_INT_ERROR | SDHCI_INT_BUS_POWER | \ > + SDHCI_INT_ACMD12ERR | SDHCI_INT_ADMA_ERROR) > In the context this is used, why not just use (unsigned)-1? Rgds -- -- Pierre Ossman WARNING: This correspondence is

Re: [PATCH 02/11] sdhci: Add support for bus-specific IO memory accessors

2009-02-21 Thread Pierre Ossman
ed controllers out there. We could have a flag so that it only has to check host->flags, which will most likely be in the cache anyway. Overhead for eSDHC is not a concern in my book, what is interesting is how much this change slows things down for othe

Re: [PATCH 10/11] sdhci: Add quirk for Freescale eSDHC controllers

2009-02-08 Thread Pierre Ossman
that we must wait for >some bit in some register, but I didn't find any reliable bits >that changes before and after the delay. Though, more investigation >on this is in my todo list. Please try to investigate more, but if you cannot improve it further then a specific qu

Re: [PATCH 09/11] sdhci: Add set_clock callback

2009-02-08 Thread Pierre Ossman
clock source that needs to be set up, but completely overriding the normal routine (i.e. the "return") should be quirked IMO. Rgds -- -- Pierre Ossman WARNING: This correspondence is being monitored by the Swedish government. Make sure your server uses encryption for

Re: [PATCH 08/11] sdhci: Add support for hosts that don't specify clocks in the cap. register

2009-02-08 Thread Pierre Ossman
nal info unless the register is set to zero. And since we know the Samsung chip needs callbacks, we might as well add them here. It's not like this is a performance critical path. Rgds -- -- Pierre Ossman WARNING: This correspondence is being monitored by the Swedish government.

Re: [PATCH 07/11] sdhci: Add quirk to suppress PIO interrupts during DMA transfers

2009-02-08 Thread Pierre Ossman
e driver difficult to understand. -- -- Pierre Ossman WARNING: This correspondence is being monitored by the Swedish government. Make sure your server uses encryption for SMTP traffic and consider using PGP for end-to-end encryption. signatur

Re: [PATCH 04/11] sdhci: Add support for card-detection polling

2009-02-08 Thread Pierre Ossman
be enabled before mmc_add_host() returns and should be disabled before calling mmc_remove_host(). Patch welcome. ;) Rgds -- -- Pierre Ossman WARNING: This correspondence is being monitored by the Swedish government. Make sure your server uses encryption for SMTP traffic

Re: [PATCH 03/11] sdhci: Add type checking for IO memory accessors

2009-02-08 Thread Pierre Ossman
t unsigned char [unsigned] [assigned] [usertype] count > > Signed-off-by: Anton Vorontsov > --- Is this really a problem? It's a lot of noise in the code and I can't really see this as a major issue, or even a minor one. :) Rgds -- -- Pierre Ossman WARNING: This corr

Re: [PATCH 02/11] sdhci: Add support for bus-specific IO memory accessors

2009-02-08 Thread Pierre Ossman
concerned, so I'd prefer something like: if (!host->ops->writel) writel(host->ioaddr + reg, val); else host->ops->writel(host, val, reg); and maybe even a likely() up there. Rgds -- -- Pierre Ossman WARNING: This correspondence is being monitored by t

Re: [PATCH RFC 0/11] FSL eSDHC support: second call for comments

2009-02-08 Thread Pierre Ossman
to relevant patches now though. Rgds -- -- Pierre Ossman WARNING: This correspondence is being monitored by the Swedish government. Make sure your server uses encryption for SMTP traffic and consider using PGP for end-to-end encryption. signature.asc Descri

Re: [PATCH] mmc: Add driver for Freescale eSDHC controllers

2009-01-14 Thread Pierre Ossman
ll the patches there or some other LKML archive. Rgds -- -- Pierre Ossman Linux kernel, MMC maintainerhttp://www.kernel.org rdesktop, core developer http://www.rdesktop.org WARNING: This correspondence is being monitored by the Swedish government. Make sure your server use

Re: [PATCH] mmc: Add driver for Freescale eSDHC controllers

2009-01-14 Thread Pierre Ossman
port it via sdhci. Rgds -- -- Pierre Ossman Linux kernel, MMC maintainerhttp://www.kernel.org rdesktop, core developer http://www.rdesktop.org WARNING: This correspondence is being monitored by the Swedish government. Make sure your server uses encryption for SMTP tra

Re: [PATCH v2] mmc: Add mmc_vddrange_to_ocrmask() helper function

2008-12-14 Thread Pierre Ossman
ll be sent once the merge window opens up. Rgds -- -- Pierre Ossman Linux kernel, MMC maintainerhttp://www.kernel.org rdesktop, core developer http://www.rdesktop.org WARNING: This correspondence is being monitored by the Swedish government. Make sure your server u

Re: [PATCH v2] mmc: Add mmc_vddrange_to_ocrmask() helper function

2008-11-30 Thread Pierre Ossman
> > Hi Pierre, > > Sorry for the delay. > This looks perfect. Just tell me when you want me to queue it up. Rgds -- -- Pierre Ossman Linux kernel, MMC maintainerhttp://www.kernel.org rdesktop, core developer http://www.rdesktop.org WARNING: Thi

Re: [PATCH 2/3] mmc: Add mmc_vddrange_to_ocrmask() helper function

2008-11-08 Thread Pierre Ossman
ty with a single bit set. If possible, try to make this function set two bits when the voltage is right on the boundary (e.g. 3.3V). Rgds -- -- Pierre Ossman Linux kernel, MMC maintainerhttp://www.kernel.org rdesktop, core developer http://www.rdesktop.org WARNING:

Re: [PATCH 0/3 RFC] MMC SPI support for OpenFirmware platforms

2008-11-08 Thread Pierre Ossman
s on an ACPI/OF/EFI/whatnot host, but I can live with this model for now. Rgds -- -- Pierre Ossman Linux kernel, MMC maintainerhttp://www.kernel.org rdesktop, core developer http://www.rdesktop.org WARNING: This correspondence is being monitored by the Swedish governm

Re: [PATCH 3/4] [MMC] mmc_spi: add polling support for the card detect line

2008-05-17 Thread Pierre Ossman
re is no card present. That should give you what you want with much more flexibility for other uses as well. Rgds -- -- Pierre Ossman Linux kernel, MMC maintainerhttp://www.kernel.org rdesktop, core developer http://www.rdesktop.org