Re: [PATCH V2] dtc: ensure #line directives don't consume data from the next line

2013-06-03 Thread Jon Loeliger
> From: Stephen Warren > > Previously, the #line parsing regex ended with ({WS}+[0-9]+)?. The {WS} > could match line-break characters. If the #line directive did not contain > the optional flags field at the end, this could cause any integer data on > the next line to be consumed as part of the

Re: DTB build failure due to preproccessing

2013-05-31 Thread Jon Loeliger
> > > > Line 374 is the "IDSEL 0x16..." line here: > > interrupt-map = < > > /* IRQ mapping for pci slots and ALI M1533 > > ... > > * management core also isn't used. > >

Re: [PATCH 1/2] dtc: Implement -d option to write out a dependency file

2012-01-09 Thread Jon Loeliger
> This will allow callers to rebuild .dtb files when any of the /include/d > .dtsi files are modified, not just the top-level .dts file. > > Signed-off-by: Stephen Warren > --- > This patch is against the Linux kernel's copy of dtc, but it applies to > upstream dtc with a couple of trivial confli

Re: [PATCH] dtc: Remove unused check variable

2011-07-17 Thread Jon Loeliger
> On Tue, Jun 28, 2011 at 08:47:09AM -0400, Josh Boyer wrote: > > Commit 376ab6f2 removed the old style check functionality from DTC, > > however the check option and variable were not removed. This leads to > > build failures when -Werror=unused-but-set-variable is specified: > > > > dtc.c:

Re: [PATCH v2] dtc: Remove unused variable in flat_read_mem_reserve

2011-07-17 Thread Jon Loeliger
> On Tue, Jun 28, 2011 at 09:47:11AM -0400, Josh Boyer wrote: > > The *p variable is declared and used to save inb->ptr, however p is > > later never used. This has been the case since commit 6c0f3676 and can > > lead to build failures with -Werror=unused-but-set-variable: > > > > flattree.c:

Re: [PATCH] Globally s/struct irq_host/struct irq_domain/

2011-01-21 Thread Jon Loeliger
> > I always reserve the right to change my mind. }:-> Naturally! > Sorry about that, No problem. The thought back then was that we'd hit the "global" piece and then we'd buy the time to hit the local pieces as we could. > but I actually applied the patch this morning with the thought that

Re: [PATCH] Globally s/struct irq_host/struct irq_domain/

2011-01-21 Thread Jon Loeliger
> > For this to make sense, it really needs to also rename irq_host_ops > structure, the IRQ_HOST_MAP* #defines, and the irq_*_host functions. > It also /should/ adjust the users of irq_domain to rename function > local variables and structure members. Otherwise there will be an > even worse mism

Re: [PATCH 1/5] scripts: dtc: Merge in changes from the dtc repository

2010-11-17 Thread Jon Loeliger
> > Hmm, is there some documentation for how to use this feature? > Specifically I have a custom board with multiple discrete computers on > it which are only very slightly physically different from each other > and I'd like to be able to avoid maintaining 2 nearly-exact copies of > the same DTS f

Re: [PATCH 1/5] scripts: dtc: Merge in changes from the dtc repository

2010-11-17 Thread Jon Loeliger
> On Tue, Nov 16, 2010 at 12:49:51PM -0800, John Bonesio wrote: > > Pull in recent changes from the main dtc repository. These changes primarily > > allow multiple device trees to be declared which are merged by dtc. This > > feature allows us to include a basic dts file and then provide more > >

Re: DTC sources move

2009-03-27 Thread Jon Loeliger
> On Fri, Mar 27, 2009 at 8:16 AM, Michal Simek wrote: > > Hi Ben, > > > > could you please move DTC to any generic location. I would like to use it f > or Microblaze cpu too. > > Michal, > > David Gibson is the one responsible for the in-tree dtc source, not > Ben, and you should prepare the pa

Re: Regarding irq_of_parse_and_map

2009-02-19 Thread Jon Loeliger
On Thu, 2009-02-19 at 17:21 +0530, Vijay Nikam wrote: > Also is it possible to compile device tree on Linux host and genreate > dtb for powerpc ? ? ? If yes, then how ? ? ? please let me know ... > thanks ... Uh, get a copy of the DTC using: $ git clone git://git.jdl.com/software/dtc.git

Re: Trouble moving custom MPC8548 board to U-boot 1.3

2009-01-06 Thread Jon Loeliger
On Tue, 2009-01-06 at 15:28 +0200, Pieter wrote: > Hi all, > > I have spent quite some time trying to move from U-Boot 1.2 to a newer > version.. I am stuck at the initialization of the ram. The ram checksum > fails and gives me a "total memory of 0". (the board has 512MB and work > when booting u

Re: Re :Re: [Ltib] ltib error -linux2.6.20.6 with MPC8360E MDS

2008-11-21 Thread Jon Loeliger
nanda wrote: Hi Stuart, Thanks for the information. gpp access was resolved. I was successful in building the linux 2.6.11 using the ltib and able to bring up the MPC8360 EMDS. But, I still face the problem for linux kernel 2.6.19 and 2.6.20. When I tried using ltib in the bringing up

Re: dtc: Use noinput flex option for convert-dtsv0 to remove warning

2008-11-17 Thread Jon Loeliger
> The convert-dtsv0 lexer doesn't use lex's input() macro/function. > This can result in "defined but not used" warnings. This patch uses > flex's noinput option to prevent this warning (as we already do for > dtc-lexer.l). > > Signed-off-by: David Gibson <[EMAIL PROTECTED]> Applied. Thanks, jd

Re: dtc: Check return value from fwrite()

2008-11-17 Thread Jon Loeliger
> There's one place in flattree.c where we currently ignore the return > value from fwrite(). On some gcc/glibc versions, where fwrite() is > declared with attribute warn_unused_result, this causes a warning. > > This patch fixes the warning, by checking the fwrite() result. > > Signed-off-by: D

Re: Building dtc etc. for packaging

2008-11-11 Thread Jon Loeliger
On Wed, 2008-11-12 at 09:39 +1100, David Gibson wrote: > Use the tree from jdl.org. Either the git tree if you really need an > up-to-date snahpshot, or one of the actual release tarballs. The tree from jdl.com will work better. :-) jdl ___ Linuxppc

Re: libfdt: Fix bug in fdt_subnode_offset_namelen()

2008-11-05 Thread Jon Loeliger
> There's currently an off-by-one bug in fdt_subnode_offset_namelen() > which causes it to keep searching after it's finished the subnodes of > the given parent, and into the subnodes of siblings of the original > node which come after it in the tree. > > This patch fixes the bug. It also extends

Re: [RFC 0/6] Proposal for a Generic PWM Device API

2008-10-10 Thread Jon Loeliger
On Fri, 2008-10-10 at 09:04 -0500, Bill Gatliff wrote: > Jon Smirl wrote: > > > What do the device tree deities have to say about PWM support? > > Dunno. What lists are they on? :) > Perhaps [EMAIL PROTECTED] too. jdl ___ Linuxppc-dev mailing lis

Re: [PATCH] Install & document convert-dtsv0

2008-10-03 Thread Jon Loeliger
> Patch against http://www.jdl.com/software/dtc.git > Signed-off-by: Niklaus Giger <[EMAIL PROTECTED]> > --- > Documentation/manual.txt | 20 > Makefile |1 + > 2 files changed, 21 insertions(+), 0 deletions(-) Applied. Thanks, jdl _

Re: [PATCH] Added preliminary support for Netstal HCU4 board

2008-10-02 Thread Jon Loeliger
On Thu, 2008-10-02 at 21:51 +0200, Niklaus Giger wrote: > git pull worked perfectly. But in Documentation/manual.txt you promise: > > -- The gitweb interface is: > > > > http://www.jdl.com/git_repos/ > And this link does not work. Gah. Thanks. jdl _

Re: [PATCH] Added preliminary support for Netstal HCU4 board

2008-10-02 Thread Jon Loeliger
On Thu, 2008-10-02 at 21:08 +0200, Niklaus Giger wrote: > > > convert-dtsv0 is a small utility program which converts (DTS) > > > Device Tree Source from the obsolete version 0 to version 1. Version 1 > > > DTS files are marked by line "/dts-v1/;" at the top of the file. > > > > Add this remark wh

Re: libfdt: Add function to explicitly expand aliases

2008-10-02 Thread Jon Loeliger
> Kumar has already added alias expansion to fdt_path_offset(). > However, in some circumstances it may be convenient for the user of > libfdt to explicitly get the string expansion of an alias. This patch > adds a function to do this, fdt_get_alias(), and uses it to implement > fdt_path_offset().

Re: libfdt: Fix bugs in fdt_get_path()

2008-09-25 Thread Jon Loeliger
> The current implementation of fdt_get_path() has a couple of bugs, > fixed by this patch. > > First, contrary to its documentation, on success it returns the length > of the node's path, rather than 0. The testcase is correspondingly > wrong, and the patch fixes this as well. > > Second, in so

Re: [PATCH] [82xx] powerpc: Add support for mpc8247 based board MGCOGE from keymile.

2008-08-29 Thread Jon Loeliger
Kumar Gala wrote: arch/powerpc/boot/dts/mgcoge.dts | 174 +++ arch/powerpc/configs/mgcoge_defconfig | 900 + arch/powerpc/platforms/82xx/Kconfig |8 + arch/powerpc/platforms/82xx/Makefile |1 + arch/powerpc/platforms/82xx/mgcoge.c | 129 +

Re: [PATCH 1/2] powerpc: Board support for GE Fanuc SBC610

2008-08-21 Thread Jon Loeliger
Martyn Welch wrote: Support for the SBC610 VPX Single Board Computer from GE Fanuc (PowerPC MPC8641D). This is the basic board support for GE Fanuc's SBC610, a 6U single board computer, based on Freescale's MPC8641D. Signed-off-by: Martyn Welch <[EMAIL PROTECTED]> --- arch/powerpc/boot/dts/ge

Re: [PATCH] powerpc: 85xx: add proper OF bus ids for the TQM85xx

2008-08-17 Thread Jon Loeliger
> Wolfgang Grandegger wrote: > > Jon Loeliger wrote: > >> > >> H. While you are there, I think you should drop > >> the "8548" part of "soc8548" to get just "[EMAIL PROTECTED]". > > > > Well, right. I'm

Re: [PATCH V2] DTC: Remove support for the legacy DTS source file format.

2008-08-15 Thread Jon Loeliger
> On Thu, Aug 14, 2008 at 7:29 PM, David Gibson > <[EMAIL PROTECTED]> wrote: > > On Thu, Aug 14, 2008 at 06:02:43PM -0500, Jon Loeliger wrote: > >> Now that all in-kernel-tree DTS files are properly /dts-v1/, > >> remove direct support for the older, un-

[PATCH V2] DTC: Remove support for the legacy DTS source file format.

2008-08-14 Thread Jon Loeliger
Now that all in-kernel-tree DTS files are properly /dts-v1/, remove direct support for the older, un-numbered DTS source file format. Convert existing tests to /dts-v1/ and remove support for the conversion tests themselves. For now, though, the conversion tool still exists. Signed-off-by: Jon

[PATCH] DTC: Remove support for the legacy DTS source file format.

2008-08-14 Thread Jon Loeliger
Now that all in-kernel-tree DTS files are properly /dts-v1/, remove direct support for the older, un-numbered DTS source file format. Convert existing tests to /dts-v1/ and remove support for the conversion tests themselves. For now, though, the conversion tool still exists. Signed-off-by: Jon

Re: [PATCH 2/2] port ndfc driver to of platform

2008-08-14 Thread Jon Loeliger
Arnd Bergmann wrote: Did we ever come to a conclusion on how this could be done, e.g. with preprocessed dts files or simpler dynamic patching of binary device trees? I am working on it. jdl ___ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org http

Re: [PATCH v3] libfdt: Add support for using aliases in fdt_path_offset()

2008-08-14 Thread Jon Loeliger
> If the path doesn't start with '/' check to see if it matches some alias > under "/aliases" and substitute the matching alias value in the path > and retry the lookup. > > Signed-off-by: Kumar Gala <[EMAIL PROTECTED]> Applied. jdl ___ Linuxppc-dev ma

Re: libfdt: Implement fdt_get_property_namelen() and fdt_getprop_namelen()

2008-08-13 Thread Jon Loeliger
> As well as fdt_subnode_offset(), libfdt includes an > fdt_subnode_offset_namelen() function that takes the subnode name to > look up not as a NUL-terminated string, but as a string with an > explicit length. This can be useful when the caller has the name as > part of a longer string, such as a

Re: dtc: Make many functions 'static'

2008-08-13 Thread Jon Loeliger
> This patch marks various functions not shared between c files > 'static', as they should be. There are a couple of functions in dtc, > and many in the testsuite. > > This is *almost* enough to enable the -Wmissing-prototypes warning. > It's not quite enough, because there's a mess of junk in th

Re: [PATCH] powerpc: Fix whitespace merge in mpc8641 hpcn device tree

2008-07-31 Thread Jon Loeliger
Kumar Gala wrote: When we coverted the .dts to v1 we lost a space between the irq and its polarity/sense information. This causes a bit of chaos as the reset of the blob is off by one cell. diff --git a/arch/powerpc/boot/dts/mpc8641_hpcn.dts b/arch/powerpc/boot/dts/mpc8641_hpcn.dts index ae08

Re: [PATCH] dtc: give advance warning that "-S" is going away.

2008-07-31 Thread Jon Loeliger
> The "-S" option allowed the specification of a minimum size for > the blob, however the main reason for caring about the size is > so there is enough padding to add a chosen node by u-boot or > whoever. In which case, folks don't really care about the absolute > size, but rather the size of the

Re: dtc: Remove unused lexer function

2008-07-31 Thread Jon Loeliger
> dtc does not use the input() function in flex. Apparently on some gcc > versions the unused function will cause warnings. Therefore, this > patch removes the function by using the 'noinput' option to flex. > > Signed-off-by: David Gibson <[EMAIL PROTECTED]> Applied. jdl _

Re: libfdt: Forgot one function when cleaning the namespace

2008-07-31 Thread Jon Loeliger
> In commit b6d80a20fc293f3b995c3ce1a6744a5574192125, we renamed all > libfdt functions to be prefixed with fdt_ or _fdt_ to minimise the > chance of collisions with things from whatever package libfdt is > embedded in, pulled into the libfdt build via that environment's > libfdt_env.h. > > Except

Re: [PATCH] dtc: give advance warning that "-S" is going away.

2008-07-30 Thread Jon Loeliger
> The "-S" option allowed the specification of a minimum size for > the blob, however the main reason for caring about the size is > so there is enough padding to add a chosen node by u-boot or > whoever. In which case, folks don't really care about the absolute > size, but rather the size of the

DTC v1.2.0 Released

2008-07-25 Thread Jon Loeliger
Folks, I have tagged and released DTC version 1.2.0 on jdl.com. git://git.jdl.com/software/dtc.git Problems with it to me, please! Enjoy, jdl ___ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-d

Re: [PATCH] powerpc: 85xx: add proper OF bus ids for the TQM85xx

2008-07-25 Thread Jon Loeliger
Wolfgang Grandegger wrote: Ah, I see. For the TQM8548 adding the following compatible line: [EMAIL PROTECTED] { ... compatible = "fsl,mpc8548-immr", "simple-bus"; H. While you are there, I think you should drop the "8548" part of "soc8548" to get just "[EMAIL

[PATCH] libfdt: Fix 'make install' target handling of .h files.

2008-07-23 Thread Jon Loeliger
The definition of LIBFDT_INCLUDES was accidentally dropped. Put it back and add srcdir prefix handling for it. Signed-off-by: Jon Loeliger <[EMAIL PROTECTED]> --- Makefile |4 +++- libfdt/Makefile.libfdt |1 + 2 files changed, 4 insertions(+), 1 deletions(-) diff -

DTC: libfdt Install Woes

2008-07-15 Thread Jon Loeliger
David, Somewhat recently, the DTC commit 6a6c972cdf9e "dtc: Clean up included Makefile fragments" removed this line LIBFDT_INCLUDES = fdt.h libfdt.h from the libfdt/Makefile.libfdt. As a result, the standalone "make install" is onw failing. We could put that line back, or remove the top-le

Re: libfdt: Increase namespace-pollution paranoia

2008-07-14 Thread Jon Loeliger
> > My (DTC) plan is to apply the single patch with some > include file fixes, and release that. > > I'll line the slew of patches up for the following release. > > jdl And that's not at all what happened. One of David's patches (BSD portability) was a superset of the include-file fixes suppli

Re: [PATCH] libfdt: Improve documentation in libfdt.h

2008-07-14 Thread Jon Loeliger
> Fix a few typos and mistakes. > > Signed-off-by: Wolfram Sang <[EMAIL PROTECTED]> Applied. jdl ___ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev

Re: libfdt: Increase namespace-pollution paranoia

2008-07-14 Thread Jon Loeliger
> libfdt is supposed to easy to embed in projects all and sundry. > Often, it won't be practical to separate the embedded libfdt's > namespace from that of the surrounding project. Which means there can > be namespace conflicts between even libfdt's internal/static functions > and functions or mac

Re: dtc: Enable and fix -Wcast-qual warnings

2008-07-14 Thread Jon Loeliger
> Enabling -Wcast-qual warnings in dtc shows up a number of places where > we are incorrectly discarding a const qualification. There are also > some places where we are intentionally discarding the 'const', and we > need an ugly cast through uintptr_t to suppress the warning. However, > most of

Re: dtc: Run relevant checks on dtb input as well as dts

2008-07-14 Thread Jon Loeliger
> This patch adjusts the testsuite to run most of the tests for the tree > checking code on input in dtb form as well as dts form. Some checks > which only make sense for dts input (like reference handling) are > excluded, as are those which currently take dtb input because they > rely on things w

Re: dtc: Enable and fix -Wpointer-arith warnings

2008-07-14 Thread Jon Loeliger
> This patch turns on the -Wpointer-arith option in the dtc Makefile, > and fixes the resulting warnings due to using (void *) in pointer > arithmetic. While convenient, pointer arithmetic on void * is not > portable, so it's better that we avoid it, particularly in libfdt. > > Signed-off-by: Dav

Re: dtc: Clean up lexing of include files

2008-07-14 Thread Jon Loeliger
> Currently we scan the /include/ directive as two tokens, the > "/include/" keyword itself, then the string giving the file name to > include. We use a special scanner state to keep the two linked > together, and use the scanner state stack to keep track of the > original state while we're parsin

Re: dtc: Address an assortment of portability problems

2008-07-14 Thread Jon Loeliger
> I've recently worked with a FreeBSD developer, getting dtc and libfdt > working on FreeBSD. This showed up a number of portability problems > in the dtc package which this patch addresses. Changes are as > follows: > > - the parent_offset and supernode_atdepth_offset testcases > used the

Re: dtc: Use libfdt endian conversion functions in libfdt

2008-07-14 Thread Jon Loeliger
> Following on from the last patch, which made dtc use the same endian > conversion functions as libfdt, this patch makes ftdump use these > functions as well. This brings us down to a single set of endian > handling functions in all of dtc and libfdt, so just one place to fix > things. > > Signe

Re: dtc: Use the same endian-conversion functions as libfdt

2008-07-14 Thread Jon Loeliger
> Currently both libfdt and dtc define a set of endian conversion macros > for accessing the device tree blob which is always big-endian. libfdt > uses names like cpu_to_fdt32() and dtc uses names like cpu_to_be32 (as > the Linux kernel). This patch switches dtc over to using the libfdt > macros

Re: dtc: Use stdint.h types throughout dtc

2008-07-14 Thread Jon Loeliger
> Currently, dtc defines Linux-like names for various fixed-size integer > types. There's no good reason to do this; even Linux itself doesn't > use these names for externally visible things any more. This patch > replaces these with the C99 standardized type names from stdint.h. > > Signed-off-

Re: dtc: Testcase for /include/ directive

2008-07-14 Thread Jon Loeliger
> This patch adds a testcase for the /include/ directive. It assembles > a sample dts file with many /include/ directives at a variety of > different lexical / grammatical contexts. > > Signed-off-by: David Gibson <[EMAIL PROTECTED]> Applied. jdl ___

Re: [PATCH] mpc7448: add alias list to DTS, clean out old chosen node

2008-07-10 Thread Jon Loeliger
Scott Wood wrote: Paul Gortmaker wrote: OK, so does that mean that the cuboot wrapper is explicitly not supported for all the 83xx, 85xx, and 86xx boards? No (except 86xx, which doesn't have cuboot, because it never existed in arch/ppc and thus there's no compatibility to maintain), it just m

Re: libfdt: Increase namespace-pollution paranoia

2008-07-09 Thread Jon Loeliger
> > > On a slightly unrelated note, are you planning to sync the in-kernel > > dtc/libfdt version with the upstream version anytime soon? > > I know jon put an -rc, not sure if he plans to pick up the slew of > patches for the next -rc or the next release, but it would be good to > resync the

Re: [RFC] Non-numbered ibm iic driver

2008-06-29 Thread Jon Loeliger
Sean MacLennan wrote: P.S. Do I need a signed-off-by for an RFC? Signed-off-by: Sean MacLennan <[EMAIL PROTECTED]> --- Not usually. Some intentionally leave the S-o-b: off of and RFC specifically to ensure that it stays RFC-ish and doesn't slip into patchness. jdl __

Re: [PATCH 12/60] microblaze_v4: Generic dts file for platforms

2008-06-26 Thread Jon Loeliger
Michal Simek wrote: Ok. Thanks for information Steve. Jon: Only for sure the main difference is only in value handling. Am I right? If yes, it is easy to change. M Right. It is essentially C-like now. And has a declarator at the top with /dts-v1/. Essentially all of the DTS files in arch/p

Re: [PATCH 12/60] microblaze_v4: Generic dts file for platforms

2008-06-26 Thread Jon Loeliger
[EMAIL PROTECTED] wrote: From: Michal Simek <[EMAIL PROTECTED]> Signed-off-by: Michal Simek <[EMAIL PROTECTED]> --- arch/microblaze/platform/generic/system.dts | 300 +++ 1 files changed, 300 insertions(+), 0 deletions(-) create mode 100644 arch/microblaze/platform/ge

Re: [PATCH 02/14] powerpc: Allow create_branch() to return errors

2008-06-24 Thread Jon Loeliger
s the patch_branch() call. Signed-off-by: Michael Ellerman <[EMAIL PROTECTED]> --- 86xx bits... Acked-by: Jon Loeliger <[EMAIL PROTECTED]> ___ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev

Re: [PATCH] fs_enet: restore promiscuous and multicast settings in restart()

2008-06-19 Thread Jon Loeliger
Vitaly Bordug wrote: On Wed, 18 Jun 2008 22:45:57 +0400 "Matvejchikov Ilya" <[EMAIL PROTECTED]> wrote: I'm glad that you have corrected it. Half a year ago I pointed out that there was such a mistake: http://patchwork.ozlabs.org/linuxppc/patch?id=10700 You've used -embedded ML, and patch wasn'

DTC 1.2.0-rc1 Tagged

2008-06-19 Thread Jon Loeliger
l bashisms from test scripts dtc: Fix some printf() format warnings when compiling 64-bit dtc: Add a testcase for 'reg' or 'ranges' in / dtc: Add support for binary includes. Jon Loeliger (1): Tag Version 1.2.0-rc1 __

Re: Question regarding mpic_assign_isu() in storcenter.c

2008-06-18 Thread Jon Loeliger
Eric Witcher wrote: The answer is that mpic_assign_isu(mpic, 1, paddr + 0x11000) places the initial base register for isu 1 on a reserved location in the PIC register map (see *). I guess you can infer from this that no badness occurs when you write to a reserved location on the PIC. See? S

Re: dtc: Add support for binary includes.

2008-06-12 Thread Jon Loeliger
David Gibson wrote: It'd be nice if we could keep the filename around for reporting here... It would. Well, I've been intending to clean up the input file handling in several ways already, I'll see if that can be worked in. With Scott's ACK on this, I intend commit David's patch. So if yo

Re: 4xx support in arch/ppc is going away Real Soon Now

2008-06-08 Thread Jon Loeliger
ce <[EMAIL PROTECTED]> Acked-by: Benjamin Herrenschmidt <[EMAIL PROTECTED]> Acked-by: Grant Likely <[EMAIL PROTECTED]> Acked-by: Jochen Friedrich <[EMAIL PROTECTED]> Acked-by: Jon Loeliger <[EMAIL PROTECTED]> Acked-by: Josh Boyer <[EMAIL PROTECTED]> Acked-by: Kumar Gala <

Re: Default flats for running dtc from kernel build

2008-06-06 Thread Jon Loeliger
On Fri, 2008-06-06 at 10:42 -0500, Kumar Gala wrote: > So maybe: > > DTS_FLAGS ?= -P 0x1000 Lowercase "p". > 1k seems like more than enough default padding. I would think so. > - k jdl ___ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org htt

Re: arch/ppc is going away Real Soon Now

2008-06-06 Thread Jon Loeliger
? > > >>>>> > > >>>>> Acked-by: Josh Boyer <[EMAIL PROTECTED]> > > >>>> Acked-by: Stephen Neuendorffer <[EMAIL PROTECTED]> > > >>> Acked-by: Arnd Bergmann <[EMAIL PROTECTE

Re: Default flats for running dtc from kernel build

2008-06-06 Thread Jon Loeliger
On Fri, 2008-06-06 at 09:51 -0500, Kumar Gala wrote: > > > > I will. But wouldn't it make sense to allow at least for some level > > of compatibility with older versions of U-Boot? Adding these options > > as default would probably not hurt? > > Agreed. I didn't realize we could actually do t

Re: [PATCH] Add support for binary includes.

2008-06-04 Thread Jon Loeliger
David Gibson wrote: But as I said that can be dealt with in the future without breaking compatibility. Objection withdrawn. And on that note, I officially implore Scott to re-submit his binary include patch! Sorry it's taken this long :(. No problem; no apology needed. [*1*] jdl [*1*]

Re: dtc: Add a testcase for 'reg' or 'ranges' in /

2008-06-02 Thread Jon Loeliger
> This patch adds an extra testcase to dtc to ensure that the > "reg_format" and "ranges_format" checks trigger as they should if a > 'reg' or 'ranges' property appears in the root node. > > Signed-off-by: David Gibson <[EMAIL PROTECTED]> Applied. Thanks, jdl __

Re: [PATCH] Add support for binary includes.

2008-06-02 Thread Jon Loeliger
> On Thu, May 29, 2008 at 09:04:29AM -0500, Jon Loeliger wrote: > > > > I believe I am fully caught up at this point. > > Not quite, this one slipped through the cracks: Rats. > dtc: Fix some printf() format warnings when compiling 64-bit > > Currently, dtc gene

Re: [PATCH] Add support for binary includes.

2008-05-29 Thread Jon Loeliger
David Gibson wrote: A while back I sent out a spiel explaining more clearly why I didn't like it, and where I thought we should go with this, but I don't think anyone noticed it at the time. I'll resend. Thanks. I started working towards a version of this I liked, but was sidetracked by a c

Re: dtc: Remove some small bashisms from test scripts

2008-05-29 Thread Jon Loeliger
> Some of the helper scripts used to run testcases contain some > constructs that are bashisms. Or at least which don't work on dash, > the minimal shell used as /bin/sh on recent Ubuntu systems. > > This patch removes these constructs so that the testsuite will pass > "out of the box" on systems

Re: libfdt: Seval cleanups to parameter checking (v3)

2008-05-29 Thread Jon Loeliger
> Subject: Re: libfdt: Seval cleanups to parameter checking (v3) Please put the "(v3)" in brackets at the begining of the Subject:. > This patch makes a couple of small cleanups to parameter checking of > libfdt functions. > > - In several functions which take a node offset, we use an > i

Re: dtc: Remove reference to dead Makefile variables

2008-05-29 Thread Jon Loeliger
> Previous cleanups have removed the LIBFDT_CLEANFILES and > DTC_CLEANFILES variables from the Makefiles. However, they're still > referenced by the Makefile. This patch gets rid of these last > vestiges. > > Signed-off-by: David Gibson <[EMAIL PROTECTED]> Applied. jdl

Re: [PATCH] Add support for binary includes.

2008-05-27 Thread Jon Loeliger
Kumar Gala wrote: On Feb 25, 2008, at 6:39 PM, David Gibson wrote: On Wed, Feb 20, 2008 at 01:19:41PM -0600, Scott Wood wrote: A property's data can be populated with a file's contents as follows: node { prop = /incbin/("path/to/data"); }; A subset of a file can be included by passing s

Re: dtc: Add program to convert dts files from v0 to v1

2008-05-19 Thread Jon Loeliger
> This patch adds a new utility program, convert-dtsv0, to the dtc > sources. This program will convert dts files from v0 to v1, > preserving comments and spacing. It also includes some heuristics to > guess an appropriate base to use in the v1 output (so it will use hex > for the contents of reg

Re: DTC patches

2008-05-19 Thread Jon Loeliger
> On Mon, May 19, 2008 at 02:22:31PM -0500, Jon Loeliger wrote: > > This leaves one outstanding dtc patch from me; the v0 to v1 conversion > program. Ah, I wasn't sure if we wanted to include that in the mess or not. There's a theory that says we've converted them

DTC patches

2008-05-19 Thread Jon Loeliger
dtc: Simplify error handling for unparseable input [resend] dtc: Clean up included Makefile fragments [resend] dtc: Trivial formatting fixes [resend] dtc: Make dt_from_blob() open its own input file, like the other input formats [resend] dtc: Rework handling of boot_cpuid_phys

Re: mpc86xx - couple of questions...

2008-05-13 Thread Jon Loeliger
> Hi, > > I took the latest tree from linux/kernel/git/galak/powerpc.git > (2.6.26-rc2), and the latest dtc from linux/kernel/git/galak/dtc.git. Hmm. galak, good. Or paulus. But the latest DTC is found on jdl.com still. > After compiling, I am having couple of questions. > > 1) Doesn't the l

Re: [PATCH] devres: support addresses greater than an unsigned long via dev_ioremap

2008-04-29 Thread Jon Loeliger
Kumar Gala wrote: Its a pretty trivial patch and would be nice to go into 2.6.26. I would also consider it a bug fix of shorts for any driver Looked like a bugfix of longs to me... :-) jdl ___ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org htt

Re: dtc: Trivial formatting fixes

2008-03-26 Thread Jon Loeliger
> This patch fixes some trivial indentation and brace/bracket style > problems. > @@ -179,9 +179,8 @@ > arg = argv[optind]; > > /* minsize and padsize are mutually exclusive */ > - if ((minsize) && (padsize)) { > + if (minsize && padsize) > die("Can't s

DTC Patch Catch Up

2008-03-23 Thread Jon Loeliger
Folks, I've applied the following patches from Gibson, in this order, to the DTC and pushed it out to git.jdl.com: dtc: Fix error reporting in push_input_file() dtc: Implement checks for the format of node and property names dtc: Fix indentation of fixup_phandle_references dtc: St

DTC and Git and MontaVista

2008-03-03 Thread Jon Loeliger
Guys, Sorry to bother everyone, but someone at MontaVista who was trying to get the DTC today needs to update their version of git to be something modern. Thanks, jdl ___ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listi

Re: [PATCH] Add support for binary includes.

2008-02-24 Thread Jon Loeliger
David Gibson wrote: >> node { >> prop = /incbin/("path/to/data"); >> }; >> >> node { >> prop = /incbin/("path/to/data", 8, 16); >> }; > > I still dislike the syntax, but haven't thought of a better one yet. > There are some issues with the implementation too, but I've been a bit > too bu

Re: [PATCH] Add support for binary includes.

2008-02-22 Thread Jon Loeliger
So, like, the other day Scott Wood mumbled: > > > > Can I ask; what is the intended usage of such a thing? How large > > would a typical binary blob be? > > I use it for embedding guest device trees in a hypervisor's device tree. Why wouldn't we instead, say, extend the source sytax to allow a

Re: libfdt: Remove no longer used code from fdt_node_offset_by_compatible()

2008-02-18 Thread Jon Loeliger
So, like, the other day David Gibson mumbled: > Since fdt_node_offset_by_compatible() was converted to the new > fdt_next_node() iterator, a chunk of initialization code became > redundant, but was not removed by oversight. This patch cleans it up. > > Signed-off-by: David Gibson <[EMAIL PROTECTE

Re: libfdt: Trivial cleanup for CHECK_HEADER)

2008-02-18 Thread Jon Loeliger
So, like, the other day David Gibson mumbled: > Currently the CHECK_HEADER() macro is defined local to fdt_ro.c. > However, there are a handful of functions (fdt_move, rw_check_header, > fdt_open_into) from other files which could also use it (currently > they open-code something more-or-less ident

Re: libfdt: More tests of NOP handling behaviour

2008-02-18 Thread Jon Loeliger
So, like, the other day David Gibson mumbled: > In light of the recently discovered bug with NOP handling, this adds > some more testcases for NOP handling. Specifically, it adds a helper > program which will add a NOP tag after every existing tag in a dtb, > and runs the standard battery of tests

Re: dtc: Fold comment handling test into testsuite

2008-02-15 Thread Jon Loeliger
So, like, the other day David Gibson mumbled: > For ages dtc has included a sample dts, comment-test.dts, for checking > various lexical corner cases in comment processing. In fact, it > predates the automated testsuite, and has never been integrated into > it. This patch addresses this oversight

Re: libfdt: Fix NOP handling bug in fdt_add_subnode_namelen()

2008-02-14 Thread Jon Loeliger
So, like, the other day David Gibson mumbled: > fdt_add_subnode_namelen() has a bug if asked to add a subnode to a > node which has NOP tags interspersed with its properties. In this > case fdt_add_subnode_namelen() will put the new subnode before the > first NOP tag, even if there are properties

Re: [PATCH] [POWERPC] Fix initial lmb add region with a non-zero base

2008-02-13 Thread Jon Loeliger
So, like, the other day Kumar Gala mumbled: > If we add to an empty lmb region with a non-zero base we will not coalesce > the number of regions done to one. This causes problems on ppc32 for the s/done/down > memory region as its assumed to only have one region. > > We can fix this be easily s

Re: libfdt: Add and use a node iteration helper function.

2008-02-12 Thread Jon Loeliger
So, like, the other day David Gibson mumbled: > This patch adds an fdt_next_node() function which can be used to > iterate through nodes of the tree while keeping track of depth. This > function is used to simplify the iteration code in a lot of other > functions, and is also exported for use by l

Re: [PATCH 1/2] powerpc: publish 85xx soc dts entries as of_device

2008-02-11 Thread Jon Loeliger
Dave Jiang wrote: > diff --git a/arch/powerpc/platforms/85xx/mpc85xx_ads.c > b/arch/powerpc/platforms/85xx/mpc85xx_ads.c > index 4e03050..024393c 100644 > --- a/arch/powerpc/platforms/85xx/mpc85xx_ads.c > +++ b/arch/powerpc/platforms/85xx/mpc85xx_ads.c > @@ -26,6 +26,8 @@ > #include > #include

Re: Moving from 2.6.14 (ppc) to 2.6.20 (powerpc): problems with PCI-PCI bridge

2008-02-04 Thread Jon Loeliger
Johan Borkhuis wrote: > Hello, > > I was using kernel version 2.6.14 (ppc) on a MVME3100 board (MPC8540 > processor). We are planning to move to 2.6.20 (powerpc), but I have some > problems with the initialization of a PCI-PCI bridge. > Connected to the MVME3100 board is a PCI-PCI bridge (HiNT,

[PATCH] [POWERPC] Fix storcenter DTS typos, feedback, IRQs.

2008-02-02 Thread Jon Loeliger
Cleaned up IRQ layout and removed unsused ISU allocations. Fixed RTC address typo from /dts-v1/ conversion. Incorporated list suggestions to use an "iomega," vendor prefix, and to use a node reference rather than a hard path. Signed-off-by: Jon Loeliger --- Kumar, I tried to use

Re: [PATCH 2/4 v4] POWERPC: Add StorCenter DTS first draft.

2008-02-01 Thread Jon Loeliger
So, like, the other day David Gibson mumbled: > > +/ { > > + model = "StorCenter"; > > + compatible = "storcenter"; > > This really needs a vendor prefix. Hey Grant! Here's how dumb I am: You were thinking "Something's wrong here..." and kept saying "Needs a model name!", and I kept saying

Re: [PATCH 1/2] Add RapidIO node into MPC8641HPCN dts file

2008-02-01 Thread Jon Loeliger
So, like, the other day "Zhang Wei" mumbled: > > > > The 8641 DTS file has been converted to /dts-v1/ format now. > > Please rewrite this patch with explicit hex numbers for > > addresses, even if 0x0, and decimal for IRQs. > > I have seen other nodes in mpc8641_hpcn.dts still use old style. > Is

Re: [PATCH 1/2] Add RapidIO node into MPC8641HPCN dts file

2008-01-31 Thread Jon Loeliger
Zhang Wei wrote: > Signed-off-by: Zhang Wei <[EMAIL PROTECTED]> > --- > arch/powerpc/boot/dts/mpc8641_hpcn.dts | 13 + > 1 files changed, 13 insertions(+), 0 deletions(-) > > diff --git a/arch/powerpc/boot/dts/mpc8641_hpcn.dts > b/arch/powerpc/boot/dts/mpc8641_hpcn.dts > index 556a

Re: [PATCH 1/2] Add RapidIO node into MPC8641HPCN dts file

2008-01-31 Thread Jon Loeliger
Zhang Wei wrote: > Signed-off-by: Zhang Wei <[EMAIL PROTECTED]> > --- > arch/powerpc/boot/dts/mpc8641_hpcn.dts | 13 + > 1 files changed, 13 insertions(+), 0 deletions(-) > > diff --git a/arch/powerpc/boot/dts/mpc8641_hpcn.dts > b/arch/powerpc/boot/dts/mpc8641_hpcn.dts > index 556a

  1   2   3   4   >