Re: [PATCH 1/1] ata/sata_sil24: MSI support, disabled by default

2009-11-16 Thread Jeff Garzik
On 11/17/2009 01:59 AM, Mahajan Vivek-B08308 wrote: From: Grant Grundler [mailto:grund...@google.com] Sent: Monday, November 16, 2009 11:08 PM +static int sata_sil24_msi;/* Disable MSI */ +module_param_named(msi, sata_sil24_msi, bool, S_IRUGO); +MODULE_PARM_DESC(msi, "Enable MSI (Default: fa

Re: [powerpc] Next tree Nov 2 : kernel BUG at mm/mmap.c:2135!

2009-11-16 Thread Sachin Sant
>htab_hash_mask= 0x7 <4>- <6>Initializing cgroup subsys cpuset <6>Initializing cgroup subsys cpu <5>Linux version 2.6.32-rc7-next-20091116 (r...@llm62) (gcc version 4.3.2 [gcc-4_3-branch revisi

[PATCH 1/1] sata_sil24: MSI support cleanup

2009-11-16 Thread Vivek Mahajan
Grant Grundler suggested the following cleanup: * Rename module param 'msi' to 'sata_sil24_msi' * Remove pci_intx() as pci_enable_msi() internally takes care of it. Reviewed-by: Grant Grundler Signed-off-by: Vivek Mahajan --- drivers/ata/sata_sil24.c | 10 -- 1 files changed, 4 ins

[RFC] powerpc/mm: honor O_SYNC flag for memory map

2009-11-16 Thread Li Yang
Rather than the original intelligent way, we grant user more freedom. This enables user to map cacheable memory not managed by Linux. Signed-off-by: Li Yang --- The only direct users of this function is fb_mmap() and /dev/mem mmap. Although I'm not sure if anything is depending on the intelligent

RE: [PATCH 1/1] ata/sata_sil24: MSI support, disabled by default

2009-11-16 Thread Mahajan Vivek-B08308
> From: Grant Grundler [mailto:grund...@google.com] > Sent: Monday, November 16, 2009 11:08 PM > > +static int sata_sil24_msi;    /* Disable MSI */ > > +module_param_named(msi, sata_sil24_msi, bool, S_IRUGO); > > +MODULE_PARM_DESC(msi, "Enable MSI (Default: false)"); > > Vivek, > Do we even sti

Re: [powerpc] Next tree Nov 2 : kernel BUG at mm/mmap.c:2135!

2009-11-16 Thread David Gibson
On Fri, Nov 13, 2009 at 03:05:33PM +0530, Sachin Sant wrote: > David Gibson wrote: > >so, could you try booting the kernel with the patch below, which > >should give a bit more information about the problem. > > > >Index: working-2.6/mm/mmap.c > >

Re: [PATCH 3/13] pmac-zilog: cleanup

2009-11-16 Thread Finn Thain
Hi Ben, On Tue, 17 Nov 2009, Benjamin Herrenschmidt wrote: > On Wed, 2009-11-04 at 00:40 +1100, Finn Thain wrote: > > Whitespace cleanups and comment typo fix. > > > > Signed-off-by: Finn Thain > > Acked-by: Benjamin Herrenschmidt > > Hi Finn. Do you want me to carry and merge those patches

Re: [PATCH 1/1] ata/sata_sil24: MSI support, disabled by default

2009-11-16 Thread Jeff Garzik
On 11/16/2009 01:19 AM, Vivek Mahajan wrote: The following patch adds MSI support. Some platforms may have broken MSI, so those are defaulted to use legacy PCI interrupts. Signed-off-by: Vivek Mahajan --- drivers/ata/sata_sil24.c |9 + 1 files changed, 9 insertions(+), 0 deletions

Re: [PATCH] sata_fsl: Split hard and soft reset

2009-11-16 Thread Jeff Garzik
On 11/05/2009 10:02 AM, Kumar Gala wrote: On Oct 16, 2009, at 11:44 AM, Anton Vorontsov wrote: From: Jiang Yutang Split sata_fsl_softreset() into hard and soft resets to make error-handling more efficient & device and PMP detection more reliable. Also includes fix for PMP support, driver te

Re: [PATCH 4/13] pmac-zilog, mac68k: replace mac68k SCC code with platform device

2009-11-16 Thread Benjamin Herrenschmidt
On Wed, 2009-11-04 at 00:40 +1100, Finn Thain wrote: > Remove the old 68k Mac serial port code and a lot of related cruft. Add > platform driver support to the pmac-zilog driver, putting the powermac- > specific bits inside #ifdef CONFIG_PPC_PMAC. Add new platform devices to > mac68k. > > Teste

Re: [PATCH 3/13] pmac-zilog: cleanup

2009-11-16 Thread Benjamin Herrenschmidt
On Wed, 2009-11-04 at 00:40 +1100, Finn Thain wrote: > Whitespace cleanups and comment typo fix. > > Signed-off-by: Finn Thain Acked-by: Benjamin Herrenschmidt Hi Finn. Do you want me to carry and merge those patches via the powerpc tree ? Cheers, Ben. __

Re: [PATCH 10/13] mac68k: start CUDA early

2009-11-16 Thread Benjamin Herrenschmidt
On Wed, 2009-11-04 at 00:46 +1100, Finn Thain wrote: > The valkyriefb driver needs the CUDA to work in order to set the video > mode at boot. Initialising the device earlier, and bring the m68k code > closer to the powermac code. > > Signed-off-by: Finn Thain Hi Finn ! > @@ -224,20 +249,9 @@

Re: [PATCH 00/10] Fix 8xx MMU/TLB

2009-11-16 Thread Scott Wood
Joakim Tjernlund wrote: Scott Wood wrote on 16/11/2009 22:27:41: On Mon, Nov 16, 2009 at 03:00:09PM -0600, Scott Wood wrote: On Sun, Nov 15, 2009 at 06:09:27PM +0100, Joakim Tjernlund wrote: [I used the wrong branch, this will hopefully not conflict] This is hopfully the last iteration of th

[PATCH] POWERPC 4xx: Fix PCI in AMCC 440EP Yosemite DTS

2009-11-16 Thread Curtis Wald
Yosemite.dts stanza for PCI was copied from Bamboo which has four PCI slots; Yosemite only has one PCI slot which is mapped to IDSEL 12, ADDR 22, IRQ2 Vector 25, INTA. Signed-off-by: Curtis Wald --- arch/powerpc/boot/dts/yosemite.dts | 17 + 1 files changed, 5 insertions(+), 12

[PATCH 11/11] net/can/mscan: improve build

2009-11-16 Thread Wolfram Sang
- move Kconfig entries to the subdirectory - do remaining renames of mpc52xx to mpc5xxx Signed-off-by: Wolfram Sang --- drivers/net/can/Kconfig | 19 +--- drivers/net/can/mscan/Kconfig | 23 +++ drivers/net/can/mscan/Makefile |4 +- drivers/net/can/mscan/mpc52xx_ca

[PATCH 10/11] net/can/mscan: add error path to mscan_open()

2009-11-16 Thread Wolfram Sang
Signed-off-by: Wolfram Sang --- drivers/net/can/mscan/mscan.c | 16 +++- 1 files changed, 11 insertions(+), 5 deletions(-) diff --git a/drivers/net/can/mscan/mscan.c b/drivers/net/can/mscan/mscan.c index 263d1a9..bb06dfb 100644 --- a/drivers/net/can/mscan/mscan.c +++ b/drivers/net/

[PATCH 09/11] net/can/mscan: replace hardcoded values with defines

2009-11-16 Thread Wolfram Sang
Not all hardcoded values have been replaced as this made the code quite unreadable. IMHO this compromise serves the purpose of readability. Signed-off-by: Wolfram Sang --- drivers/net/can/mscan/mscan.c | 15 ++- drivers/net/can/mscan/mscan.h |5 + 2 files changed, 15 insert

[PATCH 08/11] net/can/mpc52xx_can: improve properties and their description

2009-11-16 Thread Wolfram Sang
Signed-off-by: Wolfram Sang Cc: devicetree-disc...@ozlabs.org --- Documentation/powerpc/dts-bindings/fsl/mpc5200.txt |9 + drivers/net/can/mscan/mpc52xx_can.c|3 +-- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/Documentation/powerpc/dts-bindings/f

[PATCH 07/11] net/can/mpc52xx_can: refactor clock-get routine

2009-11-16 Thread Wolfram Sang
Merge two functions into one. The result is smaller as they can now share some variables. Signed-off-by: Wolfram Sang --- drivers/net/can/mscan/mpc52xx_can.c | 45 -- 1 files changed, 16 insertions(+), 29 deletions(-) diff --git a/drivers/net/can/mscan/mpc52xx_

[PATCH 06/11] net/can/mscan: drop assignment in while-construct

2009-11-16 Thread Wolfram Sang
As suggested by Wolfgang Grandegger. Signed-off-by: Wolfram Sang --- drivers/net/can/mscan/mscan.c |6 -- 1 files changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/net/can/mscan/mscan.c b/drivers/net/can/mscan/mscan.c index 76e413e..20d1991 100644 --- a/drivers/net/can/mscan

[PATCH 05/11] net/can/mscan: fix function annotations

2009-11-16 Thread Wolfram Sang
- use extern where apropriate - don't export symbols Signed-off-by: Wolfram Sang --- drivers/net/can/mscan/mscan.c |3 --- drivers/net/can/mscan/mscan.h |2 +- 2 files changed, 1 insertions(+), 4 deletions(-) diff --git a/drivers/net/can/mscan/mscan.c b/drivers/net/can/mscan/mscan.c ind

[PATCH 04/11] net/can/mscan: use {clr|set}bits8 macros

2009-11-16 Thread Wolfram Sang
Signed-off-by: Wolfram Sang --- drivers/net/can/mscan/mscan.c | 19 +++ 1 files changed, 7 insertions(+), 12 deletions(-) diff --git a/drivers/net/can/mscan/mscan.c b/drivers/net/can/mscan/mscan.c index 839b471..ca8b556 100644 --- a/drivers/net/can/mscan/mscan.c +++ b/drivers/n

[PATCH 03/11] net/can/mscan: drop support for CAN_MODE_{SLEEP|STOP}

2009-11-16 Thread Wolfram Sang
The upper layer does not support it yet. Signed-off-by: Wolfram Sang --- drivers/net/can/mscan/mscan.c |8 1 files changed, 0 insertions(+), 8 deletions(-) diff --git a/drivers/net/can/mscan/mscan.c b/drivers/net/can/mscan/mscan.c index 6394de8..839b471 100644 --- a/drivers/net/can

[PATCH 02/11] net/can/mscan: trivial fixes

2009-11-16 Thread Wolfram Sang
- remove whitespaces - use ! and ?: when apropriate - make braces consistent Signed-off-by: Wolfram Sang --- drivers/net/can/mscan/mpc52xx_can.c | 16 +--- drivers/net/can/mscan/mscan.c | 25 + 2 files changed, 18 insertions(+), 23 deletions(-) diff

[PATCH 01/11] net/can/mscan: move defines into .h file

2009-11-16 Thread Wolfram Sang
Signed-off-by: Wolfram Sang --- drivers/net/can/mscan/mscan.c | 29 - drivers/net/can/mscan/mscan.h | 29 + 2 files changed, 29 insertions(+), 29 deletions(-) diff --git a/drivers/net/can/mscan/mscan.c b/drivers/net/can/mscan/mscan.c in

updates to the mscan-driver in net-next

2009-11-16 Thread Wolfram Sang
Hello, here are the patches which fix the issues for the mscan & mpc52xx_can drivers raised by Wolfgang Grandegger and Grant Likely. They are based on the initial version of the drivers I sent a few days ago. Devicetree-discuss has been added for the property changes. I will also update my branch

Re: [PATCH 00/10] Fix 8xx MMU/TLB

2009-11-16 Thread Joakim Tjernlund
Scott Wood wrote on 16/11/2009 22:27:41: > > On Mon, Nov 16, 2009 at 03:00:09PM -0600, Scott Wood wrote: > > On Sun, Nov 15, 2009 at 06:09:27PM +0100, Joakim Tjernlund wrote: > > > [I used the wrong branch, this will hopefully not conflict] > > > > > > This is hopfully the last iteration of the se

Re: [PATCH 00/10] Fix 8xx MMU/TLB

2009-11-16 Thread Scott Wood
On Mon, Nov 16, 2009 at 03:00:09PM -0600, Scott Wood wrote: > On Sun, Nov 15, 2009 at 06:09:27PM +0100, Joakim Tjernlund wrote: > > [I used the wrong branch, this will hopefully not conflict] > > > > This is hopfully the last iteration of the series. > > Rex & Scott, please test and signoff. > > C

Re: [PATCH 00/10] Fix 8xx MMU/TLB

2009-11-16 Thread Scott Wood
On Sun, Nov 15, 2009 at 06:09:27PM +0100, Joakim Tjernlund wrote: > [I used the wrong branch, this will hopefully not conflict] > > This is hopfully the last iteration of the series. > Rex & Scott, please test and signoff. > Changes since last version: > - Added mandatory pinning of iTLB > - Add

Re: [PATCH 3/4] mpc8349emitx: add OF descriptions of LocalBus devices

2009-11-16 Thread Dmitry Eremin-Solenikov
Describe all LocalBus chipselects on MPC8349E-MITX board. Also add flash bindings. Signed-off-by: Dmitry Eremin-Solenikov --- arch/powerpc/boot/dts/mpc8349emitx.dts | 21 - 1 files changed, 20 insertions(+), 1 deletions(-) diff --git a/arch/powerpc/boot/dts/mpc8349emitx.dt

Re: [PATCH 3/4] mpc8349emitx: add OF descriptions of LocalBus devices

2009-11-16 Thread Scott Wood
On Mon, Nov 16, 2009 at 04:58:53PM +0300, Dmitry Eremin-Solenikov wrote: > + fl...@0,1 { > + #address-cells = <1>; > + #size-cells = <1>; > + compatible = "cfi-flash"; > + reg = <0x0 0x80 0x80>; > +

Re: [PATCH] net/can: add driver for mscan family & mpc52xx_mscan

2009-11-16 Thread Wolfram Sang
Hi Grant, Wolfgang commented on some points already, I will pick up the other remarks, just one question: > > +       clk_src = of_get_property(np, "fsl,mscan-clk-src", NULL); > > +       if (clk_src && strcmp(clk_src, "ip") == 0) > > Should protect against non-null. strncmp() maybe? "ip" is n

Re: spi_mpc8xxx.c: chip select polarity problem

2009-11-16 Thread Anton Vorontsov
On Mon, Nov 16, 2009 at 08:10:37PM +0300, Anton Vorontsov wrote: [...] > > I also tried to set alow_flags[x] = 0 for active low. In this case the > > transfer works, but the initial value for the CS is wrong (Low instead of > > High). > > So it might be better to fix up initial value in the plat

Re: [PATCH 1/1] ata/sata_sil24: MSI support, disabled by default

2009-11-16 Thread Grant Grundler
On Sun, Nov 15, 2009 at 10:19 PM, Vivek Mahajan wrote: > The following patch adds MSI support. Some platforms > may have broken MSI, so those are defaulted to use > legacy PCI interrupts. > > Signed-off-by: Vivek Mahajan > --- >  drivers/ata/sata_sil24.c |    9 + >  1 files changed, 9 ins

Re: spi_mpc8xxx.c: chip select polarity problem

2009-11-16 Thread Anton Vorontsov
On Mon, Nov 16, 2009 at 05:42:46PM +0100, Torsten Fleischer wrote: > Hi all, > > I have 3 devices connected to the SPI bus of the MPC8313. For the Chip Select > (CS) signals 3 GPIOs of the controller are used. But the driver uses the > inverse polarity of the CS either during the initialization

spi_mpc8xxx.c: chip select polarity problem

2009-11-16 Thread Torsten Fleischer
Hi all, I have 3 devices connected to the SPI bus of the MPC8313. For the Chip Select (CS) signals 3 GPIOs of the controller are used. But the driver uses the inverse polarity of the CS either during the initialization or at the transfer - depending on the setup of the flattened device tree. H

RE: [PATCH/RFC] Booting Xilinx ML510 board using SystemACE

2009-11-16 Thread Stephen Neuendorffer
Alon, There are at least two other ways that you might be able to reset a board: 1) Internally through the ICAP device. 2) Through a GPIO connected externally to the reset logic. Part of this is board specific, part of is it design specific. Probably it would be best to have a mechanism in the d

[Proposal] [PATCH] [RESEND] generic clock framework

2009-11-16 Thread Francesco VIRLINZI
Hi all I'm Francesco and I work in STMicroelectronics In the last ELC-E_2009 I spoke on a generic clock framework I'm working on (see http://tree.celinuxforum.org/CelfPubWiki/ELCEurope2009Presentations?action=AttachFile&do=view&target=ELC_E_2009_Generic_Clock_Framework.pdf). I wrote the gc

[PATCH 4/4] mpc8349emitx: add leds-gpio binding

2009-11-16 Thread Dmitry Eremin-Solenikov
Signed-off-by: Dmitry Eremin-Solenikov --- arch/powerpc/boot/dts/mpc8349emitx.dts | 18 ++ 1 files changed, 18 insertions(+), 0 deletions(-) diff --git a/arch/powerpc/boot/dts/mpc8349emitx.dts b/arch/powerpc/boot/dts/mpc8349emitx.dts index 097950c..fb58a7c 100644 --- a/arch/po

[PATCH 2/4] mpc8349emitx: populate I2C busses

2009-11-16 Thread Dmitry Eremin-Solenikov
Add OF descriptions of EEPROM, two GPIO extenders and SPD hanging on I2C on this board. Signed-off-by: Dmitry Eremin-Solenikov --- arch/powerpc/boot/dts/mpc8349emitx.dts | 25 + 1 files changed, 25 insertions(+), 0 deletions(-) diff --git a/arch/powerpc/boot/dts/mpc834

[PATCH 3/4] mpc8349emitx: add OF descriptions of LocalBus devices

2009-11-16 Thread Dmitry Eremin-Solenikov
Describe all LocalBus chipselects on MPC8349E-MITX board. Also add flash bindings. Signed-off-by: Dmitry Eremin-Solenikov --- arch/powerpc/boot/dts/mpc8349emitx.dts | 21 - 1 files changed, 20 insertions(+), 1 deletions(-) diff --git a/arch/powerpc/boot/dts/mpc8349emitx.dt

[PATCH 1/4] mpc8349emitx: add gpio controller declarations

2009-11-16 Thread Dmitry Eremin-Solenikov
mpc8349 bears two GPIO controllers. Enable support for them. Signed-off-by: Dmitry Eremin-Solenikov --- arch/powerpc/boot/dts/mpc8349emitx.dts | 18 ++ 1 files changed, 18 insertions(+), 0 deletions(-) diff --git a/arch/powerpc/boot/dts/mpc8349emitx.dts b/arch/powerpc/boot/dt

[PATCH 0/4] mpc8349emitx: add bindings for GPIO, I2C and leds

2009-11-16 Thread Dmitry Eremin-Solenikov
Hello, Please apply the following patches: Dmitry Eremin-Solenikov (4): mpc8349emitx: add gpio controller declarations mpc8349emitx: populate I2C busses mpc8349emitx: add OF descriptions of LocalBus devices mpc8349emitx: add leds-gpio binding arch/powerpc/boot/dts/mpc834

Re: [PATCH] net/can: add driver for mscan family & mpc52xx_mscan

2009-11-16 Thread Wolfgang Grandegger
Hi Wolfram, Wolfram Sang wrote: > Hi Wolfgang, > > On Mon, Nov 16, 2009 at 09:44:05AM +0100, Wolfgang Grandegger wrote: >> Hi Wolfram, >> >> thanks for pushing this driver to mainline. I think you should also add >> a CC to the Devicetree-discuss ML. > > thank you very much for your review! I ag

Re: [PATCH] macintosh: Explicitly set llseek to no_llseek in ans-lcd

2009-11-16 Thread Arnd Bergmann
On Monday 16 November 2009, Christoph Hellwig wrote: > As mentioned before making generic_file_llseek the new default is > probably a bad idea. The majority of our file_operations instances > don't actually support seeking, so no_llseek should become the new > default if you spend some effort on c

Re: [PATCH] macintosh: Explicitly set llseek to no_llseek in ans-lcd

2009-11-16 Thread Christoph Hellwig
On Mon, Nov 02, 2009 at 04:51:52PM +0100, Arnd Bergmann wrote: > I looked at what places in the code manipulate file->f_pos directly > and found that almost all the uses in driver code are broken because > they don't take any locks. Most of them are in driver specific > lseek operations. Others are

Re: [v9 PATCH 0/9]: cpuidle: Cleanup cpuidle/ Introduce cpuidle to POWER.

2009-11-16 Thread Arun R Bharadwaj
* Arun R Bharadwaj [2009-10-16 15:08:50]: > Hi, > > This patchset introduces cpuidle infrastructure to POWER, prototyping > for pSeries, and also does a major refactoring of current x86 idle > power management and a cleanup of cpuidle infrastructure. > > This patch series has been in discussion

Re: [PATCH] net/can: add driver for mscan family & mpc52xx_mscan

2009-11-16 Thread Wolfram Sang
Hi Wolfgang, On Mon, Nov 16, 2009 at 09:44:05AM +0100, Wolfgang Grandegger wrote: > Hi Wolfram, > > thanks for pushing this driver to mainline. I think you should also add > a CC to the Devicetree-discuss ML. thank you very much for your review! I agree with nearly all of your points and will s

Re: [PATCH] net/can: add driver for mscan family & mpc52xx_mscan

2009-11-16 Thread David Miller
From: Wolfram Sang Date: Mon, 16 Nov 2009 11:12:05 +0100 >> >> Taken from socketcan-svn, fixed remaining todos, cleaned up, tested with a >> >> phyCORE-MPC5200B-IO and a custom board. >> >> >> >> Signed-off-by: Wolfram Sang >> > >> > Applied. >> >> Unfortunately too early. I will send my revie

Re: [PATCH] net/can: add driver for mscan family & mpc52xx_mscan

2009-11-16 Thread Wolfram Sang
David, > >> Taken from socketcan-svn, fixed remaining todos, cleaned up, tested with a > >> phyCORE-MPC5200B-IO and a custom board. > >> > >> Signed-off-by: Wolfram Sang > > > > Applied. > > Unfortunately too early. I will send my review tomorrow. Sorry for the > delay. So, I'd assume that I n

Re: [PATCH] net/can: add driver for mscan family & mpc52xx_mscan

2009-11-16 Thread Wolfgang Grandegger
Hi Wolfram, thanks for pushing this driver to mainline. I think you should also add a CC to the Devicetree-discuss ML. Wolfram Sang wrote: > Taken from socketcan-svn, fixed remaining todos, cleaned up, tested with a > phyCORE-MPC5200B-IO and a custom board. > > Signed-off-by: Wolfram Sang > Cc:

Re: [PATCH] net/can: add driver for mscan family & mpc52xx_mscan

2009-11-16 Thread Wolfgang Grandegger
Grant Likely wrote: > On Fri, Nov 13, 2009 at 9:14 AM, Wolfram Sang wrote: >> Taken from socketcan-svn, fixed remaining todos, cleaned up, tested with a >> phyCORE-MPC5200B-IO and a custom board. >> >> Signed-off-by: Wolfram Sang >> Cc: Wolfgang Grandegger >> Cc: Grant Likely >> Cc: David Mille

Re: Bug in drivers/serial/of_serial.c?

2009-11-16 Thread Arnd Bergmann
On Sunday 15 November 2009, Alon Ziv wrote: > *)PORT_16450, }, > - { .type = "serial", .compatible = "ns16550", .data = (void > *)PORT_16550, }, > + { .type = "serial", .compatible = "ns16550", .data = (void > *)PORT_16550A, }, Does not seem logical. If the device claims compatibil