Hi Grant, Wolfgang commented on some points already, I will pick up the other remarks, just one question:
> > + clk_src = of_get_property(np, "fsl,mscan-clk-src", NULL); > > + if (clk_src && strcmp(clk_src, "ip") == 0) > > Should protect against non-null. strncmp() maybe? "ip" is null-terminated, or what do you mean? -- Pengutronix e.K. | Wolfram Sang | Industrial Linux Solutions | http://www.pengutronix.de/ |
signature.asc
Description: Digital signature
_______________________________________________ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev
