Hi Wolfgang, On Mon, Nov 16, 2009 at 09:44:05AM +0100, Wolfgang Grandegger wrote: > Hi Wolfram, > > thanks for pushing this driver to mainline. I think you should also add > a CC to the Devicetree-discuss ML.
thank you very much for your review! I agree with nearly all of your points and
will
send an update today. The only thing I have doubts about is removing those
lines:
> +MODULE_AUTHOR("Andrey Volkov <avol...@varma-el.com>");
> +MODULE_LICENSE("GPL v2");
> +MODULE_DESCRIPTION("CAN port driver for a MSCAN based chips");
I looked around in the kernel sources and found that they are often present in
generic modules, even if they can't be used without a wrapper (examples are all
files in drivers/i2c/algos or drivers/net/wireless/iwlwifi/iwl-core.c). As I'm
also a bit anxious to fiddle with other people's authorship, I'd prefer to keep
them.
Finally, I'll also try to test suspend/resume, but I have to find out if it is
supported on that board in general.
Regards,
Wolfram
--
Pengutronix e.K. | Wolfram Sang |
Industrial Linux Solutions | http://www.pengutronix.de/ |
signature.asc
Description: Digital signature
_______________________________________________ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev
