Re: Linux USB file storage gadget with new UDC

2013-06-03 Thread victor yeo
Hi, >> When i run USB 2.0 Command Verifier on file gadget and UDC driver, an >> error in Command Verifier says "Device must support being set to >> Addressed/Configured state". Does it mean the gadget cannot support >> putting device in addressed state or configured state, as in >> supporting the

Re: [PATCH v8 2/3] ARM: shmobile: r8a7778: add USB support

2013-06-03 Thread Sergei Shtylyov
Hello. On 03-06-2013 4:24, Kuninori Morimoto wrote: Add USB clock and EHCI, OHCI, and USB PHY platform devices for R8A7778 SoC; add a function to register PHY device with board-specific platform data and register EHCI and OHCI platfrom devices from the init_late() board method. Also, don't

[PATCH v1 1/1] mpc512x: silence a USB Kconfig dependency warning

2013-06-03 Thread Gerhard Sittig
the PPC_MPC512x config automatically selected USB_EHCI_BIG_ENDIAN_* switches, which made Kconfig warn about "unmet direct dependencies": scripts/kconfig/conf --silentoldconfig Kconfig warning: (PPC_MPC512x && 440EPX) selects USB_EHCI_BIG_ENDIAN_DESC which has unmet direct dependencies (USB_SU

[PATCH] chipidea: move to pcim_* functions

2013-06-03 Thread Andy Shevchenko
This patch makes error path cleaner and probe function tidier. Signed-off-by: Andy Shevchenko --- It assumes that removal of PCI_D0 and drvdata(NULL) were done previously. drivers/usb/chipidea/ci13xxx_pci.c | 18 +- 1 file changed, 5 insertions(+), 13 deletions(-) diff --git a

Re: [PATCH] usb: xhci: Disable runtime PM suspend for quirky controllers.

2013-06-03 Thread Oliver Neukum
On Wednesday 29 May 2013 16:32:38 Don Zickus wrote: > On Wed, May 29, 2013 at 12:38:28PM -0700, Sarah Sharp wrote: > > On Tue, May 28, 2013 at 02:41:18PM -0700, Julius Werner wrote: > > > The policy we want to achieve is to disable runtime PM iff there is a > > > device connected that doesn't have

Re: [PATCH] usb: dwc3: Addition of "dr_mode" dt property.

2013-06-03 Thread Michael Grzeschik
Hi Felipe, On Thu, May 30, 2013 at 03:31:21PM -0500, Ruchika Kharwar wrote: > This patch adds an optional parameter "dr_mode" to the dwc3 core device node. > In the case the compile flag for the DWC3 controller is set to > "USB_DWC3_DUAL_ROLE" a device tree could restrain to either functionality o

Re: [PATCH 1/7] USB: add devicetree helpers for determining dr_mode and phy_type

2013-06-03 Thread Alexander Shishkin
Michael Grzeschik writes: > From: Michael Grzeschik > > This adds two little devicetree helper functions for determining the > dr_mode (host, peripheral, otg) and phy_type (utmi, ulpi,...) from > the devicetree. This one needs an ack from Felipe. > > Signed-off-by: Michael Grzeschik > Signed-

Re: [PATCH 3/7] USB: chipidea: add PTW, PTS and STS handling

2013-06-03 Thread Alexander Shishkin
Michael Grzeschik writes: > From: Michael Grzeschik > > This patch makes it possible to configure the PTW, PTS and STS bits > inside the portsc register for host and device mode before the driver > starts and the phy can be addressed as hardware implementation is > designed. The bulk of this pa

Re: [PATCH 4/7] USB chipidea: introduce dual role mode pdata flags

2013-06-03 Thread Alexander Shishkin
Michael Grzeschik writes: > From: Sascha Hauer > > Even if a chipidea core is otg capable the board may not. This allows "may not be" > to explicitly set the core to host/peripheral mode. Without these > flags the driver falls back to the old behaviour. > > Signed-off-by: Sascha Hauer > ---

Re: [PATCH 5/7] USB chipidea i.MX: use devm_usb_get_phy_by_phandle to get phy

2013-06-03 Thread Alexander Shishkin
Michael Grzeschik writes: > From: Sascha Hauer > > Signed-off-by: Sascha Hauer Also please add a description. Regards, -- Alex -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kern

Re: [PATCH 6/7] usb: chipidea: udc: add force-full-speed option

2013-06-03 Thread Alexander Shishkin
Sascha Hauer writes: > On Sat, Jun 01, 2013 at 10:19:32AM +0200, Michael Grzeschik wrote: >> On Sat, Jun 01, 2013 at 09:39:33AM +0200, Sascha Hauer wrote: >> > On Fri, May 31, 2013 at 08:38:48PM +0200, Michael Grzeschik wrote: >> > > From: Michael Grzeschik >> > > >> > > This patch makes it pos

Re: [PATCH 7/7] usb: chipidea: usbmisc: use module_platform_driver

2013-06-03 Thread Alexander Shishkin
Michael Grzeschik writes: > From: Philipp Zabel > Please say something in the description. Thanks, -- Alex -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info

Re: [PATCH 2/4] chipidea: ci13xxx_imx: Remove reg_vbus

2013-06-03 Thread Fabio Estevam
Hi Shawn, On Tue, May 28, 2013 at 11:32 PM, Shawn Guo wrote: > Do you actually see the issue in real? While I'm fine with the change, > I do not think the current code will cause the issue you are describing > here, since the devm_kzalloc() of data ensures that data->reg_vbus is NULL > initiall

Re: [PATCH 05/11] usb: chipidea: register debugging sysfs on our device

2013-06-03 Thread Alexander Shishkin
Felipe Balbi writes: > Don't register anything non-generic under > the gadget's device as we don't really *own* > it. I've just found that this patch makes chipidea with CONFIG_CHIPIDEA_DEBUG broken on v3.9. Reason being, dbg_create_files() creates sysfs entries like "driver", "gadget" etc, whic

Re: Linux USB file storage gadget with new UDC

2013-06-03 Thread Alan Stern
On Mon, 3 Jun 2013, victor yeo wrote: > The gadget log when Command Verifier says "Device must support being > set to Addressed/Configured state" is attached. The log shows get > device descriptor, get configuration descriptor, and set configuration > requests are received. I see nothing wrong in

[Bug 59241] can't set 5bit data length on usbserial chip mos7840

2013-06-03 Thread Кекало Андрей
>--- Comment #1 from Greg Kroah-Hartman < g...@kroah.com > 2013-06-03 14:30:11 >--- >On Mon, Jun 03, 2013 at 01:44:08PM +,  bugzilla-dae...@bugzilla.kernel.org >wrote: >> Kernel Version: 3.2.0-46 patch for 3.8.0 --- mos7840.c.orig 2013-06-03 18:52:04.407415365 +0400 +++ mos7840.c 2013-06

[PATCH V3 0/2] USB: OHCI: Splitting ohci-platform into independent driver

2013-06-03 Thread Manjunath Goudar
This series patch begins the process of splitting ohci-platform up into independent driver modules and add a name for the platform-private field. Patch 1/2 separate ohci-platform into independent driver modules. V2 to V3: Directly Passed "hcd" argument without calling ohci_to_hcd() function. Pat

[PATCH 2/2] USB: OHCI: add a name for the platform-private field

2013-06-03 Thread Manjunath Goudar
This patch adds an ohci->priv field for private use by OHCI platform drivers. Until now none of the platform drivers has used this private space, but that's about to change in the next patch of this series. Signed-off-by: Manjunath Goudar Cc: Arnd Bergmann Cc: Greg KH Cc: Alan Stern Cc: linux

[PATCH 1/2] USB: OHCI: make ohci-platform a separate driver

2013-06-03 Thread Manjunath Goudar
This patch splits the ohci-platform code from ohci-hcd out into its own separate driver module.This work is part of enabling multi-platform kernels on ARM. In V2: -Passed "hcd" argument instead of "ohci" in ohci_setup() because it is using "struct usb_hcd" argument. In V3: -Directly passed

[PATCH V3 0/2] USB: OHCI: Splitting ohci-platform into independent driver

2013-06-03 Thread Manjunath Goudar
This series patch begins the process of splitting ohci-platform up into independent driver modules and add a name for the platform-private field. Patch 1/2 separate ohci-platform into independent driver modules. V2 to V3: Directly Passed "hcd" argument without calling ohci_to_hcd() function. Pat

[PATCH V3 2/2] USB: OHCI: add a name for the platform-private field

2013-06-03 Thread Manjunath Goudar
This patch adds an ohci->priv field for private use by OHCI platform drivers. Until now none of the platform drivers has used this private space, but that's about to change in the next patch of this series. Signed-off-by: Manjunath Goudar Cc: Arnd Bergmann Cc: Greg KH Cc: Alan Stern Cc: linux

[PATCH V3 1/2] USB: OHCI: make ohci-platform a separate driver

2013-06-03 Thread Manjunath Goudar
This patch splits the ohci-platform code from ohci-hcd out into its own separate driver module.This work is part of enabling multi-platform kernels on ARM. In V2: -Passed "hcd" argument instead of "ohci" in ohci_setup() because it is using "struct usb_hcd" argument. In V3: -Directly passed

Re: [Bug 59241] can't set 5bit data length on usbserial chip mos7840

2013-06-03 Thread Greg KH
On Mon, Jun 03, 2013 at 07:08:23PM +0400, Кекало Андрей wrote: > >--- Comment #1 from Greg Kroah-Hartman < g...@kroah.com > 2013-06-03 > 14:30:11 --- > >On Mon, Jun 03, 2013 at 01:44:08PM +,  > >bugzilla-dae...@bugzilla.kernel.org > >wrote: > >> Kernel Version: 3.2.0-46 > > patch for 3.8.0

Re: [PATCH V3 2/2] USB: OHCI: add a name for the platform-private field

2013-06-03 Thread Alan Stern
On Mon, 3 Jun 2013, Manjunath Goudar wrote: > This patch adds an ohci->priv field for private use by OHCI > platform drivers. > > Until now none of the platform drivers has used this private space, > but that's about to change in the next patch of this series. Acked-by: Alan Stern -- To unsubs

Re: [PATCH 3/7] USB: chipidea: add PTW, PTS and STS handling

2013-06-03 Thread Michael Grzeschik
Hey Alex, On Mon, Jun 03, 2013 at 03:35:37PM +0300, Alexander Shishkin wrote: > Michael Grzeschik writes: > > > From: Michael Grzeschik > > > > This patch makes it possible to configure the PTW, PTS and STS bits > > inside the portsc register for host and device mode before the driver > > start

[PATCH 3/5] extcon: add EXPORT_SYMBOL_GPL for exported functions

2013-06-03 Thread Kishon Vijay Abraham I
Added EXPORT_SYMBOL_GPL() for extcon_register_interest and extcon_register_notifier in order to avoid undefined reference error when building the consumer modules of extcon as _modules_. Signed-off-by: Kishon Vijay Abraham I Signed-off-by: Lokesh Vutla --- drivers/extcon/extcon-class.c |2 +

[PATCH 1/5] extcon: Add an API to get extcon device from dt node

2013-06-03 Thread Kishon Vijay Abraham I
Added an API of_extcon_get_extcon_dev() to be used by drivers to get extcon device in the case of dt boot (this can be used instead of extcon_get_extcon_dev()). Signed-off-by: Kishon Vijay Abraham I --- drivers/extcon/extcon-class.c | 40 include/linux/

[PATCH 2/5] extcon: Kconfig: Make extcon config type as bool

2013-06-03 Thread Kishon Vijay Abraham I
Changed the extcon config type to bool from module. Having extcon config type as module leads to some "undefined reference to" errors if the modules that uses these APIs are made as built-in and extcon as module. Signed-off-by: Kishon Vijay Abraham I --- drivers/extcon/Kconfig |2 +- 1 file

[PATCH 4/5] usb: dwc3: omap: improve error handling of dwc3_omap_probe

2013-06-03 Thread Kishon Vijay Abraham I
Improved the error handling of dwc3_omap_probe so that on error conditions dwc3_omap is left in the original state. Signed-off-by: Kishon Vijay Abraham I --- drivers/usb/dwc3/dwc3-omap.c | 17 ++--- 1 file changed, 14 insertions(+), 3 deletions(-) diff --git a/drivers/usb/dwc3/dwc

Re: [PATCH] staging: MIPS: add Octeon USB HCD support

2013-06-03 Thread David Daney
On 06/01/2013 11:42 AM, Aaro Koskinen wrote: Add support for Octeon USB HCD. Tested on EdgeRouter Lite with USB mass storage. The driver has been extracted from GPL sources of EdgeRouter Lite firmware (based on Linux 2.6.32.13). Some minor fixes and cleanups have been done to make it work with 3

[v3 PATCH 5/5] usb: dwc3: use extcon fwrk to receive connect/disconnect

2013-06-03 Thread Kishon Vijay Abraham I
Modified dwc3-omap to receive connect and disconnect notification using extcon framework. Also did the necessary cleanups required after adapting to extcon framework. Signed-off-by: Kishon Vijay Abraham I Acked-by: Felipe Balbi --- Changes from v2: * updated the Documentation with dwc3 dt bindin

[PATCH 0/5] dwc3: omap: adapt dwc3 to use extcon framework

2013-06-03 Thread Kishon Vijay Abraham I
The first three patches deals with cleanup of extcon inorder to get through compilation without any issues. It also adds an API to get extcon device from dt node which I felt was missing. The next two patches deals with adapt dwc3 to use extcon framework. The 4th patch (usb: dwc3: omap: improve er

Re: [PATCH] staging: MIPS: add Octeon USB HCD support

2013-06-03 Thread Greg Kroah-Hartman
On Mon, Jun 03, 2013 at 09:35:45AM -0700, David Daney wrote: > On 06/01/2013 11:42 AM, Aaro Koskinen wrote: > >Add support for Octeon USB HCD. Tested on EdgeRouter Lite with USB > >mass storage. > > > >The driver has been extracted from GPL sources of EdgeRouter Lite firmware > >(based on Linux 2.6

Re: [PATCH] staging: MIPS: add Octeon USB HCD support

2013-06-03 Thread David Daney
On 06/03/2013 09:52 AM, Greg Kroah-Hartman wrote: On Mon, Jun 03, 2013 at 09:35:45AM -0700, David Daney wrote: On 06/01/2013 11:42 AM, Aaro Koskinen wrote: Add support for Octeon USB HCD. Tested on EdgeRouter Lite with USB mass storage. The driver has been extracted from GPL sources of EdgeRou

Re: [PATCH v2 0/2] USB: PHY: Improve PHY selection logic

2013-06-03 Thread Greg KH
On Fri, May 31, 2013 at 02:29:01PM +0300, Roger Quadros wrote: > Hi, > > Improve Kconfig so that the relevant PHY driver can be explicitely > selected by the controller driver instead of relying on the user > to do so. > > Detailed description in patch 1. Felipe needs to take these, not I. than

Re: [PATCH 1/1] USB: ehci-omap: Reset dma_mask pointer on probe

2013-06-03 Thread Greg KH
On Thu, May 23, 2013 at 05:46:44PM +0300, Roger Quadros wrote: > On 05/23/2013 05:11 PM, Alan Stern wrote: > > On Thu, 23 May 2013, Roger Quadros wrote: > > > >> Device tree probed devices don't get dma_mask set. Previously > >> we were setting the dma_mask pointer only if it was NULL. > >> Howeve

Re: [RFC 0/6] xHCI and USB security bug fixes

2013-06-03 Thread Sarah Sharp
On Thu, May 30, 2013 at 07:04:03AM +0900, Greg Kroah-Hartman wrote: > On Wed, May 29, 2013 at 10:45:04AM -0700, Sarah Sharp wrote: > > On Wed, May 29, 2013 at 10:27:50AM +0900, Greg Kroah-Hartman wrote: > > > On Fri, May 24, 2013 at 05:42:52PM -0700, Sarah Sharp wrote: > > > > This patchset address

Re: [RFC 0/6] xHCI and USB security bug fixes

2013-06-03 Thread Greg Kroah-Hartman
On Mon, Jun 03, 2013 at 12:10:19PM -0700, Sarah Sharp wrote: > On Thu, May 30, 2013 at 07:04:03AM +0900, Greg Kroah-Hartman wrote: > > On Wed, May 29, 2013 at 10:45:04AM -0700, Sarah Sharp wrote: > > > On Wed, May 29, 2013 at 10:27:50AM +0900, Greg Kroah-Hartman wrote: > > > > On Fri, May 24, 2013

[PATCH 0/6] USB: make ehci-tegra its own module

2013-06-03 Thread Stephen Warren
From: Stephen Warren ehci-tegra is currently built into the main ehci-hcd driver, rather than being a separate module. This causes issues with multi-platform ARM kernels. This series separates ehci-tegra into its own module to avoid those problems. Manjunath Goudar originally wrote most of this

[PATCH 2/6] usb: phy: add MODULE_LICENSE to phy-tegra-usb.c

2013-06-03 Thread Stephen Warren
From: Stephen Warren When this file is built as a module, it needs a MODULE_LICENSE in order to access many exported symbols. Signed-off-by: Stephen Warren --- drivers/usb/phy/phy-tegra-usb.c |4 1 file changed, 4 insertions(+) diff --git a/drivers/usb/phy/phy-tegra-usb.c b/drivers/u

[PATCH 1/6] usb: phy: export ulpi_viewport_access_ops

2013-06-03 Thread Stephen Warren
From: Manjunath Goudar In order to build a ULPI PHY driver as a module, this symbol needs to be exported. Signed-off-by: Manjunath Goudar [swarren, reworked Manjunath's patches to split them more logically] Signed-off-by: Stephen Warren --- drivers/usb/phy/phy-ulpi-viewport.c |2 ++ 1 fil

[PATCH 5/6] USB: EHCI: fix circular dependency in Tegra modules

2013-06-03 Thread Stephen Warren
From: Stephen Warren The Tegra EHCI driver directly calls various functions in the Tegra USB PHY driver. The reverse is also true; the PHY driver calls into the EHCI driver. This is problematic when the two are built as modules. The calls from the PHY to EHCI driver were originally added in comm

[PATCH 3/6] USB: EHCI: expand struct ehci_driver_overrides

2013-06-03 Thread Stephen Warren
From: Manjunath Goudar Some EHCI HCD drivers may need to override additional fields in struct hc_driver, such as map_urb_for_dma, unmap_urb_for_dma, hub_control. Add fields to struct ehci_driver_overrides to allow them to do so. These new overrides will be used at least by the Tegra EHCI driver.

[PATCH 4/6] USB: EHCI: export symbols for ehci-hcd sub-drivers

2013-06-03 Thread Stephen Warren
From: Manjunath Goudar In order to split ehci-hcd.c into separate modules, various symbols must be exported. Also, rename the symbols to add an ehci_ prefix, to avoid any naming clashes. Signed-off-by: Manjunath Goudar [swarren, reworked Manjunath's patches to split them more logically] Signed-

[PATCH 6/6] USB: EHCI: make ehci-tegra a separate driver

2013-06-03 Thread Stephen Warren
From: Manjunath Goudar Separate the Tegra on-chip host controller driver from ehci-hcd host code so that it can be built as a separate driver module. This work is part of enabling multi-platform kernels on ARM. Signed-off-by: Manjunath Goudar [swarren, reworked Manjunath's patches to split them

Re: [PATCH] staging: MIPS: add Octeon USB HCD support

2013-06-03 Thread Greg Kroah-Hartman
On Sat, Jun 01, 2013 at 09:42:58PM +0300, Aaro Koskinen wrote: > Add support for Octeon USB HCD. Tested on EdgeRouter Lite with USB > mass storage. > > The driver has been extracted from GPL sources of EdgeRouter Lite firmware > (based on Linux 2.6.32.13). Some minor fixes and cleanups have been d

Re: [PATCH 1/6] usb: phy: export ulpi_viewport_access_ops

2013-06-03 Thread Sergei Shtylyov
Hello. On 06/03/2013 11:21 PM, Stephen Warren wrote: From: Manjunath Goudar In order to build a ULPI PHY driver as a module, this symbol needs to be exported. Signed-off-by: Manjunath Goudar [swarren, reworked Manjunath's patches to split them more logically] Signed-off-by: Stephen Warren

Re: [PATCH 3/6] USB: EHCI: expand struct ehci_driver_overrides

2013-06-03 Thread Alan Stern
On Mon, 3 Jun 2013, Stephen Warren wrote: > From: Manjunath Goudar > > Some EHCI HCD drivers may need to override additional fields in struct > hc_driver, such as map_urb_for_dma, unmap_urb_for_dma, hub_control. Add > fields to struct ehci_driver_overrides to allow them to do so. > > These new

Re: [PATCH 4/6] USB: EHCI: export symbols for ehci-hcd sub-drivers

2013-06-03 Thread Alan Stern
On Mon, 3 Jun 2013, Stephen Warren wrote: > From: Manjunath Goudar > > In order to split ehci-hcd.c into separate modules, various symbols must > be exported. Also, rename the symbols to add an ehci_ prefix, to avoid > any naming clashes. I have my doubts about this. Some of the exports are ok

Re: [PATCH 4/7] USB chipidea: introduce dual role mode pdata flags

2013-06-03 Thread Peter Chen
On Mon, Jun 3, 2013 at 8:37 PM, Alexander Shishkin wrote: > Michael Grzeschik writes: > >> From: Sascha Hauer >> >> Even if a chipidea core is otg capable the board may not. This allows > > "may not be" > >> to explicitly set the core to host/peripheral mode. Without these >> flags the driver fa

Re: [PATCH 1/1] usb: chipidea: Improve kconfig

2013-06-03 Thread Peter Chen
On Thu, May 9, 2013 at 3:51 AM, Randy Dunlap wrote: > On 05/08/13 03:02, Peter Chen wrote: >> Randy Dunlap reported below problem >> at i386: >>> drivers/built-in.o: In function `ci_hdrc_host_init': >>> (.text+0x2ce75c): undefined reference to `ehci_init_driver' >> >>> When USB_EHCI_HCD=m and USB

Re: [RFC] raise the maximum number of usb-serial devices to 512

2013-06-03 Thread Greg KH
On Mon, May 27, 2013 at 02:28:51PM +0200, Bjørn Mork wrote: > But, IMHO, a nicer approach would be to make the allocation completely > dynamic, using e.g. the idr subsystem. Static tables are always feel > like straight jackets to me, no matter how big they are :) You are right, I didn't change th

Re: [RFC] raise the maximum number of usb-serial devices to 512

2013-06-03 Thread Dave Jones
On Mon, Jun 03, 2013 at 07:49:59PM -0700, Greg Kroah-Hartman wrote: > On Mon, May 27, 2013 at 02:28:51PM +0200, Bjørn Mork wrote: > > But, IMHO, a nicer approach would be to make the allocation completely > > dynamic, using e.g. the idr subsystem. Static tables are always feel > > like straight

Re: gdm_usb.c:undefined reference to `usb_autopm_get_interface'

2013-06-03 Thread Greg Kroah-Hartman
On Mon, Jun 03, 2013 at 09:50:40PM -0700, Ben Chan wrote: > Thanks Alan! I revised the patch to enforce the dependency as follows: > > depends on (USB = y || USB = WIMAX_GDM72XX) > > depends on (MMC = y || MMC = WIMAX_GDM72XX) I can't accept attached patches, please resend them, in the emai

Re: [PATCH v8 2/3] ARM: shmobile: r8a7778: add USB support

2013-06-03 Thread Kuninori Morimoto
Hi > > The ohci/ehci resource will be used vainly if platform doesn't have USB > > The platform device resources are never used vainly. And remember > that if PHY doesn't get registered, OHCI/EHCI won't get probed > successfully either -- mind the usb_power_on() platform method. ? Could

Re: [PATCH] usb: gadget/uvc: Implement videobuf2 .wait_prepare and .wait_finish operations

2013-06-03 Thread Michael Grzeschik
Hi Felipe, On Mon, Apr 29, 2013 at 09:29:50AM +0300, Felipe Balbi wrote: > On Tue, Apr 23, 2013 at 01:36:33PM +0200, Laurent Pinchart wrote: > > On Tuesday 23 April 2013 14:16:56 Felipe Balbi wrote: > > > On Mon, Apr 15, 2013 at 02:45:39PM +0200, Laurent Pinchart wrote: > > > > > > > Those optiona