On Mon, 3 Jun 2013, Stephen Warren wrote: > From: Manjunath Goudar <manjunath.gou...@linaro.org> > > In order to split ehci-hcd.c into separate modules, various symbols must > be exported. Also, rename the symbols to add an ehci_ prefix, to avoid > any naming clashes.
I have my doubts about this. Some of the exports are okay, but not others. Renaming and exporting ehci_handshake is fine. ehci_tdi_reset maybe; I'm not sure. ehci_reset and ehci_halt are rather doubtful, and ehci_hub_control is definitely wrong. A better idea is to export ehci_hc_driver. Then the tegra module could call ehci_hc_driver->hub_control rather than directly accessing ehci_hub_control (this is another example of something which should be difficult, not easy). As for ehci_reset and ehci_halt (and possible ehci_tdi_reset), I rather suspect that ehci-tegra shouldn't be calling them at all. In fact, the whole implementation of suspend/resume in ehci-tegra (which is where these things get used) looks pretty dodgy. If the controller can't be suspended without invoking these private routines, then ... well, maybe it shouldn't be suspended, period. Alan Stern -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
