On Thursday, June 21, 2018 11:16 PM, Sebastian Andrzej Siewior wrote:
On 2018-06-21 22:19:32 [+0200], Daniel Mack wrote:
On Tuesday, June 19, 2018 11:55 PM, Sebastian Andrzej Siewior wrote:
Using usb_fill_int_urb() helps to find code which initializes an
URB. A grep for members of the struct
On Tuesday, June 19, 2018 11:55 PM, Sebastian Andrzej Siewior wrote:
Using usb_fill_int_urb() helps to find code which initializes an
URB. A grep for members of the struct (like ->complete) reveal lots
of other things, too.
Acked-by: Daniel Mack
Cc: Jaroslav Kysela
Cc: Takashi Iwai
Sig
callback
handler to disable the interrupts while acquiring the lock.
The callback may be invoked either in IRQ or BH context depending on the
USB host controller.
Use the _irqsave() variant of the locking primitives.
Acked-by: Daniel Mack
Cc: Jaroslav Kysela
Cc: Takashi Iwai
Signed-off-by: John
;
> We find this issue when we try to let 4 f_uac2 gadgets work together [1]
> at FS connection.
>
> [1]http://www.spinics.net/lists/linux-usb/msg123478.html
>
> Cc: andrze...@samsung.com
> Cc: Daniel Mack
> Cc: ti...@suse.de
> Cc: #v3.18+
> Cc: Alan Stern
> S
On 07/28/2015 11:30 AM, Daniel Mack wrote:
> On 07/28/2015 03:38 AM, Peter Chen wrote:
>> +static void set_ep_max_packet_size (struct f_uac2_opts *uac2_opts,
>> +struct usb_endpoint_descriptor *ep_desc, unsigned int factor)
>> +{
>> +int chmask;
>>
On 07/28/2015 03:38 AM, Peter Chen wrote:
> +static void set_ep_max_packet_size (struct f_uac2_opts *uac2_opts,
> + struct usb_endpoint_descriptor *ep_desc, unsigned int factor)
> +{
> + int chmask;
> + int srate;
> + int ssize;
> + u16 max_packet_size;
> +
> + if (ep_desc =
On 07/28/2015 03:38 AM, Peter Chen wrote:
> diff --git a/drivers/usb/gadget/function/f_uac2.c
> b/drivers/usb/gadget/function/f_uac2.c
> index 5318615..6a8e0d2 100644
> --- a/drivers/usb/gadget/function/f_uac2.c
> +++ b/drivers/usb/gadget/function/f_uac2.c
> @@ -975,6 +975,31 @@ free_ep(struct ua
nd reasonably
> sized packets"
>
Acked-by: Daniel Mack
Thanks for spotting this!
Daniel
> Cc: Daniel Mack
> Cc: #v3.18+
> Signed-off-by: Peter Chen
> ---
> drivers/usb/gadget/function/f_uac2.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
&g
;
> We find this issue when we try to let 4 f_uac2 gadgets work together [1]
> at FS connection.
>
> [1]http://www.spinics.net/lists/linux-usb/msg123478.html
>
> Cc: andrze...@samsung.com
> Cc: Daniel Mack
> Cc: ti...@suse.de
> Cc: #v3.18+
> Cc: Alan Stern
On 07/23/2015 03:00 AM, Peter Chen wrote:
> Thanks, it is correct. But looking the code at afunc_set_alt:
> the method of calculating uac2->p_pktsize seems incorrect, it
> may need to change like below:
Ok, sorry. I just read the code again an figured you're right here, this
needs fixing. It doesn
On 07/23/2015 10:35 AM, Peter Chen wrote:
> Assume the interval for each packet is 2ms, the rate is 192 kbytes
> for both FS & HS:
> uac2->p_interval = 2000;
> uac2->p_pktsize = 192 kbytes / 2000 = 96 bytes
>
> And the uac2->p_pktsize is real usb packet length, it means hardware
> would expect the
On 07/23/2015 03:00 AM, Peter Chen wrote:
>> That detail is merely about completeness. The code that calculates the
>> > value of wMaxPacketSize should take into account what is configured in
>> > bInterval of the endpoint, so if users change one thing, they don't have
>> > to tweak the other as w
On 07/22/2015 10:23 AM, Peter Chen wrote:
> On Wed, Jul 22, 2015 at 10:04:30AM +0200, Daniel Mack wrote:
>> On 07/22/2015 08:45 AM, Peter Chen wrote:
>>> According to USB Audio Device 2.0 Spec, Ch4.10.1.1:
>>> wMaxPacketSize is defined as follows:
>>> Maximum
On 07/22/2015 08:45 AM, Peter Chen wrote:
> According to USB Audio Device 2.0 Spec, Ch4.10.1.1:
> wMaxPacketSize is defined as follows:
> Maximum packet size this endpoint is capable of sending or receiving
> when this configuration is selected.
> This is determined by the audio bandwidth constrain
Hi,
On 07/14/2015 04:29 AM, Peter Chen wrote:
> According to USB Audio Device 2.0 Spec, Ch4.10.1.1:
> wMaxPacketSize is defined as follows:
> Maximum packet size this endpoint is capable of sending or receiving
> when this configuration is selected.
> This is determined by the audio bandwidth cons
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
On 11/20/2014 08:49 PM, Felipe Balbi wrote:
> On Tue, Nov 18, 2014 at 11:21:17PM +0100, Daniel Mack wrote:
>> f_midi_register_card() uses midi->id and midi->index, so they
>> need to be assigned before the function is called from
f_midi_register_card() uses midi->id and midi->index, so they need to
be assigned before the function is called from f_midi_bind_config().
Move the assigment of midi->buflen and midi->qlen as well so they are
all grouped.
Compile tested only.
Signed-off-by: Daniel Mack
---
driver
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
On 11/06/2014 08:38 AM, Sebastian Reimers wrote:
>> Sebastian (Reimers), given that you have a good test setup too,
>> any chance you can as well do some testing here?
>
> Of course. I can try to reproduce your bug and then retry it with
> Sebastian'
On 11/06/2014 05:55 AM, Felipe Balbi wrote:
> in case kernel is built without CONFIG_OF there
> will be a build warning (see below) due to of_match_ptr()
> being defined to NULL.
>
> Because of_match_ptr() is pretty pointless anyway,
> let's just remove it and fix the warning.
The alternative, of
On 11/05/2014 08:21 PM, Sebastian Andrzej Siewior wrote:
> On 11/05/2014 08:20 PM, Felipe Balbi wrote:
>>
>> could you just resend these two aptches ?
>
> I think about waiting for Daniel for some feedback. What about I resend
> them next week if I don't hear from him until then?
Sorry for the de
to
25 us. Also, when the callback is ran without taking action, it should
be rescheduled 20 us later instead of 50 us.
Reported-and-tested-by: Sven Neumann
Signed-off-by: Daniel Mack
---
drivers/usb/musb/musb_cppi41.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/driver
Hi Felipe,
On 08/29/2014 10:46 PM, Felipe Balbi wrote:
> On Wed, Aug 27, 2014 at 07:09:03PM +0200, Daniel Mack wrote:
>> Restructure some code to make it easier to read.
>>
>> While at it, return -ENOMEM instead of -EINVAL if
>> usb_ep_alloc_request() fails, and omi
Hi,
On 09/02/2014 02:41 PM, Jassi Brar wrote:
> On Sat, Aug 30, 2014 at 2:16 AM, Felipe Balbi wrote:
>> Hi,
>>
>> On Wed, Aug 27, 2014 at 07:09:03PM +0200, Daniel Mack wrote:
>>> Restructure some code to make it easier to read.
>>>
>>> W
Hi,
On 08/29/2014 08:13 AM, Jassi Brar wrote:
> +/*
> + * 5512.5Hz is going to need the maximum number of elements (80),
> + * in the length-pattern loop, among standard ALSA supported rates.
> + */
> +#define MAX_LOOP_LEN 80
> +
> struct uac2_rtd_params {
> struct snd_uac2_chip *uac2; /* p
On 08/28/2014 12:17 PM, Daniel Mack wrote:
> Felipe, could you already merge patch 1-5 of the last series (v6)?
1-4, of course. Jassi's changes will only affect patch 5/5.
Daniel
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a
On 08/28/2014 12:10 PM, Jassi Brar wrote:
> On Thu, Aug 28, 2014 at 3:33 PM, Daniel Mack wrote:
>> It's still superior to a number of unnecessary calculations done every
>> millisecond which will come up with the same result every time. So I
>> clearly favor that appr
On 08/28/2014 11:33 AM, Jassi Brar wrote:
> On Wed, Aug 27, 2014 at 10:39 PM, Daniel Mack wrote:
>> diff --git a/drivers/usb/gadget/function/f_uac2.c
>> b/drivers/usb/gadget/function/f_uac2.c
>> index 246a778..a5a27a5 100644
>> --- a/drivers/usb/gadget/function/f_
Restructure some code to make it easier to read.
While at it, return -ENOMEM instead of -EINVAL if
usb_ep_alloc_request() fails, and omit the logging in such cases
(the mm core will complain loud enough).
Signed-off-by: Daniel Mack
---
drivers/usb/gadget/function/f_uac2.c | 39
routine now.
Signed-off-by: Daniel Mack
---
drivers/usb/gadget/function/f_uac2.c | 32 +++-
1 file changed, 23 insertions(+), 9 deletions(-)
diff --git a/drivers/usb/gadget/function/f_uac2.c
b/drivers/usb/gadget/function/f_uac2.c
index 9c8831d..246a778 100644
--- a/dr
i Brar for the feedback!
Daniel
Subject: [PATCH v6 0/5] *** SUBJECT HERE ***
*** BLURB HERE ***
Daniel Mack (5):
usb: gadget: f_uac2: restructure some code in afunc_set_alt()
usb: gadget: f_uac2: add short-hand for 'dev'
usb: gadget: f_uac2: introduce agdev_to_uac2_opts
usb: ga
packet
are pre-computed for performance reasons.
Signed-off-by: Daniel Mack
---
drivers/usb/gadget/function/f_uac2.c | 69 +---
1 file changed, 65 insertions(+), 4 deletions(-)
diff --git a/drivers/usb/gadget/function/f_uac2.c
b/drivers/usb/gadget/function/f_ua
In afunc_bind() and afunc_set_alt(), &uac2->pdev.dev are used multiple
times. Adding a short-hand for them makes lines shorter so we can
remove some line wraps.
No functional change.
Signed-off-by: Daniel Mack
---
drivers/usb/gadget/function/f_uac2.c | 29 +++--
Add a simple container_of() wrapper to get a struct f_uac2_opts from a
struct struct audio_dev. Use it in two places where it is currently
open-coded.
Signed-off-by: Daniel Mack
---
drivers/usb/gadget/function/f_uac2.c | 10 --
1 file changed, 8 insertions(+), 2 deletions(-)
diff --git
On 08/27/2014 04:18 PM, Alan Stern wrote:
> On Wed, 27 Aug 2014, Daniel Mack wrote:
>> +/*
>> + * Whenever there are more bytes in the accumulator than we
>> + * need to add one more sample frame, increase this packet's
>> +
On 08/27/2014 10:38 AM, Jassi Brar wrote:
> On Wed, Aug 27, 2014 at 1:15 PM, Daniel Mack wrote:
>> Daniel Mack (5):
>> usb: gadget: f_uac2: restructure some code in afunc_set_alt()
>> usb: gadget: f_uac2: add short-hand for 'dev'
>> usb: gadget:
d at least the number of bytes
that are needed for one sample frame, increase the packet size.
This way, the packet size calculation will get rid of any kind of
imprecision that would otherwise occur with a simple division over
time.
Signed-off-by: Daniel Mack
---
drivers/usb/gadget/functio
routine now.
Signed-off-by: Daniel Mack
---
drivers/usb/gadget/function/f_uac2.c | 32 +++-
1 file changed, 23 insertions(+), 9 deletions(-)
diff --git a/drivers/usb/gadget/function/f_uac2.c
b/drivers/usb/gadget/function/f_uac2.c
index 9c8831d..246a778 100644
--- a/dr
In afunc_bind() and afunc_set_alt(), &uac2->pdev.dev are used multiple
times. Adding a short-hand for them makes lines shorter so we can
remove some line wraps.
No functional change.
Signed-off-by: Daniel Mack
---
drivers/usb/gadget/function/f_uac2.c | 29 +++--
Add a simple container_of() wrapper to get a struct f_uac2_opts from a
struct struct audio_dev. Use it in two places where it is currently
open-coded.
Signed-off-by: Daniel Mack
---
drivers/usb/gadget/function/f_uac2.c | 10 --
1 file changed, 8 insertions(+), 2 deletions(-)
diff --git
o fix buffer wrap problems in the ALSA buffer
logic, which wasn't needed before
The first two patches are just cleanups.
Thanks to Alan Stern and Jassi Brar for the feedback!
Daniel
Daniel Mack (5):
usb: gadget: f_uac2: restructure some code in afunc_set_alt()
usb: gadget: f
Restructure some code to make it easier to read.
While at it, return -ENOMEM instead of -EINVAL if
usb_ep_alloc_request() fails, and omit the logging in such cases
(the mm core will complain loud enough).
Signed-off-by: Daniel Mack
---
drivers/usb/gadget/function/f_uac2.c | 39
On 08/27/2014 09:35 AM, Jassi Brar wrote:
> On Wed, Aug 27, 2014 at 3:23 AM, Daniel Mack wrote:
>> + uac2->p_residue = 0;
>> } else {
>> dev_err(dev, "%s:%d Error!\n", __func__, __LINE__);
>>
On 08/27/2014 09:28 AM, Jassi Brar wrote:
> On Wed, Aug 27, 2014 at 12:45 PM, Daniel Mack wrote:
>> On 08/27/2014 09:07 AM, Jassi Brar wrote:
>>> On Wed, Aug 27, 2014 at 12:20 PM, Daniel Mack wrote:
>>
>>>> Hmm? The first USB_XFERS packets will only contain
On 08/27/2014 09:15 AM, Daniel Mack wrote:
> On 08/27/2014 09:07 AM, Jassi Brar wrote:
>> On Wed, Aug 27, 2014 at 12:20 PM, Daniel Mack wrote:
>
>>> Hmm? The first USB_XFERS packets will only contain zeros, and we're only
>>> preparing those here. For eve
On 08/27/2014 09:07 AM, Jassi Brar wrote:
> On Wed, Aug 27, 2014 at 12:20 PM, Daniel Mack wrote:
>> Hmm? The first USB_XFERS packets will only contain zeros, and we're only
>> preparing those here. For every successive packet, the length is
>> recalculated and the a
On 08/27/2014 06:08 AM, Jassi Brar wrote:
> On Wed, Aug 27, 2014 at 3:23 AM, Daniel Mack wrote:
>> + uac2->p_interval = (1 << (ep_desc->bInterval - 1)) * factor;
>> + req_len = rate / uac2->p_interval;
>>
> +
d at least the number of bytes
that are needed for one sample frame, increase the packet size.
This way, the packet size calculation will get rid of any kind of
imprecision that would otherwise occur with a simple division over
time.
Signed-off-by: Daniel Mack
---
drivers/usb/gadget/functio
Add a simple container_of() wrapper to get a struct f_uac2_opts from a
struct struct audio_dev. Use it in two places where it is currently
open-coded.
Signed-off-by: Daniel Mack
---
drivers/usb/gadget/function/f_uac2.c | 10 --
1 file changed, 8 insertions(+), 2 deletions(-)
diff --git
routine now.
Signed-off-by: Daniel Mack
---
drivers/usb/gadget/function/f_uac2.c | 32 +++-
1 file changed, 23 insertions(+), 9 deletions(-)
diff --git a/drivers/usb/gadget/function/f_uac2.c
b/drivers/usb/gadget/function/f_uac2.c
index 9c8831d..246a778 100644
--- a/dr
Restructure some code to make it easier to read.
While at it, return -ENOMEM instead of -EINVAL if
usb_ep_alloc_request() fails, and omit the logging in such cases
(the mm core will complain loud enough).
Signed-off-by: Daniel Mack
---
drivers/usb/gadget/function/f_uac2.c | 39
In afunc_bind() and afunc_set_alt(), &uac2->pdev.dev are used multiple
times. Adding a short-hand for them makes lines shorter so we can
remove some line wraps.
No functional change.
Signed-off-by: Daniel Mack
---
drivers/usb/gadget/function/f_uac2.c | 29 +++--
which wasn't needed before
The first two patches are just cleanups.
Thanks to Alan Stern and Jassi Brar for the feedback!
Daniel
Daniel Mack (5):
usb: gadget: f_uac2: restructure some code in afunc_set_alt()
usb: gadget: f_uac2: add short-hand for 'dev'
usb: gadge
On 08/26/2014 05:08 PM, Alan Stern wrote:
> The normal approach is to perform a simple runtime calculation (no
> pre-allocated pattern). It's not complex.
>
> Let S be the number of samples per second at the nominal transfer rate
> (for example, S = 44100). Let R be the number of packets per s
In afunc_bind() and afunc_set_alt(), &uac2->pdev.dev are used multiple
times. Adding a short-hand for them makes lines shorter so we can
remove some line wraps.
No functional change.
Signed-off-by: Daniel Mack
---
drivers/usb/gadget/function/f_uac2.c | 29 +++--
Restructure some code to make it easier to read.
While at it, return -ENOMEM instead of -EINVAL if
usb_ep_alloc_request() fails, and omit the logging in such cases
(the mm core will complain loud enough).
Signed-off-by: Daniel Mack
---
drivers/usb/gadget/function/f_uac2.c | 39
routine now.
Signed-off-by: Daniel Mack
---
drivers/usb/gadget/function/f_uac2.c | 32 +++-
1 file changed, 23 insertions(+), 9 deletions(-)
diff --git a/drivers/usb/gadget/function/f_uac2.c
b/drivers/usb/gadget/function/f_uac2.c
index efe8add..a18f147 100644
--- a/dr
ey seem to work well
on a BBB setup here.
Thanks,
Daniel
Daniel Mack (4):
usb: gadget: f_uac2: restructure some code in afunc_set_alt()
usb: gadget: f_uac2: add short-hand for 'dev'
usb: gadget: f_uac2: handle partial dma area wrap
usb: gadget: f_uac2: send reasonably sized p
tes/s. With a simple division by the number
of available frames (1000), we would be off by 400 bytes, or 100
samples per second. By preparing a sequence of lengths, we can make
each 10th packet accomodate one more frame, which results in 400 more
bytes/s.
Signed-off-by: Daniel Mack
---
driver
On 08/25/2014 07:22 PM, Jassi Brar wrote:
> On Mon, Aug 25, 2014 at 9:30 PM, Daniel Mack wrote:
>> @@ -187,7 +189,7 @@ agdev_iso_complete(struct usb_ep *ep, struct usb_request
>> *req)
>>
>> if (substream->stream == SNDRV_PCM_STREAM_PLAYBACK) {
>>
On 08/25/2014 09:00 PM, Jassi Brar wrote:
> On Mon, Aug 25, 2014 at 11:40 PM, Daniel Mack wrote:
>> Sure, but rates across devices will never match, so it doesn't matter
>> really. Two clocks on two devices will always drift, even if they're
>> totally accurate b
Hi,
On 08/25/2014 07:43 PM, Jassi Brar wrote:
> On Mon, Aug 25, 2014 at 10:52 PM, Jassi Brar wrote:
>> I believe you want to do the following in afunc_set_alt().
>> - req->length = prm->max_psize;
>> + req->length = uac2->c_pktsize;
>>
> Sorry I intended...
>- prm->max_psize = hs_epin
Hi,
On 08/25/2014 07:22 PM, Jassi Brar wrote:
> On Mon, Aug 25, 2014 at 9:30 PM, Daniel Mack wrote:
>> The UAC2 function driver currently responds to all packets at all times
>> with wMaxPacketSize packets. That results in way too fast audio
>> playback as the function dri
t two patches are just cleanups.
Sebastian, could you give these patches a try? They seem to work well
on a BBB setup here.
Thanks,
Daniel
Daniel Mack (4):
usb: gadget: f_uac2: restructure some code in afunc_set_alt()
usb: gadget: f_uac2: add short-hand for 'dev'
usb: gadget: f_uac2:
Restructure some code to make it easier to read.
While at it, return -ENOMEM instead of -EINVAL if
usb_ep_alloc_request() fails, and omit the logging in such cases
(the mm core will complain loud enough).
Signed-off-by: Daniel Mack
---
drivers/usb/gadget/function/f_uac2.c | 39
sized packets, we have to
address such cases, and copy the payload in two steps conditionally.
The 'src' and 'dst' approach doesn't work here anymore, as different
behavior is necessary in playback and capture cases. Thus, this patch
open-codes the routine now.
S
In afunc_bind() and afunc_set_alt(), &uac2->pdev.dev are used multiple
times. Adding a short-hand for them makes lines shorter so we can
remove some line wraps.
No functional change.
Signed-off-by: Daniel Mack
---
drivers/usb/gadget/function/f_uac2.c | 29 +++--
e host.
Signed-off-by: Daniel Mack
---
drivers/usb/gadget/function/f_uac2.c | 27 ++-
1 file changed, 26 insertions(+), 1 deletion(-)
diff --git a/drivers/usb/gadget/function/f_uac2.c
b/drivers/usb/gadget/function/f_uac2.c
index efe8add..610a2f1 100644
--- a/drivers/usb/
On 08/25/2014 11:30 AM, Jassi Brar wrote:
> On Mon, Aug 25, 2014 at 2:57 PM, Daniel Mack wrote:
>> On 08/25/2014 11:23 AM, Jassi Brar wrote:
>>> On Mon, Aug 25, 2014 at 2:14 PM, Daniel Mack wrote:
>>
>>>> The easiest is probably really to just calculate co
On 08/25/2014 11:23 AM, Jassi Brar wrote:
> On Mon, Aug 25, 2014 at 2:14 PM, Daniel Mack wrote:
>> The easiest is probably really to just calculate correct packet sizes
>> and stick to them. After all, the actual clock is really arbitrary, we
>> just have to pick something
Hi Clemens,
On 08/25/2014 09:15 AM, Clemens Ladisch wrote:
> Daniel Mack wrote:
>> a) Linux snd-usb-audio currently pre-calculates the estimated packet
>> sizes to expect from a USB device, and will only receive packets that
>> have the expected size or are smaller.
>
In afunc_bind() and afunc_set_alt(), &uac2->pdev.dev are used multiple
times. Adding a short-hand for them makes lines shorter so we can
remove some line wraps.
No functional change.
Signed-off-by: Daniel Mack
---
drivers/usb/gadget/function/f_uac2.c | 29 +++--
the gadget side.
Signed-off-by: Daniel Mack
---
drivers/usb/gadget/function/f_uac2.c | 37 +++-
1 file changed, 36 insertions(+), 1 deletion(-)
diff --git a/drivers/usb/gadget/function/f_uac2.c
b/drivers/usb/gadget/function/f_uac2.c
index 1d6d085..176898d 100644
Restructure some code to make it easier to read.
While at it, return -ENOMEM instead of -EINVAL if
usb_ep_alloc_request() fails, and omit the logging in such cases
(the mm core will complain loud enough).
Signed-off-by: Daniel Mack
---
drivers/usb/gadget/function/f_uac2.c | 39
That consequently leads to -EOVERFLOW errors on the
host side.
Reported-by: Sebastian Reimers
Signed-off-by: Daniel Mack
---
drivers/usb/gadget/function/f_uac2.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/usb/gadget/function/f_uac2.c
b/drivers/usb/gadget/function/f
other one to be sent.
This results in very stable timing behavior in my tests.
Patch 1/4 and 2/4 are just cleanups that I did before fixing the issues
described above. The series is intended for Felipe's current 'next'
branch.
Best regards,
Daniel
Daniel Mack (4):
usb: gadget: f_
On 08/24/2014 06:26 PM, Jassi Brar wrote:
> On Sun, Aug 24, 2014 at 7:26 PM, Daniel Mack wrote:
>> f_uac2, however, currently always completes its buffers with 512 bytes
>> packets,
> Current uac2 uses the max packset size (which may not be 512 for every
> udc) fo
On 08/22/2014 04:43 AM, Xuebing Wang wrote:
> static inline bool gadget_supports_altsettings(struct usb_gadget *gadget)
> {
> /* PXA 21x/25x/26x has no altsettings at all */
> if (gadget_is_pxa(gadget))
> return false;
>
> /* PXA 27x and 3xx have *broken
Hi Jassi,
On 08/19/2014 11:52 AM, Jassi Brar wrote:
> Its been quite some time now, but I think we designed the uac2 to rely
> on USB's ISO packets' rate control to send and receive audio data at
> announced sampling rate.
I'm still thinking how that setup should have ever been possible with
snd-
On 08/19/2014 11:56 AM, Daniel Mack wrote:
> On 07/22/2014 11:08 AM, Subbaraya Sundeep Bhatta wrote:
>> drivers/usb/gadget/Kconfig | 14 +
>> drivers/usb/gadget/Makefile |1 +
>> drivers/usb/gadget/udc-xilinx.c | 2261
>>
Hi,
On 07/22/2014 11:08 AM, Subbaraya Sundeep Bhatta wrote:
> This patch adds xilinx usb2 device driver support
Add some more information here, please. Copying the text from the
Kconfig option is already a good start.
> drivers/usb/gadget/Kconfig | 14 +
> drivers/usb/gadget/Makefile
On 08/19/2014 11:01 AM, Jassi Brar wrote:
> On Tue, Aug 19, 2014 at 2:15 PM, Daniel Mack wrote:
>> On 08/19/2014 02:01 AM, Xuebing Wang wrote:
>>
>>>>> root@imx6slevk:~#
>>>>> root@imx6slevk:~# arecord -f dat -t wav -D hw:2,0 | aplay -D hw:0,0
>&g
On 08/19/2014 10:54 AM, Xuebing Wang wrote:
>
>>> Thanks. You were trying UAC2, right?
>> Yes.
>
> Thanks Daniel. Did you hear noise (hear with ear phone, not speaker)
> especially when playing music from Ubuntu host? I am hearing slight
> noise here.
>
Not that I noticed. I'd suggest recordi
On 08/19/2014 02:01 AM, Xuebing Wang wrote:
> On 08/19/2014 01:11 AM, Daniel Mack wrote:
>> On 08/15/2014 05:49 AM, Xuebing Wang wrote:
>>> root@imx6slevk:~#
>>> root@imx6slevk:~# arecord -f dat -t wav -D hw:2,0 | aplay -D hw:0,0
>>> Recording WAVE 's
On 08/15/2014 05:49 AM, Xuebing Wang wrote:
> Jassi, thanks for your help.
>
> Without knowing what is the best way to implement UAC2 at the device
> side, I managed to simply pipe is as below:
>
> Note: When I am playing music from Ubuntu host, I can hear light noise
> from the device (via UAC
On 08/15/2014 05:25 PM, Lionel wrote:
> Thanks Daniel!
You're welcome!
> I decided to ask the vendor to fix the bug in the firmware. Do I have
> any expectation of success?
Probably not. Most audio hardware vendors don't care about Linux.
> What should be the best way to request
> support for l
Hi,
On 08/15/2014 04:00 PM, Lionel wrote:
> Hi Daniel. This is trace when i connect the midi controller.
Thanks. This one here is the setup packet followed by the answer, which
is the device descriptor:
> 8801cbae2a80 1534946150 S Ci:2:000:0 s 80 06 0100 0040 64 <
> 8801cbae2a80 15
On 08/15/2014 12:21 AM, Lion Bino wrote:
> I have a problem a midi controller, a Samson Carbon 61. When I connect
> via usb, dmesg tells me the following.
>
>
> [ 1480.097123] usb 2-1.1: new full-speed USB device number 9
> using ehci_hcd
> [ 1480.118082] usb 2-1.1: no configurati
On 08/12/2014 07:32 PM, Bin Liu wrote:
> 633 #if defined(CONFIG_USB_INVENTRA_DMA) || defined(CONFIG_USB_UX500_DMA)
> ...
> 658 #else
> 659 if (!is_cppi_enabled() && !tusb_dma_omap())
> 660 return false;
> ...
> 668 mode = (urb->transfer_flags & URB_ZERO_PACKET) ?
On 08/12/2014 07:05 PM, Bin Liu wrote:
>> Don't you need to check for (urb->transfer_flags & URB_ZERO_PACKET)
>> somewhere here? I'd not expect an extra 0-byte packet at the end of a
>> transfer unless this flag is set.
>
> mode is set to 1 when (urb->transfer_flags & URB_ZERO_PACKET), in
> musb_t
Hi Bin,
On 08/12/2014 06:46 PM, Bin Liu wrote:
> drivers/usb/musb/musb_cppi41.c | 15 +--
> 1 file changed, 13 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/usb/musb/musb_cppi41.c b/drivers/usb/musb/musb_cppi41.c
> index 5989def..e9a0e54 100644
> --- a/drivers/usb/musb/musb_
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
On 07/22/2014 07:44 PM, Felipe Balbi wrote:
> On Tue, Jul 22, 2014 at 07:09:51PM +0200, Daniel Mack wrote:
>> On 07/04/2014 07:43 AM, Takashi Iwai wrote:
>>> At Thu, 3 Jul 2014 20:15:28 +0200, Sebastian Reimers wrote:
>>>&
On 07/04/2014 07:43 AM, Takashi Iwai wrote:
> At Thu, 3 Jul 2014 20:15:28 +0200,
> Sebastian Reimers wrote:
>>
>> The pcm playback and capture sample size format was fixed
>> SNDRV_PCM_FMTBIT_S16_LE.
>>
>> This patch respects also 16, 24 and 32 bit p_ssize and c_ssize values.
>>
>> Signed-off-by:
On 06/30/2014 09:40 PM, Daniel Mack wrote:
> #3 fixes a reproducible kernel crash when unplugging streaming audio
> devices, and #5 causes data stream starvation which makes using many
s/causes/fixes/, of course.
--
To unsubscribe from this list: send the line "unsubscribe linux-
On 06/30/2014 09:31 PM, Felipe Balbi wrote:
> On Mon, Jun 30, 2014 at 09:29:10PM +0200, Daniel Mack wrote:
>> -BEGIN PGP SIGNED MESSAGE-
>> Hash: SHA1
>>
>> On 06/30/2014 09:26 PM, Felipe Balbi wrote:
>>> On Mon, Jun 30, 2014 at 09:19:08PM +0200, Dan
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
On 06/30/2014 09:26 PM, Felipe Balbi wrote:
> On Mon, Jun 30, 2014 at 09:19:08PM +0200, Daniel Mack wrote:
>> I also asked Vinod to pick this single patch for his tree, but
>> there was no answer yet.
>
> cool. hopefully we c
Hi Felipe,
Glad to see you find some time for this patch set :)
On 06/30/2014 07:19 PM, Felipe Balbi wrote:
> On Mon, May 26, 2014 at 02:52:34PM +0200, Daniel Mack wrote:
>> When a 0-length packet is received on the bus, desc->pd0 yields 1,
>> which confuses the driver's
On 06/30/2014 07:54 PM, Felipe Balbi wrote:
> Hi,
>
> On Fri, Jun 20, 2014 at 09:14:34AM +0530, George Cherian wrote:
>> On 6/20/2014 3:50 AM, Daniel Mack wrote:
>>> Hi,
>>>
>>> I've been debugging issues with musb in host mode and both full-speed
&
these changes in place, both FS and HS audio devices appear to work
well on AM335x hardware.
Signed-off-by: Daniel Mack
Reported-by: Sebastian Reimers
---
drivers/usb/musb/musb_cppi41.c | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/drivers/usb/musb/musb_cppi41.c b/dr
these patches are to be applied on top of my musb/cppi41
cleanup series that I sent ~3 weeks ago.
Thanks,
Daniel
v1 -> v2:
* clean up nanosecond/microsecond confusion in patch #2
Daniel Mack (2):
Revert "usb: musb: musb_cppi41: Handle ISOCH differently and not use
the hr
the patch tried to address can be handled differently, which is
what the next patch does.
Signed-off-by: Daniel Mack
Reported-by: Sebastian Reimers
---
drivers/usb/musb/musb_cppi41.c | 53 --
1 file changed, 53 deletions(-)
diff --git a/drivers/usb/musb/mus
1 - 100 of 436 matches
Mail list logo
