[PATCH v6] can: kvaser_usb: Add support for Kvaser CAN/USB devices

2012-11-20 Thread Olivier Sobrie
This driver provides support for several Kvaser CAN/USB devices. Such kind of devices supports up to three CAN network interfaces. It has been tested with a Kvaser USB Leaf Light (one network interface) connected to a pch_can interface. The firmware version of the Kvaser device was 2.5.205. List

[PATCH 1/1] USB: core: Free the allocated memory before exiting on error

2012-11-20 Thread Sachin Kamat
'new_interfaces' should be freed to avoid memory leak. Cc: Sarah Sharp Cc: Alan Stern Signed-off-by: Sachin Kamat --- drivers/usb/core/message.c |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/drivers/usb/core/message.c b/drivers/usb/core/message.c index a557658..165

Re: [PATCH v2 4/7] usb: chipidea: create the gadget at ci_hdrc_probe even at host role

2012-11-20 Thread Peter Chen
On Tue, Nov 20, 2012 at 10:12:30PM +0800, Peter Chen wrote: > On Tue, Nov 20, 2012 at 02:08:18PM +0200, Alexander Shishkin wrote: > > Peter Chen writes: > > > > > Since we can't load/unload gadget module on the fly, we can't > > > de-init gadget structure during the otg switch. > > > We have to c

Re: [PATCH v2 3/7] usb: chipidea: add otg id switch and vbus connect/disconnect detect

2012-11-20 Thread Peter Chen
On Tue, Nov 20, 2012 at 02:44:35PM +0200, Alexander Shishkin wrote: > Peter Chen writes: > > > diff --git a/drivers/usb/chipidea/ci.h b/drivers/usb/chipidea/ci.h > > index d738603..d32f932 100644 > > --- a/drivers/usb/chipidea/ci.h > > +++ b/drivers/usb/chipidea/ci.h > > @@ -139,6 +139,7 @@ struc

Re: [PATCH v2 3/7] usb: chipidea: add otg id switch and vbus connect/disconnect detect

2012-11-20 Thread Peter Chen
On Tue, Nov 20, 2012 at 08:52:04AM +0100, Sascha Hauer wrote: > On Tue, Nov 20, 2012 at 01:54:48PM +0800, Peter Chen wrote: > > On Mon, Nov 19, 2012 at 08:17:34PM +0100, Sascha Hauer wrote: > > > Hi Peter, > > > > > > > @@ -139,6 +139,7 @@ struct ci13xxx { > > > > enum ci_role

Re: [RFC] usb: add 'usb_get_intf()' call into the probe methods of drivers for usb interfaces.

2012-11-20 Thread harvey yang
Thanks for your comments :) Harvey On Wed, Nov 21, 2012 at 12:09 AM, Alan Stern wrote: > On Mon, 19 Nov 2012, harvey yang wrote: > >> Hi, all >> I checked many usb drivers in the mainline kernel which do not record >> this reference in their probe methods. But according to the documents >> abou

Re: kmemleak report on isp1763 and sierra MC8705

2012-11-20 Thread Greg Kroah-Hartman
On Wed, Nov 14, 2012 at 06:52:18PM +0100, Johan Hovold wrote: > On Wed, Nov 14, 2012 at 12:12:01PM -0500, Richard Retanubun wrote: > > On 10/11/12 09:30 AM, Johan Hovold wrote: > > Hi Johan, > > > > > There was a reference-count fix for the probe error path that went in to > > > v3.5. Haven't read

Re: [PATCH 00/16] OMAP USB Host cleanup

2012-11-20 Thread Tony Lindgren
Hi Roger, * Kevin Hilman [121119 15:24]: > Roger Quadros writes: > > > Kevin, > > > > On 11/16/2012 10:08 PM, Kevin Hilman wrote: > >> Roger Quadros writes: > >> > >>> Hi, > >>> > >>> This patchset addresses the following > >>> > >>> - Avoid addressing clocks one by one by name and use a for

Re: usb to parallel cable not recognized

2012-11-20 Thread Peter Stuge
Rolf Leggewie wrote: > Recently, I was given a usb-to-parallel adapter cable but the > latest mainline kernel does not recognize it. I can't find any > identifying information on the cable itself. Please let me know > what information I can provide to get this supported. The cable doesn't enumer

usb to parallel cable not recognized

2012-11-20 Thread Rolf Leggewie
Hello, I've also reported this in the bug tracker as https://bugzilla.kernel.org/show_bug.cgi?id=50791 but was advised there to bring it to the attention of the mailing list. Recently, I was given a usb-to-parallel adapter cable but the latest mainline kernel does not recognize it. I can't

Re: [PATCH 06/16] usb/gadget: convert source sink and loopback to new function interface

2012-11-20 Thread Michal Nazarewicz
> * Felipe Balbi | 2012-11-20 14:14:47 [+0200]: >> now this looks awfully wrong. Why don't you just expose the modules to >> userland (in fact they already are) and if user wants to change >> something it needs to do it via sysfs before enabling the function ? On Tue, Nov 20 2012, Sebastian Andrze

Re: [PATCH 15/16] usb/gadget: nokia: use function framework for ACM

2012-11-20 Thread Michal Nazarewicz
>> On Wed, Nov 14, 2012 at 06:15:05PM +0100, Sebastian Andrzej Siewior wrote: >>> diff --git a/drivers/usb/gadget/Kconfig b/drivers/usb/gadget/Kconfig >>> index 2d173b0..0c0d130 100644 >>> --- a/drivers/usb/gadget/Kconfig >>> +++ b/drivers/usb/gadget/Kconfig >>> @@ -859,6 +859,7 @@ config USB_G_NOK

Re: [PATCH 159/493] usb: remove use of __devinit

2012-11-20 Thread Alan Stern
On Mon, 19 Nov 2012, Bill Pemberton wrote: > CONFIG_HOTPLUG is going away as an option so __devinit is no longer > needed. > > Signed-off-by: Bill Pemberton For all the __devinit* annotations and all the EHCI, OHCI, and UHCI drivers: Acked-by: Alan Stern -- To unsubscribe from this list: se

Re: USB issue with kernel 3.6

2012-11-20 Thread Alan Stern
On Tue, 20 Nov 2012, Piergiorgio Sartor wrote: > This is the output of usbmod just when the problem happened: > > 8801232fd6c0 815566692 C Co:1:012:0 -2 0 > 880130cd9000 815566767 S Co:1:012:0 s 23 03 0004 0001 0 > 880130cd9000 816577053 C Co:1:012:0 -2 0 ... > 880026fb2780 8

Re: USB issue with kernel 3.6

2012-11-20 Thread Piergiorgio Sartor
On Sun, Nov 18, 2012 at 12:44:37PM -0500, Alan Stern wrote: > On Sun, 18 Nov 2012, Piergiorgio Sartor wrote: > > > 32830f207691176234b4c4dd17f0d7ab6d87d94b is the first bad commit > > commit 32830f207691176234b4c4dd17f0d7ab6d87d94b > > Author: Alan Stern > > Date: Wed Jul 11 11:22:53 2012 -0400

Re: autodetect USB MTP device characteristics without libusb_open()

2012-11-20 Thread Peter Stuge
Linus Walleij wrote: > If you insert any kind of device into a Windows machine, and Windows > does not find a .inf file for it, it will be probed for the OS > descriptor. > > I think it avoids anything with != 3 endpoints of the right type > though. > > And basically that is how MTP devices "just

Re: [patch] USB: usbtest: prevent a divide by zero bug

2012-11-20 Thread Sebastian Andrzej Siewior
On Sat, Nov 17, 2012 at 09:10:56PM +0300, Dan Carpenter wrote: > On Sat, Nov 17, 2012 at 06:48:55PM +0100, walter harms wrote: > > > > > > Am 17.11.2012 16:06, schrieb Dan Carpenter: > > > If param->length is zero, then this could lead to a divide by zero bug > > > later in the function when we d

Re: 3.4.4: disabling irq

2012-11-20 Thread Alan Stern
On Tue, 20 Nov 2012, Udo van den Heuvel wrote: > > Secondly, try building a kernel with the patch below and > > CONFIG_USB_DEBUG enabled. Let's see what the dmesg log says when the > > problem occurs. > > I just booted into 3.6.7 with the patch: > > # dmesg|sort|uniq > ohci_hcd :00:12.0:

Re: [PATCH 15/16] usb/gadget: nokia: use function framework for ACM

2012-11-20 Thread Sebastian Andrzej Siewior
* Felipe Balbi | 2012-11-20 14:20:34 [+0200]: >On Wed, Nov 14, 2012 at 06:15:05PM +0100, Sebastian Andrzej Siewior wrote: >> This patch converts the acm_ms gadget to make use of the function >> framework to request the ACM function. >> >> With nokia beeing the last user of the include interface,

Re: [RFC] usb: add 'usb_get_intf()' call into the probe methods of drivers for usb interfaces.

2012-11-20 Thread Alan Stern
On Mon, 19 Nov 2012, harvey yang wrote: > Hi, all > I checked many usb drivers in the mainline kernel which do not record > this reference in their probe methods. But according to the documents > about this function, we shoud record this reference in our probe > methods, just as the call to 'usb_g

Re: [PATCH 06/16] usb/gadget: convert source sink and loopback to new function interface

2012-11-20 Thread Sebastian Andrzej Siewior
* Felipe Balbi | 2012-11-20 14:14:47 [+0200]: >On Wed, Nov 14, 2012 at 06:14:56PM +0100, Sebastian Andrzej Siewior wrote: >> diff --git a/drivers/usb/gadget/f_loopback.c >> b/drivers/usb/gadget/f_loopback.c >> index 3d103a2..2d5aade 100644 >> --- a/drivers/usb/gadget/f_loopback.c >> +++ b/drivers

Re: [PATCH v2 5/7] usb: chipidea: usbmisc: add support for ahb, ipg and per clock

2012-11-20 Thread Sascha Hauer
On Fri, Nov 16, 2012 at 03:17:47PM +0200, Alexander Shishkin wrote: > Michael Grzeschik writes: > > > From: Marc Kleine-Budde > > > > This patch adds support for a second and third clock to the usbmisc driver. > > On > > modern freescale ARM cores like the imx51, imx53 and imx6q three clocks >

Re: [PATCH 05/16] usb/gadget: add some infracture to register/unregister functions

2012-11-20 Thread Sebastian Andrzej Siewior
* Felipe Balbi | 2012-11-20 14:13:12 [+0200]: >Hi, Hi, >> diff --git a/drivers/usb/gadget/composite.c b/drivers/usb/gadget/composite.c >> index 4eb07c7..c46ae24 100644 >> --- a/drivers/usb/gadget/composite.c >> +++ b/drivers/usb/gadget/composite.c >> @@ -664,6 +664,35 @@ static int set_config(str

Re: [PATCH 05/16] usb/gadget: add some infracture to register/unregister functions

2012-11-20 Thread Michal Nazarewicz
> On Wed, Nov 14, 2012 at 06:14:55PM +0100, Sebastian Andrzej Siewior wrote: >> +typedef struct usb_function *(*usb_func_alloc)(void); >> +typedef void (*usb_func_free)(struct usb_function *f); On Tue, Nov 20 2012, Felipe Balbi wrote: > isn't checkpatch.pl crying about this ? :-) > > In any case,

Re: [PATCH 09/16] usb/gadget: convert u_serial into a module

2012-11-20 Thread Michal Nazarewicz
On Tue, Nov 20 2012, Felipe Balbi wrote: > the problem with select. it will always answer 'Y' to the question > right ? No. If config that is selecting and config that is being selected are both tristate than if the former is chosen as a module, the latter will be selected as a module. From Docu

Re: [PATCH v2 6/7] usb: chipidea: usbmisc: add mx53 support

2012-11-20 Thread Michael Grzeschik
On Fri, Nov 16, 2012 at 03:22:34PM +0200, Alexander Shishkin wrote: > Michael Grzeschik writes: > > > This adds mx53 as the next user of the usbmisc driver and makes it > > possible to disable the overcurrent-detection of the internal phy. > > > > Signed-off-by: Michael Grzeschik > > Signed-off-

Re: 3.4.4: disabling irq

2012-11-20 Thread Udo van den Heuvel
On 2012-11-19 17:41, Alan Stern wrote: > Firstly, what does /proc/interrupts say? # cat /proc/interrupts CPU0 CPU1 CPU2 CPU3 0: 40 0 0 0 IO-APIC-edge timer 1:631640677734 IO-APIC-edge

Re: autodetect USB MTP device characteristics without libusb_open()

2012-11-20 Thread Linus Walleij
On Thu, Nov 8, 2012 at 3:38 PM, Bjørn Mork wrote: > Linus Walleij writes: >> One of them is an MTP interface, and will respond to MTP traffic. >> I think the magic OS handshake make that come into play... >> So Linux erroneously tries to use MSC on it, and we have to >> use libusb_detach_kernel_d

Re: [PATCH v2 2/7] usb: chipidea: add otg file

2012-11-20 Thread Peter Chen
On Tue, Nov 20, 2012 at 02:43:40PM +0100, Marc Kleine-Budde wrote: > On 11/20/2012 02:40 PM, Peter Chen wrote: > > On Tue, Nov 20, 2012 at 12:41:03PM +0100, Marc Kleine-Budde wrote: > >> On 11/20/2012 02:33 AM, Peter Chen wrote: > >>> On Mon, Nov 19, 2012 at 05:05:16PM +0100, Marc Kleine-Budde wrot

Re: [PATCH v2 4/7] usb: chipidea: create the gadget at ci_hdrc_probe even at host role

2012-11-20 Thread Peter Chen
On Tue, Nov 20, 2012 at 02:08:18PM +0200, Alexander Shishkin wrote: > Peter Chen writes: > > > Since we can't load/unload gadget module on the fly, we can't > > de-init gadget structure during the otg switch. > > We have to create gadget at the probe function no matter current > > role is the hos

Re: [PATCH 119/493] usb: remove use of __devexit_p

2012-11-20 Thread Peter Korsgaard
> "Nicolas" == Nicolas Ferre writes: Nicolas> On 11/19/2012 07:21 PM, Bill Pemberton : >> CONFIG_HOTPLUG is going away as an option so __devexit_p is no longer >> needed. >> >> Signed-off-by: Bill Pemberton >> Cc: Peter Korsgaard >> Cc: Alexander Shishkin >> Cc: Felipe Balbi

Re: [PATCH v2 2/7] usb: chipidea: add otg file

2012-11-20 Thread Marc Kleine-Budde
On 11/20/2012 02:40 PM, Peter Chen wrote: > On Tue, Nov 20, 2012 at 12:41:03PM +0100, Marc Kleine-Budde wrote: >> On 11/20/2012 02:33 AM, Peter Chen wrote: >>> On Mon, Nov 19, 2012 at 05:05:16PM +0100, Marc Kleine-Budde wrote: > +int ci_hdrc_otg_init(struct ci13xxx *ci) > +{ > + /* Usel

Re: [PATCH v2 2/7] usb: chipidea: add otg file

2012-11-20 Thread Peter Chen
On Tue, Nov 20, 2012 at 12:41:03PM +0100, Marc Kleine-Budde wrote: > On 11/20/2012 02:33 AM, Peter Chen wrote: > > On Mon, Nov 19, 2012 at 05:05:16PM +0100, Marc Kleine-Budde wrote: > >>> +int ci_hdrc_otg_init(struct ci13xxx *ci) > >>> +{ > >>> + /* Useless at current */ > >>> + ci->otg.set_periphe

Re: [PATCH v2 3/7] usb: chipidea: add otg id switch and vbus connect/disconnect detect

2012-11-20 Thread Alexander Shishkin
Peter Chen writes: > diff --git a/drivers/usb/chipidea/ci.h b/drivers/usb/chipidea/ci.h > index d738603..d32f932 100644 > --- a/drivers/usb/chipidea/ci.h > +++ b/drivers/usb/chipidea/ci.h > @@ -139,6 +139,7 @@ struct ci13xxx { > enum ci_rolerole; > bool

Re: [PATCH 15/16] usb/gadget: nokia: use function framework for ACM

2012-11-20 Thread Felipe Balbi
On Wed, Nov 14, 2012 at 06:15:05PM +0100, Sebastian Andrzej Siewior wrote: > This patch converts the acm_ms gadget to make use of the function > framework to request the ACM function. > > With nokia beeing the last user of the include interface, it is gone > now. > > Signed-off-by: Sebastian Andr

Re: [PATCH 14/16] usb/gadget: multi: use function framework for ACM

2012-11-20 Thread Felipe Balbi
On Wed, Nov 14, 2012 at 06:15:04PM +0100, Sebastian Andrzej Siewior wrote: > This patch converts the acm_ms gadget to make use of the function > framework to request the ACM function. > > Signed-off-by: Sebastian Andrzej Siewior > --- > drivers/usb/gadget/Kconfig |1 + > drivers/usb/gadget/m

Re: [PATCH 13/16] usb/gadget: cdc2: use function framework for ACM

2012-11-20 Thread Felipe Balbi
On Wed, Nov 14, 2012 at 06:15:03PM +0100, Sebastian Andrzej Siewior wrote: > This patch converts the acm_ms gadget to make use of the function > framework to request the ACM function. > > Signed-off-by: Sebastian Andrzej Siewior > --- > drivers/usb/gadget/Kconfig |1 + > drivers/usb/gadget/c

Re: [PATCH 12/16] usb/gadget: acm_ms: use function framework for ACM

2012-11-20 Thread Felipe Balbi
On Wed, Nov 14, 2012 at 06:15:02PM +0100, Sebastian Andrzej Siewior wrote: > This patch converts the acm_ms gadget to make use of the function > framework to request the ACM function. > > Signed-off-by: Sebastian Andrzej Siewior > --- > drivers/usb/gadget/Kconfig |1 + > drivers/usb/gadget/

Re: [PATCH 11/16] usb/gadget: convert f_acm to new function interface with backwards compatibility

2012-11-20 Thread Felipe Balbi
On Wed, Nov 14, 2012 at 06:15:01PM +0100, Sebastian Andrzej Siewior wrote: > This patch converts f_acm into a module which uses the new function > interface. It also converts one of its users that is g_serial to make > use of it. The other users of it (g_nokia for instance) are still using > the ol

Re: [PATCH 09/16] usb/gadget: convert u_serial into a module

2012-11-20 Thread Felipe Balbi
Hi, On Wed, Nov 14, 2012 at 06:14:59PM +0100, Sebastian Andrzej Siewior wrote: > Every user of u_serial has now to select the U_SERIAL symbol instead of > including the file. > There is one limition with this: ports and and gs_tty_driver are global > variables in u_serial. Since all users share th

[PATCH v3] usb/dummy_hcd: fix enumeration with g_multi

2012-11-20 Thread Sebastian Andrzej Siewior
If we do have endpoints named like "ep-a" then bEndpointAddress is counted internally by the gadget framework. If we do have endpoints named like "ep-1" then bEndpointAddress is assigned from the digit after "ep-". If we do have both, then it is likely that after we used up the "generic" endpoints

Re: [PATCH 06/16] usb/gadget: convert source sink and loopback to new function interface

2012-11-20 Thread Felipe Balbi
On Wed, Nov 14, 2012 at 06:14:56PM +0100, Sebastian Andrzej Siewior wrote: > This patch converts the f_sourcesink and f_loopback file to the USB-function > module. Both functions shares a few common utility functions which are > currently implemented in g_zero.c itself. This patch moves the common

Re: [PATCH 05/16] usb/gadget: add some infracture to register/unregister functions

2012-11-20 Thread Felipe Balbi
Hi, On Wed, Nov 14, 2012 at 06:14:55PM +0100, Sebastian Andrzej Siewior wrote: > This patch provides an infrastructure to register & unregister a USB > function. This allows to turn a function into a module and avoid the > '#include "f_.*.c"' magic and we get a clear API / cut between the bare > g

Re: [PATCH] usb: gadget: remove last pieces of file_storage gadget

2012-11-20 Thread Sebastian Andrzej Siewior
On 11/20/2012 01:15 PM, Michal Nazarewicz wrote: Thanks! I couldn't find time to do it myself after you mailed suggestion to remove those. No problem. I just pulled Felipe's tree and noticed that he applied your patches before I sent that email. Sebastian -- To unsubscribe from this list: sen

Re: [PATCH] usb: gadget: remove last pieces of file_storage gadget

2012-11-20 Thread Michal Nazarewicz
On Tue, Nov 20 2012, Sebastian Andrzej Siewior wrote: > This patch removes the last pieces of the file_storage gadget hidden in > storage_common behind __maybe_unused bars. > The CBI bits have no user on the gadget side. Only file_storage > implemented the obsolete protocol. > The additional USB3.

Re: [PATCH] usb/dummy_hcd: use one type of endpoint naming

2012-11-20 Thread Felipe Balbi
Hi, On Wed, Nov 14, 2012 at 06:12:21PM +0100, Sebastian Andrzej Siewior wrote: > If we do have endpoints named like "ep-a" then bEndpointAddress is > counted internally by the gadget framework. > If we do have endpoints named like "ep-1" then bEndpointAddress is > assigned from the digit after "ep

Re: [PATCH v2 4/7] usb: chipidea: create the gadget at ci_hdrc_probe even at host role

2012-11-20 Thread Alexander Shishkin
Peter Chen writes: > Since we can't load/unload gadget module on the fly, we can't > de-init gadget structure during the otg switch. > We have to create gadget at the probe function no matter current > role is the host or device, of cource, the gadget will not > be created for host-only port. No

[PATCH] usb: gadget: remove last pieces of file_storage gadget

2012-11-20 Thread Sebastian Andrzej Siewior
This patch removes the last pieces of the file_storage gadget hidden in storage_common behind __maybe_unused bars. The CBI bits have no user on the gadget side. Only file_storage implemented the obsolete protocol. The additional USB3.0 descriptors were served by file_storage, the other gadgets are

Re: [PATCH v2 2/7] usb: chipidea: add otg file

2012-11-20 Thread Marc Kleine-Budde
On 11/20/2012 02:33 AM, Peter Chen wrote: > On Mon, Nov 19, 2012 at 05:05:16PM +0100, Marc Kleine-Budde wrote: >>> +int ci_hdrc_otg_init(struct ci13xxx *ci) >>> +{ >>> + /* Useless at current */ >>> + ci->otg.set_peripheral = ci_otg_set_peripheral; >>> + ci->otg.set_host = ci_otg_set_host; >>

Re: [PATCH v5] can: kvaser_usb: Add support for Kvaser CAN/USB devices

2012-11-20 Thread Marc Kleine-Budde
On 11/20/2012 09:46 AM, Olivier Sobrie wrote: [...] >>> +static netdev_tx_t kvaser_usb_start_xmit(struct sk_buff *skb, >>> +struct net_device *netdev) >>> +{ >>> + struct kvaser_usb_net_priv *priv = netdev_priv(netdev); >>> + struct kvaser_usb *dev = priv->d

Re: [PATCH 119/493] usb: remove use of __devexit_p

2012-11-20 Thread Nicolas Ferre
On 11/19/2012 07:21 PM, Bill Pemberton : > CONFIG_HOTPLUG is going away as an option so __devexit_p is no longer > needed. > > Signed-off-by: Bill Pemberton > Cc: Peter Korsgaard > Cc: Alexander Shishkin > Cc: Felipe Balbi > Cc: Li Yang > Cc: Alan Stern > Cc: Wan ZongShun > Cc: Ben Do

Re: [PATCH v5] can: kvaser_usb: Add support for Kvaser CAN/USB devices

2012-11-20 Thread Olivier Sobrie
Hi Marc, On Wed, Nov 07, 2012 at 09:29:05PM +0100, Marc Kleine-Budde wrote: > On 10/02/2012 09:16 AM, Olivier Sobrie wrote: > > This driver provides support for several Kvaser CAN/USB devices. > > Such kind of devices supports up to three CAN network interfaces. > > > > It has been tested with a

Re: Thoughts about bandwidth management

2012-11-20 Thread Oliver Neukum
On Monday 19 November 2012 17:31:57 Alan Stern wrote: > On Mon, 19 Nov 2012, Sarah Sharp wrote: > > > On Mon, Nov 19, 2012 at 10:50:32AM -0500, Alan Stern wrote: > > Your original idea of storing the state and reverting it does seem > > feasible. However, I like the idea of doing one big fix to