Hi, On Wed, Nov 14, 2012 at 06:14:59PM +0100, Sebastian Andrzej Siewior wrote: > Every user of u_serial has now to select the U_SERIAL symbol instead of > including the file. > There is one limition with this: ports and and gs_tty_driver are global > variables in u_serial. Since all users share them, there can be only one > user loaded at a time i.e. either g_serial or g_nokia. > > Signed-off-by: Sebastian Andrzej Siewior <bige...@linutronix.de> > --- > drivers/usb/gadget/Kconfig | 9 +++++++++ > drivers/usb/gadget/Makefile | 1 + > drivers/usb/gadget/acm_ms.c | 1 - > drivers/usb/gadget/cdc2.c | 1 - > drivers/usb/gadget/dbgp.c | 4 +--- > drivers/usb/gadget/multi.c | 1 - > drivers/usb/gadget/nokia.c | 1 - > drivers/usb/gadget/serial.c | 1 - > drivers/usb/gadget/u_serial.c | 13 ++++++++++++- > 9 files changed, 23 insertions(+), 9 deletions(-) > > diff --git a/drivers/usb/gadget/Kconfig b/drivers/usb/gadget/Kconfig > index 0eb8b6f..18d2114 100644 > --- a/drivers/usb/gadget/Kconfig > +++ b/drivers/usb/gadget/Kconfig > @@ -503,6 +503,9 @@ config USB_LIBCOMPOSITE > config USB_F_SS_LB > tristate > > +config USB_U_SERIAL > + tristate > + > choice > tristate "USB Gadget Drivers" > default USB_ETH > @@ -780,6 +783,7 @@ config USB_GADGET_TARGET > > config USB_G_SERIAL > tristate "Serial Gadget (with CDC ACM and CDC OBEX support)" > + select USB_U_SERIAL
the problem with select. it will always answer 'Y' to the question right ? Have you made sure that will work always ? I mean, what if CONFIG_USB_GADGET=m and CONFIG_USB_U_SERIAL=y. IIUC u_serial won't be linked to vmlinux because the directory has only modules (CONFIG_USB_GADGET=m afterall). -- balbi
signature.asc
Description: Digital signature
