Hi, Jonathan
Fri, 04 Jul 2014, Jonathan wrote:
> Beginning with kernel 3.15.1, I am getting hard lockups every time I connect a
> drive to my USB 3 HDD dock with ASMedia ASM1051E UASP compliant chipset. The
> only way I am able work around this is to set the quirk to ignore uas for the
> device.
From: loody
...
> but what it really do is read sector, not media_change or test_unit_ready.
Maybe one of the programs that reads the mbr partition table can
be persuaded to do a direct read?
David
On Tue, Jul 08, 2014 at 05:46:45PM -0700, K. Y. Srinivasan wrote:
> + * In Hyper-V, each port/path/target maps to 1 scsi host adapter.
Does it still? The STORVSC_FC_MAX_TARGETS define suggests otherwise.
> - .cmd_per_lun = 1,
> + .cmd_per_lun = 255,
This looks like an
On Tue, Jul 08, 2014 at 05:46:46PM -0700, K. Y. Srinivasan wrote:
> Going forward it is possible that some of the commands that are not currently
> implemented will be implemented on future Windows hosts. Make command
> filtering
> depend on the host version.
> + if (vmstor_current_major <= V
> + if ((vmbus_proto_version == VERSION_WS2008) ||
> + (vmbus_proto_version == VERSION_WIN7)) {
This has superflous braces and doesn't use proper Linux indentation.
But I think simply using a switch here might be cleaner anyway.
--
To unsubscribe from this list: send the line "unsub
Looks good,
Reviewed-by: Christoph Hellwig
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
On Tue, Jul 08, 2014 at 05:46:48PM -0700, K. Y. Srinivasan wrote:
> Host does not handle WRITE_SAME_16; filter this command out. This patch
> is required to handle large devices (greater than 2 TB disks).
Storvsc already sets the no_write_same flag, where is the command coming
from?
--
To unsubsc
On Tue, Jul 08, 2014 at 05:46:50PM -0700, K. Y. Srinivasan wrote:
> Implement a simple abort handler. The host does not support "Abort"; just
> ensure that all inflight I/Os have been accounted for.
The abort handler should abort a single command, not wait for all of
them. What issue do you see t
On Tue, Jul 08, 2014 at 05:46:51PM -0700, K. Y. Srinivasan wrote:
> Correctly set SRB flags for all valid I/O directions. Some IHV drivers on the
> Windows host require this.
What are IHV drivers?
Otherwise looks fine,
Reviewed-by: Christoph Hellwig
--
To unsubscribe from this list: send the l
On Tue, Jul 08, 2014 at 05:46:52PM -0700, K. Y. Srinivasan wrote:
> --- a/drivers/scsi/storvsc_drv.c
> +++ b/drivers/scsi/storvsc_drv.c
> @@ -1023,6 +1023,13 @@ static void storvsc_handle_error(struct vmscsi_request
> *vm_srb,
> case ATA_12:
> set_host_byte(scmn
On 06/25/2014 12:57 PM, Christoph Hellwig wrote:
Can I get another review for this one?
On Fri, Jun 13, 2014 at 04:40:36PM +, Dick Kennedy wrote:
These speeds are to support the next generation of FCoE port speeds.
Signed-off-by: rkenn...@emulex.com
---
drivers/scsi/scsi_transport_fc.c |
On 06/25/2014 01:06 PM, Christoph Hellwig wrote:
Can I get another review for this one?
On Fri, Jun 06, 2014 at 10:10:35AM +0200, Maurizio Lombardi wrote:
During IO with fabric faults, one generally sees several "Unhandled error
code" messages in the syslog as shown below:
sd 4:0:6:2: [sdbw] U
On 06/25/2014 06:51 PM, Christoph Hellwig wrote:
Unlike the old request code blk-mq doesn't initialize cmd_len with a
default value, so don't rely on it being set in sd_setup_write_same_cmnd.
Signed-off-by: Christoph Hellwig
---
drivers/scsi/sd.c |3 ++-
1 file changed, 2 insertions(+),
On 06/25/2014 06:51 PM, Christoph Hellwig wrote:
Seems like these counters are missing any sort of synchronization for
updates, as a over 10 year old comment from me noted. Fix this by
using atomic counters, and while we're at it also make sure they are
in the same cacheline as the _busy counter
On 06/25/2014 06:51 PM, Christoph Hellwig wrote:
The blk-mq code path will set this to a different function, so make the
code simpler by setting it up in a legacy-request specific place.
Signed-off-by: Christoph Hellwig
---
drivers/scsi/scsi.c | 23 +--
drivers/scsi
On 06/25/2014 06:51 PM, Christoph Hellwig wrote:
Make sure we only have the logic for requeing commands in one place.
Signed-off-by: Christoph Hellwig
---
drivers/scsi/scsi.c | 35 ---
drivers/scsi/scsi_lib.c |9 ++---
2 files changed, 18 insert
On 06/25/2014 06:51 PM, Christoph Hellwig wrote:
Prepare for not taking a host-wide lock in the dispatch path by pushing
the lock down into the places that actually need it. Note that this
patch is just a preparation step, as it will actually increase lock
roundtrips and thus decrease performanc
On 06/25/2014 06:51 PM, Christoph Hellwig wrote:
Factor out a helper to set the _blocked values, which we'll reuse for the
blk-mq code path.
Signed-off-by: Christoph Hellwig
---
drivers/scsi/scsi_lib.c | 44 ++--
1 file changed, 26 insertions(+), 18
On 06/25/2014 06:51 PM, Christoph Hellwig wrote:
Avoid taking the host-wide host_lock to check the per-host queue limit.
Instead we do an atomic_inc_return early on to grab our slot in the queue,
and if nessecary decrement it after finishing all checks.
Signed-off-by: Christoph Hellwig
---
dr
On 06/25/2014 06:51 PM, Christoph Hellwig wrote:
Avoid taking the host-wide host_lock to check the per-target queue limit.
Instead we do an atomic_inc_return early on to grab our slot in the queue,
and if nessecary decrement it after finishing all checks.
Signed-off-by: Christoph Hellwig
---
On 06/25/2014 06:51 PM, Christoph Hellwig wrote:
Avoid taking the queue_lock to check the per-device queue limit. Instead
we do an atomic_inc_return early on to grab our slot in the queue,
and if nessecary decrement it after finishing all checks.
Unlike the host and target busy counters this do
On 06/25/2014 06:51 PM, Christoph Hellwig wrote:
This saves us an atomic operation for each I/O submission and completion
for the usual case where the driver doesn't set a per-target can_queue
value. Only a few iscsi hardware offload drivers set the per-target
can_queue value at the moment.
Sig
On 06/25/2014 06:51 PM, Christoph Hellwig wrote:
Replace the calls to the various blk_end_request variants with opencode
equivalents. Blk-mq is using a model that gives the driver control
between the bio updates and the actual completion, and making the old
code follow that same model allows us
On 06/25/2014 06:51 PM, Christoph Hellwig wrote:
Blk-mq drivers usually preallocate their S/G list as part of the request,
but if we want to support the very large S/G lists currently supported by
the SCSI code that would tie up a lot of memory in the preallocated request
pool. Add support to th
On 06/25/2014 06:52 PM, Christoph Hellwig wrote:
This patch adds support for an alternate I/O path in the scsi midlayer
which uses the blk-mq infrastructure instead of the legacy request code.
Use of blk-mq is fully transparent to drivers, although for now a host
template field is provided to op
On 06/25/2014 06:52 PM, Christoph Hellwig wrote:
Current the midlayer fakes up a struct request for the explicit reset
ioctls, and those don't have a tag allocated to them. The fnic driver pokes
into midlayer structures to paper over this design issue, but that won't
work for the blk-mq case.
E
From: Suresh Thiagarajan
Updated comments for pm8001: honor return value
Remaining patches are resend
Suresh Thiagarajan (8):
pm8001: Fix to remove null pointer checks that could never happen
pm8001: Cleaning up uninitialized variables
pm8001: Fix hibernation issue
pm8001: Fix potential
From: Suresh Thiagarajan
Removal of null pointer checks that could never happen
Signed-off-by: Rickard Strandqvist
Acked-by: Suresh Thiagarajan
---
drivers/scsi/pm8001/pm8001_hwi.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/scsi/pm8001/pm8001_hwi.c b/dri
From: Suresh Thiagarajan
There is a risk that the variable will be used without being initialized.
This was largely found by using a static code analysis program called cppche
Signed-off-by: Rickard Strandqvist
Acked-by: Suresh Thiagarajan
---
drivers/scsi/pm8001/pm80xx_hwi.c |6 ++
From: Suresh Thiagarajan
During hibernation, the HBA firmware may lose power and forget the device
id info. This causes the HBA to reject IO upon resume. The fix is
to call the libsas power management routines to make the domain device
forgetful.
This fixes bug 76681: https://bugzilla.kernel
From: Suresh Thiagarajan
The pm8001_get_phy_settings_info() function does not check the
kzalloc() return value and does not free the allocated memory.
Signed-off-by: Maurizio Lombardi
Acked-by: Jack Wang
Acked-by: Suresh Thiagarajan
---
drivers/scsi/pm8001/pm8001_init.c | 13 ++---
From: Suresh Thiagarajan
In the driver two different functions are used to free the same resource,
this patch makes the code easier to read. In addittion to that, some
minor optimisations were made too.
Signed-off-by: Tomas Henzl
Acked-by: Suresh Thiagarajan
---
drivers/scsi/pm8001/pm8001_hwi
From: Suresh Thiagarajan
The driver ignores the return value in a lot of places, fix
it at least somewhere (and release the resources in such cases),
to avoid that bad things happen.
Signed-off-by: Tomas Henzl
Signed-off-by: Suresh Thiagarajan
---
drivers/scsi/pm8001/pm8001_hwi.c | 33 +
From: Suresh Thiagarajan
Patch adds a new spinlock to protect the ccb management.
It may happen that concurrent threads become the same tag value
from the 'alloc' function', the spinlock prevents this situation.
Signed-off-by: Tomas Henzl
Acked-by: Suresh Thiagarajan
---
drivers/scsi/pm8001/p
From: Suresh Thiagarajan
The driver ignores the return value in a lot of places, fix
it at least somewhere (and release the resources in such cases),
to avoid that bad things happen.
A memory leak is fixed too.
Signed-off-by: Tomas Henzl
Acked-by: Suresh Thiagarajan
---
drivers/scsi/pm8001/pm
On 07/09/2014 01:47 PM, Suresh Thiagarajan wrote:
> From: Suresh Thiagarajan
>
> Updated comments for pm8001: honor return value
> Remaining patches are resend
>
> Suresh Thiagarajan (8):
> pm8001: Fix to remove null pointer checks that could never happen
> pm8001: Cleaning up uninitialized
Hi,
On 07/09/2014 01:50 PM, Suresh Thiagarajan wrote:
> From: Suresh Thiagarajan
>
> The pm8001_get_phy_settings_info() function does not check the
> kzalloc() return value and does not free the allocated memory.
This patch is already in mainline.
Regards,
Maurizio Lombardi
>
> Signed-off-by
Thanks Suresh,
I've applied the patches except for that one that had already been
merged a while ago.
Can you also send me an update for the MAINTAINERS file to list you
as the pm8001 maintainer?
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message t
Hi Suresh,
thanks for resending, please have a look and review also the patches I sent out
two days ago beginning with [PATCH 1/4] scsi: pm8001: fix a memory leak in
nvmd_resp,
(I'm afraid they will get otherwise lost the in the pm8001 patchflood)
Cheers, Tomas
On 07/09/2014 01:47 PM, Suresh T
hi all:
I try 2 methods today but there is no read command firing from usb
host to device
(I double check the existence of command by CATC protocol analyzer)
appreciate all your kind suggestion.
1. use busybox like below command
dd if=/dev/sda1 of=/dev/null bs=512 count=1 conv=sync
my dd in busybo
hi Bryn:
2014-07-08 0:25 GMT+08:00 Bryn M. Reeves :
> On Tue, Jul 08, 2014 at 12:15:54AM +0800, loody wrote:
>> so sg_read will not hammer on the page cache like dd without "iflags=direct"
>>
>> thanks for your kind help,
>
> The sg_read program (and other programs in sg3_utils) sends a command di
On Wed, 9 Jul 2014, loody wrote:
> on that usb hard disk, no matter media_change or TEST_UNIT_READY, keep
> polling the device every 3mins.
> the disconnection still happen.
>
> So I am wondering, I can use the existence wheel, such as echo 4 >
> /sys/block/sda/events_poll_
> msecs.
> but wha
On Wed, 9 Jul 2014, loody wrote:
> hi all:
> I try 2 methods today but there is no read command firing from usb
> host to device
> (I double check the existence of command by CATC protocol analyzer)
> appreciate all your kind suggestion.
>
> 1. use busybox like below command
> dd if=/dev/sda1 of=
>From Documentation/scsi/scsi_mid_low_api.txt: "resid - an LLD should
set this signed integer to the requested transfer length (i.e.
'request_bufflen') less the number of bytes that are actually
transferred." This means that resid > 0 in case of an underrun and
also that resid < 0 in case of an ove
This patch series consists of four patches of which three are bug fixes
and one is a performance optimization.
Changes compared with v1:
- Left out the fifth patch since there is no agreement about that
patch.
- Added "unlikely(...)" around the tests for overflow / underflow flags
in the SRP_C
If scsi_remove_host() is called while an rport is in the blocked
state then scsi_remove_host() will only finish if the rport is
unblocked from inside a timer function. Make sure that an rport
only enters the blocked state if a timer will be started that
will unblock it. This avoids that unloading t
FYI, this has been dropped from the series in favour of always memsetting
the cdb in common code. Take a look at the "RFC: clean up command setup"
series, on top of which I have rebased the scsi-mq changes.
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a
On Wed, Jul 09, 2014 at 01:19:41PM +0200, Hannes Reinecke wrote:
>>host_not_ready:
>> -atomic_dec(&scsi_target(sdev)->target_busy);
>> +if (scsi_target(sdev)->can_queue > 0)
>> +atomic_dec(&scsi_target(sdev)->target_busy);
>>not_ready:
>> /*
>> * lock q, handl
On 14-07-08 10:48 AM, Christoph Hellwig wrote:
On Wed, Jun 25, 2014 at 06:51:47PM +0200, Christoph Hellwig wrote:
Changes from V1:
- rebased on top of the core-for-3.17 branch, most notable the
scsi logging changes
- fixed handling of cmd_list to prevent crashes for some heavy
worklo
On Wed, 2014-06-25 at 18:51 +0200, Christoph Hellwig wrote:
> Avoid taking the queue_lock to check the per-device queue limit. Instead
> we do an atomic_inc_return early on to grab our slot in the queue,
> and if nessecary decrement it after finishing all checks.
>
> Unlike the host and target bu
> -Original Message-
> From: Christoph Hellwig [mailto:h...@infradead.org]
> Sent: Wednesday, July 9, 2014 1:45 AM
> To: KY Srinivasan
> Cc: linux-ker...@vger.kernel.org; de...@linuxdriverproject.org;
> oher...@suse.com; jbottom...@parallels.com; jasow...@redhat.com;
> a...@canonical.com;
> -Original Message-
> From: Christoph Hellwig [mailto:h...@infradead.org]
> Sent: Wednesday, July 9, 2014 1:47 AM
> To: KY Srinivasan
> Cc: linux-ker...@vger.kernel.org; de...@linuxdriverproject.org;
> oher...@suse.com; jbottom...@parallels.com; jasow...@redhat.com;
> a...@canonical.com;
> -Original Message-
> From: Christoph Hellwig [mailto:h...@infradead.org]
> Sent: Wednesday, July 9, 2014 1:44 AM
> To: KY Srinivasan
> Cc: linux-ker...@vger.kernel.org; de...@linuxdriverproject.org;
> oher...@suse.com; jbottom...@parallels.com; jasow...@redhat.com;
> a...@canonical.com;
On Wed, 2014-07-09 at 08:40 +0200, Hannes Reinecke wrote:
> On 07/09/2014 08:18 AM, Christoph Hellwig wrote:
> > On Wed, Jul 09, 2014 at 08:16:21AM +0200, Hannes Reinecke wrote:
> >> The DDP offload on ixgbe is only capable of handling requests up
> >> to 1024 sectors. So we should be exposing this
On 2014-07-09 18:39, Douglas Gilbert wrote:
On 14-07-08 10:48 AM, Christoph Hellwig wrote:
On Wed, Jun 25, 2014 at 06:51:47PM +0200, Christoph Hellwig wrote:
Changes from V1:
- rebased on top of the core-for-3.17 branch, most notable the
scsi logging changes
- fixed handling of cmd_list
> -Original Message-
> From: Christoph Hellwig [mailto:h...@infradead.org]
> Sent: Wednesday, July 9, 2014 1:43 AM
> To: KY Srinivasan
> Cc: linux-ker...@vger.kernel.org; de...@linuxdriverproject.org;
> oher...@suse.com; jbottom...@parallels.com; jasow...@redhat.com;
> a...@canonical.com;
On Wed, 2014-07-09 at 19:52 +, KY Srinivasan wrote:
>
> > -Original Message-
> > From: Christoph Hellwig [mailto:h...@infradead.org]
> > Sent: Wednesday, July 9, 2014 1:43 AM
> > To: KY Srinivasan
> > Cc: linux-ker...@vger.kernel.org; de...@linuxdriverproject.org;
> > oher...@suse.com;
> -Original Message-
> From: Christoph Hellwig [mailto:h...@infradead.org]
> Sent: Wednesday, July 9, 2014 1:42 AM
> To: KY Srinivasan
> Cc: linux-ker...@vger.kernel.org; de...@linuxdriverproject.org;
> oher...@suse.com; jbottom...@parallels.com; jasow...@redhat.com;
> a...@canonical.com;
> -Original Message-
> From: Christoph Hellwig [mailto:h...@infradead.org]
> Sent: Wednesday, July 9, 2014 1:41 AM
> To: KY Srinivasan
> Cc: linux-ker...@vger.kernel.org; de...@linuxdriverproject.org;
> oher...@suse.com; jbottom...@parallels.com; jasow...@redhat.com;
> a...@canonical.com;
> -Original Message-
> From: Christoph Hellwig [mailto:h...@infradead.org]
> Sent: Wednesday, July 9, 2014 1:40 AM
> To: KY Srinivasan
> Cc: linux-ker...@vger.kernel.org; de...@linuxdriverproject.org;
> oher...@suse.com; jbottom...@parallels.com; jasow...@redhat.com;
> a...@canonical.com;
> -Original Message-
> From: James Bottomley [mailto:jbottom...@parallels.com]
> Sent: Wednesday, July 9, 2014 12:57 PM
> To: KY Srinivasan
> Cc: linux-ker...@vger.kernel.org; h...@infradead.org;
> de...@linuxdriverproject.org; a...@canonical.com; sta...@vger.kernel.org;
> linux-scsi@vger
The following patch for megaraid_sas adds a missing initial call to
megasas_get_ld_vf_affiliation() at the end of megasas_probe_one().
Signed-off-by: Adam Radford
---
drivers/scsi/megaraid/megaraid_sas_base.c | 4
1 file changed, 4 insertions(+)
diff --git a/drivers/scsi/megaraid/megaraid_
The following patch for megaraid_sas removes some unused variables from the
megasas_instance structure.
Reviewed-by: Martin K. Petersen
Signed-off-by: Adam Radford
---
drivers/scsi/megaraid/megaraid_sas.h | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/scsi/megaraid/megaraid_sas.h
(Re-sending again based on feedback from Christoph Hellwig & Martin Petersen)
The following patch series for megaraid_sas brings the driver up to
v06.803.02.00-rc1.
1. Fix reset_mutex leak in megasas_reset_fusion().
2. Remove unused variables in megasas_instance.
3. Fix LD/VF affiliation parsing.
The following patch for megaraid_sas fixes the LD/VF affiliation policy parsing
code to account for LD targetId's and Hidden LD's (not yet affiliated with any
Virtual Functions). This also breaks megasas_get_ld_vf_affiliation() into 2
separate functions: megasas_get_ld_vf_affiliation_111() and
me
The following patch for megaraid_sas fixes a reset_mutex leak in
megasas_reset_fusion().
Reviewed-by: Martin K. Petersen
Signed-off-by: Adam Radford
---
drivers/scsi/megaraid/megaraid_sas_fusion.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/scsi/megaraid/megaraid_sas_fusion.c
The following patch for megaraid_sas updates the driver version and
Documentation/scsi/ChangeLog.megaraid_sas.
Reviewed-by: Martin K. Petersen
Signed-off-by: Adam Radford
---
Documentation/scsi/ChangeLog.megaraid_sas | 14 ++
drivers/scsi/megaraid/megaraid_sas.h | 6 +++---
dr
On Wed, 2014-07-09 at 21:14 +, KY Srinivasan wrote:
>
> > -Original Message-
> > From: James Bottomley [mailto:jbottom...@parallels.com]
> > Sent: Wednesday, July 9, 2014 12:57 PM
> > To: KY Srinivasan
> > Cc: linux-ker...@vger.kernel.org; h...@infradead.org;
> > de...@linuxdriverproje
> -Original Message-
> From: James Bottomley [mailto:jbottom...@parallels.com]
> Sent: Wednesday, July 9, 2014 3:27 PM
> To: KY Srinivasan
> Cc: linux-ker...@vger.kernel.org; m...@mkp.net; h...@infradead.org;
> de...@linuxdriverproject.org; a...@canonical.com; sta...@vger.kernel.org;
> li
On Thu, 2014-07-03 at 10:18 -0700, Christoph Hellwig wrote:
> On Thu, Jul 03, 2014 at 09:57:32AM -0700, Steven Haber wrote:
> > Both patches work fine -- zero uncommitted writes over several hundred
> > power cycles.
>
> Thanks for the testing.
>
> Below is James' patch with a trivial comment fix
Hans,
Thanks for getting back to me. It looks like the USB 3.0 controller is an Etron.
Here is the output from lspci:
00:00.0 Host bridge: Intel Corporation 2nd Generation Core Processor Family
DRAM Controller (rev 09)
00:02.0 VGA compatible controller: Intel Corporation 2nd Generation Core
Pr
> -Original Message-
> From: driverdev-devel-boun...@linuxdriverproject.org [mailto:driverdev-
> devel-boun...@linuxdriverproject.org] On Behalf Of KY Srinivasan
> Sent: Wednesday, July 9, 2014 1:07 PM
> To: Christoph Hellwig
> Cc: linux-scsi@vger.kernel.org; jasow...@redhat.com; linux-
>
> -Original Message-
> From: Jens Axboe [mailto:ax...@kernel.dk]
> Sent: Wednesday, 09 July, 2014 2:38 PM
> To: dgilb...@interlog.com; Christoph Hellwig; James Bottomley; Bart Van
> Assche; Elliott, Robert (Server Storage); linux-scsi@vger.kernel.org; linux-
> ker...@vger.kernel.org
> Sub
On Wed, 2014-07-09 at 15:57 +0200, Bart Van Assche wrote:
> --- a/drivers/infiniband/ulp/srp/ib_srp.c
> +++ b/drivers/infiniband/ulp/srp/ib_srp.c
> @@ -1644,10 +1644,14 @@ static void srp_process_rsp(struct srp_target_port
> *target, struct srp_rsp *rsp)
>SCSI_S
In this patch set I have fixed a few bugs and implemented some enhancements.
In this version of the patch I have addressed comments from
Christoph Hellwig
K. Y. Srinivasan (8):
Drivers: scsi: storvsc: Change the limits to reflect the values on
the host
Drivers: scsi: storvsc: Set cmd_per
Correctly set SRB flags for all valid I/O directions. Some IHV drivers on the
Windows host require this.
Signed-off-by: K. Y. Srinivasan
Cc:
---
drivers/scsi/storvsc_drv.c | 12 +---
1 files changed, 5 insertions(+), 7 deletions(-)
diff --git a/drivers/scsi/storvsc_drv.c b/drivers/sc
Hyper-V hosts can support multiple targets and multiple channels and larger
number of
LUNs per target. Update the code to reflect this. With this patch we can
correctly
enumerate all the paths in a multi-path storage environment.
In this version of the patch I have addressed comments from
Christ
Based on the negotiated VMBUS protocol version, we adjust the size of the
storage
protocol messages. The two sizes we currently handle are pre-win8 and post-win8.
In WS2012 R2, we are negotiating higher VMBUS protocol version than the win8
version. Make adjustments to correctly handle this.
In th
On some Windows hosts on FC SANs, TEST_UNIT_READY can return SRB_STATUS_ERROR.
Correctly handle this.
In this version of the patch I have addressed comments from
Christoph Hellwig
Signed-off-by: K. Y. Srinivasan
Cc:
---
drivers/scsi/storvsc_drv.c |7 +++
1 files changed, 7 insertions(
Implement a simple abort handler. The host does not support "Abort"; just
ensure that all inflight I/Os have been accounted for.
In this version of the patch I have addressed comments from
Christoph Hellwig
Signed-off-by: K. Y. Srinivasan
---
drivers/scsi/storvsc_drv.c | 22 +
Going forward it is possible that some of the commands that are not currently
implemented will be implemented on future Windows hosts. Even if they are not
implemented, we are told the host will corrrectly handle unsupported
commands (by returning appropriate return code and sense information).
Mak
SRB status can have additional information. Mask these out before processing
SRB status.
In this version of the patch I have addressed comments from
Christoph Hellwig
Signed-off-by: K. Y. Srinivasan
Cc:
---
drivers/scsi/storvsc_drv.c |5 -
1 files changed, 4 insertions(+), 1 deletion
Set cmd_per_lun to reflect value supported by the Host.
In this version of the patch I have addressed comments from
Christoph Hellwig
Signed-off-by: K. Y. Srinivasan
Cc:
---
drivers/scsi/storvsc_drv.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/scsi/storvs
On Wed, Jul 09, 2014 at 09:49:56AM -0700, James Bottomley wrote:
> As far as I can tell from the block MQ, we get one CPU thread per LUN.
No, that's entirely incorrect. IFF a device supports multiple hardware
queues we only submit I/O from CPUs (there might be more than one) this
queue is bound t
Set cmd_per_lun to reflect value supported by the Host.
In this version of the patch I have addressed comments from
Christoph Hellwig
Signed-off-by: K. Y. Srinivasan
Cc:
---
drivers/scsi/storvsc_drv.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/scsi/storvs
On Wed, Jul 09, 2014 at 01:12:17PM +0200, Hannes Reinecke wrote:
> Hmm. I guess there is a race window between
> atomic_read() and atomic_set().
> Doesn't this cause issues when someone calls atomic_set() just before the
> call to atomic_read?
There is a race window just _after_ the atomic_read,
On Thu, Jul 10, 2014 at 12:53:36AM +, Elliott, Robert (Server Storage)
wrote:
> the problem still occurs - fio results in low or 0 IOPS, with perf top
> reporting unusual amounts of time spent in do_io_submit and io_submit.
The diff between the two version doesn't show too much other possibl
Hannes, can you respin the patch with a comment explaining the limit?
> Does it limit IO size for pass through IO not through block layer ?
The max_sectors limit also limits the size of passthrough requests.
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of
On Mon, Jul 07, 2014 at 05:20:01PM +0200, Tomas Henzl wrote:
> The current implementation may mix the negative value returned
> from pm8001_set_nvmd with with count. -(-ENOMEM) could be interpreted
> as bytes programmed, this patch fixes it.
This still doesn;t look correct to me as err mixes up th
89 matches
Mail list logo
