[PATCH v3 0/3] dmaengine: sf-pdma: Add platform dma driver

2019-09-20 Thread Green Wan
t: dma0chan2-copy0: summary 10929638 tests, 0 failures 33984.39 iops 543750 KB/s (0) [ 7757.003008] dmatest: dma0chan3-copy0: summary 11204208 tests, 0 failures 35759.65 iops 572154 KB/s (0) Green Wan (3): dt-bindings: dmaengine: sf-pdma: add bindins for SiFive PDMA riscv: dts: add support for PDM

[PATCH v3 1/3] dt-bindings: dmaengine: sf-pdma: add bindins for SiFive PDMA

2019-09-20 Thread Green Wan
Add DT bindings document for Platform DMA(PDMA) driver of board, HiFive Unleashed Rev A00. Signed-off-by: Green Wan --- .../bindings/dma/sifive,fu540-c000-pdma.yaml | 55 +++ MAINTAINERS | 5 ++ 2 files changed, 60 insertions(+) create mode

[PATCH v3 2/3] riscv: dts: add support for PDMA device of HiFive Unleashed Rev A00

2019-09-20 Thread Green Wan
Add PDMA support to (arch/riscv/boot/dts/sifive/fu540-c000.dtsi) Signed-off-by: Green Wan --- arch/riscv/boot/dts/sifive/fu540-c000.dtsi | 7 +++ 1 file changed, 7 insertions(+) diff --git a/arch/riscv/boot/dts/sifive/fu540-c000.dtsi b/arch/riscv/boot/dts/sifive/fu540-c000.dtsi index

[PATCH v3 3/3] dmaengine: sf-pdma: add platform DMA support for HiFive Unleashed A00

2019-09-20 Thread Green Wan
-- ||--< done 27 >--|ch 2| ||--< err 28 >--|| (dma0chan2) || -- || -- ||--< done 29 >--|ch 3| ||--< err 30 >--| | (dma0chan3) -- -- Signed-off-by: G

[PATCH v2] Input: atmel_mxt_ts - Disable IRQ across suspend

2019-09-24 Thread Evan Green
d fix separately. Signed-off-by: Evan Green --- Changes in v2: - Enable and disable unconditionally (Dmitry) drivers/input/touchscreen/atmel_mxt_ts.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/input/touchscreen/atmel_mxt_ts.c b/drivers/input/touchscreen/atmel_mxt_ts.c

[PATCH] Input: atmel_mxt_ts - Disable IRQ across suspend

2019-09-23 Thread Evan Green
pending, but the interrupt is serviced before both the driver and the underlying I2C bus have been resumed. This causes EREMOTEIO errors. Disable the IRQ in suspend, and re-enable it if it was previously enabled in resume. Signed-off-by: Evan Green --- drivers/input/touchscreen/atmel_mxt_ts.c

Re: [PATCH v2 2/2] interconnect: qcom: Add tagging and wake/sleep support for sdm845

2019-07-16 Thread Evan Green
; On 7/11/2019 10:06 AM, Evan Green wrote: > > Hi Georgi and David, > > > > On Tue, Jun 18, 2019 at 2:17 AM Georgi Djakov > > wrote: > >> From: David Dai > >> > >> Add support for wake and sleep commands by using a tag to indicate > >> wh

Re: [PATCH] Input: synaptics-rmi4 - Really fix attn_data use-after-free

2020-04-28 Thread Evan Green
On Mon, Apr 27, 2020 at 6:11 PM Dmitry Torokhov wrote: > > On Mon, Apr 27, 2020 at 02:55:48PM -0700, Evan Green wrote: > > Fix a use-after-free noticed by running with KASAN enabled. If > > rmi_irq_fn() is run twice in a row, then rmi_f11_attention() (among > > others)

[RFC v2 0/4] dmaengine: sf-pdma: Add platform dma driver

2019-10-14 Thread Green Wan
an2-copy0: summary 45975 tests, 0 failures 41178.48 iops 328740 KB/s (0) [ 267.590542] dmatest: dma0chan3-copy0: summary 44768 tests, 0 failures 38560.29 iops 307726 KB/s (0) Green Wan (4): dt-bindings: dmaengine: sf-pdma: add bindins for SiFive PDMA riscv: dts: add support for PDMA device of Hi

[RFC v2 1/4] dt-bindings: dmaengine: sf-pdma: add bindins for SiFive PDMA

2019-10-14 Thread Green Wan
Add DT bindings document for Platform DMA(PDMA) driver of board, HiFive Unleashed Rev A00. Reviewed-by: Rob Herring Reviewed-by: Pragnesh Patel Signed-off-by: Green Wan --- .../bindings/dma/sifive,fu540-c000-pdma.yaml | 55 +++ 1 file changed, 55 insertions(+) create mode

[RFC v2 2/4] riscv: dts: add support for PDMA device of HiFive Unleashed Rev A00

2019-10-14 Thread Green Wan
Add PDMA support to (arch/riscv/boot/dts/sifive/fu540-c000.dtsi) Signed-off-by: Green Wan --- arch/riscv/boot/dts/sifive/fu540-c000.dtsi | 7 +++ 1 file changed, 7 insertions(+) diff --git a/arch/riscv/boot/dts/sifive/fu540-c000.dtsi b/arch/riscv/boot/dts/sifive/fu540-c000.dtsi index

[RFC v2 4/4] MAINTAINERS: Add Green as SiFive PDMA driver maintainer

2019-10-14 Thread Green Wan
Update MAINTAINERS for SiFive PDMA driver. Signed-off-by: Green Wan --- MAINTAINERS | 6 ++ 1 file changed, 6 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index a69e6db80c79..62d5b249be65 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -14778,6 +14778,12 @@ F: drivers/media/usb

[RFC v2 3/4] dmaengine: sf-pdma: add platform DMA support for HiFive Unleashed A00

2019-10-14 Thread Green Wan
;--|ch 2| ||--< err 28 >--|| (dma0chan2) || -- || -- ||--< done 29 >--|ch 3| ||--< err 30 >--|| (dma0chan3) -- -- Reviewed-by: Vinod Koul Signed-off-by: Green Wan Reported-by:

Re: [PATCH v2 0/7] Add PAS and MSA based Modem support

2020-04-29 Thread Evan Green
from memory-region > arm64: dts: qcom: sc7180: Update reserved memory map > arm64: dts: qcom: sc7180: Add Q6V5 MSS node > arm64: dts: qcom: sc7180: Update Q6V5 MSS node Tested-by: Evan Green

Re: [PATCH v2 2/2] remoteproc: qcom_q6v5_mss: Remove unused q6v5_da_to_va function

2020-04-29 Thread Evan Green
ies in my inbox. Tested-by: Evan Green

Re: [PATCH 0/2] Drop all accesses to MPSS PERPH register space

2020-04-29 Thread Evan Green
got a tree that's running the modem well. Tested-by: Evan Green

Re: [PATCH v2 00/17] net: introduce Qualcomm IPA driver (UPDATED)

2020-04-29 Thread Evan Green
On Thu, Mar 5, 2020 at 8:28 PM Alex Elder wrote: > > This series presents the driver for the Qualcomm IP Accelerator (IPA). > > This is version 2 of this updated series. It includes the following > small changes since the previous version: > - Now based on net-next instead of v5.6-rc > - Conf

Re: [PATCH v2 2/2] loop: Better discard support for block devices

2019-02-14 Thread Evan Green
On Wed, Feb 13, 2019 at 6:40 PM Martin K. Petersen wrote: > > > Evan, > > > If the backing device for a loop device is a block device, then mirror > > the discard properties of the underlying block device into the loop > > device. While in there, differentiate between REQ_OP_DISCARD and > > REQ_OP

KASAN warning in bt_for_each

2019-02-14 Thread Evan Green
Greetings, block experts! I'm trying to track down a KASAN warning I'm seeing in our downstream 4.19 kernel, and I could use a little help. The warning looks like this: [ 224.564894] BUG: KASAN: use-after-free in bt_for_each+0x1ac/0x28c [ 224.571195] Read of size 8 at addr ffc17c621340 by t

Re: KASAN warning in bt_for_each

2019-02-14 Thread Evan Green
On Thu, Feb 14, 2019 at 11:33 AM Bart Van Assche wrote: > > On Thu, 2019-02-14 at 10:04 -0800, Evan Green wrote: > > Greetings, block experts! > > > > I'm trying to track down a KASAN warning I'm seeing in our downstream > > 4.19 kernel, and I could u

Re: [PATCH v6 09/22] iommu/mediatek: Refine protect memory definition

2019-02-19 Thread Evan Green
atch delete the complex MACRO and use a common if-else > instead. > > Signed-off-by: Yong Wu Reviewed-by: Evan Green

Re: [PATCH v6 01/22] dt-bindings: mediatek: Add binding for mt8183 IOMMU and SMI

2019-02-19 Thread Evan Green
uot;gals" clock for smi-larb. > > From the diagram above, IPU0/IPU1(Image Processor Unit) and CCU(Camera > Control Unit) is connected with smi-common directly, we can take them > as "larb2", "larb3" and "larb7", and their register spaces are > different with the normal larb. > > Signed-off-by: Yong Wu Reviewed-by: Evan Green

Re: [PATCH v6 11/22] iommu/mediatek: Move vld_pa_rng into plat_data

2019-02-19 Thread Evan Green
On Sun, Feb 17, 2019 at 1:08 AM Yong Wu wrote: > > Both mt8173 and mt8183 don't have this vld_pa_rng(valid physical address > range) register while mt2712 have. Move it into the plat_data. > > Signed-off-by: Yong Wu Reviewed-by: Evan Green

Re: [PATCH v6 10/22] iommu/mediatek: Move reset_axi into plat_data

2019-02-19 Thread Evan Green
_data, it's also a preparing > patch for mt8183. > > Signed-off-by: Yong Wu > Reviewed-by: Nicolas Boichat Reviewed-by: Evan Green

Re: [PATCH v6 16/22] memory: mtk-smi: Add bus_sel for mt8183

2019-02-19 Thread Evan Green
> > And, the base of smi-common is completely different with smi_ao_base > of gen1, thus I add new variable for that. > > CC: Matthias Brugger > Signed-off-by: Yong Wu Reviewed-by: Evan Green

Re: [PATCH v6 13/22] iommu/mediatek: Add mt8183 IOMMU support

2019-02-19 Thread Evan Green
83 need reset_axi like mt8173. > 7) the larb-id in smi-common is remapped. M4U should add its larbid_remap. > > Signed-off-by: Yong Wu Reviewed-by: Evan Green

Re: [PATCH v6 06/22] iommu/io-pgtable-arm-v7s: Extend MediaTek 4GB Mode

2019-02-19 Thread Evan Green
Reviewed-by: Robin Murphy > --- > Comparing the previous version, I add MTK_4GB quirk always since mtk_iommu > has already controlled the PA itself. Helped from Evan. Thanks for all the explanation on this one. I think I understand it now, and it looks good to me. Reviewed-by: Evan Green

Re: [PATCH v6 17/22] memory: mtk-smi: Get rid of need_larbid

2019-02-19 Thread Evan Green
t;struct mtk_smi_iommu" could also > be deleted. > > CC: Matthias Brugger > Signed-off-by: Yong Wu Thanks for the cleanup. Reviewed-by: Evan Green

Re: [PATCH v6 20/22] iommu/mediatek: Rename enable_4GB to dram_is_4gb

2019-02-19 Thread Evan Green
On Sun, Feb 17, 2019 at 1:09 AM Yong Wu wrote: > > This patch only rename the variable name from enable_4GB to > dram_is_4gb for readable. > > Signed-off-by: Yong Wu Nice, this is clearer. Reviewed-by: Evan Green

Re: [PATCH v6 21/22] iommu/mediatek: Fix iova_to_phys PA start for 4GB mode

2019-02-19 Thread Evan Green
On Sun, Feb 17, 2019 at 1:09 AM Yong Wu wrote: > > In the 4GB mode, the physical address is remapped, > > Here is the detailed remap relationship. > CPU PA ->HW PA > 0x4000_ 0x1_4000_ (Add bit32) > 0x8000_ 0x1_8000_ ... > 0xc000_ 0x1_c000_

[PATCH v2 0/2] loop: Better discard for block devices

2019-02-07 Thread Evan Green
avoiding this error in the logs. I can also confirm that this fixes test block/003 in the blktests, when running blktests on a loop device backed by a block device. Changes in v2: - Unnested error if statement (Bart) Evan Green (2): loop: Report EOPNOTSUPP properly loop: Better discard

[PATCH v2 2/2] loop: Better discard support for block devices

2019-02-07 Thread Evan Green
been lumping together. This change fixes blktest block/003, and removes an extraneous error print in block/013 when testing on a loop device backed by a block device that does not support discard. Signed-off-by: Evan Green --- Changes in v2: None drivers/block/loop.c | 61

[PATCH v2 1/2] loop: Report EOPNOTSUPP properly

2019-02-07 Thread Evan Green
. Signed-off-by: Evan Green Reviewed-by: Ming Lei --- Changes in v2: - Unnested error if statement (Bart) Ming, I opted to keep your Reviewed-by since the change since v1 was trivial. Hope that's okay. --- drivers/block/loop.c | 9 +++-- 1 file changed, 7 insertions(+), 2 dele

Re: [PATCH v3 7/8] phy: qcom: Utilize UFS reset controller

2019-02-08 Thread Evan Green
On Wed, Feb 6, 2019 at 1:33 PM Stephen Boyd wrote: > > Quoting Evan Green (2019-02-05 10:59:01) > > diff --git a/drivers/phy/qualcomm/phy-qcom-ufs-qmp-20nm.c > > b/drivers/phy/qualcomm/phy-qcom-ufs-qmp-20nm.c > > index aef40f7a41d4..b05f89d734f0 100644 > > --- a/dri

Re: [PATCH v1 3/8] arm64: dts: sdm845: Add UFS PHY reset

2019-01-22 Thread Evan Green
On Mon, Jan 21, 2019 at 4:25 PM Rob Herring wrote: > > On Fri, Jan 11, 2019 at 03:01:24PM -0800, Evan Green wrote: > > Wire up the reset controller in the Qcom UFS controller for the PHY. > > This will be used to toggle PHY reset during initialization of the PHY. > > >

Re: [PATCH v1 2/8] dt-bindings: phy: qcom-ufs: Add resets property

2019-01-22 Thread Evan Green
On Wed, Jan 16, 2019 at 1:29 PM Stephen Boyd wrote: > > Quoting Evan Green (2019-01-11 15:01:23) > > diff --git a/Documentation/devicetree/bindings/ufs/ufs-qcom.txt > > b/Documentation/devicetree/bindings/ufs/ufs-qcom.txt > > index 21d9a93db2e97..985f5e99ab332 100644

Re: [PATCH v1 5/8] scsi: ufs: qcom: Expose the reset controller for PHY

2019-01-22 Thread Evan Green
On Fri, Jan 18, 2019 at 2:31 PM Stephen Boyd wrote: > > Quoting Evan Green (2019-01-11 15:01:26) > > diff --git a/drivers/scsi/ufs/ufs-qcom.c b/drivers/scsi/ufs/ufs-qcom.c > > index 3aeadb14aae1e..db46f9a64b54c 100644 > > --- a/drivers/scsi/ufs/ufs-qcom.c > > +++

Re: [PATCH v1 6/8] phy: qcom-qmp: Utilize UFS reset controller

2019-01-22 Thread Evan Green
On Fri, Jan 18, 2019 at 2:33 PM Stephen Boyd wrote: > > Quoting Evan Green (2019-01-11 15:01:27) > > @@ -1214,6 +1225,32 @@ static int qcom_qmp_phy_init(struct phy *phy) > > > > dev_vdbg(qmp->dev, "Initializing QMP phy\n"); >

Re: [PATCH v1 7/8] phy: qcom-qmp: Move UFS phy to phy_poweron/off

2019-01-22 Thread Evan Green
On Fri, Jan 18, 2019 at 2:39 PM Stephen Boyd wrote: > > Quoting Evan Green (2019-01-11 15:01:28) > > For UFS, move the actual firing up of the PHY to phy_poweron and > > phy_poweroff callbacks, rather than init/exit. UFS calls > > phy_poweroff during suspend, so now all c

Re: [PATCH v1 8/8] phy: qcom-ufs: Refactor all init steps into phy_poweron

2019-01-22 Thread Evan Green
On Fri, Jan 18, 2019 at 3:50 PM Stephen Boyd wrote: > > Quoting Evan Green (2019-01-11 15:01:29) > > diff --git a/drivers/phy/qualcomm/phy-qcom-ufs.c > > b/drivers/phy/qualcomm/phy-qcom-ufs.c > > index f2979ccad00a3..a4cff17fef925 100644 > > --- a/drivers/phy/qua

Re: [PATCH v4 3/3] scsi: ufs-bsg: Allow reading descriptors

2019-01-28 Thread Evan Green
is mapped back in user land to > the applicable sg_io_v4 xferp: dout_xferp for write descriptor, > and din_xferp for read descriptor. > > Signed-off-by: Avri Altman Reviewed-by: Evan Green

Re: [PATCH] scsi: ufs: Remove select of phy-qcom-ufs from ufs-qcom

2019-01-14 Thread Evan Green
On Mon, Jan 14, 2019 at 9:08 AM Doug Anderson wrote: > > Hi, > > On Fri, Jan 11, 2019 at 7:37 PM Martin K. Petersen > wrote: > > > > > > Evan, > > > > > CONFIG_SCSI_UFS_QCOM selects CONFIG_PHY_QCOM_UFS, assuming that > > > this was the only possible PHY driver Qualcomm's UFS controller > > > woul

[PATCH] arm64: defconfig: Add Qualcomm UFS PHY

2019-01-14 Thread Evan Green
lected, and Qualcomm platforms except for SDM845 need it. Fixes: 326a859b2814 ("scsi: ufs: Remove select of phy-qcom-ufs from ufs-qcom") Signed-off-by: Evan Green --- I unfortunately don't have a non-SDM845 device to test this on. I'm hoping it Just Works, or someone might be will

Re: [PATCH] scsi: ufs: Remove select of phy-qcom-ufs from ufs-qcom

2019-01-14 Thread Evan Green
On Mon, Jan 14, 2019 at 10:41 AM Evan Green wrote: > > On Mon, Jan 14, 2019 at 9:08 AM Doug Anderson wrote: > > > > Hi, > > > > On Fri, Jan 11, 2019 at 7:37 PM Martin K. Petersen > > wrote: > > > > > > > > > Evan, > > >

Re: [PATCH v2] soc: qcom: rpmh: Avoid accessing freed memory from batch API

2019-01-18 Thread Evan Green
msg) > if (rpm_msg->needs_free) > > > Let's fix this by allocating a chunk of completions for each message and > waiting for all of them to be completed before returning from the batch > API. Alternatively, we could wait for the last message in the bat

Re: [PATCH v6] drm/msm/a6xx: Add support for an interconnect path

2019-01-18 Thread Evan Green
On Fri, Jan 18, 2019 at 12:24 PM Jordan Crouse wrote: > > Try to get the interconnect path for the GPU and vote for the maximum > bandwidth to support all frequencies. This is needed for performance. > Later we will want to scale the bandwidth based on the frequency to > also optimize for power bu

Re: [PATCH v6] drm/msm/a6xx: Add support for an interconnect path

2019-01-18 Thread Evan Green
On Fri, Jan 18, 2019 at 3:27 PM Jordan Crouse wrote: > > On Fri, Jan 18, 2019 at 03:04:34PM -0800, Evan Green wrote: > > On Fri, Jan 18, 2019 at 12:24 PM Jordan Crouse > > wrote: > > > > > > Try to get the interconnect path for the GPU and vote for the ma

Re: [RESEND PATCH 1/2] loop: Report EOPNOTSUPP properly

2019-02-01 Thread Evan Green
On Thu, Jan 31, 2019 at 3:31 PM Bart Van Assche wrote: > > On Thu, 2019-01-31 at 14:13 -0800, Evan Green wrote: > > diff --git a/drivers/block/loop.c b/drivers/block/loop.c > > index cf5538942834..a1ba555e3b92 100644 > > --- a/drivers/block/loop.c > > +++ b/driv

Re: [v6 2/3] drm/msm/dpu: Integrate interconnect API in MDSS

2019-01-23 Thread Evan Green
uduru1 ...weird that there's a 1 in your name. > Signed-off-by: Jayant Shekhar Reviewed-by: Evan Green

Re: [v1] arm64: dts: sdm845: add interconnect DT entries for MDSS on SDM845

2019-01-23 Thread Evan Green
On Thu, Dec 20, 2018 at 10:29 PM Jayant Shekhar wrote: > > Add interconnect properties such as the source and the destination > ports for MDSS on SDM845. > > Signed-off-by: Jayant Shekhar Reviewed-by: Evan Green

[PATCH v2 0/9] phy: qcom-ufs: Enable regulators to be off in suspend

2019-01-23 Thread Evan Green
Stephen). - Remove include of reset.h (Stephen) - Fix error print of phy_power_on (Stephen) - Comment for reset controller warnings on id != 0 (Stephen) - Add static to ufs_qcom_reset_ops (Stephen). - Use devm_* to get the reset (Stephen) - Clear ufs_reset on error getting it - Remove needless error pri

[PATCH v2 1/9] dt-bindings: ufs: Add #reset-cells for Qualcomm controllers

2019-01-23 Thread Evan Green
Enable Qualcomm UFS controllers to expose the PHY reset via a reset controller. Signed-off-by: Evan Green --- Fixing up this aspect of it made me notice that this patch [1] hasn't landed yet. It really ought to. [1] https://lore.kernel.org/lkml/20181012213926.253765-1-diand...@chromium.

[PATCH v2 3/9] dt-bindings: phy: qcom-ufs: Add resets property

2019-01-23 Thread Evan Green
through the PHY framework. Signed-off-by: Evan Green Reviewed-by: Rob Herring --- Changes in v2: - Added resets to example (Stephen). Documentation/devicetree/bindings/ufs/ufs-qcom.txt | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/Documentation/devicetree/bindings

[PATCH v2 2/9] dt-bindings: phy-qcom-qmp: Add UFS PHY reset

2019-01-23 Thread Evan Green
on in suspend that shouldn't be. This new scheme gives the UFS reset to the PHY, so that it can fully initialize itself in a single callback. We can then turn regulators on during poweron and off during poweroff. Signed-off-by: Evan Green Reviewed-by: Rob Herring --- I realize I'm no

[PATCH v2 7/9] phy: qcom-qmp: Utilize UFS reset controller

2019-01-23 Thread Evan Green
Request the newly minted reset controller from the Qualcomm UFS controller, and use it to toggle the PHY reset line from within the PHY. This will allow us to merge the two phases of UFS PHY initialization. Signed-off-by: Evan Green --- Note: this change is dependent on the previous changes

[PATCH v2 5/9] arm64: dts: msm8996: Add UFS PHY reset controller

2019-01-23 Thread Evan Green
Add the reset controller for the UFS controller, and wire it up so that the UFS PHY can initialize itself without relying on implicit sequencing between the two drivers. Signed-off-by: Evan Green Reviewed-by: Stephen Boyd --- Changes in v2: None arch/arm64/boot/dts/qcom/msm8996.dtsi | 4

[PATCH v2 6/9] scsi: ufs: qcom: Expose the reset controller for PHY

2019-01-23 Thread Evan Green
Expose a reset controller that the phy can use to perform its initialization in a single callback. Also, change the use of the phy functions from ufs-qcom such that phy_poweron actually fires up the phy, and phy_poweroff actually powers it down. Signed-off-by: Evan Green --- Note: This change

[PATCH v2 8/9] phy: qcom-qmp: Move UFS phy to phy_poweron/off

2019-01-23 Thread Evan Green
For UFS, move the actual firing up of the PHY to phy_poweron and phy_poweroff callbacks, rather than init/exit. UFS calls phy_poweroff during suspend, so now all clocks and regulators for the phy can be powered down during suspend. Signed-off-by: Evan Green --- Changes in v2: - Removed

[PATCH v2 9/9] phy: qcom-ufs: Refactor all init steps into phy_poweron

2019-01-23 Thread Evan Green
in poweron, but only poweroff is called during suspend, not exit. Consolidate the initialization code into phy_poweron, and utilize the reset controller exported from the UFS driver to explicitly perform all the steps needed to initialize the PHY. Signed-off-by: Evan Green --- Changes in v2: - Use de

[PATCH v2 4/9] arm64: dts: sdm845: Add UFS PHY reset

2019-01-23 Thread Evan Green
Wire up the reset controller in the Qcom UFS controller for the PHY. This will be used to toggle PHY reset during initialization of the PHY. Signed-off-by: Evan Green Reviewed-by: Stephen Boyd --- This commit is based atop the series at [1]. Patches 1 and 2 of that series have landed, but 3, 4

Re: [PATCH] dt-bindings: ufs: Fix the compatible string definition

2019-01-23 Thread Evan Green
On Thu, Oct 18, 2018 at 12:52 AM Vivek Gautam wrote: > ... > > Yes, this patch is good to go. > I don't think this patch ever got picked up, despite being reviewed and good to go. Can it be applied somewhere? -Evan

Re: [PATCH 1/6] dt-bindings: soc: qcom: Add interconnect binding for GENI QUP

2019-01-23 Thread Evan Green
On Mon, Jan 21, 2019 at 10:34 PM Alok Chauhan wrote: > > Add documentation for the interconnect and interconnect-names bindings > for the GENI QUP as detailed by bindings/interconnect/interconnect.txt. > > Signed-off-by: Alok Chauhan > --- > Documentation/devicetree/bindings/soc/qcom/qcom,geni-s

Re: [PATCH 3/6] i2c: i2c-qcom-geni: Add interconnect support

2019-01-23 Thread Evan Green
On Mon, Jan 21, 2019 at 10:34 PM Alok Chauhan wrote: > > Get the interconnect paths for I2C based Serial Engine device > and vote accordingly based on maximum supported I2C frequency. > > Signed-off-by: Alok Chauhan > --- > drivers/i2c/busses/i2c-qcom-geni.c | 13 + > 1 file changed,

Re: [PATCH 4/6] spi: spi-geni-qcom: Add interconnect support

2019-01-23 Thread Evan Green
On Mon, Jan 21, 2019 at 10:34 PM Alok Chauhan wrote: > > Get the interconnect paths for SPI based Serial Engine device > and vote accordingly based on maximum supported SPI frequency. > > Signed-off-by: Alok Chauhan > --- > drivers/spi/spi-geni-qcom.c | 20 +++- > 1 file changed,

Re: [ 1/1] scsi: qcom-ufs: Add support for bus voting using ICB framework

2019-01-24 Thread Evan Green
On Wed, Jan 23, 2019 at 11:02 PM Asutosh Das wrote: > > Adapt to the new ICB framework for bus bandwidth voting. > > This requires the source/destination port ids. > Also this requires a tuple of values. > > The tuple is for two different paths - from UFS master > to BIMC slave. The other is from

Re: [PATCH v2 1/2] ASoC: SOF: Add Comet Lake PCI IDs

2019-05-08 Thread Evan Green
On Tue, May 7, 2019 at 3:14 PM Pierre-Louis Bossart wrote: > > Minor nit-picks below. The Kconfig would work but select CANNONLAKE even > if you don't want it. > > > > > +config SND_SOC_SOF_COMETLAKE_LP > > + tristate > > + select SND_SOC_SOF_CANNONLAKE > > This should be > select SND_SOF_

Re: [PATCH v2 2/2] ASoC: Intel: Skylake: Add Cometlake PCI IDs

2019-05-08 Thread Evan Green
On Tue, May 7, 2019 at 3:31 PM Pierre-Louis Bossart wrote: > > On 5/7/19 4:53 PM, Evan Green wrote: > > Add PCI IDs for Intel CometLake platforms, which from a software > > point of view are extremely similar to Cannonlake platforms. > > Humm, I have mixed feelings here.

Re: [PATCH v2 1/2] ASoC: SOF: Add Comet Lake PCI IDs

2019-05-08 Thread Evan Green
On Wed, May 8, 2019 at 10:00 AM Pierre-Louis Bossart wrote: > > > > On 5/8/19 11:42 AM, Evan Green wrote: > > On Tue, May 7, 2019 at 3:14 PM Pierre-Louis Bossart > > wrote: > >> > >> Minor nit-picks below. The Kconfig would work but select

Re: [PATCH v2 2/2] ASoC: Intel: Skylake: Add Cometlake PCI IDs

2019-05-08 Thread Evan Green
On Wed, May 8, 2019 at 10:04 AM Pierre-Louis Bossart wrote: > > > > On 5/8/19 11:51 AM, Evan Green wrote: > > On Tue, May 7, 2019 at 3:31 PM Pierre-Louis Bossart > > wrote: > >> > >> On 5/7/19 4:53 PM, Evan Green wrote: > >>> Add PCI ID

[PATCH] platform/chrome: cros_ec_spi: Always add of_match_table

2019-05-09 Thread Evan Green
of_match_table regardless of whether CONFIG_OF is enabled or not, since the table is used by ACPI for PRP0001 devices. Signed-off-by: Evan Green --- drivers/platform/chrome/cros_ec_spi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/platform/chrome/cros_ec_spi.c b/drivers

[PATCH v3 1/2] ASoC: SOF: Add Comet Lake PCI IDs

2019-05-10 Thread Evan Green
Add support for Intel Comet Lake platforms by adding a new Kconfig for CometLake and the appropriate PCI IDs. Signed-off-by: Evan Green --- Changes in v3: - Copy cnl_desc to new cml_desc, and avoid selecting cannonlake (Pierre-Louis) Changes in v2: - Add CML-H ID 0x06c8 (Pierre-Louis) sound

[PATCH v3 2/2] ASoC: Intel: Skylake: Add Cometlake PCI IDs

2019-05-10 Thread Evan Green
Add PCI IDs for Intel CometLake platforms, which from a software point of view are extremely similar to Cannonlake platforms. Signed-off-by: Evan Green --- Changes in v3: - Don't select CML_* in SND_SOC_INTEL_SKYLAKE (Pierre-Louis) Changes in v2: - Add 0x06c8 for CML-H (Pierre-Louis)

[PATCH v3 0/2] ASoC: Intel: Add Cometlake PCI IDs

2019-05-10 Thread Evan Green
erre-Louis) Changes in v2: - Add CML-H ID 0x06c8 (Pierre-Louis) - Add 0x06c8 for CML-H (Pierre-Louis) Evan Green (2): ASoC: SOF: Add Comet Lake PCI IDs ASoC: Intel: Skylake: Add Cometlake PCI IDs sound/soc/intel/Kconfig| 16 + sound/soc/intel/skylake/skl-messa

Re: [PATCH 09/18] soc: qcom: ipa: GSI transactions

2019-05-20 Thread Evan Green
On Mon, May 20, 2019 at 7:44 AM Alex Elder wrote: > > On 5/20/19 9:43 AM, Arnd Bergmann wrote: > > I have no idea how two 8-bit assignments could do that, > > it sounds like a serious gcc bug, unless you mean two > > 8-byte assignments, which would be within the range > > of expected behavior. If

Re: [PATCH 09/18] soc: qcom: ipa: GSI transactions

2019-05-20 Thread Evan Green
On Mon, May 20, 2019 at 9:50 AM Alex Elder wrote: > > On 5/20/19 11:34 AM, Evan Green wrote: > > On Mon, May 20, 2019 at 7:44 AM Alex Elder wrote: > >> > >> On 5/20/19 9:43 AM, Arnd Bergmann wrote: > >>> I have no idea how two 8-bit assignments could d

Re: [PATCH] platform/x86: intel_pmc_core: Report slp_s0 residency range

2019-04-05 Thread Evan Green
On Fri, Apr 5, 2019 at 12:28 AM Rajneesh Bhardwaj wrote: > > On Mon, Apr 01, 2019 at 11:05:04AM -0700, Evan Green wrote: > > The PMC driver performs a 32-bit read on the sleep s0 residency counter, > > followed by a hard-coded multiplication to convert into microseconds. >

[PATCH v5 0/2] loop: Better discard for block devices

2019-05-06 Thread Evan Green
dev's write_zeroes into loopdev's discard_sectors. Changes in v3: - Updated tags - Updated commit description Changes in v2: - Unnested error if statement (Bart) Evan Green (2): loop: Report EOPNOTSUPP properly loop: Better discard support for block devices drivers/bl

[PATCH v1 2/2] ASoC: Intel: Skylake: Add Cometlake PCI IDs

2019-05-06 Thread Evan Green
Add PCI IDs for Intel CometLake platforms, which from a software point of view are extremely similar to Cannonlake platforms. Signed-off-by: Evan Green --- sound/soc/intel/Kconfig| 9 + sound/soc/intel/skylake/skl-messages.c | 8 sound/soc/intel/skylake/skl.c

Re: [PATCH v1 0/2] ASoC: Intel: Add Cometlake PCI IDs

2019-05-06 Thread Evan Green
On Mon, May 6, 2019 at 3:53 PM Evan Green wrote: > > > This small series adds PCI IDs for Cometlake platforms, for a > dazzling audio experience. > > > Evan Green (2): > ASoC: SOF: Add Comet Lake PCI ID > ASoC: Intel: Skylake: Add Cometlake PCI IDs &

[PATCH v1 0/2] ASoC: Intel: Add Cometlake PCI IDs

2019-05-06 Thread Evan Green
This small series adds PCI IDs for Cometlake platforms, for a dazzling audio experience. Evan Green (2): ASoC: SOF: Add Comet Lake PCI ID ASoC: Intel: Skylake: Add Cometlake PCI IDs sound/soc/intel/Kconfig| 9 + sound/soc/intel/skylake/skl-messages.c | 8

[PATCH v1 1/2] ASoC: SOF: Add Comet Lake PCI ID

2019-05-06 Thread Evan Green
Add support for Intel Comet Lake platforms by adding a new Kconfig for CometLake and the appropriate PCI ID. Signed-off-by: Evan Green --- sound/soc/sof/intel/Kconfig | 16 sound/soc/sof/sof-pci-dev.c | 4 2 files changed, 20 insertions(+) diff --git a/sound/soc/sof

Re: [alsa-devel] [PATCH v1 1/2] ASoC: SOF: Add Comet Lake PCI ID

2019-05-07 Thread Evan Green
On Tue, May 7, 2019 at 1:26 PM Pierre-Louis Bossart wrote: > > > > > On 5/6/19 5:53 PM, Evan Green wrote: > >>> Add support for Intel Comet Lake platforms by adding a new Kconfig for > >>> CometLake and the appropriate PCI ID. > > > >> This

[PATCH v2 0/2] ASoC: Intel: Add Cometlake PCI IDs

2019-05-07 Thread Evan Green
This small series adds PCI IDs for Cometlake platforms, for a dazzling audio experience. Changes in v2: - Add CML-H ID 0x06c8 (Pierre-Louis) - Add 0x06c8 for CML-H (Pierre-Louis) Evan Green (2): ASoC: SOF: Add Comet Lake PCI IDs ASoC: Intel: Skylake: Add Cometlake PCI IDs sound/soc/intel

[PATCH v2 1/2] ASoC: SOF: Add Comet Lake PCI IDs

2019-05-07 Thread Evan Green
Add support for Intel Comet Lake platforms by adding a new Kconfig for CometLake and the appropriate PCI IDs. Signed-off-by: Evan Green --- Changes in v2: - Add CML-H ID 0x06c8 (Pierre-Louis) sound/soc/sof/intel/Kconfig | 32 sound/soc/sof/sof-pci-dev.c | 8

[PATCH v2 2/2] ASoC: Intel: Skylake: Add Cometlake PCI IDs

2019-05-07 Thread Evan Green
Add PCI IDs for Intel CometLake platforms, which from a software point of view are extremely similar to Cannonlake platforms. Signed-off-by: Evan Green --- Changes in v2: - Add 0x06c8 for CML-H (Pierre-Louis) sound/soc/intel/Kconfig| 18 ++ sound/soc/intel

[PATCH v4 2/2] loop: Better discard support for block devices

2019-05-02 Thread Evan Green
s an extraneous error print in block/013 when testing on a loop device backed by a block device that does not support discard. Signed-off-by: Evan Green --- Changes in v4: - Mirror blkdev's write_zeroes into loopdev's discard_sectors. Changes in v3: - Updated commit description Chan

Re: [PATCH v2] mfd: intel-lpss: Add Intel Comet Lake PCI IDs

2019-05-03 Thread Evan Green
> > --- > > - update i2c info > > drivers/mfd/intel-lpss-pci.c | 13 + > > 1 file changed, 13 insertions(+) > > > Reviewed-by: Jarkko Nikula Tested-by: Evan Green

Re: [PATCH v2 1/2] interconnect: Add support for path tags

2019-07-11 Thread Evan Green
Hi Georgi and David, On Tue, Jun 18, 2019 at 2:17 AM Georgi Djakov wrote: > > Consumers may have use cases with different bandwidth requirements based > on the system or driver state. The consumer driver can append a specific > tag to the path and pass this information to the interconnect platfor

Re: [PATCH v2 2/2] interconnect: qcom: Add tagging and wake/sleep support for sdm845

2019-07-11 Thread Evan Green
Hi Georgi and David, On Tue, Jun 18, 2019 at 2:17 AM Georgi Djakov wrote: > > From: David Dai > > Add support for wake and sleep commands by using a tag to indicate > whether or not the aggregate and set requests fall into execution > state specific bucket. > > Signed-off-by: David Dai > Signed

Re: [PATCH v3] platform/chrome: Expose resume result via debugfs

2019-07-12 Thread Evan Green
On Mon, Jul 1, 2019 at 6:41 AM Enric Balletbo i Serra wrote: > > > > On 1/7/19 8:01, Lee Jones wrote: > > On Thu, 27 Jun 2019, Enric Balletbo Serra wrote: > > > >> Hi Evan, Lee, > >> > >> Missatge de Evan Green del dia dj., 27 de juny > &g

Re: [PATCH v3] platform/chrome: Expose resume result via debugfs

2019-07-12 Thread Evan Green
On Fri, Jul 12, 2019 at 10:04 AM Evan Green wrote: > > On Mon, Jul 1, 2019 at 6:41 AM Enric Balletbo i Serra > wrote: > > > > > > > > On 1/7/19 8:01, Lee Jones wrote: > > > On Thu, 27 Jun 2019, Enric Balletbo Serra wrote: > > > > > >&

Re: [PATCH v4 3/3] interconnect: qcom: Add tagging and wake/sleep support for sdm845

2019-08-13 Thread Evan Green
> Signed-off-by: Georgi Djakov Reviewed-by: Evan Green

Re: [PATCH 2/2] interconnect: qcom: Add OSM L3 interconnect provider support

2019-08-13 Thread Evan Green
Hi Sibi, On Wed, Aug 7, 2019 at 4:24 AM Sibi Sankar wrote: > > On some Qualcomm SoCs, Operating State Manager (OSM) controls the > resources of scaling L3 caches. Add a driver to handle bandwidth > requests to OSM L3 from CPU/GPU. > > Signed-off-by: Sibi Sankar This looks good to me, just a cou

Re: [PATCH v3 1/3] interconnect: Add support for path tags

2019-08-09 Thread Evan Green
river to do the aggregation based on this state. > > Introduce icc_set_tag() function that will allow the consumers to append > an optional tag to each path. The aggregation of these tagged paths is > platform specific. > > Signed-off-by: Georgi Djakov Reviewed-by: Evan Green

Re: [PATCH v3 2/3] interconnect: Add pre_aggregate() callback

2019-08-09 Thread Evan Green
of this for now is that it will significantly simplify the code > in provider drivers. > > Suggested-by: Evan Green > Signed-off-by: Georgi Djakov Reviewed-by: Evan Green

Re: [PATCH v3 3/3] interconnect: qcom: Add tagging and wake/sleep support for sdm845

2019-08-09 Thread Evan Green
On Fri, Aug 9, 2019 at 5:13 AM Georgi Djakov wrote: > > From: David Dai > > Add support for wake and sleep commands by using a tag to indicate > whether or not the aggregate and set requests fall into execution > state specific bucket. > > Signed-off-by: David Dai > Signed-off-by: Georgi Djakov

Re: [PATCH v2 2/2] interconnect: qcom: Add tagging and wake/sleep support for sdm845

2019-07-31 Thread Evan Green
On Tue, Jul 30, 2019 at 5:37 PM David Dai wrote: > > > On 7/30/2019 3:54 PM, Evan Green wrote: > > On Thu, Jul 18, 2019 at 10:59 AM David Dai wrote: > >> On 7/16/2019 1:15 PM, Evan Green wrote: > >>> On Mon, Jul 15, 2019 at 4:34 PM David Dai > >>

Re: [PATCH] interconnect: Add pre_aggregate() callback

2019-08-05 Thread Evan Green
of this for now is that it will significantly simplify the code > in provider drivers. > > Suggested-by: Evan Green > Signed-off-by: Georgi Djakov Thanks Georgi, I like it! We should confirm that it actually does allow David to remove the sum_avg_cached and max_peak_cached sh

Re: [PATCH v2 2/2] interconnect: qcom: Add tagging and wake/sleep support for sdm845

2019-07-30 Thread Evan Green
On Thu, Jul 18, 2019 at 10:59 AM David Dai wrote: > > On 7/16/2019 1:15 PM, Evan Green wrote: > > On Mon, Jul 15, 2019 at 4:34 PM David Dai wrote: > >> Hi Evan, > >> > >> Thanks for the continued help in reviewing these patches! > > No problem. I want

[PATCH v2] platform/chrome: Expose resume result via debugfs

2019-06-17 Thread Evan Green
For ECs that support it, the EC returns the number of slp_s0 transitions and whether or not there was a timeout in the resume response. Expose the last resume result to usermode via debugfs so that usermode can detect and report S0ix timeouts. Signed-off-by: Evan Green --- Changes in v2

<    5   6   7   8   9   10   11   12   >