On Wed, May 8, 2019 at 10:00 AM Pierre-Louis Bossart <pierre-louis.boss...@linux.intel.com> wrote: > > > > On 5/8/19 11:42 AM, Evan Green wrote: > > On Tue, May 7, 2019 at 3:14 PM Pierre-Louis Bossart > > <pierre-louis.boss...@linux.intel.com> wrote: > >> > >> Minor nit-picks below. The Kconfig would work but select CANNONLAKE even > >> if you don't want it. > >> > >>> > >>> +config SND_SOC_SOF_COMETLAKE_LP > >>> + tristate > >>> + select SND_SOC_SOF_CANNONLAKE > >> > >> This should be > >> select SND_SOF_SOF_HDA_COMMON > > > > You mean SND_SOC_SOF_HDA_COMMON I assume. > > Except that I also need &cnl_desc, so I need CANNONLAKE to be on as > > well. Should I select them both? > > Ah I see. I'd rather use a different descriptor then, and make the two > platforms independent, as I did for CoffeeLake. You can use the same > descriptor for the two -H and -LP skews though.
Ok, I'll add a cml_desc and have it conditionally compiled in on either _LP or _H Kconfig. -Evan
