Re: [PATCH 11/14] nfs: idr_destroy() no longer needs idr_remove_all()

2013-01-29 Thread Myklebust, Trond
On Tue, 2013-01-29 at 17:58 -0500, J. Bruce Fields wrote: > On Fri, Jan 25, 2013 at 05:31:09PM -0800, Tejun Heo wrote: > > idr_destroy() can destroy idr by itself and idr_remove_all() is being > > deprecated. Drop reference to idr_remove_all(). Note that the code > > wasn't completely correct bef

[GIT PULL] Please pull NFS client fixes

2013-01-31 Thread Myklebust, Trond
Hi Linus, The following changes since commit 949db153b6466c6f7cad5a427ecea94985927311: Linux 3.8-rc5 (2013-01-25 11:57:28 -0800) are available in the git repository at: git://git.linux-nfs.org/projects/trondmy/linux-nfs.git tags/nfs-for-3.8-4 for you to fetch changes up to c489ee290bdbbace6

RE: [PATCH 15/19] sunrpc: don't warn for unused variable 'buf'

2013-01-25 Thread Myklebust, Trond
> -Original Message- > From: Arnd Bergmann [mailto:a...@arndb.de] > Sent: Friday, January 25, 2013 5:44 PM > To: linux-arm-ker...@lists.infradead.org > Cc: linux-kernel@vger.kernel.org; Arnd Bergmann; J. Bruce Fields; > Myklebust, Trond; linux-...@vger.kernel.org; net.

Re: New copyfile system call - discuss before LSF?

2013-02-25 Thread Myklebust, Trond
On Mon, 2013-02-25 at 16:49 -0500, Ric Wheeler wrote: > On 02/25/2013 04:14 PM, Andy Lutomirski wrote: > > On 02/21/2013 02:24 PM, Zach Brown wrote: > >> On Thu, Feb 21, 2013 at 08:50:27PM +, Myklebust, Trond wrote: > >>> On Thu, 2013-02-21 at 21:00 +0100, Paolo

Re: New copyfile system call - discuss before LSF?

2013-02-25 Thread Myklebust, Trond
On Mon, 2013-02-25 at 14:16 -0800, Andy Lutomirski wrote: > On Mon, Feb 25, 2013 at 1:59 PM, Myklebust, Trond > wrote: > > On Mon, 2013-02-25 at 16:49 -0500, Ric Wheeler wrote: > >> On 02/25/2013 04:14 PM, Andy Lutomirski wrote: > >> > On 02/21/2013 02:24 PM, Zach

Re: New copyfile system call - discuss before LSF?

2013-02-25 Thread Myklebust, Trond
On Mon, 2013-02-25 at 15:35 -0800, Andy Lutomirski wrote: > On Mon, Feb 25, 2013 at 3:28 PM, Myklebust, Trond > wrote: > > On Mon, 2013-02-25 at 14:16 -0800, Andy Lutomirski wrote: > >> On Mon, Feb 25, 2013 at 1:59 PM, Myklebust, Trond > >> wrote: > >> &

Re: linux-next: build failure after merge of the nfsd tree

2013-02-28 Thread Myklebust, Trond
On Fri, 2013-03-01 at 12:04 +1100, Stephen Rothwell wrote: > Hi all, > > After merging the nfsd tree, today's linux-next build (powerpc > ppc64_defconfig) failed like this: > > net/sunrpc/xprtsock.c:1923:30: error: 'struct rpc_task' has no member named > 'tk_xprt' > > Caused by commit dc107402a

[GIT PULL] Please pull NFS client bugfixes

2013-02-20 Thread Myklebust, Trond
Hi Linus, The following changes since commit 88b62b915b0b7e25870eb0604ed9a92ba4bfc9f7: Linux 3.8-rc6 (2013-02-01 12:08:14 +1100) are available in the git repository at: git://git.linux-nfs.org/projects/trondmy/linux-nfs.git tags/nfs-for-3.9-1 for you to fetch changes up to 666b3d803a511fbc

Re: New copyfile system call - discuss before LSF?

2013-02-21 Thread Myklebust, Trond
On Thu, 2013-02-21 at 12:37 +0100, Ric Wheeler wrote: > We have debated the need to have a system call to allow for offloading copy > operations, for example to an NFS server (part to the new NFS 4.2 > specification), SCSI target device (two different SCSI commands do this), > local > file syst

Re: [PATCH] sunrpc/auth_gss: fix sparse warnings for gss_mech_switch

2013-02-21 Thread Myklebust, Trond
On Thu, 2013-02-21 at 20:10 +0200, Silviu-Mihai Popescu wrote: > This fixes the following sparse warnings: > * net/sunrpc/auth_gss/gss_mech_switch.c:143:21: warning: symbol > '_gss_mech_get_by_name' was not declared. Should it be static? > * net/sunrpc/auth_gss/gss_mech_switch.c:208:21:

Re: New copyfile system call - discuss before LSF?

2013-02-21 Thread Myklebust, Trond
On Thu, 2013-02-21 at 21:00 +0100, Paolo Bonzini wrote: > Il 21/02/2013 15:57, Ric Wheeler ha scritto: > >>> > >> sendfile64() pretty much already has the right arguments for a > >> "copyfile", however it would be nice to add a 'flags' parameter: the > >> NFSv4.2 version would use that to specify w

Re: New copyfile system call - discuss before LSF?

2013-02-21 Thread Myklebust, Trond
On Thu, 2013-02-21 at 23:05 +0100, Ric Wheeler wrote: > On 02/21/2013 09:00 PM, Paolo Bonzini wrote: > > Il 21/02/2013 15:57, Ric Wheeler ha scritto: > >>> sendfile64() pretty much already has the right arguments for a > >>> "copyfile", however it would be nice to add a 'flags' parameter: the > >>>

RE: New copyfile system call - discuss before LSF?

2013-02-21 Thread Myklebust, Trond
> -Original Message- > From: Zach Brown [mailto:z...@redhat.com] > Sent: Thursday, February 21, 2013 5:25 PM > To: Myklebust, Trond > Cc: Paolo Bonzini; Ric Wheeler; Linux FS Devel; linux-kernel@vger.kernel.org; > Chris L. Mason; Christoph Hellwig; Alexander Viro;

RE: New copyfile system call - discuss before LSF?

2013-02-22 Thread Myklebust, Trond
> -Original Message- > From: Zach Brown [mailto:z...@redhat.com] > Sent: Friday, February 22, 2013 1:22 PM > To: Ric Wheeler > Cc: Paolo Bonzini; Myklebust, Trond; Linux FS Devel; linux- > ker...@vger.kernel.org; Chris L. Mason; Christoph Hellwig; Alexander Viro; &g

Re: [PATCH] Fix memset in NFS zap caches

2012-09-03 Thread Myklebust, Trond
On Mon, 2012-09-03 at 20:35 +0200, Andi Kleen wrote: > Fix memset in nfs_zap_caches_locked > > This memset overruns the buffer by 4 bytes on 64bit systems. > > gcc 4.8 correct complains: > > /backup/lsrc/git/linux-lto-2.6/fs/nfs/inode.c: In function > 'nfs_zap_caches_locked': > /backup/lsrc/git/

Re: [PATCH] Fix memset in NFS zap caches

2012-09-03 Thread Myklebust, Trond
On Mon, 2012-09-03 at 20:47 +0200, Andi Kleen wrote: > > No, this is a gcc bug. > > > > NFS_COOKIEVERF(inode) resolves to an array, so the current code is > > correct. The above change will cause the 2nd half of the array to remain > > uninitialised... > > Are you sure? > > include/linux/nfs_fs.

Re: [PATCH] Fix memset in NFS zap caches

2012-09-03 Thread Myklebust, Trond
On Mon, 2012-09-03 at 14:52 -0400, Trond Myklebust wrote: > On Mon, 2012-09-03 at 20:47 +0200, Andi Kleen wrote: > > > No, this is a gcc bug. > > > > > > NFS_COOKIEVERF(inode) resolves to an array, so the current code is > > > correct. The above change will cause the 2nd half of the array to remai

[GIT PULL] Please pull NFS client bugfixes

2012-09-12 Thread Myklebust, Trond
Hi Linus, The following changes since commit 086600430493e04b802bee6e5b3ce0458e4eb77f: NFSv3: Ensure that do_proc_get_root() reports errors correctly (2012-08-20 12:52:42 -0400) are available in the git repository at: git://git.linux-nfs.org/projects/trondmy/linux-nfs.git tags/nfs-for-3.6-

Re: [ 042/108] NFS: Alias the nfs module to nfs4

2012-09-12 Thread Myklebust, Trond
On Wed, 2012-09-12 at 21:08 -0400, Josh Boyer wrote: > On Wed, Sep 12, 2012 at 7:28 PM, Greg Kroah-Hartman > wrote: > > From: Greg KH > > > > 3.5-stable review patch. If anyone has any objections, please let me know. > > > > -- > > > > commit 425e776d93a7a5070b77d4f458a5bab0f9246

Re: [PATCH v2] SUNRPC: check current nsproxy before set of node name on client creation

2012-09-13 Thread Myklebust, Trond
On Thu, 2012-09-13 at 16:11 +0400, Stanislav Kinsbursky wrote: > 10.09.2012 19:41, Myklebust, Trond пишет: > > On Mon, 2012-09-10 at 19:37 +0400, Stanislav Kinsbursky wrote: > >> Hi, Trond. > >> So, if I understand you right, we can create rpc client (or increase usage &

Re: [PATCH 0/3] lockd: use per-net refrence-counted NSM clients

2012-09-14 Thread Myklebust, Trond
On Fri, 2012-09-14 at 13:01 -0400, Chuck Lever wrote: > What happens if statd is restarted? Nothing unusual. Why? > Sent from my iPhone > > On Sep 14, 2012, at 10:25 AM, Stanislav Kinsbursky > wrote: > > > This is a bug fix for https://bugzilla.redhat.com/show_bug.cgi?id=830862. > > > > The

RE: linux-next: build failure after merge of the nfs tree

2012-10-01 Thread Myklebust, Trond
> -Original Message- > From: linux-kernel-ow...@vger.kernel.org [mailto:linux-kernel- > ow...@vger.kernel.org] On Behalf Of Stephen Rothwell > Sent: Monday, October 01, 2012 8:39 PM > To: Trond Myklebust > Cc: linux-n...@vger.kernel.org; linux-kernel@vger.kernel.org > Subject: linux-next: b

Re: Heads-up: 3.6.2 / 3.6.3 NFS server oops: 3.6.2+ regression? (also an unrelated ext4 data loss bug)

2012-10-23 Thread Myklebust, Trond
On Tue, 2012-10-23 at 12:46 -0400, J. Bruce Fields wrote: > On Tue, Oct 23, 2012 at 05:32:21PM +0100, Nix wrote: > > On 23 Oct 2012, J. Bruce Fields uttered the following: > > > nfs-utils shouldn't be capable of oopsing the kernel, so from my > > > (selfish) point of view I'd actually rather you st

RE: Heads-up: 3.6.2 / 3.6.3 NFS server oops: 3.6.2+ regression? (also an unrelated ext4 data loss bug)

2012-10-23 Thread Myklebust, Trond
> -Original Message- > From: Nix [mailto:n...@esperi.org.uk] > Sent: Tuesday, October 23, 2012 1:36 PM > To: Myklebust, Trond > Cc: J. Bruce Fields; Ted Ts'o; linux-kernel@vger.kernel.org; Schumaker, > Bryan; Peng Tao; gre...@linuxfoundation.org; linux-...@vger.

Re: Heads-up: 3.6.2 / 3.6.3 NFS server oops: 3.6.2+ regression? (also an unrelated ext4 data loss bug)

2012-10-23 Thread Myklebust, Trond
On Tue, 2012-10-23 at 17:44 +, Myklebust, Trond wrote: > You can't hold a spinlock while sleeping. Both mutex_lock() and nsm_create() > can definitely sleep. > > The correct way to do this is to grab the spinlock and recheck the value of > ln->nsm_users inside the &#x

Re: Heads-up: 3.6.2 / 3.6.3 NFS server oops: 3.6.2+ regression? (also an unrelated ext4 data loss bug)

2012-10-23 Thread Myklebust, Trond
On Tue, 2012-10-23 at 13:57 -0400, Trond Myklebust wrote: > On Tue, 2012-10-23 at 17:44 +0000, Myklebust, Trond wrote: > > You can't hold a spinlock while sleeping. Both mutex_lock() and > > nsm_create() can definitely sleep. > > > > The correct way to do this is

Re: [PATCH 182/193] net/sunrpc: remove CONFIG_EXPERIMENTAL

2012-10-23 Thread Myklebust, Trond
INIBAND_ADDR_TRANS > default SUNRPC && INFINIBAND > help > This option allows the NFS client and server to support Acked-by: Trond Myklebust -- Trond Myklebust Linux NFS client maintainer NetApp trond.mykleb...@netapp.com www.netapp.com N�r��yb�X��ǧv�^�)޺{.n�+{zX����ܨ}���Ơz�&j:+v���zZ+��+zf���h���~i���z��w���?�&�)ߢf��^jǫy�m��@A�a��� 0��h���i

[GIT PULL] Please pull more NFS related bugfixes

2012-10-25 Thread Myklebust, Trond
Hi Linus, This pull fixes a fairly urgent issue with the NFSv2/v3 statd code that is causing Oopses, as well as some long standing races with the SUNRPC tcp code. The following changes since commit 0e9e3e306c7e472bdcffa34c4c4584301eda03b3: Merge tag 'stable/for-linus-3.7-rc2-tag' of git://git

RE: [PATCH] lockd: fix races in per-net NSM client handling

2012-10-31 Thread Myklebust, Trond
> -Original Message- > From: linux-kernel-ow...@vger.kernel.org [mailto:linux-kernel- > ow...@vger.kernel.org] On Behalf Of Pawel Sikora > Sent: Wednesday, October 31, 2012 2:03 PM > To: Greg KH > Cc: skinsbur...@parallels.com; sta...@vger.kernel.org; linux- > ker...@vger.kernel.org; bagg..

[GIT PULL] Please pull NFS client bugfixes

2012-11-03 Thread Myklebust, Trond
Hi Linus, The following changes since commit 08f05c49749ee655bef921d12160960a273aad47: Return the right error value when dup[23]() newfd argument is too large (2012-10-30 21:27:28 -0700) are available in the git repository at: git://git.linux-nfs.org/projects/trondmy/linux-nfs.git tags/nfs

Re: [ 243/262] NFS: Fix Oopses in nfs_lookup_revalidate and nfs4_lookup_revalidate

2012-11-03 Thread Myklebust, Trond
On Fri, 2012-09-28 at 11:52 -0700, Greg Kroah-Hartman wrote: > From: Greg KH > > 3.5-stable review patch. If anyone has any objections, please let me know. Hi Greg, Can we please apply this patch to the older stable kernels too? I see that Ben has already applied it to the 3.2 kernel, but it

[GIT PULL] Please pull NFS client updates for 3.6...

2012-07-30 Thread Myklebust, Trond
Hi Linus, The following changes since commit 9249e17fe094d853d1ef7475dd559a2cc7e23d42: VFS: Pass mount flags to sget() (2012-07-14 16:38:34 +0400) are available in the git repository at: git://git.linux-nfs.org/projects/trondmy/linux-nfs.git tags/nfs-for-3.6-1 for you to fetch changes up t

Re: [PATCH] SUNRPC: return negative value in case rpcbind client creation error

2012-07-30 Thread Myklebust, Trond
On Fri, 2012-07-20 at 15:57 +0400, Stanislav Kinsbursky wrote: > Without this patch kernel will panic on LockD start, because lockd_up() checks > lockd_up_net() result for negative value. > >From my pow it's better to return negative value from rpcbind routines > >instead > of replacing all such c

Re: linux-next: manual merge of the akpm tree with the nfs tree

2012-07-31 Thread Myklebust, Trond
On Tue, 2012-07-31 at 11:33 +0100, Mel Gorman wrote: > On Tue, Jul 31, 2012 at 02:24:41PM +1000, Stephen Rothwell wrote: > > Hi Andrew, > > > > Today's linux-next merge of the akpm tree got a conflict in > > net/sunrpc/xprtsock.c between commit 5cf02d09b50b ("nfs: skip commit in > > releasepage if

Re: linux-next: manual merge of the akpm tree with the nfs tree

2012-07-31 Thread Myklebust, Trond
On Tue, 2012-07-31 at 16:19 +0100, Mel Gorman wrote: > On Tue, Jul 31, 2012 at 02:37:24PM +0000, Myklebust, Trond wrote: > > On Tue, 2012-07-31 at 11:33 +0100, Mel Gorman wrote: > > > On Tue, Jul 31, 2012 at 02:24:41PM +1000, Stephen Rothwell wrote: > > > > Hi An

Re: linux-next: manual merge of the akpm tree with the nfs tree

2012-07-31 Thread Myklebust, Trond
On Tue, 2012-07-31 at 11:44 -0700, Andrew Morton wrote: > On Tue, 31 Jul 2012 18:50:22 +0100 > Mel Gorman wrote: > > > Stephen Rothwell reported a merge conflict between a MM patch "nfs: > > enable swap on NFS" and an NFS patch "nfs: skip commit in > > releasepage if we're freeing memory for fs-r

[GIT PULL] Please pull second wave of NFS client changes for 3.6

2012-07-31 Thread Myklebust, Trond
Hi Linus, The following changes since commit f44106e2173f08ccb1c9195d85a6c22388b461c1: nfs: fix fl_type tests in NFSv4 code (2012-07-30 18:09:13 -0400) are available in the git repository at: git://git.linux-nfs.org/projects/trondmy/linux-nfs.git tags/nfs-for-3.6-2 for you to fetch changes

[GIT PULL] Please pull one NFS client bugfix

2013-08-29 Thread Myklebust, Trond
Hi Linus, The following changes since commit fa8218def1b1a16f0a410e2c1c767b4738cc81fa: Merge tag 'regmap-v3.11-rc7' of git://git.kernel.org/pub/scm/linux/kernel/git/broonie/regmap (2013-08-27 10:10:30 -0700) are available in the git repository at: git://git.linux-nfs.org/projects/trondmy

Re: [PATCH v3 24/25] sunrpc: Change how dentry's d_lock field is accessed

2013-07-08 Thread Myklebust, Trond
On Thu, 2013-07-04 at 05:20 +0100, Al Viro wrote: > On Wed, Jul 03, 2013 at 04:25:32PM -0400, Waiman Long wrote: > > There is no change in logic and everything should just work. > > > - spin_lock(&file->f_path.dentry->d_lock); > > + d_lock(file->f_path.dentry); > >

[GIT PULL] Please pull NFS client updates

2013-07-08 Thread Myklebust, Trond
Hi Linus, The following changes since commit f722406faae2d073cc1d01063d1123c35425939e: Linux 3.10-rc1 (2013-05-11 17:14:08 -0700) are available in the git repository at: git://git.linux-nfs.org/projects/trondmy/linux-nfs.git tags/nfs-for-3.11-1 for you to fetch changes up to 959d921f5eb887

[GIT PULL] Please pull NFS client updates

2013-07-11 Thread Myklebust, Trond
Hi Linus, The following pull request mainly contains some small readdir optimisations that had dependencies on Al Viro's readdir rewrite. There is also a fix for a nasty deadlock which surfaced earlier in this merge window. The following changes since commit a82a729f04232ccd0b59406574ba4cf20027a4

[GIT PULL] Please pull NFS client updates for 3.12

2013-09-09 Thread Myklebust, Trond
Hi Linus, The following changes since commit 7c6d4dca777d6423cb9ccdc019cad94c75adcbe4: Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/mattst88/alpha (2013-07-23 14:39:57 -0700) are available in the git repository at: git://git.linux-nfs.org/projects/trondmy/lin

Re: Kernel size increase of +256 KiB (was: Re: RPCSEC_GSS: Share all credential caches on a per-transport basis)

2013-09-12 Thread Myklebust, Trond
On Thu, 2013-09-12 at 15:24 +0200, Geert Uytterhoeven wrote: > On Mon, Sep 9, 2013 at 6:57 PM, Linux Kernel Mailing List > wrote: > > diff --git a/net/sunrpc/auth_gss/auth_gss.c b/net/sunrpc/auth_gss/auth_gss.c > > index 5ec15bb..dc4b449 100644 > > --- a/net/sunrpc/auth_gss/auth_gss.c > > +++ b/ne

Re: [PATCH] sunrpc: Add missing kuids conversion for printing

2013-09-12 Thread Myklebust, Trond
On Thu, 2013-09-12 at 15:09 +0200, Geert Uytterhoeven wrote: > m68k/allmodconfig: > > net/sunrpc/auth_generic.c: In function ‘generic_key_timeout’: > net/sunrpc/auth_generic.c:241: warning: format ‘%d’ expects type ‘int’, but > argument 2 has type ‘kuid_t’ > > commit cdba321e291f0fbf5abda4d883402

[GIT PULL] Please pull NFS client changes (part 2)

2013-09-12 Thread Myklebust, Trond
Hi Linus, The following changes since commit b1b3e136948a2bf4915326acb0d825d7d180753f: NFSv4: use mach cred for SECINFO_NO_NAME w/ integrity (2013-09-07 18:39:25 -0400) are available in the git repository at: git://git.linux-nfs.org/projects/trondmy/linux-nfs.git tags/nfs-for-3.12-2 for y

Re: Kernel size increase of +256 KiB (was: Re: RPCSEC_GSS: Share all credential caches on a per-transport basis)

2013-09-12 Thread Myklebust, Trond
On Thu, 2013-09-12 at 21:20 +0200, Geert Uytterhoeven wrote: > On Thu, Sep 12, 2013 at 4:13 PM, Myklebust, Trond > wrote: > >> > --- a/net/sunrpc/auth_gss/auth_gss.c > >> > +++ b/net/sunrpc/auth_gss/auth_gss.c > >> > @@ -51,6 +51,7 @@ > >&

RE: [RFC][PATCH 0/4] SunRPC/NFS: Use no_printk() in

2013-09-26 Thread Myklebust, Trond
> -Original Message- > From: J. Bruce Fields [mailto:bfie...@fieldses.org] > Sent: Thursday, September 26, 2013 10:21 AM > To: David Howells > Cc: Myklebust, Trond; o...@lixom.net; linux-...@vger.kernel.org; linux- > ker...@vger.kernel.org > Subject: Re: [RFC][PATCH

RE: [PATCH 3/4] SunRPC: Use no_printk() for the null dprintk() and dfprintk()

2013-09-26 Thread Myklebust, Trond
> -Original Message- > From: David Howells [mailto:dhowe...@redhat.com] > Sent: Thursday, September 26, 2013 10:36 AM > To: Joe Perches > Cc: dhowe...@redhat.com; bfie...@fieldses.org; Myklebust, Trond; > o...@lixom.net; linux-...@vger.kernel.org; linux-kernel@vger.kernel

RE: [RFC] extending splice for copy offloading

2013-09-28 Thread Myklebust, Trond
> -Original Message- > From: Miklos Szeredi [mailto:mik...@szeredi.hu] > Sent: Saturday, September 28, 2013 12:50 AM > To: Zach Brown > Cc: J. Bruce Fields; Ric Wheeler; Anna Schumaker; Kernel Mailing List; Linux- > Fsdevel; linux-...@vger.kernel.org; Myklebust, Trond

RE: [RFC] extending splice for copy offloading

2013-09-30 Thread Myklebust, Trond
> -Original Message- > From: Ric Wheeler [mailto:rwhee...@redhat.com] > Sent: Monday, September 30, 2013 10:29 AM > To: Miklos Szeredi > Cc: J. Bruce Fields; Myklebust, Trond; Zach Brown; Anna Schumaker; Kernel > Mailing List; Linux-Fsdevel; linux-...@vger.kernel.org

Re: [RFC] extending splice for copy offloading

2013-09-30 Thread Myklebust, Trond
On Mon, 2013-09-30 at 19:17 +0200, Bernd Schubert wrote: > It would be nice if there would be way if the file system would get a > hint that the target file is supposed to be copy of another file. That > way distributed file systems could also create the target-file with the > correct meta-infor

Re: [RFC] extending splice for copy offloading

2013-09-30 Thread Myklebust, Trond
On Mon, 2013-09-30 at 19:48 +0200, Bernd Schubert wrote: > On 09/30/2013 07:44 PM, Myklebust, Trond wrote: > > On Mon, 2013-09-30 at 19:17 +0200, Bernd Schubert wrote: > >> It would be nice if there would be way if the file system would get a > >> hint that the target

Re: [RFC] extending splice for copy offloading

2013-09-30 Thread Myklebust, Trond
On Mon, 2013-09-30 at 20:49 +0200, Bernd Schubert wrote: > On 09/30/2013 08:02 PM, Myklebust, Trond wrote: > > On Mon, 2013-09-30 at 19:48 +0200, Bernd Schubert wrote: > >> On 09/30/2013 07:44 PM, Myklebust, Trond wrote: > >>> On Mon, 2013-09-30 at 19:17 +0200, B

Re: [RFC] extending splice for copy offloading

2013-09-30 Thread Myklebust, Trond
On Mon, 2013-09-30 at 22:00 +0200, Bernd Schubert wrote: > On 09/30/2013 09:34 PM, Myklebust, Trond wrote: > > On Mon, 2013-09-30 at 20:49 +0200, Bernd Schubert wrote: > >> On 09/30/2013 08:02 PM, Myklebust, Trond wrote: > >>> On Mon, 2013-09-30 at 19:48 +0200, Bern

Re: [RFC] extending splice for copy offloading

2013-09-30 Thread Myklebust, Trond
On Mon, 2013-09-30 at 16:08 -0400, Ric Wheeler wrote: > On 09/30/2013 04:00 PM, Bernd Schubert wrote: > > pNFS, FhGFS, Lustre, Ceph, etc., all of them shall implement their own > > interface? And userspace needs to address all of them differently? > > The NFS and SCSI groups have each defined a

[GIT PULL] Please pull NFS client bugfixes

2013-09-30 Thread Myklebust, Trond
Hi Linus, The following changes since commit 4a10c2ac2f368583138b774ca41fac4207911983: Linux 3.12-rc2 (2013-09-23 15:41:09 -0700) are available in the git repository at: git://git.linux-nfs.org/projects/trondmy/linux-nfs.git tags/nfs-for-3.12-4 for you to fetch changes up to 367156d9a87b2

[GIT PULL] Please pull an NFS client bugfix

2013-09-21 Thread Myklebust, Trond
Hi Linus, The following changes since commit 272b98c6455f00884f0350f775c5342358ebb73f: Linux 3.12-rc1 (2013-09-16 16:17:51 -0400) are available in the git repository at: git://git.linux-nfs.org/projects/trondmy/linux-nfs.git tags/nfs-for-3.12-3 for you to fetch changes up to a0f6ed8ebe4f6d

Re: [PATCH v2] SUNRPC: check current nsproxy before set of node name on client creation

2012-09-07 Thread Myklebust, Trond
On Mon, 2012-08-13 at 08:10 -0400, Jeff Layton wrote: > On Mon, 13 Aug 2012 15:37:31 +0400 > Stanislav Kinsbursky wrote: > > > v2: > > 1) rpc_clnt_set_nodename() prototype updated. > > 2) fixed errors in comment. > > > > When child reaper exits, it can destroy mount namespace it belongs to, and

Re: [PATCH v2] SUNRPC: check current nsproxy before set of node name on client creation

2012-09-08 Thread Myklebust, Trond
On Sat, 2012-09-08 at 08:59 +0300, Stanislav Kinsbursky wrote: > 08.09.2012 01:32, Myklebust, Trond пишет: > > On Mon, 2012-08-13 at 08:10 -0400, Jeff Layton wrote: > >> On Mon, 13 Aug 2012 15:37:31 +0400 > >> Stanislav Kinsbursky wrote: > >> > >>>

Re: [PATCH v2] SUNRPC: check current nsproxy before set of node name on client creation

2012-09-10 Thread Myklebust, Trond
On Mon, 2012-09-10 at 12:43 +0400, Stanislav Kinsbursky wrote: > 08.09.2012 18:33, Myklebust, Trond пишет: > > On Sat, 2012-09-08 at 08:59 +0300, Stanislav Kinsbursky wrote: > >> 08.09.2012 01:32, Myklebust, Trond пишет: > >>> On Mon, 2012-08-13 at 08:10 -0400, Jeff L

Re: [PATCH v2] SUNRPC: check current nsproxy before set of node name on client creation

2012-09-10 Thread Myklebust, Trond
On Mon, 2012-09-10 at 19:37 +0400, Stanislav Kinsbursky wrote: > Hi, Trond. > So, if I understand you right, we can create rpc client (or increase usage > counter) on NSMPROC_MON call and destroy (or decrease usage counter) on > NSMPROC_UNMON call. > Will this solution works? The rpc client(s) w

Re: [GIT PULL] Disintegrate UAPI for nfs

2012-10-09 Thread Myklebust, Trond
On Tue, 2012-10-09 at 14:30 +0100, David Howells wrote: > Can you merge the following branch into the nfs tree please. > > This is to complete part of the Userspace API (UAPI) disintegration for which > the preparatory patches were pulled recently. After these patches, userspace > headers will be

Re: [PATCH v3] SUNRPC: set desired file system root before connecting local transports

2012-10-09 Thread Myklebust, Trond
On Tue, 2012-10-09 at 15:35 -0400, J. Bruce Fields wrote: > Cc'ing Eric since I seem to recall he suggested doing it this way? > > Seems OK to me, but maybe that swap_root should be in common code? (Or > maybe we could use set_fs_root()?) > > I'm assuming it's up to Trond to take this.--b. I'm

[GIT PULL] Please pull NFS client updates for 3.7

2012-10-10 Thread Myklebust, Trond
Hi Linus, The following changes since commit c46de2263f42fb4bbde411b9126f471e9343cb22: Merge branch 'for-linus' of git://git.kernel.dk/linux-block (2012-09-19 11:04:34 -0700) are available in the git repository at: git://git.linux-nfs.org/projects/trondmy/linux-nfs.git tags/nfs-for-3.7-1

RE: [PATCH 041/270] pnfsblock: fix partial page buffer wirte

2012-11-30 Thread Myklebust, Trond
> -Original Message- > From: Greg Kroah-Hartman [mailto:gre...@linuxfoundation.org] > Sent: Thursday, November 29, 2012 8:46 PM > To: Ben Hutchings > Cc: Peng Tao; Myklebust, Trond; linux-kernel@vger.kernel.org; > sta...@vger.kernel.org; kernel-t...@lists.ubuntu.c

Re: Regression with initramfs and nfsroot (appears to be in the dcache)

2012-11-30 Thread Myklebust, Trond
On Fri, 2012-11-30 at 02:00 +, Al Viro wrote: > On Thu, Nov 29, 2012 at 05:54:02PM -0800, Patrick McLean wrote: > > > Very interesting. Do you have anything mounted on the corresponding > > > directories on server? The picture looks like you are getting empty > > > fhandles in readdir+ resp

RE: [PATCH 20/22] nfs: add support for read_iter, write_iter

2012-10-22 Thread Myklebust, Trond
> -Original Message- > From: Dave Kleikamp [mailto:dave.kleik...@oracle.com] > Sent: Monday, October 22, 2012 11:15 AM > To: linux-fsde...@vger.kernel.org > Cc: linux-kernel@vger.kernel.org; Zach Brown; Maxim V. Patlasov; Dave > Kleikamp; Myklebust, Trond; linux-.

Re: [ 02/37] lockd: use rpc clients cl_nodename for id encoding

2012-10-22 Thread Myklebust, Trond
On Sun, 2012-10-21 at 09:26 -0700, Greg Kroah-Hartman wrote: > On Sat, Oct 20, 2012 at 12:15:18AM +0100, Ben Hutchings wrote: > > On Thu, Oct 18, 2012 at 08:16:25PM -0700, Greg Kroah-Hartman wrote: > > > 3.0-stable review patch. If anyone has any objections, please let me > > > know. > > > > > >

[GIT PULL] Please pull NFS client bugfixes...

2012-10-22 Thread Myklebust, Trond
Hi Linus, The following changes since commit ddffeb8c4d0331609ef2581d84de4d763607bd37: Linux 3.7-rc1 (2012-10-14 14:41:04 -0700) are available in the git repository at: git://git.linux-nfs.org/projects/trondmy/linux-nfs.git tags/nfs-for-3.7-2 for you to fetch changes up to e9b7e91745fa9df9

RE: [PATCH 0/3] Add O_DENY* flags to fcntl and cifs

2012-12-07 Thread Myklebust, Trond
> -Original Message- > From: linux-nfs-ow...@vger.kernel.org [mailto:linux-nfs- > ow...@vger.kernel.org] On Behalf Of Pavel Shilovsky > Sent: Friday, December 07, 2012 9:43 PM > To: Christoph Hellwig > Cc: linux-c...@vger.kernel.org; linux-kernel@vger.kernel.org; linux- > fsde...@vger.kerne

Re: [PATCH v3] SUNRPC: set desired file system root before connecting local transports

2012-11-14 Thread Myklebust, Trond
On Wed, 2012-11-14 at 16:01 -0500, J. Bruce Fields wrote: > On Mon, Nov 12, 2012 at 12:37:54PM +0400, Stanislav Kinsbursky wrote: > > 07.11.2012 22:33, J. Bruce Fields пишет: > > >On Tue, Nov 06, 2012 at 08:36:05AM -0500, J. Bruce Fields wrote: > > >>On Tue, Nov 06, 2012 at 08:10:18AM -0500, Christ

Re: [PATCH v3] SUNRPC: set desired file system root before connecting local transports

2012-11-14 Thread Myklebust, Trond
On Wed, 2012-11-14 at 16:42 -0500, J. Bruce Fields wrote: > On Wed, Nov 14, 2012 at 09:36:33PM +0000, Myklebust, Trond wrote: > > On Wed, 2012-11-14 at 16:01 -0500, J. Bruce Fields wrote: > > > On Mon, Nov 12, 2012 at 12:37:54PM +0400, Stanislav Kinsbursky wrote: > > > &

Re: [PATCH v3] SUNRPC: set desired file system root before connecting local transports

2012-11-15 Thread Myklebust, Trond
On Wed, 2012-11-14 at 22:14 -0800, Eric W. Biederman wrote: > "J. Bruce Fields" writes: > > > On Wed, Nov 14, 2012 at 09:51:33PM +, Myklebust, Trond wrote: > >> On Wed, 2012-11-14 at 16:42 -0500, J. Bruce Fields wrote: > >> > Simo's patches use

Re: nfsd oops on Linus' current tree.

2013-01-03 Thread Myklebust, Trond
On Thu, 2013-01-03 at 17:08 -0500, Tejun Heo wrote: > Hello, > > On Thu, Jan 03, 2013 at 03:11:20PM -0500, J. Bruce Fields wrote: > > Both rpciod and nfsiod already set WQ_MEM_RECLAIM. > > > > But, right, looking at kernel/workqueue.c, it seems that the dedicated > > "rescuer" threads are invoked

Re: nfsd oops on Linus' current tree.

2013-01-03 Thread Myklebust, Trond
On Thu, 2013-01-03 at 17:26 -0500, Tejun Heo wrote: > Hello, Trond. > > On Thu, Jan 03, 2013 at 10:12:32PM +, Myklebust, Trond wrote: > > > The analysis is likely completely wrong, so please don't go off doing > > > something unnecessary. Please

Re: nfsd oops on Linus' current tree.

2013-01-03 Thread Myklebust, Trond
On Thu, 2013-01-03 at 18:11 -0500, Trond Myklebust wrote: > On Thu, 2013-01-03 at 17:26 -0500, Tejun Heo wrote: > > Ooh, BTW, there was a bug where workqueue code created a false > > dependency between two work items. Workqueue currently considers two > > work items to be the same if they're on th

Re: [PATCH] pnfs: Increase the refcount when LAYOUTGET fails the first time

2013-01-04 Thread Myklebust, Trond
On Fri, 2013-01-04 at 20:19 +0800, ycn...@gmail.com wrote: > From: Yanchuan Nian > > The layout will be set unusable if LAYOUTGET fails. Is it reasonable to > increase the refcount iff LAYOUTGET fails the first time? > > Signed-off-by: Yanchuan Nian > --- > fs/nfs/pnfs.c |2 +- > 1 files c

Re: [PATCH] nfs: fix null checking in nfs_get_option_str()

2013-01-04 Thread Myklebust, Trond
On Fri, 2013-01-04 at 03:22 -0500, Xi Wang wrote: > The following null pointer check is broken. > > *option = match_strdup(args); > return !option; > > The pointer `option' must be non-null, and thus `!option' is always false. > Use `!*option' instead. > > The bug was introduced in c

Re: [PATCH] nfs: avoid dereferencing null pointer in initiate_bulk_draining

2013-01-05 Thread Myklebust, Trond
On Sat, 2013-01-05 at 14:19 -0500, Nickolai Zeldovich wrote: > Fix an inverted null pointer check in initiate_bulk_draining(). > > Signed-off-by: Nickolai Zeldovich > --- > fs/nfs/callback_proc.c |2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/fs/nfs/callback_proc.c

[GIT PULL] Please pull NFS client changesets for Linux 3.8

2012-12-17 Thread Myklebust, Trond
Hi Linus, The following changes since commit 0e4a43ed08e2f44aa7b96aa95d0a540d675483e1: Merge git://git.kernel.org/pub/scm/linux/kernel/git/steve/gfs2-3.0-fixes (2012-11-07 13:38:56 +0100) are available in the git repository at: git://git.linux-nfs.org/projects/trondmy/linux-nfs.git tags/n

Re: nfsd oops on Linus' current tree.

2012-12-21 Thread Myklebust, Trond
On Fri, 2012-12-21 at 13:08 -0500, J. Bruce Fields wrote: > On Fri, Dec 21, 2012 at 10:33:48AM -0500, Dave Jones wrote: > > Did a mount from a client (also running Linus current), and the > > server spat this out.. > > > > [ 6936.306135] [ cut here ] > > [ 6936.306154] WARN

RE: nfsd oops on Linus' current tree.

2012-12-21 Thread Myklebust, Trond
mber 21, 2012 6:08 PM To: Myklebust, Trond Cc: Dave Jones; Linux Kernel; linux-...@vger.kernel.org; Adamson, Dros Subject: Re: nfsd oops on Linus' current tree. On Fri, Dec 21, 2012 at 06:40:54PM +0000, Myklebust, Trond wrote: > On Fri, 2012-12-21 at 13:08 -0500, J. Bruce Fields wrote: >

RE: nfsd oops on Linus' current tree.

2012-12-21 Thread Myklebust, Trond
assuming the former. From: J. Bruce Fields [bfie...@fieldses.org] Sent: Friday, December 21, 2012 6:26 PM To: Myklebust, Trond Cc: Dave Jones; Linux Kernel; linux-...@vger.kernel.org; Adamson, Dros Subject: Re: nfsd oops on Linus' current tree. On Fri, Dec 21, 2012 at 11:15:40P

Re: [PATCH v2 2/4] SUNRPC: fix races on PipeFS MOUNT notifications

2013-06-17 Thread Myklebust, Trond
On Tue, 2013-06-11 at 18:39 +0400, Stanislav Kinsbursky wrote: > Below are races, when RPC client can be created without PiepFS dentries > > CPU#0 CPU#1 > - - > rpc_new_client

Re: 3.10-rc3 NFSv3 mount issues

2013-05-30 Thread Myklebust, Trond
On Thu, 2013-05-30 at 16:26 -0400, Chuck Lever wrote: > On May 30, 2013, at 4:19 PM, Jim Schutt wrote: > > > Hi, > > > > I've been trying to test 3.10-rc3 on some diskless clients, and found > > that I can no longer mount my root file system via NFSv3. > > > > I poked around looking at NFS chan

[GIT PULL] Please pull 2 NFS client bugfixes

2013-05-31 Thread Myklebust, Trond
Hi Linus, The following changes since commit 83c168bf8017212a9d502536f9dcd0b54d24e330: NFS: Fix SETCLIENTID fallback if GSS is not available (2013-05-23 18:50:40 -0400) are available in the git repository at: git://git.linux-nfs.org/projects/trondmy/linux-nfs.git tags/nfs-for-3.10-4 for y

Re: [PATCH v3 2/4] SUNRPC: fix races on PipeFS UMOUNT notifications

2013-06-25 Thread Myklebust, Trond
On Mon, 2013-06-24 at 11:52 +0400, Stanislav Kinsbursky wrote: > CPU#0 CPU#1 > - - > rpc_kill_sb > sn->pipefs_sb = NULLrpc_release_client > (UMOUNT_EVENT)

[GIT PULL] Please pull NFS client bugfixes

2013-03-26 Thread Myklebust, Trond
Hi Linus, The following changes since commit 6dbe51c251a327e012439c4772097a13df43c5b8: Linux 3.9-rc1 (2013-03-03 15:11:05 -0800) are available in the git repository at: git://git.linux-nfs.org/projects/trondmy/linux-nfs.git tags/nfs-for-3.9-3 for you to fetch changes up to 1166fde6a923c30f

Re: sunrpc/clnt.c: BUG kmalloc-256 (Not tainted): Poison overwritten

2013-07-14 Thread Myklebust, Trond
On Sun, 2013-07-14 at 10:02 +0200, Toralf Förster wrote: > This bisected commit produces at a 32 bit user mode linux guest the attached > BUG : > > commit 245268c951262b861bc1be4e9dc812352499 > Author: Trond Myklebust > Date: Wed Jul 10 15:33:01 2013 -0400 > > SUNRPC: Fix a deadlock i

Re: [Ksummit-2013-discuss] [ATTEND] How to act on LKML

2013-07-16 Thread Myklebust, Trond
On Tue, 2013-07-16 at 19:31 -0400, Ric Wheeler wrote: > On 07/16/2013 07:12 PM, Sarah Sharp wrote: > > On Tue, Jul 16, 2013 at 06:54:59PM -0400, Steven Rostedt wrote: > >> On Tue, 2013-07-16 at 15:43 -0700, Sarah Sharp wrote: > >> > >>> Yes, that's true. Some kernel developers are better at modera

Re: [PATCH] fs/nfs/inode.c: adjust code alignment

2013-08-05 Thread Myklebust, Trond
On Mon, 2013-08-05 at 16:47 +0200, Julia Lawall wrote: > From: Julia Lawall > > Signed-off-by: Julia Lawall > > --- > > This patch adjusts the code so that the alignment matches the current > semantics. I have no idea if it is the intended semantics, though. Should > the call to nfs_setsecur

Re: [3.10.4] NFS locking panic, plus persisting NFS shutdown panic from 3.9.*

2013-08-05 Thread Myklebust, Trond
On Mon, 2013-08-05 at 16:50 +0100, Nix wrote: > On 5 Aug 2013, Jeff Layton said: > > > On Mon, 5 Aug 2013 11:04:27 -0400 > > Jeff Layton wrote: > > > >> On Mon, 05 Aug 2013 15:48:01 +0100 > >> Nix wrote: > >> > >> > On 5 Aug 2013, Jeff Layton stated: > >> > > >> > > On Sun, 04 Aug 2013 16:40:5

Re: [3.10.4] NFS locking panic, plus persisting NFS shutdown panic from 3.9.*

2013-08-05 Thread Myklebust, Trond
On Mon, 2013-08-05 at 13:37 -0400, Jeff Layton wrote: > On Mon, 5 Aug 2013 16:15:01 + > "Myklebust, Trond" wrote: > > > From 3c50ba80105464a28d456d9a1e0f1d81d4af92a8 Mon Sep 17 00:00:00 2001 > > From: Trond Myklebust > > Date: Mon, 5 Aug 2013 12:06:12 -0

Re: [3.10.4] NFS locking panic, plus persisting NFS shutdown panic from 3.9.*

2013-08-05 Thread Myklebust, Trond
On Mon, 2013-08-05 at 19:33 +0100, Nix wrote: > On 5 Aug 2013, Trond Myklebust told this: > > Does the attached patch fix the problem? > > > From 3c50ba80105464a28d456d9a1e0f1d81d4af92a8 Mon Sep 17 00:00:00 2001 > > From: Trond Myklebust > > Date: Mon, 5 Aug 2013 12:06:12 -0400 > > Subject: [PATC

Re: [3.10.4] NFS locking panic, plus persisting NFS shutdown panic from 3.9.*

2013-08-05 Thread Myklebust, Trond
On Mon, 2013-08-05 at 14:33 -0400, Jeff Layton wrote: > On Mon, 5 Aug 2013 18:18:03 + > "Myklebust, Trond" wrote: > > > On Mon, 2013-08-05 at 13:37 -0400, Jeff Layton wrote: > > > On Mon, 5 Aug 2013 16:15:01 + > > > &qu

Re: [3.10.4] NFS locking panic, plus persisting NFS shutdown panic from 3.9.*

2013-08-07 Thread Myklebust, Trond
On Wed, 2013-08-07 at 11:18 +0100, Nix wrote: > On 6 Aug 2013, Trond Myklebust verbalised: > > True. How about something like the following instead. Note the change to > > the original patch... > > Well, with those applied I could reboot without a panic for the first > time since 3.8.x: looking go

Re: [3.10.4] NFS locking panic, plus persisting NFS shutdown panic from 3.9.*

2013-08-07 Thread Myklebust, Trond
On Wed, 2013-08-07 at 22:01 +0100, Nix wrote: > On 7 Aug 2013, Trond Myklebust said: > > > On Wed, 2013-08-07 at 11:18 +0100, Nix wrote: > >> On 6 Aug 2013, Trond Myklebust verbalised: > >> > True. How about something like the following instead. Note the change to > >> > the original patch... > >>

Re: [GIT PULL] x86 fixes for 3.11-rc2

2013-07-18 Thread Myklebust, Trond
On Thu, 2013-07-18 at 17:46 -0700, Linus Torvalds wrote: > Finnish is hard. But good for swearing. Only because the ratio of vowels to consonants causes an immediate outbreak of swearing among those who try... Trond -- Trond Myklebust Linux NFS client maintainer NetApp trond.mykleb...@netapp.c

[GIT PULL] Please pull NFS client fixes

2013-07-19 Thread Myklebust, Trond
Hi Linus, The following changes since commit ad81f0545ef01ea651886dddac4bef6cec930092: Linux 3.11-rc1 (2013-07-14 15:18:27 -0700) are available in the git repository at: git://git.linux-nfs.org/projects/trondmy/linux-nfs.git tags/nfs-for-3.11-3 for you to fetch changes up to b4a2cf76ab7c08

Re: Linux 3.11-rc2

2013-07-22 Thread Myklebust, Trond
On Tue, 2013-07-23 at 03:04 +0200, rydb...@euromail.se wrote: > Hi Trond, Linus, > > On Sun, Jul 21, 2013 at 12:53:10PM -0700, Linus Torvalds wrote: > > So it's been another week, and -rc2 is out there. > > This one happens to break nfs in a rather blunt-instrument fashion - > creating files on a

  1   2   >