On Sun, 2012-10-21 at 09:26 -0700, Greg Kroah-Hartman wrote: > On Sat, Oct 20, 2012 at 12:15:18AM +0100, Ben Hutchings wrote: > > On Thu, Oct 18, 2012 at 08:16:25PM -0700, Greg Kroah-Hartman wrote: > > > 3.0-stable review patch. If anyone has any objections, please let me > > > know. > > > > > > ------------------ > > > > > > From: Stanislav Kinsbursky <skinsbur...@parallels.com> > > > > > > commit 303a7ce92064c285a04c870f2dc0192fdb2968cb upstream. > > > > > > Taking hostname from uts namespace if not safe, because this cuold be > > > performind during umount operation on child reaper death. And in this case > > > current->nsproxy is NULL already. > > > > In this case (3.0.y) you haven't included the following change > > (commit cb7323fffa85 'lockd: create and use per-net NSM RPC clients on > > MON/UNMON requests') that makes lockd actually use cl_nodename. I > > think this patch alone won't fix the bug, as nsm_args::nodename can > > end up pointing to freed memory. > > > > (I also wonder whether clients should really be per-net or per UTS > > namespace, and whether those should be orthogonal namespaces at all.) > > Hm, Trond, should I also include the other commit above in the next > 3.0-stable release? > > Or should this one be dropped?
Hi Greg, Applying this patch shouldn't be harmful, but since it isn't actually fixing a problem (there being no net-namespace code in Linux-3.0), I'd suggest just dropping it. Thanks! Trond -- Trond Myklebust Linux NFS client maintainer NetApp trond.mykleb...@netapp.com www.netapp.com
