On Wed, 2012-09-12 at 21:08 -0400, Josh Boyer wrote: > On Wed, Sep 12, 2012 at 7:28 PM, Greg Kroah-Hartman > <gre...@linuxfoundation.org> wrote: > > From: Greg KH <gre...@linuxfoundation.org> > > > > 3.5-stable review patch. If anyone has any objections, please let me know. > > > > ------------------ > > > > commit 425e776d93a7a5070b77d4f458a5bab0f924652c upstream. > > > > This allows distros to remove the line from their modprobe > > configuration. > > > > Signed-off-by: Bryan Schumaker <bjsch...@netapp.com> > > Signed-off-by: Trond Myklebust <trond.mykleb...@netapp.com> > > [bwh: Backported to 3.2: adjust context] > > Signed-off-by: Ben Hutchings <b...@decadent.org.uk> > > Signed-off-by: Greg Kroah-Hartman <gre...@linuxfoundation.org> > > Could someone elaborate why this is acceptable now, while it wasn't > during the timeframe I sent an identical patch months ago? > > http://lkml.indiana.edu/hypermail/linux/kernel/1204.3/02064.html > > We had some trouble in Fedora 17 because of this and would up with > patches to nfs-utils because the modalias was NAKed. If we're bringing > it into stable (and upstream) at this point, it would be good to know > what changed so I can go and undo what we did because I was told no. > > Please don't get me wrong, I'm all for simplicity. I'm just perhaps > so simple that the brief changelog confuses me because it doesn't > actually describe why the original solution wasn't followed up on.
Linux-3.6 converts NFSv2/v3/v4 into modules, and so modprobe.conf entries of the form alias nfs4 nfs will now fail to ensure that 'mount -t nfs4 ...' works. In order to facilitate the task for the distros when dealing with kernels >= 3.5.x, we've added the automatic module alias so that they can remove the hard-coded aliases in modprobe.conf while remaining backward-compatible. -- Trond Myklebust Linux NFS client maintainer NetApp trond.mykleb...@netapp.com www.netapp.com
