On Fri, 2013-01-04 at 20:19 +0800, ycn...@gmail.com wrote:
> From: Yanchuan Nian <ycn...@gmail.com>
>
> The layout will be set unusable if LAYOUTGET fails. Is it reasonable to
> increase the refcount iff LAYOUTGET fails the first time?
>
> Signed-off-by: Yanchuan Nian <ycn...@gmail.com>
> ---
> fs/nfs/pnfs.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/fs/nfs/pnfs.c b/fs/nfs/pnfs.c
> index e7165d9..d00260b 100644
> --- a/fs/nfs/pnfs.c
> +++ b/fs/nfs/pnfs.c
> @@ -254,7 +254,7 @@ static void
> pnfs_layout_set_fail_bit(struct pnfs_layout_hdr *lo, int fail_bit)
> {
> lo->plh_retry_timestamp = jiffies;
> - if (test_and_set_bit(fail_bit, &lo->plh_flags))
> + if (!test_and_set_bit(fail_bit, &lo->plh_flags))
> atomic_inc(&lo->plh_refcount);
> }
>
Thank for spotting this! Applying to the bugfixes branch...
--
Trond Myklebust
Linux NFS client maintainer
NetApp
trond.mykleb...@netapp.com
www.netapp.com
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
