Replace goto err_gpio by return ret
Signed-off-by: Helen Koike
---
Changes since v1:
- this is a new patch in the series
sound/soc/codecs/tpa6130a2.c | 11 ---
1 file changed, 4 insertions(+), 7 deletions(-)
diff --git a/sound/soc/codecs/tpa6130a2.c b/sound/soc/codecs/tpa6130a2.c
ernel/git/broonie/sound.git for-next
Available at
https://git.collabora.com/cgit/user/koike/linux.git/log/?h=sound/review/tpa6130a2
Helen Koike (5):
ASoC: tpa6130a2: Register component
ASoC: tap6130a2: Use regmap
ASoC: tpa6130a2: Use snd soc volsw functions
ASoC: tpa6130a2: Add DAPM support
Use snd_soc_{info,get,put}_volsw instead of custom volume functions
Signed-off-by: Lars-Peter Clausen
[koike: port for upstream]
Signed-off-by: Helen Koike
[On N900]
Tested-By: Sebastian Reichel
---
Changes since v1:
- Add tested-by from Sebastian
sound/soc/codecs/tpa6130a2.c | 64
Add DAPM support and updated rx51 accordingly.
As a consequence:
- the exported function tpa6130a2_stereo_enable is not needed anymore
- the mutex is dealt in the DAPM
- the power state is tracked by the DAPM
Signed-off-by: Lars-Peter Clausen
[koike: port for upstream]
Signed-off-by: Helen Koike
Add tpa6130a2 controls by the component API and update rx51 accordingly
Signed-off-by: Lars-Peter Clausen
[koike: port for upstream]
Signed-off-by: Helen Koike
Tested-By: Sebastian Reichel
Reviewed-By: Sebastian Reichel
---
Changes since v1:
- Remove prefix from snd_kcontrol_new in
Use regmap instead of open-coding IO access and caching
Signed-off-by: Lars-Peter Clausen
[koike: port for upstream]
Signed-off-by: Helen Koike
[On N900]
Tested-By: Sebastian Reichel
---
Changes since v1:
- Add tested-by from Sebastian
sound/soc/codecs/tpa6130a2.c | 166
Hi Sebastian,
Thank you for reviewing the patches.
On 20-06-2016 14:12, Helen Koike wrote:
Add DAPM support and updated rx51 accordingly.
As a consequence:
- the exported function tpa6130a2_stereo_enable is not needed anymore
- the mutex is dealt in the DAPM
- the power state is tracked by the
Remove unused function declaration from header
Signed-off-by: Helen Koike
---
sound/soc/codecs/max9877.h | 2 --
1 file changed, 2 deletions(-)
diff --git a/sound/soc/codecs/max9877.h b/sound/soc/codecs/max9877.h
index 6da7229..368343f 100644
--- a/sound/soc/codecs/max9877.h
+++ b/sound/soc
Remove the warning:
warning: ‘err’ may be used uninitialized in this function
[-Wmaybe-uninitialized]
Signed-off-by: Helen Koike
---
sound/hda/hdac_regmap.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/sound/hda/hdac_regmap.c b/sound/hda/hdac_regmap.c
index 87041dd
On 20-06-2016 16:44, Lars-Peter Clausen wrote:
+ /* before widget power up */
+ if (SND_SOC_DAPM_EVENT_ON(event)) {
+ /* Turn on the chip */
+ tpa6130a2_power(data, true);
+ /* Sync the registers */
+ ret = regcache_sync(data->
If link is disabled, media_entity_remote_pad returns NULL, causing a
NULL pointer deference.
Ignore links that are not enabled instead.
Signed-off-by: Helen Koike
---
drivers/media/platform/vimc/vimc-common.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/media/platform/vimc
Add API to allow userspace to create any type of topology in vimc using
basic system calls such as mkdir/rmdir/read/write.
Signed-off-by: Helen Koike
---
Hi,
This patch introduces the configufs API for configuring the topology in
vimc while it removes the hardcoded topology, so now, when you
The name of the struct is configfs_bin_attribute instead of
configfs_attribute
Signed-off-by: Helen Koike
---
Documentation/filesystems/configfs/configfs.txt | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Documentation/filesystems/configfs/configfs.txt
b/Documentation
Hi Tomasz,
On 12/13/18 2:02 AM, Tomasz Figa wrote:
> On Thu, Dec 6, 2018 at 1:12 AM Helen Koike wrote:
>>
>> Hi Ville
>>
>> On 11/27/18 11:34 AM, Ville Syrjälä wrote:
>>> On Fri, Nov 23, 2018 at 07:53:26PM -0200, Helen Koike wrote:
>>>> Allow us
Hello,
On 12/13/18 7:01 AM, Daniel Vetter wrote:
> On Thu, Dec 13, 2018 at 04:43:57PM +0900, Tomasz Figa wrote:
>> Hi Helen,
>>
>> On Sat, Nov 24, 2018 at 6:54 AM Helen Koike
>> wrote:
>>>
>>> This flag tells core to jump ahead the queued update if
Hi Mauro,
On 12/15/18 4:01 PM, Mauro Carvalho Chehab wrote:
> Hi Lucas,
>
>
> Em Sat, 15 Dec 2018 14:46:31 -0200
> Lucas A. M. Magalhães escreveu:
>
>> The previous code pipeline used the stack to walk on the graph and
>> process a frame. Basically the vimc-sensor entity starts a thread that
>
Hi Lucas,
Thank you for your patch, just some small comments below.
On 12/15/18 2:46 PM, Lucas A. M. Magalhães wrote:
> The previous code pipeline used the stack to walk on the graph and
> process a frame. Basically the vimc-sensor entity starts a thread that
> generates the frames and calls the
Hi Hans,
On 12/10/18 9:31 AM, Hans Verkuil wrote:
> On 12/7/18 7:22 PM, Helen Koike wrote:
>> Add API to allow userspace to create any type of topology in vimc using
>> basic system calls such as mkdir/rmdir/read/write.
>>
>> Signed-off-by: Helen Koike
>&g
Hi Leonardo,
Thanks for the patch, just some small comments below.
Please, check previous log messages with git log
arch/x86/entry/vdso/vdso2c.h, you will see that most patches had the
prefix "x86/vdso:" in the commit message.
On 10/16/18 9:08 PM, Leonardo Brás wrote:
> Renames the char variable
Hi Leonardo,
On 10/16/18 9:09 PM, Leonardo Brás wrote:
> Removes an unnecessary shadowed local variable (start).
> Optimize test of isdigit:
> - If isalpha returns true, isdigit will return false, so no need to test.
This patch does two different things, it should be in two separated
Hi Leonardo,
Thanks for the patch, just some small comments below.
On 10/16/18 9:09 PM, Leonardo Brás wrote:
> Changes the usage of DEF_FIELD_ADDR in this function to create a
> reference and operate over it using an aux variable.
> It also changes the loop logic used to find duplicates, to avoid
Hi Leonardo,
Thanks for the patch.
On 10/16/18 9:08 PM, Leonardo Brás wrote:
> Adds -Wshadow=local on KBUILD_HOSTCFLAGS to show shadow warnings
> on tools built for HOST.
>
> Signed-off-by: Leonardo Brás
> ---
> Makefile | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a
Hi Leonardo,
Thanks for the patches.
On 10/16/18 9:07 PM, Leonardo Brás wrote:
> This patchset add -Wshadow=local on KBUILD_HOSTCFLAGS and fixes
> all code that show this warning.
>
> The third patch was already submitted, but was not merged yet.
> I like to think it's part of this patchset, bu
Hi Leonardo,
Thanks for your patch.
On 10/22/18 11:10 PM, Leonardo Brás wrote:
> Creates DEF_FIELD_ADDR_VAR as a more generic version of the DEF_FIELD_ADD
> macro, allowing usage of a variable name other than the struct element name.
> Also, sets DEF_FIELD_ADDR as a specific usage of DEF_FILD_ADD
Hi Leonardo,
On 10/22/18 11:10 PM, Leonardo Brás wrote:
> Creates DEF_FIELD_ADDR_VAR as a more generic version of the DEF_FIELD_ADD
> macro, allowing usage of a variable name other than the struct element name.
> Also, sets DEF_FIELD_ADDR as a specific usage of DEF_FILD_ADDR_VAR in which
> the var
phy);
+ int ret;
+
+ ret = phy_mipi_dphy_config_validate(&opts->mipi_dphy);
+ if (ret)
+ return ret;
+
+ dsi->dphy_config = *config;
+ dsi->lane_mbps = div_u64(config->hs_clk_rate, 1000 * 1000 * 1);
+
+ return 0;
+}
+
+static int dw_mipi_dsi
On 3/15/19 8:29 AM, Michel Dänzer wrote:
> On 2019-03-15 11:25 a.m., Boris Brezillon wrote:
>> On Fri, 15 Mar 2019 11:11:36 +0100
>> Michel Dänzer wrote:
>>
>>> On 2019-03-14 6:51 p.m., Helen Koike wrote:
>>>> On 3/14/19 6:15 AM, Michel Dänzer wro
Hi Beatriz,
Thank you for the patch, just some small comments.
Regarding the patch title, if you run
git log drivers/staging/rtl8723bs/hal/hal_com_phycfg.c
You will see that commits starts with the following tags "staging:
rtl8723bs: "
Also, try to add a bit more information to the title,
Hi Hans,
Thank you for your comment, please see my reply below.
On 2/23/21 9:35 AM, Hans Verkuil wrote:
Hi Helen,
On 14/01/2021 19:07, Helen Koike wrote:
This is part of the multiplanar and singleplanar unification process.
v4l2_ext_pix_format is supposed to work for both cases.
We also add
The script was trying to load vivid and run some commands on top of it
even when $vivid = 0.
Wrap all vivid code under $vivid variable.
Signed-off-by: Helen Koike
---
contrib/test/test-media | 66 -
1 file changed, 33 insertions(+), 33 deletions(-)
diff
On 2/17/21 3:22 PM, Hans Verkuil wrote:
On 17/02/2021 19:11, Helen Koike wrote:
The script was trying to load vivid and run some commands on top of it
even when $vivid = 0.
Wrap all vivid code under $vivid variable.
Signed-off-by: Helen Koike
---
contrib/test/test-media | 66
Hello,
On 1/14/21 3:07 PM, Helen Koike wrote:
> Hello,
>
> This is v6 of the Extended API for formats and buffers (see below the new
> API).
>
> The new API comes for free for old drivers through the conversion layer, which
> is independent of vb2.
>
> I completly
On 6/1/20 9:37 AM, Laurent Pinchart wrote:
> On Mon, Jun 01, 2020 at 05:46:26PM +0530, Kaaira Gupta wrote:
>> On Fri, May 29, 2020 at 05:43:57PM +0200, Dafna Hirschfeld wrote:
>>> Hi,
>>> Thanks for the patch
>>>
>>> I don't know how real devices handle ARGB formats,
>>> I wonder if it should be
On 6/1/20 10:53 AM, Kaaira Gupta wrote:
> Hi!
>
> Currently there is no method to know if the test image generated by vimc
> is correct (except for comparing it with a known 'correct' image). So, I
> wanted to investigate about a possibility to add text to each color bar
> of the generated patt
Hi Dafna,
On 5/21/20 9:03 AM, Dafna Hirschfeld wrote:
> Hi
>
> On 15.04.20 03:30, Helen Koike wrote:
>> Add v4l2_pipeline_stream_{enable,disable} helper functions to iterate
>> through the subdevices in a given stream (i.e following links from sink
>> to source) an
t; Hi Dafna,
>>>>
>>>> On 28/07/2020 15:00, Dafna Hirschfeld wrote:
>>>>>
>>>>>
>>>>> On 28.07.20 14:07, Dafna Hirschfeld wrote:
>>>>>> Hi
>>>>>>
>>>>>> On 28.07.
Hi Tomasz,
On 12/21/20 12:13 AM, Tomasz Figa wrote:
> On Thu, Dec 17, 2020 at 10:20 PM Helen Koike
> wrote:
>>
>> Hi Tomasz,
>>
>> Thanks for your comments, I have a few questions below.
>>
>> On 12/16/20 12:13 AM, Tomasz Figa wrote:
>>> On Tu
On 11/20/20 10:20 AM, Hans Verkuil wrote:
> On 20/11/2020 13:40, Tomasz Figa wrote:
>> On Fri, Nov 20, 2020 at 9:24 PM Hans Verkuil wrote:
>>>
>>> On 20/11/2020 12:06, Tomasz Figa wrote:z
>>>> Hi Helen,
>>>>
>>>> On Tue,
Just minor things.
Add capabilities to v4l_print_create_buffers(), clarify docs and remove
a redundant check.
Helen Koike (3):
media: v4l2-ioctl: print capabilities in v4l_print_create_buffers()
media: videodev2.h: clarify v4l2_pix_format_mplane.sizeimage docs when
to set to zero
media
sizeimage field should be set to zero for unused planes, even when
v4l2_pix_format_mplane.num_planes is smaller then the index of planes.
Signed-off-by: Helen Koike
---
I caught this with v4l2-compliance, which throws an error if we dirty
planes, even if invalid, so I would like to make it
request_fd is validated under media_request_get_by_fd() just below this
check. Thus remove it.
Suggested-by: Tomasz Figa
Signed-off-by: Helen Koike
---
drivers/media/common/videobuf2/videobuf2-v4l2.c | 5 -
1 file changed, 5 deletions(-)
diff --git a/drivers/media/common/videobuf2
Print capabilities field from struct v4l2_create_buffers for better
debugging.
Signed-off-by: Helen Koike
---
drivers/media/v4l2-core/v4l2-ioctl.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/media/v4l2-core/v4l2-ioctl.c
b/drivers/media/v4l2-core/v4l2
Add normalization to pixelformats, so we can fallback to it when using
Ext API, and eliminating the handling of two variantes (M and non-M
formats).
Signed-off-by: Helen Koike
---
Changes in v6:
- New patch
---
drivers/media/v4l2-core/v4l2-common.c | 16
include/media/v4l2
u32 bytesused;
union {
__u32 mmap_offset;
__u64 userptr;
__s32 dmabuf_fd;
} m;
__u32 reserved[6];
};
Helen Koike (11):
media: v4l2-common: add normalized pixelformat field to struct
v4l2_format_info
media: v4l2: E
the
_ext_ hooks.
Signed-off-by: Boris Brezillon
Signed-off-by: Helen Koike
---
Changes in v6:
The main change here was fixing the conversion, so planes reflects color
planes,
and to implement this properly I made major refactors compared to the previous
version.
- struct
v4l2_buffer object, making it undependent of this struct.
Signed-off-by: Helen Koike
---
Changes in v6:
- New patch
---
.../media/common/videobuf2/videobuf2-v4l2.c | 176 ++
1 file changed, 97 insertions(+), 79 deletions(-)
diff --git a/drivers/media/common/videobuf2/videobuf2-v4l2
n the reserved area if needed or
use the Request API to collect more metadata information from the
frame.
Signed-off-by: Hans Verkuil
Signed-off-by: Boris Brezillon
Signed-off-by: Helen Koike
---
Changes in v6:
This patch was completely refactored, and based on previous version from
Hans and
oad() into color planes
when a single memory buffer is used.
Signed-off-by: Boris Brezillon
Signed-off-by: Helen Koike
---
Changes in v6:
This patch is based on original "media: videobuf2: Expose helpers to implement
the _ext_fmt and _ext_buf hooks"
- This patch was complet
Add vb2 ext hooks and call vb2_set_pixelformat().
This allows more flexibility with buffer handling.
Signed-off-by: Helen Koike
---
Changes in v6:
- New patch to exemplify how drivers would easily support features from Ext Buf
---
drivers/media/test-drivers/vivid/vivid-core.c| 2 ++
drivers
Just a new version of v4l2_fill_mbus_format() and v4l2_fill_ext_pix_format()
to deal with the new v4l2_ext_pix_format struct.
This is needed to convert the VIMC driver to the EXT_FMT/EXT_BUF iocts.
Signed-off-by: Boris Brezillon
Signed-off-by: Helen Koike
---
Changes in v6:
- Rename
Add vb2 ext hooks and call vb2_set_pixelformat().
This allows more flexibility with buffer handling.
Signed-off-by: Helen Koike
---
Changes in v6:
- New patch to exemplify how drivers would easily support features from Ext Buf
---
drivers/media/test-drivers/vimc/vimc-capture.c | 3 +++
1 file
Add documentation and update references in current documentation for the
Extended API.
Signed-off-by: Helen Koike
---
Changes in v6:
- Update note saying ext_api should be used for new applications on
newer kernels (Tomasz and Hans)
- Fix typos pointed in v5 (Hand and Tomasz)
- Change order
Simplify Multi/Single planer API handling by converting to v4l2_ext_pix_format.
Signed-off-by: Boris Brezillon
Signed-off-by: Helen Koike
---
Changes in v6:
- Update with new format and buffer structs
Changes in v4:
- Update with new format and buffer structs
- Rebased on top of media/master
-by: Boris Brezillon
Signed-off-by: Helen Koike
---
Changes in v6:
- Update with new format and buffer structs
- duplicate v4l2_ioctl_ops for touch devices.
Changes in v4:
- Update with new format and buffer structs
- Rebased on top of media/master (post 5.8-rc1)
Changes in v3:
- Rebased on top
underlying buffer.
Suggested-by: Hans Verkuil
Signed-off-by: Helen Koike
---
Hello,
As discussed on
https://patchwork.linuxtv.org/project/linux-media/patch/gh5kef5bkeel3o6b2dkgc2dfagu9klj...@4ax.com/
This patch also helps the conversion layer of the Ext API patchset,
where we are not exposing the
Since we always use the size of the underlying buffer for dmabuf, remove
the size parameter from the attach_dmabuf() callback.
Suggested-by: Hans Verkuil
Signed-off-by: Helen Koike
---
drivers/media/common/videobuf2/videobuf2-core.c | 2 +-
drivers/media/common/videobuf2/videobuf2-dma
provides a bigger length and bytesused then the underlying buffer.
Suggested-by: Hans Verkuil
Signed-off-by: Helen Koike
---
Hello,
As discussed on
https://patchwork.linuxtv.org/project/linux-media/patch/gh5kef5bkeel3o6b2dkgc2dfagu9klj...@4ax.com/
This patch also helps the conversion layer of
Hi Laurent,
On 3/25/21 7:53 AM, Laurent Pinchart wrote:
Hi Helen,
On Wed, Mar 24, 2021 at 09:17:11PM -0300, Helen Koike wrote:
Always use dmabuf size when considering the length of the buffer.
Discard userspace provided length.
Fix length check error in _verify_length(), which was handling
diferently, and also not catching the case where userspace
provides a bigger length and bytesused then the underlying buffer.
Suggested-by: Hans Verkuil
Signed-off-by: Helen Koike
---
Hello,
As discussed on
https://patchwork.linuxtv.org/project/linux-media/patch/gh5kef5bkeel3o6b2dkgc2dfagu9klj
(if the link has no caption the label must
precede a section header)
Fixes: df22026aebd8 ("media: videodev2.h, v4l2-ioctl: add rkisp1 meta buffer
format")
Signed-off-by: Helen Koike
Reported-by: Stephen Rothwell
---
Documentation/admin-guide/media/rkisp1.rst
Hi Stephen,
On 11/18/20 2:32 AM, Stephen Rothwell wrote:
> Hi all,
>
> After merging the v4l-dvb tree, today's linux-next build (htmldocs)
> produced these warnings:
>
> Documentation/output/videodev2.h.rst:6: WARNING: undefined label:
> v4l2-meta-fmt-rk-isp1-params (if the link has no caption
Hi Tomasz,
On 11/19/20 2:45 AM, Tomasz Figa wrote:
> On Sat, Nov 14, 2020 at 11:21:26AM -0300, Helen Koike wrote:
>> Hi Tomasz,
>>
>> On 10/2/20 4:49 PM, Tomasz Figa wrote:
>>> Hi Helen,
>>>
>>> On Tue, Aug 04, 2020 at 04:29:33PM -030
On 8/4/20 4:29 PM, Helen Koike wrote:
> Add documentation and update references in current documentation for the
> Extended API.
>
> Signed-off-by: Helen Koike
> ---
> Changes in v5:
> - new patch
>
> .../userspace-api/media/v4l/buffer.rst| 5 +
>
On 11/19/20 7:08 AM, Helen Koike wrote:
> Hi Tomasz,
>
> On 11/19/20 2:45 AM, Tomasz Figa wrote:
>> On Sat, Nov 14, 2020 at 11:21:26AM -0300, Helen Koike wrote:
>>> Hi Tomasz,
>>>
>>> On 10/2/20 4:49 PM, Tomasz Figa wrote:
>>>> Hi Hel
Hi Alexandre,
Thanks for your review.
On 8/14/20 4:49 AM, Alexandre Courbot wrote:
> On Wed, Aug 5, 2020 at 4:32 AM Helen Koike wrote:
>>
>> This is part of the multiplanar and singleplanar unification process.
>> v4l2_ext_pix_format is supposed to work for both cases.
Hi Dan,
Thank you for your patch.
On 11/30/20 9:53 AM, Dan Carpenter wrote:
> The debugfs_create_dir() function never returns NULLs. It's not supposed
> to checked for errors in the normal case and there is no need to check
> in this function so let's just delete this dead code.
>
> Signed-off-
Hi Hans,
Thank you for your review.
On 9/9/20 9:27 AM, Hans Verkuil wrote:
> Hi Helen,
>
> Again I'm just reviewing the uAPI.
>
> On 04/08/2020 21:29, Helen Koike wrote:
>> From: Hans Verkuil
>>
>> Those extended buffer ops have several purpose:
&g
On 11/23/20 12:46 PM, Tomasz Figa wrote:
> On Tue, Nov 24, 2020 at 12:08 AM Helen Koike
> wrote:
>>
>> Hi Hans,
>>
>> Thank you for your review.
>>
>> On 9/9/20 9:27 AM, Hans Verkuil wrote:
>>> Hi Helen,
>>>
>>> Again I'
Hi Tomasz,
On 11/20/20 8:14 AM, Tomasz Figa wrote:
> Hi Helen,
>
> On Tue, Aug 04, 2020 at 04:29:34PM -0300, Helen Koike wrote:
>> From: Hans Verkuil
>>
>> Those extended buffer ops have several purpose:
>> 1/ Fix y2038 issues by converting the timestamp into
Hi Peilin,
On 11/26/20 9:21 AM, Peilin Ye wrote:
> Fix 4 typos under drivers/media/platform/rockchip/rkisp1/ found by
> checkpatch, including the RKISP1_CIF_MI_{M,S}P_PINGPONG_ENABLE macro
> definitions.
>
> Signed-off-by: Peilin Ye
Thanks
Acked-by: Helen Koike
> ---
Hi Tomasz,
Thanks for your comments, I have a few questions below.
On 12/16/20 12:13 AM, Tomasz Figa wrote:
> On Tue, Dec 15, 2020 at 11:37 PM Helen Koike
> wrote:
>>
>> Hi Tomasz,
>>
>> On 12/14/20 7:46 AM, Tomasz Figa wrote:
>>> On Fri, Dec 4,
Hi Dan,
On 12/1/20 11:27 AM, Dan Carpenter wrote:
> On Mon, Nov 30, 2020 at 11:20:05AM -0300, Helen Koike wrote:
>> Hi Dan,
>>
>> Thank you for your patch.
>>
>> On 11/30/20 9:53 AM, Dan Carpenter wrote:
>>> The debugfs_create_dir() function never return
just delete this code.
>
> Signed-off-by: Dan Carpenter
Since the debugfs_create_*() functions already check the parent
with IS_ERR(), this looks good to me.
Acked-by: Helen Koike
Thanks
Helen
> ---
> v2: Fix subject
>
> drivers/media/platform/rockchip/rkisp1/rkisp1-dev.c
Hi,
Please see my 2 points below (about v4l2_ext_buffer and another about
timestamp).
On 12/3/20 12:11 PM, Hans Verkuil wrote:
> On 23/11/2020 18:40, Helen Koike wrote:
>>
>>
>> On 11/23/20 12:46 PM, Tomasz Figa wrote:
>>> On Tue, Nov 24, 2020 at 12:08 AM Helen K
YUV 4:4:4 is not subsampled, fix this in the docs.
Fixes: da785536e007 ("media: doc: pixfmt-yuv: Move all semi-planar YUV formats
to common file")
Signed-off-by: Helen Koike
---
Documentation/userspace-api/media/v4l/pixfmt-yuv-planar.rst | 4 ++--
1 file changed, 2 insertions(+), 2
On 1/23/21 6:56 AM, Laurent Pinchart wrote:
> Hi Helen,
>
> Thank you for the patch.
>
> On Fri, Jan 22, 2021 at 03:27:23PM -0300, Helen Koike wrote:
>> YUV 4:4:4 is not subsampled, fix this in the docs.
>>
>> Fixes: da785536e007 ("media: doc: pixfmt-yuv
On 1/25/21 10:57 AM, Helen Koike wrote:
>
>
> On 1/23/21 6:56 AM, Laurent Pinchart wrote:
>> Hi Helen,
>>
>> Thank you for the patch.
>>
>> On Fri, Jan 22, 2021 at 03:27:23PM -0300, Helen Koike wrote:
>>> YUV 4:4:4 is not subsampled, fix this
YUV 4:4:4 is not subsampled, fix this in the docs.
Fixes: da785536e007 ("media: doc: pixfmt-yuv: Move all semi-planar YUV formats
to common file")
Signed-off-by: Helen Koike
---
Changes in v2:
- s/No sub-sampling/The chroma plane is not subsampled/ (Laurent)
- Fixed description reg
On 1/25/21 6:31 AM, Hans Verkuil wrote:
> On 14/01/2021 19:01, Helen Koike wrote:
>> sizeimage field should be set to zero for unused planes, even when
>> v4l2_pix_format_mplane.num_planes is smaller then the index of planes.
>
> then -> than
Ack.
>
>&
Hi Tomasz,
On 12/14/20 7:46 AM, Tomasz Figa wrote:
> On Fri, Dec 4, 2020 at 4:52 AM Helen Koike wrote:
>>
>> Hi,
>>
>> Please see my 2 points below (about v4l2_ext_buffer and another about
>> timestamp).
>>
>> On 12/3/20 12:11 PM, Hans Verkuil wrot
Hi Tomasz,
Thank you for your comments,
On 12/14/20 5:52 AM, Tomasz Figa wrote:
> Hi Helen,
>
> On Tue, Aug 04, 2020 at 04:29:35PM -0300, Helen Koike wrote:
>> The VB2 layer is used by a lot of drivers. Patch it to support the
>> _EXT_PIX_FMT and _EXT_BUF ioctls in order
Hi Tomasz,
Thank you for your comments,
On 12/14/20 7:36 AM, Tomasz Figa wrote:
> On Tue, Nov 24, 2020 at 5:33 AM Helen Koike wrote:
>>
>> Hi Tomasz,
>>
>>
>> On 11/20/20 8:14 AM, Tomasz Figa wrote:
>>> Hi Helen,
>>>
>>> On Tue, Au
Hello,
On 8/4/20 4:29 PM, Helen Koike wrote:
> Hello,
>
> This is v5 of the Extended API for formats and buffers, which introduces
> the following new ioctls:
>
> int ioctl(int fd, VIDIOC_G_EXT_PIX_FMT, struct v4l2_ext_pix_format *argp)
> int ioctl(int fd, VIDIOC_
h
> most closely matches the cr50 i2c protocol behavior.
>
> Cc: Helen Koike
> Signed-off-by: Duncan Laurie
> [swb...@chromium.org: Depend on i2c even if it's a module, replace
> boilier plate with SPDX tag, drop asm/byteorder.h include, simplify
> return from probe]
Hi Laurent,
Thanks for your review, I just have some comments/questions below.
On 8/15/19 2:54 PM, Laurent Pinchart wrote:
> Hi Helen,
>
> Thank you for the patch.
>
> On Wed, Aug 07, 2019 at 10:37:55AM -0300, Helen Koike wrote:
>> On 8/7/19 10:05 AM, Sakari Ailus wrot
Hi Sakari,
Thanks for your review. I just have some comments/questions below.
On 8/8/19 6:14 AM, Sakari Ailus wrote:
> Hi Helen,
>
> On Tue, Jul 30, 2019 at 03:42:47PM -0300, Helen Koike wrote:
>> From: Jacob Chen
>>
>> Add the subdev driver for rockchip isp1.
>
Hi Shuah,
Thanks for the patches.
On 8/15/19 4:42 PM, Shuah Khan wrote:
> vimc uses Component API to split the driver into functional components.
> The real hardware resembles a monolith structure than component and
> component structure added a level of complexity making it hard to
> maintain wi
debayer.o vimc-scaler.o vimc-sensor.o
> +
> +obj-$(CONFIG_VIDEO_VIMC) += vimc.o
>
> -obj-$(CONFIG_VIDEO_VIMC) += vimc.o vimc-capture.o vimc-debayer.o \
> -vimc-scaler.o vimc-sensor.o
> diff --git a/drivers/media/platform/vimc/vimc-capture.c
> b/drivers/media/platf
On 9/6/19 11:42 PM, Shuah Khan wrote:
> After practically re-writing the driver to collpase it into a monolith,
> I am adding myself as a reviewer for vimc driver.
Thank you!
>
> Signed-off-by: Shuah Khan
Acked-by: Helen Koike
> ---
> MAINTAINERS | 1 +
> 1 file
> kernel: [ 4136.715976] kernfs_fop_write+0x128/0x1b0
> kernel: [ 4136.715982] __vfs_write+0x1b/0x40
> kernel: [ 4136.715987] vfs_write+0xc3/0x1d0
> kernel: [ 4136.715993] ksys_write+0xaa/0xe0
> kernel: [ 4136.715999] __x64_sys_write+0x1a/0x20
> kernel: [ 4136.716005] do_s
On 9/6/19 11:42 PM, Shuah Khan wrote:
> vimc driver is now a monolithic driver. Update the module parameter
> usage information to reflect that.
>
> Signed-off-by: Shuah Khan
Acked-by: Helen Koike
> ---
> Documentation/media/v4l-drivers/vimc.rst | 12 ++--
&g
vimc-streamer.o vimc-capture.o \
> + vimc-debayer.o vimc-scaler.o vimc-sensor.o
> +
> +obj-$(CONFIG_VIDEO_VIMC) += vimc.o
>
> -obj-$(CONFIG_VIDEO_VIMC) += vimc.o vimc-capture.o vimc-debayer.o \
> -vimc-scaler.o vimc-sensor.o
> diff --git a/drivers/med
Hi Shuah,
On 9/6/19 11:42 PM, Shuah Khan wrote:
> Move duplicated IS_SRC and IS_SINK dfines to common header. Rename
> them to VIMC_IS_SRC and VIM_IS_SINK.
>
> Signed-off-by: Shuah Khan
> ---
> drivers/media/platform/vimc/vimc-common.h | 4
> drivers/media/platform/vimc/vimc-debayer.c |
On 9/15/19 8:52 PM, Shuah Khan wrote:
> On 9/15/19 1:25 PM, Helen Koike wrote:
>> Hi Shuah,
>>
>> On 9/6/19 11:42 PM, Shuah Khan wrote:
>>> Move duplicated IS_SRC and IS_SINK dfines to common header. Rename
>>> them to VIMC_IS_SRC and VIM_IS_
Hi Randy,
On 9/14/19 11:16 PM, Randy Dunlap wrote:
> Kernel is 5.3-rc8 on x86_64.
>
> Loading, unloading, and then loading the vimc-debayer module causes:
>
>
> [ 793.542496] [ cut here ]
> [ 793.542518] DEBUG_LOCKS_WARN_ON(lock->magic != lock)
> [ 793.542536] WARNING
'"Debayer B":0[fmt:SBGGR8_1X8/640x480]'
>
> v4l2-ctl -z platform:vimc -d "RGB/YUV Capture" -v width=1920,height=1440
> v4l2-ctl -z platform:vimc -d "Raw Capture 0" -v pixelformat=BA81
> v4l2-ctl -z platform:vimc -d "Raw Capture 1" -v
> kernel: [ 4136.715976] kernfs_fop_write+0x128/0x1b0
> kernel: [ 4136.715982] __vfs_write+0x1b/0x40
> kernel: [ 4136.715987] vfs_write+0xc3/0x1d0
> kernel: [ 4136.715993] ksys_write+0xaa/0xe0
> kernel: [ 4136.715999] __x64_sys_write+0x1a/0x20
> kernel: [ 4136.716005] do_s
On 9/17/19 1:35 PM, Shuah Khan wrote:
> Move duplicated IS_SRC and IS_SINK dfines to common header. Rename
> them to VIMC_IS_SRC and VIM_IS_SINK.
>
> Signed-off-by: Shuah Khan
Acked-by: Helen Koike
> ---
> drivers/media/platform/vimc/vimc-common.h | 4
> driver
On 9/17/19 1:35 PM, Shuah Khan wrote:
> vimc driver is now a monolithic driver. Update the module parameter
> usage information to reflect that.
>
> Signed-off-by: Shuah Khan
Acked-by: Helen Koike
> ---
> Documentation/media/v4l-drivers/vimc.rst | 12 ++--
&g
On 9/17/19 1:35 PM, Shuah Khan wrote:
> After practically re-writing the driver to collpase it into a monolith,
> I am adding myself as a reviewer for vimc driver.
>
> Signed-off-by: Shuah Khan
Acked-by: Helen Koike
> ---
> MAINTAINERS | 1 +
> 1 file changed, 1 i
1 - 100 of 380 matches
Mail list logo
