n mkfs.btrfs", you will see the difference.
>
> Signed-off-by: Zhi Yong Wu
Whoops, yes. Thanks for spotting that.
Reviewed-by: Eric Sandeen
> ---
> man/mkfs.btrfs.8.in | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/man/mkfs.btrfs.8.in b/man/mk
On 10/23/12 5:19 PM, Theodore Ts'o wrote:
> On Tue, Oct 23, 2012 at 09:57:08PM +0100, Nix wrote:
>>
>> It is now quite clear that this is a bug introduced by one or more of
>> the post-3.6.1 ext4 patches (which have all been backported at least to
>> 3.5, so the problem is probably there too).
>>
>
On 10/23/12 3:57 PM, Nix wrote:
> (I'd provide more sample errors, but this bug has been eating
> newly-written logs in /var all day, so not much has survived.)
>
> I rebooted into 3.6.1 rescue mode and fscked everything: lots of
> orphans, block group corruption and cross-linked files. The pro
On 10/23/12 11:15 PM, Nix wrote:
> On 24 Oct 2012, Eric Sandeen uttered the following:
>
>> On 10/23/12 3:57 PM, Nix wrote:
>>> The only unusual thing about the filesystems on this machine are that
>>> they have hardware RAID-5 (using the Areca driver), so I&
On 10/24/2012 12:23 AM, Theodore Ts'o wrote:
> On Tue, Oct 23, 2012 at 11:27:09PM -0500, Eric Sandeen wrote:
>>
>> Ok, fair enough. If the BBU is working, nobarrier is ok; I don't trust
>> journal_async_commit, but that doesn't mean this isn't a regre
On 10/24/2012 02:49 PM, Nix wrote:
> On 24 Oct 2012, Theodore Ts'o spake thusly:
>> Toralf, Nix, if you could try applying this patch (at the end of this
>> message), and let me know how and when the WARN_ON triggers, and if it
>> does, please send the empty_bug_workaround plus the WARN_ON(1) repor
On 10/25/12 1:20 PM, Theodore Ts'o wrote:
> On Thu, Oct 25, 2012 at 06:39:30PM +0200, Toralf Förster wrote:
>> After a lot of file operations (Gentoo emerging, kernel build, git
>> pulls, ...) I s2disk the system (that with the external USB drive)
>> yesterday, wake it up today, rebooted it -
>> an
Linda Walsh wrote:
>
> David Chinner wrote:
>> Filesystem bugs rarely hang systems hard like that - more likely is
>> a hardware or driver problem. And neither of the lockdep reports
>> below are likely to be responsible for a system wide, no-response
>> hang.
> ---
> "Ish", the 32-bitter, h
Linda Walsh wrote:
>
> Eric Sandeen wrote:
>> Linda Walsh wrote:
>>> David Chinner wrote:
>>>> Filesystem bugs rarely hang systems hard like that - more likely is
>>>> a hardware or driver problem. And neither of the lockdep reports
>>>>
Takashi Sato wrote:
> Hi,
>
> Christoph Hellwig wrote:
>> On Fri, Feb 08, 2008 at 08:26:57AM -0500, Andreas Dilger wrote:
>>> You may as well make the common ioctl the same as the XFS version,
>>> both by number and parameters, so that applications which already
>>> understand the XFS ioctl will w
On 9/20/12 9:07 PM, Namhyung Kim wrote:
> Hi again,
>
> On Thu, 20 Sep 2012 20:12:50 -0500, Eric Sandeen wrote:
>> -$(OUTPUT)util/parse-events-flex.c: util/parse-events.l
>> +$(OUTPUT)util/parse-events-flex.c: util/parse-events.l
>> util/parse-events-bison.c
>
&
front of
the bison calls in tools/perf/Makefile and running make -j4 on a
smaller box i.e.:
sleep 10; $(QUIET_BISON)$(BISON) -v util/pmu.y -d -o
$(OUTPUT)util/pmu-bison.c
Adding the following dependencies fixes it for me.
Signed-off-by: Eric Sandeen
---
V2: Fix other bison dependency
On 10/24/12 3:17 PM, Jan Kara wrote:
> On Tue 23-10-12 19:57:09, Eric Sandeen wrote:
>> On 10/23/12 5:19 PM, Theodore Ts'o wrote:
>>> On Tue, Oct 23, 2012 at 09:57:08PM +0100, Nix wrote:
>>>>
>>>> It is now quite clear that this is a bug introd
On 10/23/12 3:57 PM, Nix wrote:
> [Bruce, Trond, I fear it may be hard for me to continue chasing this NFS
> lockd crash as long as ext4 on 3.6.3 is hosing my filesystems like
> this. Apologies.]
> The only unusual thing about the filesystems on this machine are that
> they have hardware RAID-
On 10/27/12 7:45 AM, Nix wrote:
> [nfs people purged from Cc]
>
> On 27 Oct 2012, Theodore Ts'o verbalised:
>
>> Huh? It's not turned on by default. If you mount with no mount
>> options, journal checksums are *not* turned on.
>
> ?! it's turned on for me, and though I use weird mount options
On 10/27/12 1:47 PM, Nix wrote:
> On 27 Oct 2012, Theodore Ts'o said:
>
>> On Sat, Oct 27, 2012 at 01:45:25PM +0100, Nix wrote:
>>> Ah! it's turned on by journal_async_commit. OK, that alone argues
>>> against use of journal_async_commit, tested or not, and I'd not have
>>> turned it on if I'd not
On 10/27/12 4:19 PM, Eric Sandeen wrote:
> On 10/27/12 1:47 PM, Nix wrote:
>> On 27 Oct 2012, Theodore Ts'o said:
>>
>>> On Sat, Oct 27, 2012 at 01:45:25PM +0100, Nix wrote:
>>>> Ah! it's turned on by journal_async_commit. OK, that alone argues
>&
fix it survives
many iterations.
Signed-off-by: Eric Sandeen
cc: Nix
---
A little more going on here to try to properly handle error
cases & moving to the next group; despite
ext4_handle_release_buffer being a no-op, I've tried
to sprinkle it in at the right places. Double checking
on r
On 10/28/12 8:00 PM, Theodore Ts'o wrote:
> On Sat, Oct 27, 2012 at 05:42:07PM -0500, Eric Sandeen wrote:
>>
>> It looks like the inode_bitmap_bh is being modified outside a transaction:
>>
>> ret2 = ext4_test_and_set_bit(ino, inode_bitm
On 10/28/12 9:34 PM, Theodore Ts'o wrote:
> On Sun, Oct 28, 2012 at 09:24:19PM -0500, Eric Sandeen wrote:
>> Yeah, I knew it wasn't ;) I did resend
>> [PATCH] ext4: fix unjournaled inode bitmap modification
>> which is a bit more involved.
>
> Yeah, sorr
On 10/28/12 9:30 PM, Theodore Ts'o wrote:
> On Sat, Oct 27, 2012 at 11:23:57PM -0500, Eric Sandeen wrote:
>> A little more going on here to try to properly handle error
>> cases & moving to the next group; despite
>> ext4_handle_release_buffer being a no-op, I'v
e leak either way.
>
> Spotted with Coverity.
>
> Signed-off-by: Dave Jones
Looks right to me.
Reviewed-by: Eric Sandeen
Thanks!
-Eric
> diff --git a/fs/ext4/xattr.c b/fs/ext4/xattr.c
> index c081e34..f3a6220 100644
> --- a/fs/ext4/xattr.c
> +++ b/fs/e
On 9/10/13 4:02 PM, Theodore Ts'o wrote:
> On Tue, Sep 10, 2013 at 02:47:33PM -0600, Andreas Dilger wrote:
>> I agree that SELinux is enabled on enterprise distributions by default,
>> but I'm also interested to know how much overhead this imposes. I would
>> expect that writing large external xat
On 9/11/13 6:30 AM, Theodore Ts'o wrote:
> On Tue, Sep 10, 2013 at 10:13:16PM -0500, Eric Sandeen wrote:
>>
>> Above doesn't tell us the prevalence of various contexts on the actual
>> system,
>> but they are all under 100 bytes in any case.
>
> OK, s
On 9/11/13 11:49 AM, Eric Sandeen wrote:
> On 9/11/13 6:30 AM, Theodore Ts'o wrote:
>> On Tue, Sep 10, 2013 at 10:13:16PM -0500, Eric Sandeen wrote:
>>>
>>> Above doesn't tell us the prevalence of various contexts on the actual
>>> system,
&g
On 9/11/13 3:32 PM, David Lang wrote:
> On Wed, 11 Sep 2013, Eric Sandeen wrote:
>
>>> The reason why I'm pushing here is that mbcache shouldn't be showing
>>> up in the profiles at all if there is no external xattr block. And so
>>> if newer versions
On 9/11/13 3:36 PM, Thavatchai Makphaibulchoke wrote:
> I seem to be seeing the same thing as Eric is seeing.
...
> For both filesystems, the security xattr are about 32.17 and 34.87 bytes
> respectively.
...
Can you triple-check the inode size on your fs, for good measure?
dumpe2fs -h /dev/wh
On 12/7/12 3:14 PM, Theodore Ts'o wrote:
> On Fri, Dec 07, 2012 at 02:30:19PM -0500, Steven Rostedt wrote:
>> How is this similar? By adding this bit, we removed incentive from a
>> group of developers that have the means to fix the real issue at hand
>> (the performance problem with ext4). Thus, i
On 12/7/12 3:57 PM, Chris Mason wrote:
> On Fri, Dec 07, 2012 at 02:49:04PM -0700, Ric Wheeler wrote:
>> On 12/07/2012 04:43 PM, Chris Mason wrote:
>>> On Fri, Dec 07, 2012 at 02:27:43PM -0700, Theodore Ts'o wrote:
On Fri, Dec 07, 2012 at 04:09:32PM -0500, Chris Mason wrote:
> Persistent t
On 12/7/12 3:57 PM, Chris Mason wrote:
> On Fri, Dec 07, 2012 at 02:49:04PM -0700, Ric Wheeler wrote:
>> On 12/07/2012 04:43 PM, Chris Mason wrote:
>>> On Fri, Dec 07, 2012 at 02:27:43PM -0700, Theodore Ts'o wrote:
On Fri, Dec 07, 2012 at 04:09:32PM -0500, Chris Mason wrote:
> Persistent t
On 12/29/12 5:16 PM, Sergei Trofimovich wrote:
> It fixes boot panic when trying to boot from btrfs filesystem.
> kernel tries to mount as xfs and gets fatal -EUCLEAN:
>
> [0.17] VFS: Cannot open root device "ubda" or unknown-block(98,0):
> error -117
> [0.17] Please append a corr
On 5/30/13 10:03 PM, CAI Qian wrote:
> OK, so the minimal workload to trigger this I found so far was to
> run trinity, ltp and then xfstests. I have been able to easily
> reproduced on 3 servers so far, and I'll post full logs here for
> LKML and linux-mm as this may unrelated to XFS only. As far
On Jun 23, 2013, at 12:01 PM, Andreas Dilger wrote:
> On 2013-06-23, at 0:07, Namjae Jeon wrote:
>
>> From: Namjae Jeon
>>
>> This patch series introduces 2 new ioctls for ext4.
>>
>> Truncate_block_range ioctl truncates blocks from source file.
>
> How is this different from fallocate(FALL
On 8/20/13 6:20 AM, Geert Uytterhoeven wrote:
> u64 is "unsigned long long" on all architectures now, so there's no need to
> cast it when formatting it using the "ll" length modifier.
>
> Signed-off-by: Geert Uytterhoeven
> ---
> fs/btrfs/backref.c | 24 ++--
> fs/btrfs/check-integri
On 8/20/13 9:16 AM, Eric Sandeen wrote:
> On 8/20/13 6:20 AM, Geert Uytterhoeven wrote:
>> u64 is "unsigned long long" on all architectures now, so there's no need to
>> cast it when formatting it using the "ll" length modifier.
>>
>> Si
On 8/7/13 4:43 PM, Sergei Trofimovich wrote:
...
> Meet uselex.rb: one-file script to parse 'nm' output:
>
> https://github.com/trofi/uselex/blob/master/uselex.rb
Nice to meet you! I think I've met your close relative,
ftp://ftp.samba.org/pub/unpacked/junkcode/findstatic.pl :)
#!/usr/bin
On 7/22/13 5:24 PM, Jóhann B. Guðmundsson wrote:
> null null null no more Opts: (null) but something that actually makes sense to
> human beings...
It's not clear to me how this changes the (null) output...
Have you tested it? What's the difference in output?
-Eric
> Signed-off-by: Jóhann B. Gu
On 8/13/13 11:59 AM, Randy Dunlap wrote:
> On 08/13/13 01:28, Stephen Rothwell wrote:
>> Hi all,
>>
>> Changes since 20130812:
>>
>
> on i386:
>
> fs/built-in.o: In function `xfs_log_calc_minimum_size':
> (.text+0x1797a9): undefined reference to `__udivdi3'
>
>
See:
[PATCH] xfs: call roundup_
On 2/27/13 2:58 PM, Dmitry Monakhov wrote:
> On Wed, 27 Feb 2013 14:29:07 -0500, Theodore Ts'o wrote:
>> On Wed, Feb 27, 2013 at 02:19:23PM -0500, Dave Jones wrote:
>>>
>>> Looks like it's fixed here too.
>>>
>>> How did this make it through -next without anyone hitting it ?
>>>
>>> I can't rememb
On 5/12/13 4:01 AM, Dmitry Monakhov wrote:
> In fact '4eec70' are vexing because I have reviewed and tested this patch
> before
> it was marked as Review-by, but missed the bug. This is because xfstests
> was executed manually logs was full of warnings but tainted flag was not
> checked at the end
On 5/13/13 12:01 PM, Jan Kara wrote:
> On Mon 13-05-13 11:34:12, Eric Sandeen wrote:
>> On 5/12/13 4:01 AM, Dmitry Monakhov wrote:
>>> In fact '4eec70' are vexing because I have reviewed and tested this patch
>>> before
>>> it was marked as Review-by
On 5/14/13 2:11 AM, Dmitry Monakhov wrote:
> On Mon, 13 May 2013 12:09:22 -0500, Eric Sandeen wrote:
>> On 5/13/13 12:01 PM, Jan Kara wrote:
>>> On Mon 13-05-13 11:34:12, Eric Sandeen wrote:
>>>> On 5/12/13 4:01 AM, Dmitry Monakhov wrote:
>>>>> In fac
On 5/14/13 2:12 PM, Toralf Förster wrote:
> At a stable 32 bit stable Gentoo with kernel v3.10-rc1-113-ga2c7a54 I cannot
> umount an (EXT4) fs
> which was created in a file located in a tmpfs partition and loop mounted :
>
> That file system was used to hold victims files shared via NFSv4 to an
On 5/24/13 3:03 AM, Dave Chinner wrote:
> Right, patch below should fix the problem.
>
> What a frustrating bug. Now, where's my bottle of scotch?
In your pantry, Dave. Next to the others! ;)
-Eric
> Cheers,
>
> Dave.
>
--
To unsubscribe from this list: send the line "unsubscribe linux-ker
front of
the bison call in tools/perf/Makefile and running make -j4 on a
smaller box:
sleep 10; $(QUIET_BISON)$(BISON) -v util/pmu.y -d -o
$(OUTPUT)util/pmu-bison.c
Adding the following dependency fixes it for me:
Signed-off-by: Eric Sandeen
---
diff --git a/tools/perf/Makefile b/tools
On 9/20/12 7:24 PM, Namhyung Kim wrote:
> Hi Eric,
>
> On Thu, 20 Sep 2012 18:53:01 -0500, Eric Sandeen wrote:
>> Parallel builds of perf were failing for me on a 32p box, with:
>>
>> * new build flags or prefix
>> util/pmu.l:7:23: error: pmu-b
front of
the bison calls in tools/perf/Makefile and running make -j4 on a
smaller box i.e.:
sleep 10; $(QUIET_BISON)$(BISON) -v util/pmu.y -d -o
$(OUTPUT)util/pmu-bison.c
Adding the following dependencies fixes it for me.
Signed-off-by: Eric Sandeen
---
V2: Fix other bison dependency
On 8/10/12 11:14 PM, Justin Piszcz wrote:
> On Fri, Aug 10, 2012 at 7:07 PM, Justin Piszcz
>>
>> Hi,
>>
>> Found the root cause, the 3.5.1 kernel cannot mount my ext4 filesystem
>> (60TB).
You are a brave man running ext4 at 60T, but thank you for testing :)
Backing out 8aeb00ff85ad25453765dd339b
called only as do_mount() helpers;
none of them should be in any path that would see a performance
benefit from inlining...
Signed-off-by: Eric Sandeen <[EMAIL PROTECTED]>
---
Index: linux-2.6.24-mm1/fs/namespace.c
===
---
Andrew Morton wrote:
> Does the patch actually help? I mean, if a() calls b() and both use N
> bytes of locals, our worst-case stack usage remains ~2N whether or not b()
> was inlined in a()? In fact, uninlining makes things a little worse due to
> callframe stuff.
I think it does.
[linux-2.6.
Arjan van de Ven wrote:
> On Wed, 6 Feb 2008 14:34:57 -0800
> Andrew Morton <[EMAIL PROTECTED]> wrote:
>
>> Does the patch actually help? I mean, if a() calls b() and both use N
>> bytes of locals, our worst-case stack usage remains ~2N whether or
>> not b() was inlined in a()? In fact, uninlini
168, which is mostly the struct nameidata nd;
left on the stack.
These functions are called only as do_mount() helpers;
none of them should be in any path that would see a performance
benefit from inlining...
Signed-off-by: Eric Sandeen <[EMAIL PROTECTED]>
---
Index: linux-2.6.24-mm1/fs/na
Andrew Morton wrote:
> On Wed, 06 Feb 2008 17:11:38 -0600
> Eric Sandeen <[EMAIL PROTECTED]> wrote:
>
>> /*
>> * recursively change the type of the mountpoint.
>> + * noinline this do_mount helper to save do_mount stack space.
>> */
>> -static
Andrew Morton wrote:
> On Wed, 06 Feb 2008 17:11:38 -0600
> Eric Sandeen <[EMAIL PROTECTED]> wrote:
>
>> /*
>> * recursively change the type of the mountpoint.
>> + * noinline this do_mount helper to save do_mount stack space.
>> */
>> -static
Andi Kleen wrote:
> Andrew Morton <[EMAIL PROTECTED]> writes:
>>> */
>>> -static int do_change_type(struct nameidata *nd, int flag)
>>> +static noinline int do_change_type(struct nameidata *nd, int flag)
>> What we could do here is defined a new noinline_because_of_stack_suckiness
>> and use that
ad in [1] for more details.
>
> If you are on Linux-Next (next-20130118) you need the following three patches.
>
> Ilya Zykov (2):
> tty: Correct tty buffer flush.
> tty: Add driver unthrottle in ioctl(...,TCFLSH,..).
>
> Eric Sandeen (1):
> jbd2: don
On 1/22/13 5:50 PM, Jan Kara wrote:
> On Mon 21-01-13 18:11:30, Ted Tso wrote:
>> On Tue, Jan 22, 2013 at 12:04:32AM +0100, Sedat Dilek wrote:
>>>
>>> Beyond the FUSE/LOOP fun, will you apply this patch to your linux-next GIT
>>> tree?
>>>
>>> Feel free to add...
>>>
>>> Tested-by: Sedat Dile
On 1/23/13 3:44 AM, Jan Kara wrote:
> On Tue 22-01-13 19:37:46, Eric Sandeen wrote:
>> On 1/22/13 5:50 PM, Jan Kara wrote:
>>> On Mon 21-01-13 18:11:30, Ted Tso wrote:
>>>> On Tue, Jan 22, 2013 at 12:04:32AM +0100, Sedat Dilek wrote:
>>>>>
>>>
Include falloc.h in header-y; it defines a flag
for the fallocate sysctl.
Signed-off-by: Eric Sandeen <[EMAIL PROTECTED]>
---
--- linux.orig/include/linux/Kbuild
+++ linux/include/linux/Kbuild
@@ -61,6 +61,7 @@ header-y += efs_fs_sb.h
header-y += elf-fdpic.h
header-y += elf-em.h
he
Gaudenz Steinlin wrote:
> Hi
>
> Since upgrading to 2.6.25-rc1 I see filesystem corruption on my XFS
> filesystem. I can reproduce this by doing "git reset --hard v2.6.25-rc1"
> on a git checkout which is on some other revision. Git outputs strange
> error messages (like file xxx is a directory wh
Rafael J. Wysocki wrote:
> On Monday, 25 of February 2008, Eric Sandeen wrote:
>> If you're feeling motivated, maybe you can narrow it down to which of
>> the changes - xfs_highbit32, xfs_highbit64, xfs_lowbit32, or
>> xfs_lowbit64 - is causing the problem? (or maybe
Takashi Sato wrote:
> o Elevate XFS ioctl numbers (XFS_IOC_FREEZE and XFS_IOC_THAW) to the VFS
> As Andreas Dilger and Christoph Hellwig advised me, I have elevated
> them to include/linux/fs.h as below.
> #define FIFREEZE_IOWR('X', 119, int)
> #define FITHAW _IOWR('X',
Gaudenz Steinlin wrote:
> On Tue, Feb 26, 2008 at 01:13:56AM +0100, Rafael J. Wysocki wrote:
>> On Tuesday, 26 of February 2008, Christoph Hellwig wrote:
>>> On Tue, Feb 26, 2008 at 12:52:56AM +0100, Rafael J. Wysocki wrote:
> I'm not suggesting a partial revert; I just wonder which part of the
I'm wondering about the status of the "kaweth" Kawasaki LSI KL5KUSB100
USB to Ethernet Controller driver for 2.4. According to
http://www.hiru.aoba.yokohama.jp/%7eura/USB/usbether.html, this chipset
is used in the 3Com USB Network Adapter, Linksys USB10T, D-Link DSB-650,
SMC 2102USB, Netgear EA10
Michael Rothwell wrote:
> > It also doesn't seem to work in 2.2. :) The original development of
> > this driver was going on at http://drivers.rd.ilan.net/kaweth/ but there
> > have been no updates for quite some time.
>
> Well, it doesn't work you _you_ on 2.2, obviously. But it works for us
Ok, so the problem with the current driver is that it will attempt to
load the firmware even if firmware is already loaded. This will hang
the device.
The trick is to look at the device release number
(dev->descriptor.bcdDevice) - if no firmware is present, it returns
0x0002, if firmware is pres
This patch, against 2.4.1-ac4, does the following for the KLSI
USB->ethernet adapter:
(patch at http://lager.dyndns.org/kaweth/KLSI-2.4.1-ac4.patch.bz2)
o Fixes firmware downloading. If firmware is already loaded
and an attempt is made to download it again, the device
will hang. This will
Greg KH wrote:
> Silently changing descriptor ids while connected is just asking for
> trouble :)
Ok, fair enough - here's a patch against 2.4.1-ac6 which causes the
device to disconnect/reconnect after firmware load (and a couple other
minor kernel logging & formatting cleanups, plus one more d
Chris Wedgwood wrote:
On Wed, Aug 17, 2005 at 10:45:48PM +0200, Jesper Juhl wrote:
It seems slightly odd to me that XFS support should be in a separate
submenu, when all the other filesystems are not using submenus but
are directly selectable from the Filesystems menu.
XFS also has an out-o
Eric Sandeen wrote:
I have no problem with removing the submenu.
Hm, however, if this is a purely cosmetic thing, let's go all the way
and format the xfs options like the others, with indentation etc:
config XFS_RT
- bool "Realtime support (EXPERIMENTAL)"
+ bool
e
cipher on the cached key_tfm_list, and sets a pointer
to it if it exists. This can then be called from
ecryptfs_parse_options(), and new key_tfm's can be added only when
a cached one is not found.
With list locking changes suggested by akpm.
Signed-off-by: Eric Sandeen <[EMAIL PROTE
t indeterminate for
a given fs, but in any case the reported mount options can
be used in a new mount command to get the same behavior.
Signed-off-by: Eric Sandeen <[EMAIL PROTECTED]>
Acked-by: Michael Halcrow <[EMAIL PROTECTED]&
his, and it's happy with the following
change.
Signed-off-by: Eric Sandeen <[EMAIL PROTECTED]>
---
Index: linux/fs/ecryptfs/keystore.c
===
--- linux.orig/fs/ecryptfs/keystore.c
+++ linux/fs/ecryptfs/keystore.c
@@ -
Soeren Sonnenburg wrote:
> Dear all,
>
> I've just got this oops (causing the machine to hang finally)...
>
> Any ideas?
> Soeren
I've seen an awful lot of oopses out there on this path,
kswapd->shrink_icache_memory; some get a little further and oops in
ext3_discard_reservation.
A few were cha
Willy Tarreau wrote:
> Hi Dann,
>
> On Wed, Jan 23, 2008 at 11:12:12PM -0700, dann frazier wrote:
>> This is a 2.4 backport of a linux-2.6 change by Eric Sandeen
>> (commit be6aab0e9fa6d3c6d75aa1e38ac972d8b4ee82b8)
>>
>> CVE-2006-5753 was assigned for this issue.
dann frazier wrote:
> Thanks Eric. Sounds like my comment about exercising these code paths
> wasn't too clear - the comments with your patch do make the issue
> clear, and this program demonstrates the void cast promotion issue
> well. I'm just not sure of a good way to demonstrate that my backpo
lled from
ecryptfs_parse_options(), and new key_tfm's can be added only when
a cached one is not found.
Signed-off-by: Eric Sandeen <[EMAIL PROTECTED]>
---
Index: linux-2.6.24-rc3/fs/ecryptfs/crypto.c
===
--- linux-2.6
hen be called from
ecryptfs_parse_options(), and new key_tfm's can be added only when
a cached one is not found.
With list locking changes suggested by akpm.
Signed-off-by: Eric Sandeen <[EMAIL PROTECTED]>
---
Index: linux-2.
Andrew Morton wrote:
> On Sat, 22 Dec 2007 11:42:37 -0600 Eric Sandeen <[EMAIL PROTECTED]> wrote:
>
>> Andrew Morton wrote:
>>
>>> It would all look a lot more solid if this locking was retained and both
>>> ecryptfs_tfm_exists() and ecryptfs_add_new_key_
lled from
ecryptfs_parse_options(), and new key_tfm's can be added only when
a cached one is not found.
With list locking changes suggested by akpm.
Signed-off-by: Eric Sandeen <[EMAIL PROTECTED]>
---
Index: linux-2.6.24-rc3/fs/ec
Roman Zippel wrote:
> Hi,
>
> On Thursday 20 December 2007, Eric Sandeen wrote:
>
>> Index: linux-2.6.24-rc3/fs/hfs/brec.c
>> ===
>> --- linux-2.6.24-rc3.orig/fs/hfs/brec.c
>> +++ linux-2.6.24-r
WANG Cong wrote:
> TOPDIR is obsolete, use objtree instead.
> This patch removes TOPDIR from all fs/ Makefiles.
> diff --git a/fs/xfs/Makefile b/fs/xfs/Makefile
> index 49e3e7e..d1d3d49 100644
> --- a/fs/xfs/Makefile
> +++ b/fs/xfs/Makefile
> @@ -1 +1 @@
> -include $(TOPDIR)/fs/xfs/Makefile-linux-
Sam Ravnborg wrote:
> Hi Eric.
>
> Took a look at this now and fixed it like this.
> Let me know if you see other issues.
>
> [I know this is more than 6 months ago you reported it - sorry]
>
> Sam
Wow, blast from the past; if you'd done it a bit earlier it would have
been in the same ye
Roman, with this on top does it look better to you?
I'll get hfsplus done in a bit.
Thanks,
-Eric
-
Fix up previous hfs fsfuzzer patch to address Roman's comments.
Signed-off-by: Eric Sandeen <[EMAIL PROTECTED]>
---
diff -u linux-2.6.24-rc3/fs/hfs/brec.c lin
Adrian Bunk wrote:
> Most people and all distributions use CONFIG_EXPERIMENTAL=y simply
> because too many options (including options required for hardware
> support) depend on it.
>
> Compare e.g.:
> - "Marvell SATA support (HIGHLY EXPERIMENTAL)"
> - "Provide NFSv4 client support (EXPERIMENTAL)
Mingming Cao wrote:
> [PATCH] jbd2 stats through procfs
>
> The patch below updates the jbd stats patch to 2.6.20/jbd2.
> The initial patch was posted by Alex Tomas in December 2005
> (http://marc.info/?l=linux-ext4&m=113538565128617&w=2).
> It provides statistics via procfs such as transaction li
def __KERNEL__ around the
function seems to help, patch below.
BR, Tobias
Signed-off-by: Eric Sandeen <[EMAIL PROTECTED]>
---
Index: linux-2.6.24-rc1/include/linux/ext2_fs.h
===
--- linux-2.6.24-rc1.orig/include/linux/ext
Andrew Morton wrote:
> I did this instead:
(moved offending function from ext2_fs.h to ext2.h)
Look like a better plan, thanks.
-Eric
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kern
Address Roman's review comments for the previously sent on-disk
corruption hfs robustness patch.
I still owe a patch for hfsplus.
Signed-off-by: Eric Sandeen <[EMAIL PROTECTED]>
---
Index: linux-2.6.24-rc6-mm1/fs/
Adrian Bunk wrote:
> The Coverity checker spotted the following NULL dereference introduced
> by commit cf0594625083111ae522496dc1c256f7476939c2:
Oops. Thanks, Adrian.
Patch sent on a different thread, following another fixup patch for
Roman - you're cc'd.
Thanks,
-Eric
--
To unsubscribe from
Fix potential null deref introduced by commit
cf0594625083111ae522496dc1c256f7476939c2
http://bugzilla.kernel.org/show_bug.cgi?id=9748
Signed-off-by: Eric Sandeen <[EMAIL PROTECTED]>
---
Index: linux-2.6.24-rc6-mm1/fs/hfs/b
Andrew Morton wrote:
> On Mon, 14 Jan 2008 15:15:04 -0600
> Eric Sandeen <[EMAIL PROTECTED]> wrote:
>
>> Address Roman's review comments for the previously sent on-disk
>> corruption hfs robustness patch.
>>
>> I still owe a patch for hfsplus.
>>
Alan Cox wrote:
>> Writeback cache on disk in iteself is not bad, it only gets bad if the
>> disk is not engineered to save all its dirty cache on power loss,
>> using the disk motor as a generator or alternatively a small battery.
>> It would be awfully nice to know which brands fail here, if any,
eCryptfs wasn't setting s_blocksize in it's superblock; just pick
it up from the lower FS. Having an s_blocksize of 0 made things
like "filefrag" which call FIGETBSZ unhappy.
Signed-off-by: Eric Sandeen <[EMAIL PROTECTED]>
---
Index: linux-2.6
te, as it indicates filesystem
corruption.
Signed-off-by: Eric Sandeen <[EMAIL PROTECTED]
---
Index: linux-2.6.24-rc3/fs/ext3/namei.c
===
--- linux-2.6.24-rc3.orig/fs/ext3/namei.c
+++ linux-2.6.24-rc3/fs/ext3/namei.c
@@ -1049,6 +1049,9 @@
te, as it indicates filesystem
corruption.
Signed-off-by: Eric Sandeen <[EMAIL PROTECTED]
---
Index: linux-2.6.24-rc3/fs/ext4/namei.c
===
--- linux-2.6.24-rc3.orig/fs/ext4/namei.c
+++ linux-2.6.24-rc3/fs/ext4/namei.c
@@ -1050,6 +1050,9 @@
files in ext4_file_write().
This patch is currently living in the ext4 patch queue.
Signed-off-by: Eric Sandeen <[EMAIL PROTECTED]>
---
Index: linux-2.6.24-rc3/fs/read_write.c
===
--- linux-2.6.24-rc3.orig/fs/read_write.c
+++ linu
mmap ops disabled - mmap still needs work. (A version of this
patch on a RHEL5 kernel ran for over 110 million fsx ops)
I added a few comments as well, to the best of my understanding
as I read through the code.
Signed-off-by: Eric Sandeen <[EMAIL PROTECTED]>
---
Index: linux-2.6.24-rc3/
tes - pos);
}
to fix up too-large writes to these files in ext4_file_write().
This patch is currently living in the ext4 patch queue.
Signed-off-by: Eric Sandeen <[EMAIL PROTECTED]>
---
Index: linux-2.6.24-rc3/
Passing a cipher name > 32 chars on mount results in an overflow
when the cipher name is printed, because the last character
in the struct ecryptfs_key_tfm's cipher_name string was never
zeroed.
Signed-off-by: Eric Sandeen <[EMAIL PROTECTED]>
---
Index: linux-2.6.24-rc3/fs/ecr
1 - 100 of 348 matches
Mail list logo
