Arjan van de Ven wrote: > On Wed, 6 Feb 2008 14:34:57 -0800 > Andrew Morton <[EMAIL PROTECTED]> wrote: > >> Does the patch actually help? I mean, if a() calls b() and both use N >> bytes of locals, our worst-case stack usage remains ~2N whether or >> not b() was inlined in a()? In fact, uninlining makes things a >> little worse due to callframe stuff. > > it gets interesting at the three-way.. > if a() calls b() and then calls c(), and they all use N, > the total usage is now 3N not 2N.
*nod* It'd be nice if it could be max of (a,b,c) though. Or maybe compilers don't work that way. :) > (although current gcc is already somewhat smarter about this, and 3N might > actually be 2N for some cases) on x86, gcc 4.1.2, do_mount goes from 360 to 112 bytes w/ the patch I sent. with gcc 4.3, it goes from 364 to 104. -ERic -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
