Andi Kleen wrote: > Andrew Morton <[EMAIL PROTECTED]> writes: >>> */ >>> -static int do_change_type(struct nameidata *nd, int flag) >>> +static noinline int do_change_type(struct nameidata *nd, int flag) >> What we could do here is defined a new noinline_because_of_stack_suckiness >> and use that. Reasons: >> >> - self-documenting, so we don't need to comment each site >> >> - can be made a no-op for suitable __GNUC__ values if gcc ever fixes this > > In theory it should be already fixed; iirc Richard H. (cc'ed) added > code for this somewhere in 4.x. Don't quite remember which x, likely > either 1 or 2. > > e.g. if I do a quick test here on gcc 4.2 then it definitely > reuses stack slots between inlines. As you can see only ~100 bytes > are allocated, not ~200.
On gcc 4.1.2 and 4.3 (fedora flavors) I don't see it re-used in do_mount, though... *shrug* -Eric -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
