On Fri, Nov 23, 2012 at 12:48:26AM +0800, Chuansheng Liu wrote:
>
> By default, the watchdog threshold is 10, it means every 4s
> every CPU will receive one hrtimer interrupt, for low power
> device, it will cause 4-5mV power impact when device is deep
> sleep.
>
> So here want to optimize it as
On Mon, Nov 26, 2012 at 03:06:53PM -0800, Prasad Koya wrote:
> Hi
>
> Before going into crashkernel, nmi_shootdown_cpus() calls
> register_die_notifier(), which calls vmalloc_sync_all(). I'm seeing
> lockup in sync_global_pgds() (init_64.c). From 3.2 and up,
> register_die_notifier() is replaced w
On Tue, Nov 27, 2012 at 03:20:11PM -0800, Prasad Koya wrote:
> I'm definitely seeing above lockup with 2.6.38.8. In 3.2 and up kernel
> nmi_shootdown_cpus() replaced register_die_notifier() with
> register_nmi_handler() which doesn't call vmalloc_sync_all. If I patch
> my 2.6.38.8 so it behaves as
On Wed, Nov 28, 2012 at 07:24:52PM +0800, Chuansheng Liu wrote:
>
> By default, the watchdog threshold is 10, it means every 4s
> every CPU will receive one hrtimer interrupt, for low power
> device, it will cause 4-5mV power impact when device is deep
> sleep.
>
> So here want to optimize it as
On Fri, Feb 01, 2013 at 02:57:43PM -0800, Andy Lutomirski wrote:
> Current kernels print this on my Dell server:
>
>[ cut here ]
>WARNING: at drivers/iommu/intel_irq_remapping.c:542
>intel_enable_irq_remapping+0x7b/0x27e()
>Hardware name: PowerEdge R620
>
On Mon, Apr 01, 2013 at 03:47:42AM +, Pan, Zhenjie wrote:
> Watchdog use performance monitor of cpu clock cycle to generate NMI to detect
> hard lockup.
> But when cpu's frequency changes, the event period will also change.
> It's not as expected as the configuration.
> For example, set the NM
Hi Mike,
On Tue, Jan 29, 2013 at 05:42:43PM +0400, Mike Lykov wrote:
>
> So my questions:
>
> 1. Are there a BUG in soft lockup detection mechanizm? Changing
> watchdog_thresh to 30 have a side effect in production - D-state
> userspace processes will be detected slowly. Are there a need to
> de
On Wed, Jan 30, 2013 at 01:39:23PM +0400, Mike Lykov wrote:
> 29.01.2013 19:33, Don Zickus пишет:
>
> >The softlockup mechanism works scheduling a high priority task that kicks
> >the softlockups. If the unzip thread is taking too long, it could
> >acciden
On Tue, Jan 29, 2013 at 10:48:27PM +0530, anish kumar wrote:
> Sorry for digressing from the topic but I think there is something wrong
> with my understanding or something wrong with the code.So I guess Don
> can clarify this.
> If I pass this below parameter during boot i.e. setting watchdog_enab
On Thu, Jan 31, 2013 at 03:21:02PM +0400, Mike Lykov wrote:
>
> 30.01.2013 19:40, Don Zickus пишет:
> > I have never seen usage like 'kernel.watchdog_thresh=30'. Could you try
> > 'watchdog_thresh=30' instead?
>
> Ok. "kernel.watchdog_thresh=30&
x that had x2apic enabled. Everything looked as expected. I
couldn't figure out how to test a virtual guest setup to verify the WARN
works as expected.
Cc: Suresh Siddha
Cc: "H. Peter Anvin"
Cc: Prarit Bhargava
Signed-off-by: Don Zickus
---
drivers/iommu/intel_irq_remapping.c
On Thu, Jan 31, 2013 at 08:52:00PM +0200, Gleb Natapov wrote:
> > http://www.invisiblethingslab.com/resources/2011/Software%20Attacks%20on%20Intel%20VT-d.pdf
> >
> > After talking with folks, the threat of irq injections on virtual guests
> > made sense. However, when discussing if this was possi
> set_sample_period();
> + /*
> + * We shouldn't enable watchdog threads if it is not
^^^
the 'not' is not needed I believe. Other than that, if it helps
to understand the code better. I am fine wi
On Fri, Feb 01, 2013 at 02:44:43PM +0400, Mike Lykov wrote:
> 31.01.2013 18:46, Don Zickus пишет:
>
> >>>I also attached another patch as suggested by Andrew to add a
> >>>touch_softlockup_watchdog in the unlzma routine. Probably makes things
> >>>
> set_sample_period();
> + /*
> + * Watchdog threads shouldn't be enabled if they are
> + * disabled.'watchdog_disabled' variable check in
Missing a 'The' ^^^
Other than that,
Acked-by: Don Zickus
--
To unsubscribe from this list: send t
->enable watchdog
Unlike enable watchdog->enable watchdog which is wrong.
Signed-off-by: anish kumar
[small text cleanups]
Signed-off-by: Don Zickus
---
kernel/watchdog.c |5 +
1 files changed, 5 insertions(+), 0 deletions(-)
diff --git a/kernel/watchdog.c b/kernel/watchdog.c
On Wed, Jul 25, 2012 at 12:39:45PM +0800, Ming Lei wrote:
> Use raw_smp_processor_id in lockup_detector_bootcpu_resume()
> because it is enough when non-boot CPUs are offline.
>
> This patch fixes the following warning when DEBUG_PREEMPT
> is enabled.
Is this patched on top of linux-next?
It see
On Fri, Jul 27, 2012 at 08:38:21AM +0800, Ming Lei wrote:
> On Fri, Jul 27, 2012 at 3:43 AM, Don Zickus wrote:
> > On Wed, Jul 25, 2012 at 12:39:45PM +0800, Ming Lei wrote:
> >> Use raw_smp_processor_id in lockup_detector_bootcpu_resume()
> >> because it is enough whe
On Tue, Aug 27, 2013 at 12:41:51PM +0900, Yoshihiro YUNOMAE wrote:
> Hi Don,
>
> Sorry for the late reply.
>
> (2013/08/22 22:11), Don Zickus wrote:
> >On Thu, Aug 22, 2013 at 05:38:07PM +0900, Yoshihiro YUNOMAE wrote:
> >>>So, I agree with Eric, let's remov
On Mon, Oct 07, 2013 at 10:05:16PM -0300, Marcelo Tosatti wrote:
> In certain occasions it is possible for a hung task detector
> positive to be false: continuation from a paused VM, for example.
>
> Add a method to reset detection, similar as is done
> with other kernel watchdogs.
This makes sen
>
> Suggested by Don Zickus.
>
> Signed-off-by: Marcelo Tosatti
Awesome. Thanks for figuring this out Marcelo. Does that mean we can
revert commit 5d1c0f4a now? :-)
This meets my expectations. I'll leave it to the virt folks to figure out
if this covers all the c
On Tue, Oct 08, 2013 at 07:08:11PM -0300, Marcelo Tosatti wrote:
> On Tue, Oct 08, 2013 at 09:37:05AM -0400, Don Zickus wrote:
> > On Mon, Oct 07, 2013 at 10:05:17PM -0300, Marcelo Tosatti wrote:
> > > Implement reset of kernel watchdogs at pvclock read time. This avoids
> &g
e sub-options should depend on the main option rather than a more
> generic higher level one.
Looks good to me.
Acked-by: Don Zickus
>
> Signed-off-by: Jan Beulich
> Cc: Don Zickus
> Cc: Peter Zijlstra
>
> ---
> lib/Kconfig.debug |9 +
> 1 file chan
the sample period as a variable, and set it as
> __read_mostly type.
Seems safe and also helps the case of changing the value while running.
Now one has to disable/re-enable the watchdog to utilize the new value.
Acked-by: Don Zickus
>
> Signed-off-by: liu chuansheng
> -
On Fri, Dec 07, 2012 at 09:41:13PM +, Seiji Aguchi wrote:
> [Issue]
>
> If one cpu ,which is taking a psinfo->buf_lock,
> receive NMI from a panicked cpu via smp_send_stop(),
> the panicked cpu hangs up in pstore_dump() called by
> kmsg_dump(KMSG_DUMP_PANIC)
> because the psinfo->buf_lock is
On Fri, Dec 07, 2012 at 11:43:03PM +, Seiji Aguchi wrote:
> > Can all these things really happen (did you run into this problem on a real
> > system?). Or is this just a theoretical problem. Ugly (but
> > practical) hacks might be OK to solve real problems.
>
> It is a theoretical problem r
On Tue, Dec 11, 2012 at 01:42:56PM -0500, Dave Jones wrote:
> Looks like we're doing a double-init on a timer.
>
> I had been experimenting with powertop, so that may have triggered something
> maybe suspend/resume related ?
Is this coming out of a resume then?
I am not familiar with ODEBUG, so
27;t think of why it wasn't implemented this way to
begin with.
Acked-by: Don Zickus
>
> Cc: Don Zickus
> Cc: Ingo Molnar
> Cc: Thomas Gleixner
> Signed-off-by: Namhyung Kim
> ---
> kernel/watchdog.c | 10 --
> 1 file changed, 4 insertions(+), 6 d
On Mon, Dec 17, 2012 at 08:56:27PM +, Seiji Aguchi wrote:
> Changelog v1 -> v2
> - Erase a logic checking the number of online cpus.
> - Create a patchset to fix deadlocking issue in both pstore filesystem and
>efi_pstore driver.
>- Introduce a function, is_non_blocking_path(), to che
On Wed, Dec 19, 2012 at 08:51:31PM +0100, Bjørn Mork wrote:
> commit 8d451690 ("watchdog: Fix CPU hotplug regression") cause
> an oops or hard lockup when doing
>
> echo 0 > /proc/sys/kernel/nmi_watchdog
> echo 1 > /proc/sys/kernel/nmi_watchdog
>
> and the kernel is booted with nmi_watchdog=1 (
ocked in non-blocking paths
> such as nmi, panic and emergency-restart paths (PATCH 2/2)
>
> [Issue]
>
> There are some paths in kernel which shouldn't be blocked,
> like NMI, panic case after stopping cpus, emergency-restart.
I am ok with it.
Acked-by: Don Zickus
-
On Wed, Dec 19, 2012 at 10:44:44PM +0100, Bjørn Mork wrote:
> Bjørn Mork writes:
> > Don Zickus writes:
> >
> >> What about the opposite cases?
> >> nmi_watchdog=1
> >> echo 1 > /sys/devices/system/cpu/cpu1/online
> >
> > I don't s
dded trylock in watchdog_ping and used that function for kicking.
renamed export function to be more generic.
v3: small cleanups, remove mutex_safe variable from EXPORT_SYMBOL
Signed-off-by: Don Zickus
---
drivers/watchdog/watchdog_dev.c | 74 +++---
include/l
On Wed, Apr 17, 2013 at 02:49:59PM -0700, Eric W. Biederman wrote:
> Don Zickus writes:
>
> > A common problem with kdump is that during the boot up of the
> > second kernel, the hardware watchdog times out and reboots the
> > machine before a vmcore can be captured.
>
On Thu, Apr 18, 2013 at 02:04:00PM +0200, Stephane Eranian wrote:
> On Thu, Apr 18, 2013 at 1:42 PM, Peter Zijlstra
> wrote:
> > On Tue, 2013-04-16 at 06:57 +, Pan, Zhenjie wrote:
> >> Watchdog use performance monitor of cpu clock cycle to generate NMI to
> >> detect hard lockup.
> >> But wh
On Thu, Apr 18, 2013 at 06:49:04AM -0700, Guenter Roeck wrote:
> On Thu, Apr 18, 2013 at 09:00:09AM -0400, Don Zickus wrote:
> > On Wed, Apr 17, 2013 at 02:49:59PM -0700, Eric W. Biederman wrote:
> > > Don Zickus writes:
> > >
> > > > A common problem with
On Thu, Apr 18, 2013 at 09:35:05AM -0700, Eric W. Biederman wrote:
> Don Zickus writes:
>
> > A common problem with kdump is that during the boot up of the
> > second kernel, the hardware watchdog times out and reboots the
> > machine before a vmcore can be captured.
>
On Mon, Apr 22, 2013 at 12:50:34AM +, Pan, Zhenjie wrote:
> > I believe it mattered to the Chrome folks. They want the watchdog to be as
> > tight as possible so the user experience isn't a hang but a quick reboot
> > instead. They like setting the watchdog to something like 2 seconds.
> >
>
; Signed-off-by: Frederic Weisbecker
> Cc: Steven Rostedt
> Cc: Paul E. McKenney
> Cc: Ingo Molnar
> Cc: Andrew Morton
> Cc: Thomas Gleixner
> Cc: Peter Zijlstra
> Cc: Li Zhong
> Cc: Don Zickus
> Cc: Srivatsa S. Bhat
> Cc: Anish Singh
> ---
> kernel/wa
On Thu, Jun 13, 2013 at 04:22:12PM +0200, Frederic Weisbecker wrote:
> On Thu, Jun 13, 2013 at 10:02:07AM -0400, Don Zickus wrote:
> > On Thu, Jun 13, 2013 at 03:10:59PM +0200, Frederic Weisbecker wrote:
> > > On Wed, Jun 12, 2013 at 01:03:16PM -0400, Don Zickus wrote:
> >
On Thu, Jun 13, 2013 at 04:56:03PM +0200, Frederic Weisbecker wrote:
> > > > Peter,
> > > >
> > > > Where is this patch?
> > >
> > > Which patch? The old version of the current one? It was part of a
> > > previous series
> > > that needed improvements so it hasn't been applied yet.
> >
> > I gu
On Thu, Jun 13, 2013 at 03:10:59PM +0200, Frederic Weisbecker wrote:
> On Wed, Jun 12, 2013 at 01:03:16PM -0400, Don Zickus wrote:
> > On Wed, Jun 12, 2013 at 04:02:36PM +0200, Frederic Weisbecker wrote:
> > > When the watchdog runs, it prevents the full dynticks
> > &g
On Thu, Jun 13, 2013 at 11:48:11AM -0400, Steven Rostedt wrote:
> On Thu, 2013-06-13 at 11:20 -0400, Don Zickus wrote:
>
> > I don't know enough about how full dynticks work to even present a
> > solution. But currently I was working with the Red Hat performance team
>
On Wed, May 29, 2013 at 12:38:28PM -0700, Sarah Sharp wrote:
> On Tue, May 28, 2013 at 02:41:18PM -0700, Julius Werner wrote:
> > The policy we want to achieve is to disable runtime PM iff there is a
> > device connected that doesn't have persist_enabled or a reset_resume()
> > handler and whose pa
On Fri, Jun 28, 2013 at 05:37:39PM -0300, Marcelo Tosatti wrote:
> On Fri, Jun 28, 2013 at 10:12:15AM -0400, Don Zickus wrote:
> > On Thu, Jun 27, 2013 at 11:57:23PM -0300, Marcelo Tosatti wrote:
> > >
> > > One possibility for a softlockup report in a Linux VM, is th
On Thu, Jun 27, 2013 at 11:57:23PM -0300, Marcelo Tosatti wrote:
>
> One possibility for a softlockup report in a Linux VM, is that the host
> system is overcommitted to the point where the watchdog task is unable
> to make progress (unable to touch the watchdog).
I think I am confused on the VM/
On Tue, Aug 20, 2013 at 03:12:32AM -0700, Eric W. Biederman wrote:
> Yoshihiro YUNOMAE writes:
>
> > Hi Ingo,
> >
> > Thank you for fixing typos!
> > OK, I'll fix them and rename to ioapic_zap_locks().
> >
> > Thank you again!
>
>
> The better fix for this would be to remove the disable_IO_APIC
On Wed, Aug 21, 2013 at 06:42:17PM +0200, Frederic Weisbecker wrote:
> hw_nmi_get_sample_period() is simply a conversion from a period
> to cycles. Lets generalize the API naming so that it can be used for
> wider purpose than just watchdog perf event settings. Also it makes the
> function name les
On Thu, Aug 22, 2013 at 05:38:07PM +0900, Yoshihiro YUNOMAE wrote:
> >So, I agree with Eric, let's remove the disable_IO_APIC() stuff and keep
> >the code simpler.
>
> Thank you for commenting about my patch.
> I didn't know you already have submitted the patches for this deadlock
> problem.
>
>
On Fri, Jul 19, 2013 at 11:04:59AM +0200, Michal Hocko wrote:
> watchdog_tresh controls how often nmi perf event counter checks per-cpu
> hrtimer_interrupts counter and blows up if the counter hasn't changed
> since the last check. The counter is updated by per-cpu watchdog_hrtimer
> hrtimer which
On Fri, Jul 19, 2013 at 11:04:58AM +0200, Michal Hocko wrote:
> proc_dowatchdog doesn't synchronize multiple callers which
> might lead to confusion when two parallel callers might confuse
> watchdog_enable_all_cpus resp. watchdog_disable_all_cpus (e.g. watchdog
> gets enabled even if watchdog_thre
On Fri, Jul 19, 2013 at 06:37:50PM +0200, Michal Hocko wrote:
> On Fri 19-07-13 12:08:52, Don Zickus wrote:
> > On Fri, Jul 19, 2013 at 11:04:59AM +0200, Michal Hocko wrote:
> > > watchdog_tresh controls how often nmi perf event counter checks per-cpu
> > > hrtimer_inte
sing a sample period? The idea is it could follow the varying cpu
frequencies better (and probably simplify some of the code too).
Acked-by: Don Zickus
>
> Signed-off-by: Frederic Weisbecker
> Cc: Jiri Olsa
> Cc: Peter Zijlstra
> Cc: Namhyung Kim
> Cc: Ingo Molnar
>
the lockup detector. This makes it a little too heavy
for a restart routine like this.
The only odd thing is I can't figure out which version you were using to
apply this patch. I can't find old_thresh (though I understand the idea
of it).
Cheers,
Don
>
> The hrtimer is simply res
On Fri, Jul 19, 2013 at 06:33:23PM +0200, Michal Hocko wrote:
> On Fri 19-07-13 12:10:48, Don Zickus wrote:
> > On Fri, Jul 19, 2013 at 11:04:58AM +0200, Michal Hocko wrote:
> > > proc_dowatchdog doesn't synchronize multiple callers which
> > > might lead to con
On Tue, Jul 23, 2013 at 04:07:29PM +0200, Michal Hocko wrote:
> On Tue 23-07-13 09:53:34, Don Zickus wrote:
> > On Mon, Jul 22, 2013 at 04:32:46PM +0200, Michal Hocko wrote:
> > > The nmi one is disabled and then reinitialized from scratch. This
> > > has an unpl
s enabled even if watchdog_thresh was set to 0 already).
>
> This patch adds a local mutex which synchronizes callers to the sysctl
> handler.
>
> Signed-off-by: Michal Hocko
Acked-by: Don Zickus
> ---
> kernel/watchdog.c | 7 +--
> 1 file changed, 5 insertions(+), 2 deletions
On Wed, May 15, 2013 at 10:37:29AM +0200, Peter Zijlstra wrote:
> On Tue, May 14, 2013 at 06:02:51PM +0200, Frederic Weisbecker wrote:
> > From: Steven Rostedt
> >
> > Trying to test the nohz_full code, I was not able to get it to work.
> > Finally I enabled the tick_stop tracepoint and it showed
On Wed, May 15, 2013 at 11:27:02AM -0400, Steven Rostedt wrote:
> > Coming into the middle of the thread is always hard, but why/how does perf
> > disable nohz_full? I didn't think the hardware events of perf would cause
> > problems as they are no different than an irq. Curious.
>
> Right now p
On Wed, May 15, 2013 at 07:11:53PM +0200, Peter Zijlstra wrote:
> On Wed, May 15, 2013 at 06:59:15PM +0200, Peter Zijlstra wrote:
> > On Wed, May 15, 2013 at 11:27:02AM -0400, Steven Rostedt wrote:
> > > Right now perf requires a tick, not sure exactly why, but you can look
> > > at the code in per
On Mon, Apr 08, 2013 at 01:46:58PM +0800, Dave Young wrote:
> On 04/06/2013 04:16 AM, Don Zickus wrote:
> > A common problem with kdump is that during the boot up of the
> > second kernel, the hardware watchdog times out and reboots the
> > machine before a vmcore can be captu
On Mon, Apr 08, 2013 at 08:15:09AM -0700, Guenter Roeck wrote:
> On Mon, Apr 08, 2013 at 08:48:58AM -0400, Don Zickus wrote:
> > On Mon, Apr 08, 2013 at 01:46:58PM +0800, Dave Young wrote:
> > > On 04/06/2013 04:16 AM, Don Zickus wrote:
> > > > A common problem with
On Tue, Apr 09, 2013 at 07:52:28AM -0700, Guenter Roeck wrote:
> On Tue, Apr 09, 2013 at 10:44:31AM -0400, Don Zickus wrote:
> > On Mon, Apr 08, 2013 at 08:15:09AM -0700, Guenter Roeck wrote:
> > > On Mon, Apr 08, 2013 at 08:48:58AM -0400, Don Zickus wrote:
> > > >
On Tue, Apr 09, 2013 at 09:07:58AM -0700, Guenter Roeck wrote:
> > > Just look for the use of mod_timer in the watchdog directory.
> >
> > So looking at the mod_timer logic in various drivers, it seems regardless
> > if the /dev/watchdog device is opened or not, if it is running, it will
> > autom
On Wed, Apr 10, 2013 at 06:51:23AM -0700, Guenter Roeck wrote:
> On Wed, Apr 10, 2013 at 09:40:39AM -0400, Don Zickus wrote:
> > On Tue, Apr 09, 2013 at 09:07:58AM -0700, Guenter Roeck wrote:
> > > > > Just look for the use of mod_timer in the watchdog directory.
> >
On Wed, Apr 10, 2013 at 08:10:41AM -0700, Guenter Roeck wrote:
> On Wed, Apr 10, 2013 at 10:20:55AM -0400, Don Zickus wrote:
> > On Wed, Apr 10, 2013 at 06:51:23AM -0700, Guenter Roeck wrote:
> > > On Wed, Apr 10, 2013 at 09:40:39AM -0400, Don Zickus wrote:
> > > >
On Mon, Apr 22, 2013 at 10:37:36PM +0200, Peter Zijlstra wrote:
> On Mon, 2013-04-22 at 00:50 +, Pan, Zhenjie wrote:
> > This make watchdog reset happen before hard lockup detect.
>
> Doesn't your watchdog trigger an NMI you can use to print the panic?
>
> ISTR some people (hi Don!) spending
On Thu, Apr 18, 2013 at 07:54:13AM -0700, Guenter Roeck wrote:
> > No, that will probably work. It is my misunderstanding. Is there a
> > common way to check the timeout length and the ping frequency?
> >
> Usually it is configured in /etc/watchdog.conf if the watchdog package
> is installed. Th
On Wed, Apr 10, 2013 at 08:10:41AM -0700, Guenter Roeck wrote:
> > have no idea how to even find out if multiple watchdogs are open on the
> > system. Is there a list I could walk? And with regard to 'watchdog is
>
> /* the dev_t structure to store the dynamically allocated watchdog devices */
>
On Fri, Apr 12, 2013 at 02:30:24PM -0700, Guenter Roeck wrote:
> On Fri, Apr 12, 2013 at 05:16:27PM -0400, Don Zickus wrote:
> > On Wed, Apr 10, 2013 at 08:10:41AM -0700, Guenter Roeck wrote:
> > > > have no idea how to even find out if multiple watchdogs are open on the
>
can do but reboot.
>
> Signed-off-by: Li Zefan
Acked-by: Don Zickus
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
On Fri, May 17, 2013 at 10:31:20AM +0800, Li Zefan wrote:
>
> Signed-off-by: Li Zefan
Acked-by: Don Zickus
> ---
> Documentation/sysctl/kernel.txt | 14 ++
> 1 file changed, 14 insertions(+)
>
> diff --git a/Documentation/sysctl/kernel.txt b/Documentat
On Fri, May 17, 2013 at 10:31:35AM +0800, Li Zefan wrote:
> The old softlockup detector has been replaced with new lockup
> detector long ago.
>
> Signed-off-by: Li Zefan
Acked-by: Don Zickus
> ---
> Documentation/sysctl/kernel.txt | 10 --
> 1 file changed, 10 d
: Andrew Morton
> Cc: Thomas Gleixner
> Cc: Peter Zijlstra
> Cc: Li Zhong
> Cc: Don Zickus
> ---
> kernel/watchdog.c |6 ++
> 1 files changed, 6 insertions(+), 0 deletions(-)
>
> diff --git a/kernel/watchdog.c b/kernel/watchdog.c
> index 05039e3..7e1
s a pure internal state.
Heh. Thanks for the cleanup.
Acked-by: Don Zickus
>
> Signed-off-by: Frederic Weisbecker
> Cc: Ingo Molnar
> Cc: Don Zickus
> Cc: Peter Zijlstra
> ---
> include/linux/nmi.h |2 +-
> kernel/sysctl.c |4 ++--
> kernel/watchd
se the subsystem spuriously thinks it's
> already running.
>
> Initialize it properly on boot.
Looks fine to me. Can't think of a case where this breaks something.
Acked-by: Don Zickus
>
> Signed-off-by: Frederic Weisbecker
> Cc: Don Zickus
> Cc: Ingo Molna
On Wed, Mar 06, 2013 at 05:17:04PM +0530, anish singh wrote:
> On Tue, Feb 19, 2013 at 2:18 AM, Don Zickus wrote:
> > On Sat, Feb 16, 2013 at 05:44:09PM +0530, anish kumar wrote:
> >> From: anish kumar
> >>
> >> This watchdog_disabled flag is bit of
On Tue, Aug 21, 2012 at 09:49:21AM +0200, Ingo Molnar wrote:
> > A lot of the overhead on the larger builds is also some
> > specific gcc code that I'm working with the gcc developers on
> > to improve. So the 4x extreme case will hopefully go down.
> >
> > The large builds also currently suffer
On Wed, Feb 13, 2013 at 03:28:00PM +0530, anish singh wrote:
> On Wed, Feb 13, 2013 at 2:51 PM, Ingo Molnar wrote:
> >
> > * anish singh wrote:
> >
> >> Is the below patch picked up?
> >>
> >> On Sun, Feb 3, 2013 at 9:31 PM, anish kumar
> >> wrote:
> >> > From: anish kumar
> >> >
> >> > This w
hdog_thresh is 20,
> the sample value will be: 0x1 DCD6 5000
>
> >From case2, we need use u64 to express the sample period.
> Otherwise, Changing the threshold thru proc often can
> not be successful.
I guess I should have tested 32-bit more. :-) Good catch.
Acked-by: Don Z
On Thu, Jan 10, 2013 at 09:27:28AM -0800, Colin Cross wrote:
> On Thu, Jan 10, 2013 at 6:02 AM, Don Zickus wrote:
> > On Wed, Jan 09, 2013 at 05:57:39PM -0800, Colin Cross wrote:
> >> Emulate NMIs on systems where they are not available by using timer
> >> interrupts on
On Wed, Jan 09, 2013 at 05:57:39PM -0800, Colin Cross wrote:
> Emulate NMIs on systems where they are not available by using timer
> interrupts on other cpus. Each cpu will use its softlockup hrtimer
> to check that the next cpu is processing hrtimer interrupts by
> verifying that a counter is inc
nmi
watchdog isn't working correctly.
No technical changes have been made. Compiler tested.
Signed-off-by: Don Zickus <[EMAIL PROTECTED]>
---
arch/x86/kernel/nmi_32.c |2 +-
arch/x86/kernel/nmi_64.c |2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/x86/k
On Wed, Nov 21, 2007 at 10:34:59AM -0800, Arjan van de Ven wrote:
> On Wed, 21 Nov 2007 12:14:20 -0500
> Don Zickus <[EMAIL PROTECTED]> wrote:
>
> > Our automated test suite looks for keywords like error, fail, warning
> > in the boot log. In the case when the nm
Our automated test suite looks for keywords like error, fail, warning in the
boot log. In the case when the nmi watchdog is determined to be stuck in
check_nmi_watchdog(), none of those keywords are displayed.
This patch adds a keyword, 'Warning, so it makes it easier to notice when the
nmi
watc
On Wed, Jul 18, 2007 at 11:07:40PM +0900, Ken'ichi Ohmichi wrote:
> The content of mkdfinfo file has been increasing whenever adding
> features and correcting bugs. The content is increasing even now.
> And, the feature addition is done not only for new kernels but also
> for old upstream kernels.
On Thu, Jul 19, 2007 at 06:49:53PM +0200, Bernhard Walle wrote:
> * Don Zickus <[EMAIL PROTECTED]> [2007-07-19 18:39]:
> >
> > I am not a big fan of this approach as it forces distros to require
> > kexec-tools when building a kernel. Even Joe Hacker who wants a
Trivial change to pass vmsplice arguments through the compat layer on
pp64.
Signed-off-by: Don Zickus <[EMAIL PROTECTED]>
diff --git a/include/asm-powerpc/systbl.h b/include/asm-powerpc/systbl.h
index 8d853c5..0b00068 100644
--- a/include/asm-powerpc/systbl.h
+++ b/include/asm-powerpc/sy
taskstats.h is missing from the kernel headers package. It was designed
to be used from userland, so it should be safe.
Signed-off-by: Don Zickus <[EMAIL PROTECTED]>
diff --git a/include/linux/Kbuild b/include/linux/Kbuild
index 4ff0f57..b5f9a62 100644
--- a/include/linux/Kbuild
+++ b/i
On Wed, Sep 21, 2016 at 11:18:29AM +0200, Jiri Olsa wrote:
> On Wed, Sep 21, 2016 at 09:08:40AM +, Stanislav Ievlev wrote:
> > Hi, Jiri!
> >
> > Why are you not using unsigned integer for counters in c2c_stats structure?
>
> hi,
> never really thought of that, because that's one of the origin
On Tue, Jun 20, 2017 at 02:33:09PM -0700, kan.li...@intel.com wrote:
> From: Kan Liang
>
> Some users reported spurious NMI watchdog timeouts.
>
> We now have more and more systems where the Turbo range is wide enough
> that the NMI watchdog expires faster than the soft watchdog timer that
> upd
n]
>
> This adds another #ifdef around it.
Thanks!
Acked-by: Don Zickus
>
> Fixes: mmotm ("kernel/watchdog: provide watchdog_nmi_reconfigure() for arch
> watchdogs")
> Signed-off-by: Arnd Bergmann
> ---
> kernel/watchdog.c | 4
> 1 file changed
On Wed, Jun 21, 2017 at 12:40:28PM +, Liang, Kan wrote:
>
> > >
> > > The right fix for mainline can be found here.
> > > perf/x86/intel: enable CPU ref_cycles for GP counter perf/x86/intel,
> > > watchdog: Switch NMI watchdog to ref cycles on x86
> > > https://patchwork.kernel.org/patch/97790
On Fri, May 26, 2017 at 10:31:03AM +1000, Nicholas Piggin wrote:
> On Thu, 25 May 2017 09:55:59 -0400
> Don Zickus wrote:
>
> > On Thu, May 25, 2017 at 06:28:54PM +1000, Nicholas Piggin wrote:
> > > For architectures that define HAVE_NMI_WATCHDOG, instead of havin
On Fri, May 26, 2017 at 10:39:09AM +1000, Nicholas Piggin wrote:
> On Thu, 25 May 2017 10:08:33 -0400
> Don Zickus wrote:
>
> > On Thu, May 25, 2017 at 06:28:56PM +1000, Nicholas Piggin wrote:
> > > After reconfiguring watchdog sysctls etc., architecture specific
> &g
On Mon, Oct 30, 2017 at 03:45:12PM -0700, Guenter Roeck wrote:
> Hi Thomas,
>
> we are seeing the following crash in v4.14-rc5/rc7 if
> CONFIG_HARDLOCKUP_DETECTOR
> is enabled.
>
> [5.908021] NMI watchdog: Enabled. Permanently consumes one hw-PMU counter.
> [5.915836]
> =
On Tue, Oct 31, 2017 at 10:16:22AM -0700, Guenter Roeck wrote:
> On Tue, Oct 31, 2017 at 02:48:50PM +0100, Peter Zijlstra wrote:
> > On Mon, Oct 30, 2017 at 03:45:12PM -0700, Guenter Roeck wrote:
> > > I added some logging and a long msleep() in
> > > hardlockup_detector_perf_cleanup().
> > > Here
> > Is Chrome OS, changing the default timeout from 10s to something else?
> > That would explain it as a script is executed late in the boot cycle and
> > explain the quick restart.
> >
>
> Correct, Chrome OS changes the timeout from 10 to 5 seconds.
>
> A little experiment suggests that the pr
On Tue, Oct 31, 2017 at 03:11:07PM -0700, Guenter Roeck wrote:
> On Tue, Oct 31, 2017 at 10:32:00PM +0100, Thomas Gleixner wrote:
>
> [ ...]
>
> > So we have to revert
> >
> > a33d44843d45 ("watchdog/hardlockup/perf: Simplify deferred event destroy")
> >
> > Patch attached.
> >
>
> Tested-by
ack dumps"). But this flags is removed in
> commit 9c48f1c629ecfa114850c03f875c6691003214de ("x86, nmi: Wire up NMI
> handlers to new routines").
Sounds right.
Acked-by: Don Zickus
>
> Since it isn't used any more, remove it.
>
> Signed-off-by: Minfei
1 - 100 of 659 matches
Mail list logo
