On Wed, Mar 06, 2013 at 05:17:04PM +0530, anish singh wrote: > On Tue, Feb 19, 2013 at 2:18 AM, Don Zickus <dzic...@redhat.com> wrote: > > On Sat, Feb 16, 2013 at 05:44:09PM +0530, anish kumar wrote: > >> From: anish kumar <anish198519851...@gmail.com> > >> > >> This watchdog_disabled flag is bit of cryptic.Howerver it's usefullnes is > >> multifold. > >> Uses are: > >> 1. Check if smpboot_register_percpu_thread function passed. > >> 2. Makes sure that user enables and disables the watchdog in sequence > >> i.e. enable watchdog->disable watchdog->enable watchdog > >> Unlike enable watchdog->enable watchdog which is wrong. > >> > >> Signed-off-by: anish kumar <anish198519851...@gmail.com> > >> --- > >> kernel/watchdog.c | 5 +++++ > >> 1 files changed, 5 insertions(+), 0 deletions(-) > >> > >> diff --git a/kernel/watchdog.c b/kernel/watchdog.c > >> index 75a2ab3..8a20ebe 100644 > >> --- a/kernel/watchdog.c > >> +++ b/kernel/watchdog.c > >> @@ -518,6 +518,11 @@ int proc_dowatchdog(struct ctl_table *table, int > >> write, > >> return ret; > >> > >> set_sample_period(); > >> + /* > >> + * Watchdog threads shouldn't be enabled if they are > >> + * disabled.'watchdog_disabled' variable check in > > > > Missing a 'The' ^^^ > > > > Other than that, > > > > Acked-by: Don Zickus <dzic...@redhat.com> > Is this patch picked up?
Andrew, Do you want me to respin the patch with that change? Or how should I move this patch forward? Cheers, Don -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
