On Mon, Sep 10, 2012 at 12:54:07PM +0100, Jan Beulich wrote: > The main option should not appear in the resulting .config when the > dependencies aren't met (i.e. use "depends on" rather than directly > setting the default from the combined dependency values). > > The sub-options should depend on the main option rather than a more > generic higher level one.
Looks good to me. Acked-by: Don Zickus <dzic...@redhat.com> > > Signed-off-by: Jan Beulich <jbeul...@suse.com> > Cc: Don Zickus <dzic...@redhat.com> > Cc: Peter Zijlstra <a.p.zijls...@chello.nl> > > --- > lib/Kconfig.debug | 9 +++++---- > 1 file changed, 5 insertions(+), 4 deletions(-) > > --- 3.6-rc5/lib/Kconfig.debug > +++ 3.6-rc5-kconfig-cleanup-hardlockup/lib/Kconfig.debug > @@ -196,12 +196,13 @@ config LOCKUP_DETECTOR > thresholds can be controlled through the sysctl watchdog_thresh. > > config HARDLOCKUP_DETECTOR > - def_bool LOCKUP_DETECTOR && PERF_EVENTS && HAVE_PERF_EVENTS_NMI && \ > - !HAVE_NMI_WATCHDOG > + def_bool y > + depends on LOCKUP_DETECTOR && !HAVE_NMI_WATCHDOG > + depends on PERF_EVENTS && HAVE_PERF_EVENTS_NMI > > config BOOTPARAM_HARDLOCKUP_PANIC > bool "Panic (Reboot) On Hard Lockups" > - depends on LOCKUP_DETECTOR > + depends on HARDLOCKUP_DETECTOR > help > Say Y here to enable the kernel to panic on "hard lockups", > which are bugs that cause the kernel to loop in kernel > @@ -212,7 +213,7 @@ config BOOTPARAM_HARDLOCKUP_PANIC > > config BOOTPARAM_HARDLOCKUP_PANIC_VALUE > int > - depends on LOCKUP_DETECTOR > + depends on HARDLOCKUP_DETECTOR > range 0 1 > default 0 if !BOOTPARAM_HARDLOCKUP_PANIC > default 1 if BOOTPARAM_HARDLOCKUP_PANIC > > > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
