Re: [PATCH v3 4/6] bus: ti-sysc: Add support for software reset

2018-07-04 Thread Faiz Abbas
Hi, On Thursday 05 July 2018 11:25 AM, Tony Lindgren wrote: > * Faiz Abbas [180704 13:37]: >> After taking a second look at this thread, I don't see anything big to >> be modified. >> >> We both agree that "reset status bit in sysconfig register" is the quirk >> case which can be added once such

Re: [PATCH v3 4/6] bus: ti-sysc: Add support for software reset

2018-07-04 Thread Tony Lindgren
* Faiz Abbas [180704 13:37]: > After taking a second look at this thread, I don't see anything big to > be modified. > > We both agree that "reset status bit in sysconfig register" is the quirk > case which can be added once such an IP is discovered in ti-sysc. Yes agreed. > All I need to chang

Re: [PATCH v3 4/6] bus: ti-sysc: Add support for software reset

2018-07-04 Thread Faiz Abbas
Hi, On Tuesday 03 July 2018 01:01 PM, Tony Lindgren wrote: > * Faiz Abbas [180703 07:31]: >> Hi, >> >> On Tuesday 03 July 2018 12:37 PM, Tony Lindgren wrote: >>> * Tony Lindgren [180611 07:06]: * Faiz Abbas [180611 06:48]: > Hi, > > On Monday 11 June 2018 11:59 AM, Tony Lindgre

Re: [PATCH v3 4/6] bus: ti-sysc: Add support for software reset

2018-07-03 Thread Tony Lindgren
* Faiz Abbas [180703 07:31]: > Hi, > > On Tuesday 03 July 2018 12:37 PM, Tony Lindgren wrote: > > * Tony Lindgren [180611 07:06]: > >> * Faiz Abbas [180611 06:48]: > >>> Hi, > >>> > >>> On Monday 11 June 2018 11:59 AM, Tony Lindgren wrote: > * Faiz Abbas [180611 06:28]: > > Great. I t

Re: [PATCH v3 4/6] bus: ti-sysc: Add support for software reset

2018-07-03 Thread Faiz Abbas
Hi, On Tuesday 03 July 2018 12:37 PM, Tony Lindgren wrote: > * Tony Lindgren [180611 07:06]: >> * Faiz Abbas [180611 06:48]: >>> Hi, >>> >>> On Monday 11 June 2018 11:59 AM, Tony Lindgren wrote: * Faiz Abbas [180611 06:28]: > Great. I thought I completely misunderstood you. But I don't

Re: [PATCH v3 4/6] bus: ti-sysc: Add support for software reset

2018-07-03 Thread Tony Lindgren
* Tony Lindgren [180611 07:06]: > * Faiz Abbas [180611 06:48]: > > Hi, > > > > On Monday 11 June 2018 11:59 AM, Tony Lindgren wrote: > > > * Faiz Abbas [180611 06:28]: > > >> Great. I thought I completely misunderstood you. But I don't see what > > >> adding another function will accomplish. A

Re: [PATCH v3 4/6] bus: ti-sysc: Add support for software reset

2018-06-11 Thread Tony Lindgren
* Faiz Abbas [180611 06:48]: > Hi, > > On Monday 11 June 2018 11:59 AM, Tony Lindgren wrote: > > * Faiz Abbas [180611 06:28]: > >> Great. I thought I completely misunderstood you. But I don't see what > >> adding another function will accomplish. A QUIRK flag used in the same > >> function would

Re: [PATCH v3 4/6] bus: ti-sysc: Add support for software reset

2018-06-10 Thread Faiz Abbas
Hi, On Monday 11 June 2018 11:59 AM, Tony Lindgren wrote: > * Faiz Abbas [180611 06:28]: >> Great. I thought I completely misunderstood you. But I don't see what >> adding another function will accomplish. A QUIRK flag used in the same >> function would work well enough> > Fine with me as long as

Re: [PATCH v3 4/6] bus: ti-sysc: Add support for software reset

2018-06-10 Thread Tony Lindgren
* Faiz Abbas [180611 06:28]: > Great. I thought I completely misunderstood you. But I don't see what > adding another function will accomplish. A QUIRK flag used in the same > function would work well enough. Fine with me as long as the function stays simple for both syss and sysc reset. Regards

Re: [PATCH v3 4/6] bus: ti-sysc: Add support for software reset

2018-06-10 Thread Faiz Abbas
On Monday 11 June 2018 11:39 AM, Tony Lindgren wrote: > * Faiz Abbas [180611 06:09]: >> Hi Tony, >> >> On Friday 08 June 2018 11:51 AM, Tony Lindgren wrote: >>> * Faiz Abbas [180607 10:24]: Hi, On Thursday 07 June 2018 01:05 PM, Tony Lindgren wrote: > * Faiz Abbas [180606 0

Re: [PATCH v3 4/6] bus: ti-sysc: Add support for software reset

2018-06-10 Thread Tony Lindgren
* Faiz Abbas [180611 06:09]: > Hi Tony, > > On Friday 08 June 2018 11:51 AM, Tony Lindgren wrote: > > * Faiz Abbas [180607 10:24]: > >> Hi, > >> > >> On Thursday 07 June 2018 01:05 PM, Tony Lindgren wrote: > >>> * Faiz Abbas [180606 06:14]: > +static int sysc_reset(struct sysc *ddata) > >>

Re: [PATCH v3 4/6] bus: ti-sysc: Add support for software reset

2018-06-10 Thread Faiz Abbas
Hi Tony, On Friday 08 June 2018 11:51 AM, Tony Lindgren wrote: > * Faiz Abbas [180607 10:24]: >> Hi, >> >> On Thursday 07 June 2018 01:05 PM, Tony Lindgren wrote: >>> * Faiz Abbas [180606 06:14]: +static int sysc_reset(struct sysc *ddata) +{ + int offset = ddata->offsets[SYSC_SYS

Re: [PATCH v3 4/6] bus: ti-sysc: Add support for software reset

2018-06-07 Thread Tony Lindgren
* Faiz Abbas [180607 10:24]: > Hi, > > On Thursday 07 June 2018 01:05 PM, Tony Lindgren wrote: > > * Faiz Abbas [180606 06:14]: > >> +static int sysc_reset(struct sysc *ddata) > >> +{ > >> + int offset = ddata->offsets[SYSC_SYSCONFIG]; > >> + int val = sysc_read(ddata, offset); > >> + > >> +

Re: [PATCH v3 4/6] bus: ti-sysc: Add support for software reset

2018-06-07 Thread Faiz Abbas
Hi, On Thursday 07 June 2018 01:05 PM, Tony Lindgren wrote: > * Faiz Abbas [180606 06:14]: >> +static int sysc_reset(struct sysc *ddata) >> +{ >> +int offset = ddata->offsets[SYSC_SYSCONFIG]; >> +int val = sysc_read(ddata, offset); >> + >> +val |= (0x1 << ddata->cap->regbits->srst_shi

Re: [PATCH v3 4/6] bus: ti-sysc: Add support for software reset

2018-06-07 Thread Tony Lindgren
* Faiz Abbas [180606 06:14]: > +static int sysc_reset(struct sysc *ddata) > +{ > + int offset = ddata->offsets[SYSC_SYSCONFIG]; > + int val = sysc_read(ddata, offset); > + > + val |= (0x1 << ddata->cap->regbits->srst_shift); > + sysc_write(ddata, offset, val); > + > + /* Poll o