Re: [RFC PATCH] perf tui: Annotate entries in callchains

2015-03-28 Thread Arnaldo Carvalho de Melo
Em Fri, Mar 27, 2015 at 04:05:03PM -0700, Stephane Eranian escreveu: > On Mon, Mar 23, 2015 at 9:56 AM, Arnaldo Carvalho de Melo wrote: > > Le 23 mars 2015 13:49:24 GMT-03:00, Stephane Eranian a > > écrit : > >>On Sun, Mar 22, 2015 at 5:27 PM, Namhyung Kim > >>> Did you play with acme/perf/core

Re: [RFC PATCH] perf tui: Annotate entries in callchains

2015-03-27 Thread Stephane Eranian
On Mon, Mar 23, 2015 at 9:56 AM, Arnaldo Carvalho de Melo wrote: > > > Le 23 mars 2015 13:49:24 GMT-03:00, Stephane Eranian a > écrit : >>On Sun, Mar 22, 2015 at 5:27 PM, Namhyung Kim >>wrote:(). >>> >>> Did you play with acme/perf/core not tip/perf/core? I got same >>> problem but then I real

Re: [RFC PATCH] perf tui: Annotate entries in callchains

2015-03-23 Thread Arnaldo Carvalho de Melo
Le 23 mars 2015 13:49:24 GMT-03:00, Stephane Eranian a écrit : >On Sun, Mar 22, 2015 at 5:27 PM, Namhyung Kim >wrote:(). >> >> Did you play with acme/perf/core not tip/perf/core? I got same >> problem but then I realize it's not the Arnaldo's tree. When I >> changed to acme/perf/core the pro

Re: [RFC PATCH] perf tui: Annotate entries in callchains

2015-03-23 Thread Stephane Eranian
On Sun, Mar 22, 2015 at 5:27 PM, Namhyung Kim wrote: > Hi Stephane, > > On Fri, Mar 20, 2015 at 02:12:30PM -0700, Stephane Eranian wrote: >> On Fri, Mar 20, 2015 at 2:07 PM, Arnaldo Carvalho de Melo >> wrote: >> > Em Fri, Mar 20, 2015 at 05:39:22PM -0300, Arnaldo Carvalho de Melo >> > escreveu:

Re: [RFC PATCH] perf tui: Annotate entries in callchains

2015-03-22 Thread Namhyung Kim
Hi Stephane, On Fri, Mar 20, 2015 at 02:12:30PM -0700, Stephane Eranian wrote: > On Fri, Mar 20, 2015 at 2:07 PM, Arnaldo Carvalho de Melo > wrote: > > Em Fri, Mar 20, 2015 at 05:39:22PM -0300, Arnaldo Carvalho de Melo escreveu: > >> Em Fri, Mar 20, 2015 at 10:15:53AM -0700, Stephane Eranian escr

Re: [RFC PATCH] perf tui: Annotate entries in callchains

2015-03-20 Thread Arnaldo Carvalho de Melo
Em Fri, Mar 20, 2015 at 06:34:29PM -0300, Arnaldo Carvalho de Melo escreveu: > Strange, are you pressing 'V' on the main 'perf record' view, i.e. before > getting to the annotation browser, to see the DSO just after the symbol? > > Trying with a deeper callchain in pow-me-harder.c... I'm not bein

Re: [RFC PATCH] perf tui: Annotate entries in callchains

2015-03-20 Thread Arnaldo Carvalho de Melo
Em Fri, Mar 20, 2015 at 02:12:30PM -0700, Stephane Eranian escreveu: > On Fri, Mar 20, 2015 at 2:07 PM, Arnaldo Carvalho de Melo > wrote: > > Em Fri, Mar 20, 2015 at 05:39:22PM -0300, Arnaldo Carvalho de Melo escreveu: > >> Em Fri, Mar 20, 2015 at 10:15:53AM -0700, Stephane Eranian escreveu: > >>

Re: [RFC PATCH] perf tui: Annotate entries in callchains

2015-03-20 Thread Stephane Eranian
On Fri, Mar 20, 2015 at 2:07 PM, Arnaldo Carvalho de Melo wrote: > Em Fri, Mar 20, 2015 at 05:39:22PM -0300, Arnaldo Carvalho de Melo escreveu: >> Em Fri, Mar 20, 2015 at 10:15:53AM -0700, Stephane Eranian escreveu: >> > On Thu, Mar 19, 2015 at 5:39 PM, Arnaldo Carvalho de Melo >> > wrote: >> >

Re: [RFC PATCH] perf tui: Annotate entries in callchains

2015-03-20 Thread Arnaldo Carvalho de Melo
Em Fri, Mar 20, 2015 at 05:39:22PM -0300, Arnaldo Carvalho de Melo escreveu: > Em Fri, Mar 20, 2015 at 10:15:53AM -0700, Stephane Eranian escreveu: > > On Thu, Mar 19, 2015 at 5:39 PM, Arnaldo Carvalho de Melo > > wrote: > > > On Mar 19, 2015 9:34 PM, "Stephane Eranian" wrote: > > >> On Thu, Mar

Re: [RFC PATCH] perf tui: Annotate entries in callchains

2015-03-20 Thread Arnaldo Carvalho de Melo
Em Fri, Mar 20, 2015 at 10:15:53AM -0700, Stephane Eranian escreveu: > Hi, > > On Thu, Mar 19, 2015 at 5:39 PM, Arnaldo Carvalho de Melo > wrote: > > On Mar 19, 2015 9:34 PM, "Stephane Eranian" wrote: > >> > >> Hi Arnaldo, > >> > >> On Thu, Mar 19, 2015 at 3:58 PM, Arnaldo Carvalho de Melo > >>

Re: [RFC PATCH] perf tui: Annotate entries in callchains

2015-03-20 Thread Arnaldo Carvalho de Melo
On March 20, 2015 2:15:53 PM GMT-03:00, Stephane Eranian wrote: >> Thanks for testing, please let us know if you have further >suggestions, >> >Ok, it does not work. >I think it works as long as the caller you want to annotate is in the >same module. >But suppose, I am on malloc() (libc) and I

Re: [RFC PATCH] perf tui: Annotate entries in callchains

2015-03-20 Thread Stephane Eranian
Hi, On Thu, Mar 19, 2015 at 5:39 PM, Arnaldo Carvalho de Melo wrote: > On Mar 19, 2015 9:34 PM, "Stephane Eranian" wrote: >> >> Hi Arnaldo, >> >> On Thu, Mar 19, 2015 at 3:58 PM, Arnaldo Carvalho de Melo >> wrote: >> > >> > Hi Stephane, >> > >> > This patch, together with what is in my

Re: [RFC PATCH] perf tui: Annotate entries in callchains

2015-03-19 Thread Stephane Eranian
Hi Arnaldo, On Thu, Mar 19, 2015 at 3:58 PM, Arnaldo Carvalho de Melo wrote: > > Hi Stephane, > > This patch, together with what is in my perf/core branch, should > implement that feature we talked about recently, i.e. to allow > annotating entries in callchains, please take a look at see

[RFC PATCH] perf tui: Annotate entries in callchains

2015-03-19 Thread Arnaldo Carvalho de Melo
Hi Stephane, This patch, together with what is in my perf/core branch, should implement that feature we talked about recently, i.e. to allow annotating entries in callchains, please take a look at see if you think it is ok, - Arnaldo From: Arnaldo Carvalho de Melo Subject: [PATCH 1/1]