Em Fri, Mar 20, 2015 at 10:15:53AM -0700, Stephane Eranian escreveu: > Hi, > > On Thu, Mar 19, 2015 at 5:39 PM, Arnaldo Carvalho de Melo > <arnaldo.m...@gmail.com> wrote: > > On Mar 19, 2015 9:34 PM, "Stephane Eranian" <eran...@google.com> wrote: > >> > >> Hi Arnaldo, > >> > >> On Thu, Mar 19, 2015 at 3:58 PM, Arnaldo Carvalho de Melo > >> <a...@kernel.org> wrote: > >> > > >> > Hi Stephane, > >> > > >> > This patch, together with what is in my perf/core branch, should > >> > implement that feature we talked about recently, i.e. to allow > >> > annotating entries in callchains, please take a look at see if you think > >> > it is ok, > >> > > >> I tried on tip.git and a simple example. It does what I wanted. > >> I will try on more complex test cases. > >> Thanks for implementing this quickly. > > > > Thanks for testing, please let us know if you have further suggestions, > > > Ok, it does not work. > I think it works as long as the caller you want to annotate is in the > same module. > But suppose, I am on malloc() (libc) and I want to see a caller of > malloc(), it will > propose 'annotate bar()', but will still show me the code of libc:malloc. > > In my earlier test, everything worked because the callee and caller were in > the > same module. > > Could you fix this?
I thought that was covered because it deals with a "map_symbol" struct, where it finds both the symbol and the DSO where it came from, etc. Checking that now... - Arnaldo -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
