Re: [PATCH net] tcp: fix keepalive when data remain undelivered

2021-02-19 Thread Yuchung Cheng
optimization > to further reduce the number of keepalive probes in the presence of > packet retransmit. > > c. Use the elapsed time (instead of the 0-window probe counter) in > evaluating tcp keepalive timeout. > > Thanks to Eric Dumazet, Neal Cardwell, and Yuchung Che

Re: [PATCH] tcp: fix TCP_USER_TIMEOUT with zero window

2021-01-13 Thread Yuchung Cheng
On Wed, Jan 13, 2021 at 12:49 PM Eric Dumazet wrote: > > On Wed, Jan 13, 2021 at 9:12 PM Enke Chen wrote: > > > > From: Enke Chen > > > > The TCP session does not terminate with TCP_USER_TIMEOUT when data > > remain untransmitted due to zero window. > > > > The number of unanswered zero-window p

Re: [PATCH] tcp: keepalive fixes

2021-01-12 Thread Yuchung Cheng
On Tue, Jan 12, 2021 at 2:31 PM Enke Chen wrote: > > From: Enke Chen > > In this patch two issues with TCP keepalives are fixed: > > 1) TCP keepalive does not timeout when there are data waiting to be >delivered and then the connection got broken. The TCP keepalive >timeout is not evaluat

Re: [net-next PATCH v3] tcp: Add logic to check for SYN w/ data in tcp_simple_retransmit

2020-12-14 Thread Yuchung Cheng
for a fastopen socket. Doing this we will mark all of > > the packets related to the fastopen SYN as lost. > > > > Signed-off-by: Alexander Duyck > > --- > > > > SGTM, thanks ! > > Signed-off-by: Eric Dumazet Nice work. I tested and verified it works with our pa

Re: [net-next PATCH] tcp: Add logic to check for SYN w/ data in tcp_simple_retransmit

2020-12-12 Thread Yuchung Cheng
On Sat, Dec 12, 2020 at 11:01 AM Alexander Duyck wrote: > > On Sat, Dec 12, 2020 at 10:34 AM Yuchung Cheng wrote: > > > > On Fri, Dec 11, 2020 at 5:28 PM Alexander Duyck > > wrote: > > > > > > From: Alexander Duyck > > > > > &g

Re: [net-next PATCH] tcp: Add logic to check for SYN w/ data in tcp_simple_retransmit

2020-12-12 Thread Yuchung Cheng
On Fri, Dec 11, 2020 at 5:28 PM Alexander Duyck wrote: > > From: Alexander Duyck > > There are cases where a fastopen SYN may trigger either a ICMP_TOOBIG > message in the case of IPv6 or a fragmentation request in the case of > IPv4. This results in the socket stalling for a second or more as it

Re: [net PATCH] tcp: Mark fastopen SYN packet as lost when receiving ICMP_TOOBIG/ICMP_FRAG_NEEDED

2020-12-11 Thread Yuchung Cheng
On Fri, Dec 11, 2020 at 1:51 PM Alexander Duyck wrote: > > On Fri, Dec 11, 2020 at 11:18 AM Eric Dumazet wrote: > > > > On Fri, Dec 11, 2020 at 6:15 PM Alexander Duyck > > wrote: > > > > > > On Fri, Dec 11, 2020 at 8:22 AM Eric Dumazet wrote: > > > > > > > > On Fri, Dec 11, 2020 at 5:03 PM Alex

Re: [PATCH 4.19 000/139] 4.19.7-stable review

2018-12-05 Thread Yuchung Cheng
On Wed, Dec 5, 2018 at 4:08 AM Rafael David Tinoco wrote: > > On 12/5/18 4:58 AM, Greg Kroah-Hartman wrote: > > On Tue, Dec 04, 2018 at 07:09:46PM -0200, Rafael David Tinoco wrote: > >> On 12/4/18 8:48 AM, Greg Kroah-Hartman wrote: > >>> This is the start of the stable review cycle for the 4.19.7

Re: [REGRESSION] Warning in tcp_fastretrans_alert() of net/ipv4/tcp_input.c

2017-09-28 Thread Yuchung Cheng
warning but want to nail the bigger issue first. > > On středa 27. září 2017 2:18:32 CEST Yuchung Cheng wrote: >> On Tue, Sep 26, 2017 at 5:12 PM, Yuchung Cheng wrote: >> > On Tue, Sep 26, 2017 at 6:10 AM, Roman Gushchin wrote: >> >>> On Wed, Sep 20,

Re: [REGRESSION] Warning in tcp_fastretrans_alert() of net/ipv4/tcp_input.c

2017-09-26 Thread Yuchung Cheng
On Tue, Sep 26, 2017 at 5:12 PM, Yuchung Cheng wrote: > On Tue, Sep 26, 2017 at 6:10 AM, Roman Gushchin wrote: >>> On Wed, Sep 20, 2017 at 6:46 PM, Roman Gushchin wrote: >>> > >>> > > Hello. >>> > > >>> > > Since, IIRC, v

Re: [REGRESSION] Warning in tcp_fastretrans_alert() of net/ipv4/tcp_input.c

2017-09-26 Thread Yuchung Cheng
On Tue, Sep 26, 2017 at 6:10 AM, Roman Gushchin wrote: >> On Wed, Sep 20, 2017 at 6:46 PM, Roman Gushchin wrote: >> > >> > > Hello. >> > > >> > > Since, IIRC, v4.11, there is some regression in TCP stack resulting in >> > > the >> > > warning shown below. Most of the time it is harmless, but rar

Re: [REGRESSION] Warning in tcp_fastretrans_alert() of net/ipv4/tcp_input.c

2017-09-21 Thread Yuchung Cheng
On Wed, Sep 20, 2017 at 6:46 PM, Roman Gushchin wrote: > > > Hello. > > > > Since, IIRC, v4.11, there is some regression in TCP stack resulting in the > > warning shown below. Most of the time it is harmless, but rarely it just > > causes either freeze or (I believe, this is related too) panic in

Re: TCP reaching to maximum throughput after a long time

2016-04-12 Thread Yuchung Cheng
On Tue, Apr 12, 2016 at 2:40 PM, Ben Greear wrote: > On 04/12/2016 01:29 PM, Eric Dumazet wrote: >> >> On Tue, 2016-04-12 at 13:23 -0700, Ben Greear wrote: >> >>> It worked well enough for years that I didn't even know other algorithms >>> were >>> available. It was broken around 4.0 time, and I

Re: TCP reaching to maximum throughput after a long time

2016-04-12 Thread Yuchung Cheng
On Tue, Apr 12, 2016 at 7:52 AM, Eric Dumazet wrote: > > On Tue, 2016-04-12 at 12:17 +, Machani, Yaniv wrote: > > Hi, > > After updating from Kernel 3.14 to Kernel 4.4 we have seen a TCP > > performance degradation over Wi-Fi. > > In 3.14 kernel, TCP got to its max throughout after less than

Re: [REGRESSION] tcp/ipv4: kernel panic because of (possible) division by zero

2016-01-06 Thread Yuchung Cheng
On Wed, Jan 6, 2016 at 10:19 AM, Yuchung Cheng wrote: > On Wed, Jan 6, 2016 at 8:50 AM, Oleksandr Natalenko > wrote: >> >> Unfortunately, the patch didn't help -- I've got the same stacktrace with >> slightly different offset (+3) within the function. >>

Re: [REGRESSION] tcp/ipv4: kernel panic because of (possible) division by zero

2016-01-06 Thread Yuchung Cheng
may not be the culprit of this div0 issue because I wasn't able to reproduce exactly your issue on our servers. But I will post the fix today and CC you. > > > On December 22, 2015 4:10:32 AM EET, Yuchung Cheng wrote: > >On Mon, Dec 21, 2015

Re: [REGRESSION] tcp/ipv4: kernel panic because of (possible) division by zero

2015-12-21 Thread Yuchung Cheng
On Mon, Dec 21, 2015 at 12:25 PM, Oleksandr Natalenko wrote: > Commit 3759824da87b30ce7a35b4873b62b0ba38905ef5 (tcp: PRR uses CRB mode by > default and SS mode conditionally) introduced changes to net/ipv4/tcp_input.c > tcp_cwnd_reduction() that, possibly, cause division by zero, and therefore, >

Re: [PATCH RFC net-next 2/2] tcp: Add Redundant Data Bundling (RDB)

2015-10-26 Thread Yuchung Cheng
On Mon, Oct 26, 2015 at 2:35 PM, Andreas Petlund wrote: > > > > On 26 Oct 2015, at 15:50, Neal Cardwell wrote: > > > > On Fri, Oct 23, 2015 at 4:50 PM, Bendik Rønning Opstad > > wrote: > >> @@ -2409,6 +2412,15 @@ static int do_tcp_setsockopt(struct sock *sk, int > >> level, > > ... > >> +

Re: [PATCH RFC net-next 0/2] tcp: Redundant Data Bundling (RDB)

2015-10-23 Thread Yuchung Cheng
On Fri, Oct 23, 2015 at 1:50 PM, Bendik Rønning Opstad wrote: > > This is a request for comments. > > Redundant Data Bundling (RDB) is a mechanism for TCP aimed at reducing > the latency for applications sending time-dependent data. > Latency-sensitive applications or services, such as online game

Re: [PATCH] tcp: Fix RFC reference in comment

2015-01-13 Thread Yuchung Cheng
On Tue, Jan 13, 2015 at 1:10 PM, Debabrata Banerjee wrote: > > Comment in tcp_cwnd_restart() was referencing the wrong RFC for the algorithm > it's implementing. > > Signed-off-by: Debabrata Banerjee > --- > net/ipv4/tcp_output.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff -

Re: TCP connection issues against Amazon S3

2015-01-07 Thread Yuchung Cheng
On Wed, Jan 7, 2015 at 12:37 PM, Erik Grinaker wrote: > On 07 Jan 2015, at 15:58, Eric Dumazet wrote: >> On Wed, 2015-01-07 at 13:31 +, Erik Grinaker wrote: >>> On 06 Jan 2015, at 22:00, Yuchung Cheng wrote: >>>> On Tue, Jan 6, 2015 at 1:04 PM, Erik Grinaker

Re: TCP connection issues against Amazon S3

2015-01-06 Thread Yuchung Cheng
On Tue, Jan 6, 2015 at 1:04 PM, Erik Grinaker wrote: > >> On 06 Jan 2015, at 20:26, Erik Grinaker wrote: >> >>> >>> On 06 Jan 2015, at 20:13, Eric Dumazet wrote: >>> >>> On Tue, 2015-01-06 at 19:42 +, Erik Grinaker wrote: >>> The transfer on the functioning Netherlands server does indee

Re: TCP connection issues against Amazon S3

2015-01-06 Thread Yuchung Cheng
On Tue, Jan 6, 2015 at 11:01 AM, Erik Grinaker wrote: > >> On 06 Jan 2015, at 18:33, Yuchung Cheng wrote: >> >> On Tue, Jan 6, 2015 at 10:17 AM, Erik Grinaker wrote: >>> >>>> On 06 Jan 2015, at 17:20, Eric Dumazet wrote: >>>> On Tue, 2015-0

Re: TCP connection issues against Amazon S3

2015-01-06 Thread Yuchung Cheng
On Tue, Jan 6, 2015 at 10:17 AM, Erik Grinaker wrote: > >> On 06 Jan 2015, at 17:20, Eric Dumazet wrote: >> On Tue, 2015-01-06 at 16:11 +, Erik Grinaker wrote: On 06 Jan 2015, at 16:04, Eric Dumazet wrote: On Tue, 2015-01-06 at 15:14 +, Erik Grinaker wrote: > (CCing Yuchung

Re: [PATCH] tcp: don't use timestamp from repaired skb-s to calculate RTT

2014-08-12 Thread Yuchung Cheng
On Tue, Aug 12, 2014 at 2:45 AM, Andrey Vagin wrote: > We don't know right timestamp for repaired skb-s. Wrong RTT estimations > isn't good, because some congestion modules heavily depends on it. > > This patch adds the TCPCB_REPAIRED flag, which is included in > TCPCB_RETRANS. > > Thanks to Eric

Re: [PATCH 08/24] net, diet: Make TCP metrics optional

2014-05-05 Thread Yuchung Cheng
On Mon, May 5, 2014 at 3:25 PM, Andi Kleen wrote: > From: Andi Kleen > > This is all the code that saves connection information > between different sockets. Not really essential for > small systems. > > Saves about 5.5k text > >textdata bss dec hex filename > 492952 19571

Re: Experimental Privacy Functions and TCP SYN Payloads

2014-02-12 Thread Yuchung Cheng
On Wed, Feb 12, 2014 at 3:35 AM, Daniel Borkmann wrote: > (please cc netdev) > > On 02/12/2014 11:25 AM, Quinn Wood wrote: >> >> If program on host A spoofs the source address of an outgoing IPv4 packet >> then >> places that address in the first 32 bits of a UDP payload, a program on >> host B >>

Re: [PATCH net] tcp: delete unused req in tcp_synack_rtt_meas()

2013-10-24 Thread Yuchung Cheng
On Thu, Oct 24, 2013 at 2:31 AM, Weiping Pan wrote: > The parameter req is not used since > 375fe02c9179(tcp: consolidate SYNACK RTT sampling) Hi Weiping: I just sent a bug-fix "tcp: fix SYNACK RTT estimation in Fast Open" that will also take care of this redundant parameter. Thanks. . > > Signed

Re: [RFC PATCH] tun: don't zeroize sock->file on detach

2012-08-08 Thread Yuchung Cheng
socket.file = NULL >> tun_free_netdev() >> sk_release_sock() >> sock_release(sock->file == NULL) >> iput(SOCK_INODE(sock)) <== dereference on NULL pointer >> >> This patch just removes zeroing of socket's file from __tun_detach(). >

Re: resurrecting tcphealth

2012-07-20 Thread Yuchung Cheng
On Mon, Jul 16, 2012 at 6:03 AM, Piotr Sawuk wrote: > On Mo, 16.07.2012, 13:46, Eric Dumazet wrote: >> On Mon, 2012-07-16 at 13:33 +0200, Piotr Sawuk wrote: >>> On Sa, 14.07.2012, 01:55, Stephen Hemminger wrote: >>> > I am not sure if the is really necessary since the most >>> > of the stats are a