On 22/05/17 23:30, Alexander Sverdlin wrote:
> As agreed with Ryan, change the maintainership.
Thanks for taking this over Alexander.
Acked-by: Ryan Mallon
> Signed-off-by: Alexander Sverdlin
> ---
> MAINTAINERS | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
&g
On 29/08/14 00:15, Sudip Mukherjee wrote:
> printk replaced with corresponding pr_err, dev_alert, dev_notice and pr_info.
> fixed two broken user-visible strings used by the corresponding printk
>
> Signed-off-by: Sudip Mukherjee
> ---
>
> In the first patch i sent Greg suggested to use dev_er
On 12/08/14 17:35, Sanjeev Sharma wrote:
> on some architecture spin_is_locked() always return false in
> uniprocessor configuration and can therefore not be used
> with BUG_ON.it would be advise to replace with
> lockdep_assert_held().
>
> Signed-off-by: Sanjeev Sharma
> ---
> drivers/misc/sgi-
On 12/02/14 19:54, Tomi Valkeinen wrote:
> On 11/02/14 21:07, Ryan Mallon wrote:
>> On 12/02/14 03:06, Tomi Valkeinen wrote:
>>
>>> On 20/09/13 10:06, Ryan Mallon wrote:
>>>> Several video drivers open code the fb_write write function with code
>>>>
On 12/02/14 03:06, Tomi Valkeinen wrote:
> On 20/09/13 10:06, Ryan Mallon wrote:
>> Several video drivers open code the fb_write write function with code
>> which is very similar to fb_sys_write. Replace the open code versions
>> with calls to fb_sys_write. An fb_sync callbac
All in kernel users of %n in format strings have now been removed and
the %n directive is ignored. Remove the handling of %n so that it is
treated the same as any other invalid format string directive. Keep a
warning in place to deter new instances of %n in format strings.
Signed-off-by: Ryan
On 29/01/14 09:51, Kees Cook wrote:
> On Mon, Jan 27, 2014 at 5:02 PM, Ryan Mallon wrote:
>> On 28/01/14 11:39, Kees Cook wrote:
>>> If arguments are consumed without output when encountering %n, it
>>> could be used to benefit or improve information leak attacks
On 28/01/14 11:39, Kees Cook wrote:
> If arguments are consumed without output when encountering %n, it
> could be used to benefit or improve information leak attacks that were
> exposed via a limited size buffer. Since %n is not used by the kernel,
> there is no reason to make an info leak attack
On 28/01/14 10:56, Kees Cook wrote:
> On Mon, Jan 27, 2014 at 3:11 PM, Ryan Mallon wrote:
>> On 28/01/14 10:03, Kees Cook wrote:
>>> Now that there has been a full release of the kernel, and all users
>>> of %n have been dropped, switch to %n use triggering a BUG. Igno
On 28/01/14 10:03, Kees Cook wrote:
> Now that there has been a full release of the kernel, and all users
> of %n have been dropped, switch to %n use triggering a BUG. Ignoring
> arguments could be used to assist in information leaks if an arbitrary
> format string was under the control of an attac
On 13/12/13 06:06, Theodore Ts'o wrote:
> On Thu, Dec 12, 2013 at 05:52:24PM +0100, vegard.nos...@oracle.com wrote:
>> From: Vegard Nossum
>>
>> The idea is simple -- since different kernel versions are vulnerable to
>> different root exploits, hackers most likely try multiple exploits before
>>
On 14/12/13 00:06, Ingo Molnar wrote:
>
> * Ryan Mallon wrote:
>
>> On 13/12/13 08:13, Kees Cook wrote:
>>> On Thu, Dec 12, 2013 at 11:06 AM, Theodore Ts'o wrote:
>>>> On Thu, Dec 12, 2013 at 05:52:24PM +0100, vegard.nos...@oracle.com wrote:
>>&
On 13/12/13 20:20, Vegard Nossum wrote:
> On 12/13/2013 12:50 AM, Ryan Mallon wrote:
>> On 13/12/13 08:13, Kees Cook wrote:
>>> On Thu, Dec 12, 2013 at 11:06 AM, Theodore Ts'o wrote:
>>>> On Thu, Dec 12, 2013 at 05:52:24PM +0100, vegard.nos...@oracle.com wrote
On 13/12/13 08:13, Kees Cook wrote:
> On Thu, Dec 12, 2013 at 11:06 AM, Theodore Ts'o wrote:
>> On Thu, Dec 12, 2013 at 05:52:24PM +0100, vegard.nos...@oracle.com wrote:
>>> From: Vegard Nossum
>>>
>>> The idea is simple -- since different kernel versions are vulnerable to
>>> different root expl
On 11/12/13 16:12, Joe Perches wrote:
> seq_printf and seq_puts returns are often misused.
>
> Instead of checking the seq_printf or seq_puts return,
> add a new seq_overflow function to test if a seq_file has
> overflowed the available buffer space.
>
> This will eventually allow seq_printf and
On 25/11/13 10:38, Johannes Weiner wrote:
> The VM maintains cached filesystem pages on two types of lists. One
> list holds the pages recently faulted into the cache, the other list
> holds pages that have been referenced repeatedly on that first list.
> The idea is to prefer reclaiming young pag
On 05/11/13 19:44, Frank Haverkamp wrote:
> Debugfs interfaces for the GenWQE card. Help to debug potential
> problems. Dump internal chip state for debugging and failure
> determination.
>
> Signed-off-by: Frank Haverkamp
> Co-authors: Joerg-Stephan Vogt ,
> Michael Jung ,
>
On 05/11/13 19:44, Frank Haverkamp wrote:
> Sysfs interfaces for the GenWQE card. There are attributes to query
> the version of the bitstream as well as some for the driver. For
> debugging, please also see the debugfs interfaces of this driver.
>
> Signed-off-by: Frank Haverkamp
> Co-authors:
On 05/11/13 04:08, Frank Haverkamp wrote:
> Selecting interface names via configuration option is obsolete.
Don't do this. You are adding completely new code, so there is no reason
to post a patch full of code that is known to be incorrect, followed by
a set of patches fixing things. Just post the
On 30/10/13 20:32, Frank Haverkamp wrote:
> From: Frank Haverkamp
> Signed-off-by: Frank Haverkamp
> Co-authors: Joerg-Stephan Vogt ,
> Michael Jung ,
> Michael Ruettger
> ---
> Documentation/ABI/testing/debugfs-driver-genwqe | 57 +
> Documentation/ABI/testing/sysfs-
On 31/10/13 04:35, Greg KH wrote:
> On Wed, Oct 30, 2013 at 10:32:58AM +0100, Frank Haverkamp wrote:
>> +if GENWQE
>> +
>> +config GENWQE_DEVNAME
>> +string "Name for sysfs and device nodes"
>> +default "genwqe"
>> +help
>> + Select alternate name for sysfs and device
cleaner when adding new entries.
>
> Signed-off-by: H Hartley Sweeten
Acked-by: Ryan Mallon
> Cc: Ryan Mallon
> Cc: Alan Stern
> Cc: Lennert Buytenhek
> Cc: Greg Kroah-Hartman
> Cc: Olof Johansson
> Cc: Russell King
> ---
> arch/arm/configs/ep93xx_defconfig
On 15/10/13 08:35, H Hartley Sweeten wrote:
> Convert ep93xx to use the OHCI platform driver and remove the
> ohci-ep93xx bus glue driver.
>
> Signed-off-by: H Hartley Sweeten
> Cc: Alan Stern
> Cc: Greg Kroah-Hartman
> Cc: Ryan Mallon
Cc'ed Olof, who wanted to s
On 15/10/13 02:47, Hartley Sweeten wrote:
> On Friday, October 11, 2013 8:11 PM, Michael Opdenacker wrote:
>> This patch proposes to remove the use of the IRQF_DISABLED flag
>>
>> It's a NOOP since 2.6.35 and it will be removed one day.
>>
>> Signed-off-by: Michael Opdenacker
>> ---
>> arch/arm/m
d by using dmesg_restrict.
Signed-off-by: Ryan Mallon
Cc: sta...@vger.kernel.org
---
This is a temporary solution only, but fixes a minor security hole when
kptr_restrict=1. I am working to fix this properly, but there is still
some discussion around how to achieve this, see here:
https://lkm
On 15/10/13 08:35, H Hartley Sweeten wrote:
> Convert ep93xx to use the OHCI platform driver and remove the
> ohci-ep93xx bus glue driver.
>
> Signed-off-by: H Hartley Sweeten
> Cc: Alan Stern
> Cc: Greg Kroah-Hartman
> Cc: Ryan Mallon
> ---
> diff --git a/drivers
On 14/10/13 21:17, Djalal Harouni wrote:
> On Fri, Oct 11, 2013 at 02:19:14PM +1100, Ryan Mallon wrote:
>> On 11/10/13 13:20, Eric W. Biederman wrote:
>>> Joe Perches writes:
>>>
>>>> Some setuid binaries will allow reading of files which have read
>&
On 12/10/13 09:37, Eric W. Biederman wrote:
> Ryan Mallon writes:
>
>> The only remaining problem is kernel/module.c:module_sect_show() which
>> is used to write the sysfs files in /sys/module//sections/.
>> Those files are actually are really good target for leaking
On 11/10/13 15:42, George Spelvin wrote:
> ebied...@xmission.com (Eric W. Biederman) wrote:
>> Sigh. This is all wrong. The only correct thing to test is
>> file->f_cred. Aka the capabilities of the program that opened the
>> file.
>>
>> Which means that the interface to %pK in the case of kptr
On 11/10/13 16:38, Joe Perches wrote:
> On Fri, 2013-10-11 at 16:31 +1100, Ryan Mallon wrote:
>> On 11/10/13 16:25, Joe Perches wrote:
>>> Printing kernel pointers via %pK has a minor defect when
>>> kptr_restrict is set to 2: the pointer may be emitted
>>> a
On 11/10/13 16:25, Joe Perches wrote:
> Printing kernel pointers via %pK has a minor defect when
> kptr_restrict is set to 2: the pointer may be emitted
> as "pK-error" instead of all 0's when in an interrupt.
NAK. This is not a defect, as I explained earlier. It is really a defect
that it _doesn
On 11/10/13 15:42, George Spelvin wrote:
> ebied...@xmission.com (Eric W. Biederman) wrote:
>> Sigh. This is all wrong. The only correct thing to test is
>> file->f_cred. Aka the capabilities of the program that opened the
>> file.
>>
>> Which means that the interface to %pK in the case of kptr_
On 11/10/13 13:20, Eric W. Biederman wrote:
> Joe Perches writes:
>
>> Some setuid binaries will allow reading of files which have read
>> permission by the real user id. This is problematic with files which
>> use %pK because the file access permission is checked at open() time,
>> but the kptr_
On 09/10/13 18:55, Mika Westerberg wrote:
> On Tue, Oct 08, 2013 at 05:00:54PM +0200, Romain Baeriswyl wrote:
>> static void __i2c_dw_enable(struct dw_i2c_dev *dev, bool enable)
>> @@ -286,6 +287,7 @@ int i2c_dw_init(struct dw_i2c_dev *dev)
>> u32 input_clock_khz;
>> u32 hcnt, lcnt;
>>
On 10/10/13 10:09, Joe Perches wrote:
> Changes in V3a:
>
> Do the in_irq tests only when kptr_restrict is 1.
> Document the %pK mechanism in vsnprintf
> Add missing documentation for %pV and %pNF too
I really did mean post a follow-up/separate patch, not a different
version of mine. The missing
On 10/10/13 09:33, Joe Perches wrote:
> On Thu, 2013-10-10 at 09:25 +1100, Ryan Mallon wrote:
>
>> if (kptr_restrict && (in_irq() || in_serving_softirq() ||
>>in_nmi())) {
>>
>> Is making sure that you don't
On 10/10/13 09:14, Joe Perches wrote:
> On Thu, 2013-10-10 at 09:04 +1100, Ryan Mallon wrote:
>> On 10/10/13 09:00, Joe Perches wrote:
> []
>>> Move the interrupt tests and pK-error printk
>>> into case 1:
>>>
>>> It's the only case where CAP_S
On 10/10/13 09:00, Joe Perches wrote:
> On Thu, 2013-10-10 at 08:52 +1100, Ryan Mallon wrote:
>> Some setuid binaries will allow reading of files which have read
>> permission by the real user id. This is problematic with files which
>> use %pK because the file access permissi
ned-off-by: Ryan Mallon
---
Changes since v2:
* Fixed typo in comment: 'proccess' -> 'process'
* Use a switch statement for the kptr_restrict values
* Updated the sysctl documentation
Changes since v1:
* Fix the description to say 'vsprintf' instead of
On 09/10/13 13:00, Joe Perches wrote:
> On Wed, 2013-10-09 at 12:55 +1100, Ryan Mallon wrote:
>> On 09/10/13 12:30, Joe Perches wrote:
>>> On Tue, 2013-10-08 at 17:49 -0700, Joe Perches wrote:
>>>> On Wed, 2013-10-09 at 11:15 +1100, Ryan Mallon wrote:
>>>>
On 09/10/13 12:30, Joe Perches wrote:
> On Tue, 2013-10-08 at 17:49 -0700, Joe Perches wrote:
>> On Wed, 2013-10-09 at 11:15 +1100, Ryan Mallon wrote:
>>> Some setuid binaries will allow reading of files which have read
>>> permission by the real user id. This is p
up ids are equal to the
real ids. If a setuid binary reads the contents of a file which uses
%pK then the pointer values will be printed as NULL if the real user
is unprivileged.
Signed-off-by: Ryan Mallon
---
Changes since v1:
* Fix the description to say 'vsprintf' instead of
On 04/10/13 20:30, Janani Venkataraman wrote:
> From:Suzuki K. Poulose
>
> vma_dump_size calculates the file size of a vma area in the core file. It
> assumes the vma belongs to the "current". Make it generic to work for any
> task.
> This will be reused by application core dump infrastructure.
On 04/10/13 10:41, Kees Cook wrote:
> On Wed, Aug 28, 2013 at 1:49 PM, Kees Cook wrote:
>
> BTW, this just came to my attention:
> http://marc.info/?l=linux-kernel&m=138049414321387&w=2
>
> Same problem, just for /proc/kallsyms. This would benefit from the
> open vs read cred check as well, I
On 02/10/13 11:57, Mathieu Rhéaume wrote:
> This patch changes seq_printf for seq_puts in binder.c.
> It fixes the warnings emitted by checkpatch.pl.
>
> Signed-off-by: Mathieu Rhéaume
> ---
> drivers/staging/android/binder.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> dif
On 30/09/13 10:41, Dan Rosenberg wrote:
> On 09/29/2013 07:41 PM, George Spelvin wrote:
>>> Right, so the pppd application is actually doing the correct thing.
>> And a CAP_SYSLOG setuid binary that *doesn't* DTRT seems like a more
>> immediate security hole than leaking kernel addresses. After al
On 30/09/13 09:15, George Spelvin wrote:
> The basic idea is good, but I'm not sure if this is the correct permission
> check to use.
>
> After all, a setuid program might also want to give filtered access to
> a /proc file with some %pK values.
Yeah. I'm not sure if this will break some applicat
ULL if the real user is unprivileged.
Signed-off-by: Ryan Mallon
---
diff --git a/lib/vsprintf.c b/lib/vsprintf.c
index 26559bd..b1cd14d 100644
--- a/lib/vsprintf.c
+++ b/lib/vsprintf.c
@@ -1312,10 +1312,24 @@ char *pointer(const char *fmt, char *buf, char *end,
On 23/09/13 12:16, Joe Perches wrote:
> On Mon, 2013-09-23 at 11:59 +1000, Ryan Mallon wrote:
>> This seems like a lot of code churn for very little benefit. At a quick
>> glance:
>>
>> git grep extern include/ | wc -l
>> 11427
>>
>> Not all of tho
On 23/09/13 03:32, Joe Perches wrote:
> There are a mix of function prototypes with and without extern
> in the kernel sources. Standardize on not using extern for
> function prototypes.
>
> Function prototypes don't need to be written with extern.
> extern is assumed by the compiler. Its use is
Several video drivers open code the fb_write write function with code
which is very similar to fb_sys_write. Replace the open code versions
with calls to fb_sys_write. An fb_sync callback is added to each of
the drivers.
Signed-off-by: Ryan Mallon
---
diff --git a/drivers/video/auo_k190x.c
On 19/09/13 01:56, Michal Simek wrote:
> This new subsystem should unify all fpga drivers which
> do the same things. Load configuration data to fpga
> or another programmable logic through common interface.
> It doesn't matter if it is MMIO device, gpio bitbanging,
> etc. connection. The point is
On 19/09/13 05:48, Dmitry Torokhov wrote:
> Hi Ryan,
>
> On Wed, Sep 18, 2013 at 08:55:44AM +1000, Ryan Mallon wrote:
>> Rework the code in uinput_inject_event so that it matches the code in
>> evdev_write and allows injecting more than one event, or zero events.
>
>
Rework the code in uinput_inject_event so that it matches the code in
evdev_write and allows injecting more than one event, or zero events.
Signed-off-by: Ryan Mallon
---
drivers/input/misc/uinput.c | 18 +-
1 file changed, 13 insertions(+), 5 deletions(-)
diff --git a
If input_event_from_user() fails in evdev write() and at least one
event has been written successfully then return the number of bytes
written. If no events have been written, then the EFAULT error is
returned.
Signed-off-by: Ryan Mallon
---
drivers/input/evdev.c |3 ++-
1 file changed, 2
On 11/09/13 10:14, Dmitry Torokhov wrote:
> Hi Ryan,
>
> On Wed, Sep 11, 2013 at 09:32:52AM +1000, Ryan Mallon wrote:
>> Rework the code in uinput_inject_event so that it matches the code in
>> evdev_write and allows injecting more than one event, or zero events.
>>
&g
On 11/09/13 10:12, Dmitry Torokhov wrote:
> Hi Ryan,
>
> On Wed, Sep 11, 2013 at 09:32:53AM +1000, Ryan Mallon wrote:
>> Call input_inject_event rather than input_event in uinput_inject_event. This
>> mirrors the behaviour of evdev_write. input_inject_event will ignore the
Rework the code in uinput_inject_event so that it matches the code in
evdev_write and allows injecting more than one event, or zero events.
Signed-off-by: Ryan Mallon
---
drivers/input/misc/uinput.c | 14 +-
1 file changed, 9 insertions(+), 5 deletions(-)
diff --git a/drivers
Call input_inject_event rather than input_event in uinput_inject_event. This
mirrors the behaviour of evdev_write. input_inject_event will ignore the
injected event if the uinput input device has been grabbed for exclusive
access by a handler other than uinput.
Signed-off-by: Ryan Mallon
On 24/07/13 16:09, Prashant Shah wrote:
> Signed-off-by: Prashant Shah
> ---
> drivers/net/ethernet/8390/wd.c |2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/8390/wd.c b/drivers/net/ethernet/8390/wd.c
> index 03eb3ee..b43a63f 100644
> --- a/driver
= mport_id) {
> list_del(&scan->node);
> kfree(scan);
> + break;
> }
> + }
>
> mutex_unlock(&rio_mport_list_lock);
>
Reviewed-by: Ryan Mallon
--
To unsubscribe from this list: send the li
On 05/07/13 16:02, Dan Carpenter wrote:
> We need to use the _safe version of list_for_each_entry() because we
> are freeing the iterator.
>
> Signed-off-by: Dan Carpenter
>
> diff --git a/drivers/rapidio/rio.c b/drivers/rapidio/rio.c
> index f4f30af..84ac64a 100644
> --- a/drivers/rapidio/rio.c
On 29/06/13 04:44, H Hartley Sweeten wrote:
> This inline helper function is only used to determine the bus width
> of the current transfer (8 or 16 bit). Add a bool flag to the private
> structure and set it appropriately for each transfer.
>
> Signed-off-by: H Hartley Swee
always call ep93xx_spi_chip_setup()
> to configure the hardware for each transfer in the message.
>
> Remove the redundant ep93xx_spi_chp_setup() in ep93xx_spi_process_transfer()
> which just initializes the hardware to the "default" based on the SPI
> device.
>
> S
gt;
> Signed-off-by: H Hartley Sweeten
> Cc: Ryan Mallon
> Cc: Mika Westerberg
> Cc: Mark Brown
> Cc: Grant Likely
> ---
> drivers/spi/spi-ep93xx.c | 64
> +++-
> 1 file changed, 20 insertions(+), 44 deletions(-)
>
On 11/06/13 20:14, Thierry Reding wrote:
> On Mon, Jun 10, 2013 at 04:12:07PM -0700, H Hartley Sweeten wrote:
> [...]
>> +What: /sys/class/pwm/pwmchipN/pwmX/duty
>> +Date: May 2013
>> +KernelVersion: 3.11
>> +Contact:H Hartley Sweeten
>> +Description:
>> +
On 31/05/13 19:27, Andy Shevchenko wrote:
> To support some (legacy) firmwares and platforms let's make life easier for
> their customers.
>
> This patch extracts SFI GPIO API from arch/x86/platform/mrst/mrst.c.
>
> Signed-off-by: Andy Shevchenko
> Acked-by: Len Brown
> Cc: Grant Likely
> Cc:
On 30/05/13 07:08, H Hartley Sweeten wrote:
> Add a simple sysfs interface to the PWM framework.
>
> /sys/class/pwm/
> `-- pwmchipN/ for each PWM chip
> |-- export (w/o) ask the kernel to export a PWM to userspace
> |-- npwm (r/o) number of PWM in pwmchip
+++-
> 1 file changed, 50 insertions(+), 137 deletions(-)
>
Series looks fine to me.
Reviewed-by: Ryan Mallon
~Ryan
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
On 24/05/13 01:12, David Howells wrote:
> Linus Torvalds wrote:
>
>> We do *not* want to add some crazy "spin_is_nt_locked". We just want
>> to get rid of these idiotic debug tests.
>
> Generally, I think you are right, though there are also some checks in
> deallocation routines that check that
On 26/03/13 09:40, Andrew Morton wrote:
> On Fri, 22 Mar 2013 17:15:49 +0100 Guennadi Liakhovetski
> wrote:
>
>> Add support for configuring AS3711 backlight driver from DT.
>>
>> Signed-off-by: Guennadi Liakhovetski
>> Reviwed-by: Mark Brown
>> ---
>> drivers/video/backlight/as3711_bl.c | 1
remove the init/exit boilerplate.
>>
>> Signed-off-by: H Hartley Sweeten
>> Cc: Ryan Mallon
>> Cc: Arnd Bergmann
>> Cc: Greg Kroah-Hartman
>
> Acked-by: Arnd Bergmann
For the whole series:
Acked-by: Ryan Mallon
Not sure if I should take these
On 16/03/13 12:03, H Hartley Sweeten wrote:
> Remove the __init tag from ep93xxbl_probe() to fix the section
> mismatch warning.
>
> Signed-off-by: H Hartley Sweeten
> Cc: Ryan Mallon
> Cc: Richard Purdie
> Cc: Florian Tobias Schandinat
There is a patch for this alr
claration of function
> 'devm_ioremap'
> drivers/video/ep93xx-fb.c:533: warning: assignment makes pointer from integer
> without a cast
>
> Include to pickup the declaration of 'devm_ioremap'.
>
> Signed-off-by: H Hartley Sweeten
> Cc:
> Cc: Flor
On 06/03/13 09:44, Tejun Heo wrote:
> Hello,
>
> On Wed, Mar 06, 2013 at 09:40:48AM +1100, Ryan Mallon wrote:
>>> Ooh, right, and that cpumask_t is going away and you can't statically
>>> allocate cpumask_var_t, so it needs an allocation and error check from
>&g
On 04/03/13 20:02, Jingoo Han wrote:
> When platform_driver_probe() is not used, bind/unbind via sysfs is
> enabled. Thus, __init/__exit annotations should be removed from
> probe()/remove().
>
> Signed-off-by: Jingoo Han
Acked-by: Ryan Mallon
> ---
> Changes since v1
On 06/03/13 09:34, Tejun Heo wrote:
> On Tue, Mar 05, 2013 at 02:33:27PM -0800, Tejun Heo wrote:
>> Hello, Ryan.
>>
>> On Wed, Mar 06, 2013 at 09:29:35AM +1100, Ryan Mallon wrote:
>>>> @@ -148,6 +148,8 @@ struct worker_pool {
>>>>struc
On 05/03/13 05:37, Tejun Heo wrote:
> Introduce struct workqueue_attrs which carries worker attributes -
> currently the nice level and allowed cpumask along with helper
> routines alloc_workqueue_attrs() and free_workqueue_attrs().
>
> Each worker_pool now carries ->attrs describing the attribute
On 01/03/13 21:57, Michail Kurachkin wrote:
> From: Michail Kurochkin
>
> Signed-off-by: Michail Kurochkin
> ---
> drivers/staging/tdm/kirkwood_tdm.c | 162
> +---
> drivers/staging/tdm/kirkwood_tdm.h | 10 ++-
> drivers/staging/tdm/tdm.h |5 +-
On 01/03/13 21:52, Michail Kurachkin wrote:
> From: Michail Kurochkin
>
> Signed-off-by: Michail Kurochkin
> ---
> drivers/staging/tdm/kirkwood_tdm.c | 932
>
> drivers/staging/tdm/kirkwood_tdm.h | 110 +
> 2 files changed, 1042 insertions(+), 0 dele
On 01/03/13 21:50, Michail Kurachkin wrote:
> From: Michail Kurochkin
>
> Signed-off-by: Michail Kurochkin
Hi Michail,
Quick review below. I'll try to find some time to look through
the other patches later.
~Ryan
> ---
> drivers/staging/Kconfig|4 +
> drivers/staging/Makefile
On 13/02/13 18:03, Alexandre Courbot wrote:
> From: Alexandre Courbot
>
> Their value being obtained by gpio_chip_hwgpio(), this better reflects
> their use.
>
> Signed-off-by: Alexandre Courbot
> ---
> drivers/gpio/gpiolib.c | 70
> +-
> 1 file
On 13/02/13 18:02, Alexandre Courbot wrote:
> From: Alexandre Courbot
>
> Some functions dereferenced their GPIO descriptor argument without
> checking its validity first, potentially leading to an oops when given
> an invalid argument.
>
> This patch also makes gpio_get_value() more resilient w
On 14/11/12 05:46, Constantine Shulyupin wrote:
> From: Constantine Shulyupin
>
> LDT is useful for Linux driver development beginners,
> hackers and as starting point for a new drivers.
> The driver uses following Linux facilities: module, platform driver,
> file operations (read/write, mmap, io
On 09/11/12 07:23, Sasha Levin wrote:
> Signed-off-by: Sasha Levin
> ---
> drivers/net/vmxnet3/vmxnet3_drv.c |2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/vmxnet3/vmxnet3_drv.c
> b/drivers/net/vmxnet3/vmxnet3_drv.c
> index 0ae1bcc..7e9622f 100644
> ---
On 10/11/12 08:07, Stephen Warren wrote:
> On 11/08/2012 04:06 PM, Ryan Mallon wrote:
>> On 09/11/12 08:01, Stephen Warren wrote:
>>> remove ARM's struct sys_timer .offset function pointer, and instead
>>> directly set the arch_gettimeoffset function poin
lts
> by 1000, since the removed arm_gettimeoffset() did this. Also,
> s/unsigned long/u32/ just to make the function prototypes exactly
> match that of arch_gettimeoffset.
>
> Cc: Russell King
> Cc: Andrew Victor
> Cc: Nicolas Ferre
> Cc: Jean-Christophe Plagniol-Villa
On 06/11/12 08:40, Tabi Timur-B04825 wrote:
> On Mon, Nov 5, 2012 at 2:40 PM, Grant Likely
> wrote:
>
>> Jane is building custom BeagleBone expansion boards called 'capes'. She
>> can boot the system with a stock BeagleBoard device tree, but additional
>> data is needed before a cape can be used
On 04/11/12 04:45, Luca Clementi wrote:
> On Fri, Nov 2, 2012 at 11:29 AM, Greg Kroah-Hartman
> wrote:
>> On Thu, Nov 01, 2012 at 11:15:52PM -0700, Luca Clementi wrote:
>>> + vfree(current_log->buffer);
>>> + kfree(current_log->misc.name);
>>> + kfree(current
On 02/11/12 17:15, Luca Clementi wrote:
> Created the module_exit for the android logger so that
> it can be loaded and unloaded as a module. Fixed
> module_init and some other minor issues.
>
> Signed-off-by: Luca Clementi
> Cc: Greg Kroah-Hartman
> Cc: Brian Swetland
> ---
> drivers/staging/
On 18/10/12 09:01, Krzysztof Halasa wrote:
> Hi,
>
>
> Unfortunately, as I already explained to you in
> https://lkml.org/lkml/2012/9/29/37, my resources for IXP4xx are very
> limited (and this isn't a paid job) and I'm in no way able to do what
> you require. This, coupled with my inability t
On 28/10/12 21:20, Ingo Molnar wrote:
>
> * Andrew Morton wrote:
>
>> On Sat, 27 Oct 2012 15:12:03 +0200 Ingo Molnar wrote:
>>
>>> There's 3 types of conversions done:
>>>
>>>uninitialized_var(x)=> x = 0 /* for scalar types */
>>>uninitialized_var(x)=> x = NULL
On 23/10/12 09:13, Linus Walleij wrote:
> On Mon, Oct 22, 2012 at 2:39 AM, Ryan Mallon wrote:
>
>> The gpio_export function uses nested if statements and the status
>> variable to handle the failure cases. This makes the function logic
>> difficult to follow. Re
number of split lines and makes the code easier
to read.
Signed-off-by: Ryan Mallon
---
Changes since v1:
- Return immediately if no unwinding needed
- Added pr_debug to immediate returns
- Changed unavailable (!requested || exported) to -EPERM
diff --git a/drivers/gpio/gpiolib.c b/drivers/gpio
On 19/10/12 21:07, Linus Walleij wrote:
> On Wed, Oct 17, 2012 at 1:41 AM, Ryan Mallon wrote:
>
>> The gpio_export function uses nested if statements and the status
>> variable to handle the failure cases. This makes the function logic
>> difficult to follow. Re
number of split lines and makes the code easier
to read.
Signed-off-by: Ryan Mallon
---
diff --git a/drivers/gpio/gpiolib.c b/drivers/gpio/gpiolib.c
index 5d6c71e..a142246 100644
--- a/drivers/gpio/gpiolib.c
+++ b/drivers/gpio/gpiolib.c
@@ -702,68 +702,74 @@ int gpio_export(unsigned gpio, bool
On 16/10/12 19:25, Jingoo Han wrote:
> This patch uses pr_* instead of printk. Also, gpio_dbg
> is replaced with pr_debug.
>
> Signed-off-by: Ryan Mallon
If I recall correctly, I only offered review comments on this patch,
I wasn't directly involved in writing it, or in the s
On 16/10/12 10:31, Roland Stigge wrote:
> The recurring task of providing simultaneous access to GPIO lines (especially
> for bit banging protocols) needs an appropriate API.
>
> This patch adds a kernel internal "Block GPIO" API that enables simultaneous
> access to several GPIOs. This is done by
On 16/10/12 04:20, Roland Stigge wrote:
> Hi Ryan,
>
> thank you for your feedback, I will include it, except for some points
> noted below:
>>> + gbc->mask |= BIT(bit);
>>> +
>>> + /* collect gpios that are specified together, represented by
>>> +* neighboring bit
On 13/10/12 06:11, Roland Stigge wrote:
> This patch adds sysfs support to the block GPIO API.
>
> Signed-off-by: Roland Stigge
Hi Roland,
Some comments below,
~Ryan
>
> ---
> Documentation/ABI/testing/sysfs-gpio |6
> drivers/gpio/gpiolib.c | 226
>
1 - 100 of 139 matches
Mail list logo
