On 23/10/12 09:13, Linus Walleij wrote: > On Mon, Oct 22, 2012 at 2:39 AM, Ryan Mallon <rmal...@gmail.com> wrote: > >> The gpio_export function uses nested if statements and the status >> variable to handle the failure cases. This makes the function logic >> difficult to follow. Refactor the code to abort immediately on failure >> using goto. This makes the code slightly longer, but significantly >> reduces the nesting and number of split lines and makes the code easier >> to read. > > Splendid, patch applied!
Thanks. >> Signed-off-by: Ryan Mallon > > Interesting that you sign off without an email address, I just added it > thinking it was a mistake. Whoops. Yeah, should be: Signed-off-by: Ryan Mallon <rmal...@gmail.com> Thanks, ~Ryan -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
