On 23/09/13 03:32, Joe Perches wrote: > There are a mix of function prototypes with and without extern > in the kernel sources. Standardize on not using extern for > function prototypes. > > Function prototypes don't need to be written with extern. > extern is assumed by the compiler. Its use is as unnecessary as > using auto to declare automatic/local variables in a block. > > Signed-off-by: Joe Perches <j...@perches.com>
This seems like a lot of code churn for very little benefit. At a quick glance: git grep extern include/ | wc -l 11427 Not all of those will need to be removed, but that is still a huge number to change, and doesn't include extern usage in C files or local headers. You are probably never going to remove all the instances, so what is the point of just randomly doing a handful? ~Ryan > --- > include/net/ping.h | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/include/net/ping.h b/include/net/ping.h > index 5db0224..3f67704 100644 > --- a/include/net/ping.h > +++ b/include/net/ping.h > @@ -103,8 +103,8 @@ void ping_seq_stop(struct seq_file *seq, void *v); > int ping_proc_register(struct net *net, struct ping_seq_afinfo *afinfo); > void ping_proc_unregister(struct net *net, struct ping_seq_afinfo *afinfo); > > -extern int __init ping_proc_init(void); > -extern void ping_proc_exit(void); > +int __init ping_proc_init(void); > +void ping_proc_exit(void); > #endif > > void __init ping_init(void); > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
