On Mon, Feb 25, 2008 at 8:31 AM, Ingo Molnar <[EMAIL PROTECTED]> wrote:
>
> * Paolo Ciarrocchi <[EMAIL PROTECTED]> wrote:
>
> > Before:
> > total: 34 errors, 14 warnings, 456 lines checked
> >
> > After:
> > total: 0 errors, 8 warnings, 45
On 2/25/08, Andy Whitcroft
> As we want the messages to be as short as possible, I am leaning towards
> standardising on:
>
> spaces prohibited
> spaces required
>
in that case i would prefer:
space not required
space required
ciao,
--
Paolo
http://paolo.ciarrocchi.googlepages.com/
--
To uns
On 2/25/08, Joe Perches <[EMAIL PROTECTED]> wrote:
> On Sun, 2008-02-24 at 22:11 +0100, Paolo Ciarrocchi wrote:
> > - "driver.\n", __FUNCTION__, drive->name);
> > + "driver.\n", __func__, drive->name);
>
> Is there consensus on this style co
This email didn't reach lkml...
Hi Ingo,
two more coding style patches.
Compile tested, against x86/testing 4a6af5bbbd74dd812224900d3468b008d117da29
Paolo Ciarrocchi (2):
x86: Coding Style fixes to arch/x86/power/cpu_32.c
x86: Coding Style fixes to arch/x86/kernel/cpu/com
Before:
total: 34 errors, 14 warnings, 456 lines checked
After:
total: 0 errors, 8 warnings, 456 lines checked
Signed-off-by: Paolo Ciarrocchi <[EMAIL PROTECTED]>
---
drivers/ide/pci/cy82c693.c | 74 ++--
1 files changed, 37 insertions(
Applies on top of the previous patch.
Signed-off-by: Paolo Ciarrocchi <[EMAIL PROTECTED]>
---
drivers/ide/ide-cd.c | 14 +++---
1 files changed, 7 insertions(+), 7 deletions(-)
diff --git a/drivers/ide/ide-cd.c b/drivers/ide/ide-cd.c
index 3181e71..76317ab 100644
--- a/drive
Before:
total: 43 errors, 66 warnings, 2183 lines checked
After:
total: 0 errors, 36 warnings, 2192 lines checked
I didn't (and I don't plan to) fix the warnings:
WARNING: line over 80 characters
Signed-off-by: Paolo Ciarrocchi <[EMAIL PROTECTED]>
---
drivers/ide
Hi Bart,
three more patches, all are compile tested and against yesterday linux-next
"IDE: Replace __FUNCTION__ with __func__" depends
on "IDE: Coding Style fixes to drivers/ide/ide-cd.c"
Paolo Ciarrocchi (3):
IDE: Coding Style fixes to drivers/ide/ide-cd.
File is now error free, only a few
WARNING: line over 80 characters
are left.
Compile tested.
Signed-off-by: Paolo Ciarrocchi <[EMAIL PROTECTED]>
---
drivers/ide/pci/it8213.c |9 -
1 files changed, 4 insertions(+), 5 deletions(-)
diff --git a/drivers/ide/pci/it8213.c b/drive
On Sun, Feb 24, 2008 at 4:18 PM, Benny Halevy <[EMAIL PROTECTED]> wrote:
[...]
> How about:
> - WARN("no space between function name and
> open parenthesis '('\n" . $herecurr);
> + WARN("there should be no space between
> function nam
On Sun, Feb 24, 2008 at 5:38 PM, Bartlomiej Zolnierkiewicz
<[EMAIL PROTECTED]> wrote:
>
> On Saturday 23 February 2008, Paolo Ciarrocchi wrote:
> > Bart,
> > here is a new series of patches that remove some errors
> > and warnings reported by checkpatch.pl from th
File is now error free.
Compile tested.
Signed-off-by: Paolo Ciarrocchi <[EMAIL PROTECTED]>
---
arch/x86/kernel/cpu/common.c | 105 ++---
1 files changed, 56 insertions(+), 49 deletions(-)
diff --git a/arch/x86/kernel/cpu/common.c b/arch/x86/kern
File is now error free.
Compile tested.
Patch is against x86#testing
Signed-off-by: Paolo Ciarrocchi <[EMAIL PROTECTED]>
---
arch/x86/power/cpu_32.c | 41 +++--
1 files changed, 23 insertions(+), 18 deletions(-)
diff --git a/arch/x86/power/cpu_32.c
Fix all the errors and a few warnings.
Compile tested.
Signed-off-by: Paolo Ciarrocchi <[EMAIL PROTECTED]>
---
drivers/ide/pci/cmd640.c | 90 +++---
1 files changed, 45 insertions(+), 45 deletions(-)
diff --git a/drivers/ide/pci/cmd640.c b/drive
File is now error free, 2 warnings left.
Compile tested.
Signed-off-by: Paolo Ciarrocchi <[EMAIL PROTECTED]>
---
drivers/ide/legacy/ali14xx.c | 11 ++-
1 files changed, 6 insertions(+), 5 deletions(-)
diff --git a/drivers/ide/legacy/ali14xx.c b/drivers/ide/legacy/ali14xx.c
File is now error free.
Compile tested.
Signed-off-by: Paolo Ciarrocchi <[EMAIL PROTECTED]>
---
drivers/ide/ide-floppy.c |4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/ide/ide-floppy.c b/drivers/ide/ide-floppy.c
index 5f133df..cea77e0 100644
--- a/d
Fix a lot of errors and warnings.
Compile tested.
Signed-off-by: Paolo Ciarrocchi <[EMAIL PROTECTED]>
---
drivers/ide/legacy/hd.c | 79 ---
1 files changed, 40 insertions(+), 39 deletions(-)
diff --git a/drivers/ide/legacy/hd.c b/drivers/ide/
Compile tested.
Signed-off-by: Paolo Ciarrocchi <[EMAIL PROTECTED]>
---
drivers/ide/pci/opti621.c | 50 ++--
1 files changed, 25 insertions(+), 25 deletions(-)
diff --git a/drivers/ide/pci/opti621.c b/drivers/ide/pci/opti621.c
index cfd46ae..3
Bart,
here is a new series of patches that remove some errors
and warnings reported by checkpatch.pl from the IDE subsystem.
All the patches have been compile tested and are against this morning (CET time
:-)
linux-next
Paolo Ciarrocchi (6):
IDE: Coding Style fixes to drivers/ide/pci
> | -/**
> | +/*
> ^^^
>
> Hi Paolo, it seems you just broke kdoc structure
thank you for your comment, i didn't know that.
Won't happen in future patches.
Bart, can you fix that or do you want me to re-create the series?
Ciao,
--
Paolo
http://paolo.ciarrocchi.googlepages.com/
--
To unsubscri
File is now error and warning free.
Compile tested.
Signed-off-by: Paolo Ciarrocchi <[EMAIL PROTECTED]>
---
drivers/ide/pci/tc86c001.c | 28 ++--
1 files changed, 14 insertions(+), 14 deletions(-)
diff --git a/drivers/ide/pci/tc86c001.c b/drivers/ide/pci/tc86
On Sat, Feb 23, 2008 at 3:04 PM, Paolo Ciarrocchi
<[EMAIL PROTECTED]> wrote:
> Hi Bartlomiej,
> The following 10 patches remove a huge number of errors and warnings
> reported by checkpatch.pl from the IDE subsystem.
>
> All the patches have been compile tested.
I forgo
File is now error free.
Compile tested.
Signed-off-by: Paolo Ciarrocchi <[EMAIL PROTECTED]>
---
drivers/ide/pci/jmicron.c |3 +--
1 files changed, 1 insertions(+), 2 deletions(-)
diff --git a/drivers/ide/pci/jmicron.c b/drivers/ide/pci/jmicron.c
index 440266f..673f7dc 100644
--- a/d
File is now error free, only 1 warning left.
Compile tested.
Signed-off-by: Paolo Ciarrocchi <[EMAIL PROTECTED]>
---
drivers/ide/pci/slc90e66.c |6 +++---
1 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/ide/pci/slc90e66.c b/drivers/ide/pci/slc90e66.c
index 2
File is now error free.
Compile tested.
Signed-off-by: Paolo Ciarrocchi <[EMAIL PROTECTED]>
---
drivers/ide/pci/generic.c | 50 ++--
1 files changed, 25 insertions(+), 25 deletions(-)
diff --git a/drivers/ide/pci/generic.c b/drivers/ide/pci/gen
Lot of errors and warnings removed.
Compile tested.
Signed-off-by: Paolo Ciarrocchi <[EMAIL PROTECTED]>
---
drivers/ide/ide-proc.c | 175 +++
1 files changed, 86 insertions(+), 89 deletions(-)
diff --git a/drivers/ide/ide-proc.c b/drivers/i
File is now error and warning free.
Compile tested.
Signed-off-by: Paolo Ciarrocchi <[EMAIL PROTECTED]>
---
drivers/ide/legacy/ide-4drives.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/ide/legacy/ide-4drives.c b/drivers/ide/legacy/ide-4drives.c
File is now error free.
Compile tested.
Signed-off-by: Paolo Ciarrocchi <[EMAIL PROTECTED]>
---
drivers/ide/ide-pnp.c | 10 +-
1 files changed, 5 insertions(+), 5 deletions(-)
diff --git a/drivers/ide/ide-pnp.c b/drivers/ide/ide-pnp.c
index c125b05..479663d 100644
--- a/drive
File is now error free.
Compile tested.
Signed-off-by: Paolo Ciarrocchi <[EMAIL PROTECTED]>
---
drivers/ide/setup-pci.c | 45 -
1 files changed, 20 insertions(+), 25 deletions(-)
diff --git a/drivers/ide/setup-pci.c b/drivers/ide/setup-pci.c
File is now error free.
Compile tested.
Signed-off-by: Paolo Ciarrocchi <[EMAIL PROTECTED]>
---
drivers/ide/legacy/umc8672.c | 53 -
1 files changed, 26 insertions(+), 27 deletions(-)
diff --git a/drivers/ide/legacy/umc8672.c b/drivers/ide/
About 300 errors and warnings fixed.
File is now error free.
Compile tested.
Signed-off-by: Paolo Ciarrocchi <[EMAIL PROTECTED]>
---
drivers/ide/pci/sis5513.c | 190 ++---
1 files changed, 93 insertions(+), 97 deletions(-)
diff --git a/drivers/i
Hi Bartlomiej,
The following 10 patches remove a huge number of errors and warnings
reported by checkpatch.pl from the IDE subsystem.
All the patches have been compile tested.
Paolo Ciarrocchi (10):
IDE: Coding Style fixes to drivers/ide/pci/sis5513.c
IDE: Coding Style fixes to
On Mon, Jan 28, 2008 at 4:13 PM, Paolo Ciarrocchi
<[EMAIL PROTECTED]> wrote:
>
> On Jan 28, 2008 3:56 PM, Andy Whitcroft <[EMAIL PROTECTED]> wrote:
> > On Mon, Jan 14, 2008 at 11:29:13PM +0100, Paolo Ciarrocchi wrote:
> > > Hi Andy,
> > > When I star
File is now error and warning free.
Compile tested.
Signed-off-by: Paolo Ciarrocchi <[EMAIL PROTECTED]>
---
arch/x86/oprofile/nmi_timer_int.c |6 +++---
1 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/arch/x86/oprofile/nmi_timer_int.c
b/arch/x86/oprofile/nmi_timer
File is now error free.
Compile tested.
Signed-off-by: Paolo Ciarrocchi <[EMAIL PROTECTED]>
---
arch/x86/xen/multicalls.c |4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/x86/xen/multicalls.c b/arch/x86/xen/multicalls.c
index 5e6f36f..5791eb2 100644
---
File is now error and warning free.
Compile tested.
Signed-off-by: Paolo Ciarrocchi <[EMAIL PROTECTED]>
---
arch/x86/kernel/msr.c |4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/x86/kernel/msr.c b/arch/x86/kernel/msr.c
index af51ea8..4dfb405 100644
---
File is now error free.
Compile tested.
Signed-off-by: Paolo Ciarrocchi <[EMAIL PROTECTED]>
---
arch/x86/kernel/acpi/sleep.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/arch/x86/kernel/acpi/sleep.c b/arch/x86/kernel/acpi/sleep.c
index 6bc815c..dd78326 100644
File is now error free.
Compile tested.
Signed-off-by: Paolo Ciarrocchi <[EMAIL PROTECTED]>
---
arch/x86/kernel/cpu/cyrix.c | 115 +--
1 files changed, 57 insertions(+), 58 deletions(-)
diff --git a/arch/x86/kernel/cpu/cyrix.c b/arch/x86/kern
File is now error free.
Compile tested.
Signed-off-by: Paolo Ciarrocchi <[EMAIL PROTECTED]>
---
arch/x86/kernel/cpu/mcheck/mce_32.c | 50 +-
1 files changed, 25 insertions(+), 25 deletions(-)
diff --git a/arch/x86/kernel/cpu/mcheck/mce_32.c
b/arch/x86/
File is now error and warning free.
Compile tested.
Signed-off-by: Paolo Ciarrocchi <[EMAIL PROTECTED]>
---
arch/x86/boot/cpucheck.c | 20 ++--
1 files changed, 10 insertions(+), 10 deletions(-)
diff --git a/arch/x86/boot/cpucheck.c b/arch/x86/boot/cpucheck.c
index 7
File is now error and warning free.
Compile tested.
Signed-off-by: Paolo Ciarrocchi <[EMAIL PROTECTED]>
---
arch/x86/kernel/cpu/mcheck/winchip.c |8
1 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/arch/x86/kernel/cpu/mcheck/winchip.c
b/arch/x86/kernel/cpu/
Fix plenty of errors and warnings.
Compile tested.
Signed-off-by: Paolo Ciarrocchi <[EMAIL PROTECTED]>
---
arch/x86/kernel/vm86_32.c | 174 +++--
1 files changed, 89 insertions(+), 85 deletions(-)
diff --git a/arch/x86/kernel/vm86_32.c b/arch/x86/
File is now error and warning free.
Compile tested.
Signed-off-by: Paolo Ciarrocchi <[EMAIL PROTECTED]>
---
arch/x86/kernel/cpu/mcheck/non-fatal.c | 21 -
1 files changed, 12 insertions(+), 9 deletions(-)
diff --git a/arch/x86/kernel/cpu/mcheck/non-fatal.c
b/ar
File is now error free.
Compile tested.
Signed-off-by: Paolo Ciarrocchi <[EMAIL PROTECTED]>
---
arch/x86/kernel/cpu/transmeta.c | 22 --
1 files changed, 12 insertions(+), 10 deletions(-)
diff --git a/arch/x86/kernel/cpu/transmeta.c b/arch/x86/kernel/cpu/transmeta.c
File is now error free.
Compile tested.
Signed-off-by: Paolo Ciarrocchi <[EMAIL PROTECTED]>
---
arch/x86/kernel/cpu/amd.c | 94 +++--
1 files changed, 48 insertions(+), 46 deletions(-)
diff --git a/arch/x86/kernel/cpu/amd.c b/arch/x86/kernel/cpu
File is now error and warning free.
Compile tested.
Signed-off-by: Paolo Ciarrocchi <[EMAIL PROTECTED]>
---
arch/x86/lib/memcpy_32.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/arch/x86/lib/memcpy_32.c b/arch/x86/lib/memcpy_32.c
index 37756b6..5415a9d 100644
File is now error free.
Compile tested.
Signed-off-by: Paolo Ciarrocchi <[EMAIL PROTECTED]>
---
arch/x86/kernel/cpu/mtrr/state.c | 14 --
1 files changed, 8 insertions(+), 6 deletions(-)
diff --git a/arch/x86/kernel/cpu/mtrr/state.c b/arch/x86/kernel/cpu/mtrr/state.c
File is now error free
Compile tested.
Signed-off-by: Paolo Ciarrocchi <[EMAIL PROTECTED]>
---
arch/x86/kernel/mca_32.c | 96 +
1 files changed, 53 insertions(+), 43 deletions(-)
diff --git a/arch/x86/kernel/mca_32.c b/arch/x86/kernel/mc
File is now error free.
Compile tested.
Signed-off-by: Paolo Ciarrocchi <[EMAIL PROTECTED]>
---
arch/x86/oprofile/init.c | 13 +++--
1 files changed, 7 insertions(+), 6 deletions(-)
diff --git a/arch/x86/oprofile/init.c b/arch/x86/oprofile/init.c
index 5341d48..cdfe4c5 100644
File is now error free.
Compile tested.
Signed-off-by: Paolo Ciarrocchi <[EMAIL PROTECTED]>
---
arch/x86/lib/strstr_32.c |4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/x86/lib/strstr_32.c b/arch/x86/lib/strstr_32.c
index a3dafbf..42e8a50 100644
--- a/ar
File is now error free.
Compile tested
Signed-off-by: Paolo Ciarrocchi <[EMAIL PROTECTED]>
---
arch/x86/kernel/cpu/intel.c | 83 ++
1 files changed, 43 insertions(+), 40 deletions(-)
diff --git a/arch/x86/kernel/cpu/intel.c b/arch/x86/kern
Signed-off-by: Paolo Ciarrocchi <[EMAIL PROTECTED]>
---
arch/x86/boot/pm.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/arch/x86/boot/pm.c b/arch/x86/boot/pm.c
index 1a0f936..a93cb8b 100644
--- a/arch/x86/boot/pm.c
+++ b/arch/x86/boot/pm.c
@@ -100,7 +100,7 @@
File is now error free.
Signed-off-by: Paolo Ciarrocchi <[EMAIL PROTECTED]>
---
arch/x86/kernel/summit_32.c | 43 +++
1 files changed, 23 insertions(+), 20 deletions(-)
diff --git a/arch/x86/kernel/summit_32.c b/arch/x86/kernel/summit_32.c
Various coding style fixes.
Paolo Ciarrocchi (20):
x86: Coding Style fix to arch/x86/boot/pm.c
x86: Coding Style fixes to arch/x86/kernel/summit_32.c
x86: Coding Style fixes to arch/x86/kernel/cpu/intel.c
x86: Coding Style fixes to arch/x86/oprofile/init.c
x86
Fix lot of errors and warnings.
Compile tested.
Signed-off-by: Paolo Ciarrocchi <[EMAIL PROTECTED]>
---
arch/x86/boot/compressed/misc.c | 66 ---
1 files changed, 34 insertions(+), 32 deletions(-)
diff --git a/arch/x86/boot/compressed/misc.c b/ar
After the patch:
total: 0 errors, 0 warnings, 25 lines checked
arch/x86/kernel/cpu/umc.c has no obvious style problems and is ready for
submission.
Compile tested.
Signed-off-by: Paolo Ciarrocchi <[EMAIL PROTECTED]>
---
arch/x86/kernel/cpu/umc.c | 12 +++-
1 files chan
Hopefully this time the patches will reach the list :-)
After the patch:
total: 0 errors, 0 warnings, 122 lines checked
arch/x86/kernel/cpu/mcheck/p6.c has no obvious style problems and is ready for
submission.
Compile tested.
Signed-off-by: Paolo Ciarrocchi <[EMAIL PROTECTED]>
---
ar
On Feb 20, 2008 9:58 AM, Ingo Molnar <[EMAIL PROTECTED]> wrote:
>
> * Paolo Ciarrocchi <[EMAIL PROTECTED]> wrote:
>
> > - for (i = 0; apic_probe[i]; ++i) {
> > - if (apic_probe[i]->mps_oem_check(mpc,oem,productid)) {
> > + for (i = 0;
On Feb 14, 2008 2:35 PM, Stephen Rothwell <[EMAIL PROTECTED]> wrote:
> Hi all,
>
> I have created the first cut of the linux-next tree at
Hi Stephen,
I would like to update the "The development process" section in
Documentation/HOWTO including some information about the linux-next tree.
I underst
On 2/18/08, Ingo Molnar <[EMAIL PROTECTED]> wrote:
> * Paolo Ciarrocchi <[EMAIL PROTECTED]> wrote:
>
> > > /*
> > > - * Set up an actual MCR
> > > + * Set up an actual MCR
> > > */
> >
> > This was not highlighted by checkp
On Feb 18, 2008 3:56 AM, Ingo Molnar <[EMAIL PROTECTED]> wrote:
>
> * Paolo Ciarrocchi <[EMAIL PROTECTED]> wrote:
>
> > [PATCH] x86: Coding style fixes for arch/x86/kernel/cpu/centaur.c
> >
> > Kills more than 150 errors/warnings
>
> thanks Paolo, appl
On 2/17/08, Ingo Molnar <[EMAIL PROTECTED]> wrote:
>
> * Paolo Ciarrocchi <[EMAIL PROTECTED]> wrote:
>
> > [PATCH 2/2] x86: coding style fixes arch/x86/lib/csum-wrappers_64.c
> >
> > On top of the previous patch makes the file errors free according to
>
[PATCH 2/2] x86: coding style fixes arch/x86/lib/csum-wrappers_64.c
On top of the previous patch makes the file errors free according to
checkpatch.pl
Signed-off-by: Paolo Ciarrocchi <[EMAIL PROTECTED]>
---
arch/x86/lib/csum-wrappers_64.c |9 -
1 files changed, 4 insertions
[PATCH 1/2] x86: whitespaces fixes in arch/x86/lib/csum-wrappers_64.c
Signed-off-by: Paolo Ciarrocchi <[EMAIL PROTECTED]>
---
arch/x86/lib/csum-wrappers_64.c | 77 ---
1 files changed, 39 insertions(+), 38 deletions(-)
diff --git a/arch/x86/li
[PATCH] x86: coding style fixes in arch/x86/lib/io_64.c
This simple patch makes the file error free (according to
checkpatch.pl)
Signed-off-by: Paolo Ciarrocchi <[EMAIL PROTECTED]>
---
arch/x86/lib/io_64.c | 10 +-
1 files changed, 5 insertions(+), 5 deletions(-)
diff --git
On 1/29/08, Paolo Ciarrocchi <[EMAIL PROTECTED]> wrote:
> Hi all,
> this patch series implements a few clean up suggested by
> checkpatch.pl
>
> I compiled tested every single patch and verified that
> the clean up only patches are not modifying the md5sum of
> the relat
On 1/29/08, Joe Perches <[EMAIL PROTECTED]> wrote:
> On Tue, 2008-01-29 at 00:08 +0100, Paolo Ciarrocchi wrote:
> > \diff --git a/arch/x86/math-emu/errors.c b/arch/x86/math-emu/errors.c
> > index 6102fe0..569a62e 100644
> > --- a/arch/x86/math-emu/errors.c
> >
On 1/29/08, Stefan Richter <[EMAIL PROTECTED]> wrote:
> Paolo Ciarrocchi wrote:
> > --- a/arch/x86/math-emu/errors.c
> > +++ b/arch/x86/math-emu/errors.c
> > @@ -75,7 +75,8 @@ void FPU_printall(void)
> > FPU_get_user(FPU_modrm, 1 + (u_char __user *) addr
fix lines over 80 characters
Signed-off-by: Paolo Ciarrocchi <[EMAIL PROTECTED]>
---
arch/x86/math-emu/errors.c |6 --
1 files changed, 4 insertions(+), 2 deletions(-)
diff --git a/arch/x86/math-emu/errors.c b/arch/x86/math-emu/errors.c
index 569a62e..e5a5b80 100644
--- a/arch/x8
include missing KERN_ facility level
Signed-off-by: Paolo Ciarrocchi <[EMAIL PROTECTED]>
---
arch/x86/math-emu/errors.c | 52 ++--
1 files changed, 26 insertions(+), 26 deletions(-)
diff --git a/arch/x86/math-emu/errors.c b/arch/x86/math-emu/er
Fix plenty of "That open brace { should be on the previous line"
Signed-off-by: Paolo Ciarrocchi <[EMAIL PROTECTED]>
---
arch/x86/math-emu/errors.c | 137 +++-
1 files changed, 47 insertions(+), 90 deletions(-)
diff --git a/arch/x86/mat
Fix space related errors
Signed-off-by: Paolo Ciarrocchi <[EMAIL PROTECTED]>
---
arch/x86/math-emu/errors.c | 134 ++--
1 files changed, 67 insertions(+), 67 deletions(-)
diff --git a/arch/x86/math-emu/errors.c b/arch/x86/math-emu/errors.c
index 4
Fix trailing statements should be on next line
Signed-off-by: Paolo Ciarrocchi <[EMAIL PROTECTED]>
---
arch/x86/math-emu/errors.c | 39 ++-
1 files changed, 26 insertions(+), 13 deletions(-)
diff --git a/arch/x86/math-emu/errors.c b/arch/x86/ma
Clean up comments
Signed-off-by: Paolo Ciarrocchi <[EMAIL PROTECTED]>
---
arch/x86/math-emu/errors.c | 144 ++--
1 files changed, 72 insertions(+), 72 deletions(-)
diff --git a/arch/x86/math-emu/errors.c b/arch/x86/math-emu/errors.c
index e
Remove dead code
Signed-off-by: Paolo Ciarrocchi <[EMAIL PROTECTED]>
---
arch/x86/math-emu/errors.c | 37 -
1 files changed, 0 insertions(+), 37 deletions(-)
diff --git a/arch/x86/math-emu/errors.c b/arch/x86/math-emu/errors.c
index a1b0d22..ece95cd
Hi all,
this patch series implements a few clean up suggested by
checkpatch.pl
I compiled tested every single patch and verified that
the clean up only patches are not modifying the md5sum of
the relative .o file.
Before the patches:
total: 214 errors, 28 warnings, 739 lines checked
After:
tota
On Jan 28, 2008 3:56 PM, Andy Whitcroft <[EMAIL PROTECTED]> wrote:
> On Mon, Jan 14, 2008 at 11:29:13PM +0100, Paolo Ciarrocchi wrote:
> > Hi Andy,
> > When I started using checkpatch I was confused by the following WARN
> > message:
> >
> >
On Jan 27, 2008 11:48 PM, Paolo Ciarrocchi <[EMAIL PROTECTED]> wrote:
>
> On Jan 27, 2008 11:42 PM, Ingo Molnar <[EMAIL PROTECTED]> wrote:
> >
> > * Dmitri Vorobiev <[EMAIL PROTECTED]> wrote:
> >
> > > Looks like it would be better to proceed
On Jan 27, 2008 11:42 PM, Ingo Molnar <[EMAIL PROTECTED]> wrote:
>
> * Dmitri Vorobiev <[EMAIL PROTECTED]> wrote:
>
> > Looks like it would be better to proceed in the following manner:
> >
> > 1) remove dead code (no md5 change);
> > 2) reformat the lines to use tabs, not spaces (no md5 change);
>
On Jan 27, 2008 11:32 PM, Dmitri Vorobiev <[EMAIL PROTECTED]> wrote:
[..]
>
> Is there any point in changing code inside the #if 0/#endif block?
Just to avoid checkpatch complaints :-)
> > @@ -76,10 +74,10 @@ void Un_impl(void)
> > /*
> > Called for opcodes which are illegal and which are kn
the md5sum difference?
Signed-off-by: Paolo Ciarrocchi <[EMAIL PROTECTED]>
---
The only remaining errors are like the following:
ERROR: need consistent spacing around '*' (ctx:WxB)
#110: FILE: errors.c:110:
+ FPU_get_user(FPU_modrm, 1 + (u_char _
On Jan 27, 2008 10:45 PM, Dmitri Vorobiev <[EMAIL PROTECTED]> wrote:
> > - math_abort(FPU_info,SIGILL);
> > + math_abort(FPU_info , SIGILL);
>
> Looks like you're trading bad for worse here.
Should I make it read like math_abort(FPU_info, SIGILL); ?
>
> > }
> >
> >
> > @@ -88,61 +86,69 @@ void
dec hex filename
3476 0 03476 d94 error.o.after
3476 0 03476 d94 error.o.before
Signed-off-by: Paolo Ciarrocchi <[EMAIL PROTECTED]>
---
The only remaining errors are like the following:
ERROR: need consistent spacing around '*'
On Jan 14, 2008 11:23 PM, Paolo Ciarrocchi <[EMAIL PROTECTED]> wrote:
> Add a filename option (default to 0)
> in order to get the following summary output:
> ./scripts/checkpatch.pl --filename --file ./arch/sparc/kernel/apc.c
> ...
> ...
> ...
> ./arch/sparc/kernel/ap
On 1/15/08, Cyrill Gorcunov <[EMAIL PROTECTED]> wrote:
> [Paolo Ciarrocchi - Mon, Jan 14, 2008 at 11:23:39PM +0100]
> Hi Paolo,
>
> the options you're complaining about (in most) are enabled by default so
> there is no reason to 'turn them on' explicitly /
Hi Andy,
When I started using checkpatch I was confused by the following WARN message:
no space between function name and open parenthesis
I thought the problem was that a space was missing while the truth is the
opposite.
How about the following patch?
--- checkpatch.pl.old 2008-01
Add a filename option (default to 0)
in order to get the following summary output:
./scripts/checkpatch.pl --filename --file ./arch/sparc/kernel/apc.c
...
...
...
./arch/sparc/kernel/apc.c --> total: 18 errors, 3 warnings, 186 lines checked
---
Andy,
I wonder why checkpatch doesn't show all the
On Jan 14, 2008 6:30 PM, Andy Whitcroft <[EMAIL PROTECTED]> wrote:
> On Sun, Jan 13, 2008 at 11:34:05PM +0100, Paolo Ciarrocchi wrote:
> > With the patch applied the output of checkpatch.pl is as follow:
> > ./arch/arm/mach-footbridge/ebsa285-pci.c
> > total: 1 errors, 0
though it might me useful for other purposes to add the file name
after the list of errors and warnings and before the summary,
when the list is long I find handy to print out the filename as a reminder.
Signed-off-by: Paolo Ciarrocchi <[EMAIL PROTECTED]>
diff --git a/scripts/checkpatc
On Jan 11, 2008 12:08 AM, Daniel Walker <[EMAIL PROTECTED]> wrote:
> The git logs also show that arch/x86/math-emu/fpu_trig.c hasn't been
> modified since it was pull in on Oct. 11 ..
Daniel,
are we looking at the same tree?
fpu_trig.c has been modified (and cleaned up) by Ingo 35 hours ago:
http
On Jan 11, 2008 12:30 AM, Paolo Ciarrocchi <[EMAIL PROTECTED]> wrote:
>
> On Jan 11, 2008 12:08 AM, Daniel Walker <[EMAIL PROTECTED]> wrote:
> >
> > On Thu, 2008-01-10 at 23:35 +0100, Paolo Ciarrocchi wrote:
> > > On Jan 10, 2008 9:03 PM,
On Jan 11, 2008 12:08 AM, Daniel Walker <[EMAIL PROTECTED]> wrote:
>
> On Thu, 2008-01-10 at 23:35 +0100, Paolo Ciarrocchi wrote:
> > On Jan 10, 2008 9:03 PM, Daniel Walker <[EMAIL PROTECTED]> wrote:
> > >
> > >
> > > I was playing with c
Fix some codying style errors in ./arch/x86/math-emu/reg_ld_str.c
total: 4 errors, 31 warnings, 1223 lines checked
patch is against a x86 which I pulled a few minutes ago.
Signed-off-by: Paolo Ciarrocchi <[EMAIL PROTECTED]>
---
arch/x86/math-emu/reg_ld_str.c | 25 --
On Jan 10, 2008 11:41 PM, Daniel Walker <[EMAIL PROTECTED]> wrote:
>
> On Thu, 2008-01-10 at 23:35 +0100, Paolo Ciarrocchi wrote:
> > On Jan 10, 2008 9:03 PM, Daniel Walker <[EMAIL PROTECTED]> wrote:
> > >
> > >
> > > I was playing with c
On Jan 10, 2008 9:03 PM, Daniel Walker <[EMAIL PROTECTED]> wrote:
>
>
> I was playing with checkpatch.pl ;) .. I made a list of style offenders
> inside the arch/x86/ sub-directory. I thought it might be helpful to
> prioritize any style clean ups that people might want to do for x86 ..
> OTOH some
On 1/10/08, Andi Kleen <[EMAIL PROTECTED]> wrote:
> I'm already cloning the branches; the problem is not getting conflicts etc.
> when updating.
Isn't git pull --force what you are looking for?
Ciao,
--
Paolo
http://paolo.ciarrocchi.googlepages.com/
--
To unsubscribe from this list: send the li
On Jan 9, 2008 12:06 AM, Andi Kleen <[EMAIL PROTECTED]> wrote:
> > I would suggest to only work on files that compile. e.g. do a
> >
> > make allyesconfig
> > make -j$[$(grep -c processor /proc/cpuinfo)*2] &1 |tee LOG
> > (will probably take a long time)
> >
> > first and then only mod
Simple coding style fixes.
Signed-off-by: Paolo Ciarrocchi <[EMAIL PROTECTED]>
---
arch/x86/pci/fixup.c | 30 +++---
1 files changed, 15 insertions(+), 15 deletions(-)
diff --git a/arch/x86/pci/fixup.c b/arch/x86/pci/fixup.c
index 6cff66d..cb63007 100644
---
Simple coding style fixes.
Signed-off-by: Paolo Ciarrocchi <[EMAIL PROTECTED]>
---
arch/x86/pci/acpi.c |4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/x86/pci/acpi.c b/arch/x86/pci/acpi.c
index 0234f28..c3c9cbf 100644
--- a/arch/x86/pci/acpi.c
+++ b/arch/x
Simple coding style fixes.
File is now "error" free according to checkpatch.pl
Signed-off-by: Paolo Ciarrocchi <[EMAIL PROTECTED]>
---
arch/x86/pci/direct.c | 10 +-
1 files changed, 5 insertions(+), 5 deletions(-)
diff --git a/arch/x86/pci/direct.c b/arch/x86/pc
1 - 100 of 165 matches
Mail list logo
