On Jan 11, 2008 12:30 AM, Paolo Ciarrocchi <[EMAIL PROTECTED]> wrote: > > On Jan 11, 2008 12:08 AM, Daniel Walker <[EMAIL PROTECTED]> wrote: > > > > On Thu, 2008-01-10 at 23:35 +0100, Paolo Ciarrocchi wrote: > > > On Jan 10, 2008 9:03 PM, Daniel Walker <[EMAIL PROTECTED]> wrote: > > > > > > > > > > > > I was playing with checkpatch.pl ;) .. I made a list of style offenders > > > > inside the arch/x86/ sub-directory. I thought it might be helpful to > > > > prioritize any style clean ups that people might want to do for x86 .. > > > > OTOH some of these might show imperfections in checkpatch.pl .. Either > > > > way I thought it was interesting to review .. > > > > > > > > These are sorted by errors, then warnings.. I only included the first > > > > hundred files which includes about the top %30 of the list .. The > > > > kprobes_64.c error rate is a little miss-leading because several errors > > > > are found on a single line .. > > > > > > I just pulled > > > git://git.kernel.org/pub/scm/linux/kernel/git/x86/linux-2.6-x86 mm > > > > > > > ./arch/x86/math-emu/fpu_trig.c > > > > total: 649 errors, 11 warnings, 1845 lines checked > > > > > > On that tree checkpatch reports: > > > total: 5 errors, 54 warnings, 1643 lines checked > > > > > > > ./arch/x86/kernel/kprobes_64.c > > > > total: 528 errors, 9 warnings, 749 lines checked > > > > > > total: 0 errors, 0 warnings, 1 lines checked > > > > I pulled the tree your working with , and it's got mostly the same > > issues .. Are you sure your running the commands properly? > > > > The "lines checked" values that you listed looks wrong .. A few you > > listed as "0 lines checked" , or "1 lines checked" .. Which can't be > > right.. > > > > The git logs also show that arch/x86/math-emu/fpu_trig.c hasn't been > > modified since it was pull in on Oct. 11 .. > > Top commit in my tree is: > commit 62ba5681e2e2d70794719794eadb441875e6d3b3 > Author: From: Jan Beulich <[EMAIL PROTECTED]> > Date: Wed Jan 9 13:31:14 2008 +0100 > > > [EMAIL PROTECTED]:~/linux-2.6$ ./scripts/checkpatch.pl --file > ./arch/x86/kernel/kprobes_64.c > total: 0 errors, 0 warnings, 1 lines checked > > [EMAIL PROTECTED]:~/linux-2.6$ ls -l ./arch/x86/kernel/k* > -rw-r--r-- 1 paolo paolo 2853 2007-11-08 23:00 ./arch/x86/kernel/k8.c > -rw-r--r-- 1 paolo paolo 1207 2008-01-10 23:27 ./arch/x86/kernel/kdebugfs.c > -rw-r--r-- 1 paolo paolo 9828 2008-01-10 23:27 ./arch/x86/kernel/kgdb_32.c > -rw-r--r-- 1 paolo paolo 11936 2008-01-10 23:27 ./arch/x86/kernel/kgdb_64.c > -rw-r--r-- 1 paolo paolo 2223 2008-01-10 23:27 > ./arch/x86/kernel/kgdb-jmp_32.S > -rw-r--r-- 1 paolo paolo 1783 2008-01-10 23:27 > ./arch/x86/kernel/kgdb-jmp_64.S > -rw-r--r-- 1 paolo paolo 1 2008-01-10 23:27 > ./arch/x86/kernel/kprobes_64.c <-- What? > -rw-r--r-- 1 paolo paolo 32078 2008-01-10 23:27 ./arch/x86/kernel/kprobes.c > > I've pulled the tree as follow: > git branch x86 > git checkout x86 > git-pull --force > git://git.kernel.org/pub/scm/linux/kernel/git/x86/linux-2.6-x86.git mm > > I tried to pull again and I've got: > [EMAIL PROTECTED]:~/linux-2.6$ git-pull --force > git://git.kernel.org/pub/scm/linux/kernel/git/x86/linux-2.6-x86.git mm > Already up-to-date. > > gitweb seems to confirm what I'm seeing: > http://git.kernel.org/?p=linux/kernel/git/x86/linux-2.6-x86.git;a=shortlog;h=mm > http://git.kernel.org/?p=linux/kernel/git/x86/linux-2.6-x86.git;a=blob_plain;f=arch/x86/kernel/kprobes_64.c;hb=mm > which is an empty file
That's the result of the kprobe unification: http://git.kernel.org/?p=linux/kernel/git/x86/linux-2.6-x86.git;a=commitdiff;h=17735e04f7f18bea4dcbe4daa31c34acac55b332 Ciao, -- Paolo http://paolo.ciarrocchi.googlepages.com/ -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
