Re: [PATCH v3] net/ipv4: add tracepoint for icmp_send

2024-03-22 Thread Denis Kirjanov
On 3/21/24 05:10, xu.xi...@zte.com.cn wrote: > From: he peilin > > Introduce a tracepoint for icmp_send, which can help users to get more > detail information conveniently when icmp abnormal events happen. > > 1. Giving an usecase example: > = > When an application

Re: [PATCH net] ipvs: Simplify the allocation of ip_vs_conn slab caches

2024-01-17 Thread Denis Kirjanov
On 1/17/24 10:20, Kunwu Chan wrote: > Use the new KMEM_CACHE() macro instead of direct kmem_cache_create > to simplify the creation of SLAB caches. > > Signed-off-by: Kunwu Chan The patch is actually for net-next > --- > net/netfilter/ipvs/ip_vs_conn.c | 4 +--- > 1 file changed, 1 inserti

Re: [PATCH] fs: export kern_path_locked

2021-02-16 Thread Denis Kirjanov
On 2/14/21, Al Viro wrote: > On Fri, Jan 29, 2021 at 01:18:55PM +, Christoph Hellwig wrote: >> On Fri, Jan 29, 2021 at 04:11:05PM +0300, Denis Kirjanov wrote: >> > Do you mean just: >> >> We'll still need to lock the parent inode. > > Not just "

[PATCH] fs: export kern_path_locked

2021-01-25 Thread Denis Kirjanov
the function is used outside and we have a prototype defined in namei.h Signed-off-by: Denis Kirjanov --- fs/namei.c | 1 + 1 file changed, 1 insertion(+) diff --git a/fs/namei.c b/fs/namei.c index 78443a85480a..3de3b3642302 100644 --- a/fs/namei.c +++ b/fs/namei.c @@ -2450,6 +2450,7 @@ struct

Re: [net/af_unix] 556d816147: WARNING:lock_held_when_returning_to_user_space

2020-12-01 Thread Denis Kirjanov
knod() should be fixed as well. I'll send a next version shortly. Thanks! > url: > https://github.com/0day-ci/linux/commits/Denis-Kirjanov/net-af_unix-don-t-create-a-path-for-a-binded-socket/20201130-213012 > base: https://git.kernel.org/cgit/linux/kernel/git/davem/net.git > 4d5

Re: [PATCH v3 2/2] powerpc/pseries: pass MSI affinity to irq_create_mapping()

2020-11-25 Thread Denis Kirjanov
On 11/25/20, Laurent Vivier wrote: > With virtio multiqueue, normally each queue IRQ is mapped to a CPU. > > But since commit 0d9f0a52c8b9f ("virtio_scsi: use virtio IRQ affinity") > this is broken on pseries. Please add "Fixes" tag. Thanks! > > The affinity is correctly computed in msi_desc bu

Re: [PATCH net v2] net: emaclite: Add error handling for of_address_ and _mdio_setup functions

2020-11-17 Thread Denis Kirjanov
On 11/17/20, Radhey Shyam Pandey wrote: > From: Shravya Kumbham > > Add ret variable, condition to check the return value and error > path for the of_address_to_resource() function. It also adds error > handling for mdio setup and decrement refcount of phy node. > > Addresses-Coverity: Event chec

Re: [PATCH] xsk: add cq event

2020-11-16 Thread Denis Kirjanov
On 11/16/20, Denis Kirjanov wrote: > On 11/16/20, Xuan Zhuo wrote: >> On Mon, 16 Nov 2020 12:13:21 +0300, Denis Kirjanov >> >> wrote: >>> On 11/16/20, Xuan Zhuo wrote: >>> > When we write all cq items to tx, we have to wait for a new event >&g

Re: [PATCH] xsk: add cq event

2020-11-16 Thread Denis Kirjanov
On 11/16/20, Xuan Zhuo wrote: > On Mon, 16 Nov 2020 12:13:21 +0300, Denis Kirjanov > wrote: >> On 11/16/20, Xuan Zhuo wrote: >> > When we write all cq items to tx, we have to wait for a new event based >> > on poll to indicate that it is writable. But the current

Re: [PATCH] xsk: add cq event

2020-11-16 Thread Denis Kirjanov
On 11/16/20, Xuan Zhuo wrote: > When we write all cq items to tx, we have to wait for a new event based > on poll to indicate that it is writable. But the current writability is > triggered based on whether tx is full or not, and In fact, when tx is > dissatisfied, the user of cq's item may not ne

Re: [PATCH] bpf: Fix unsigned 'datasec_id' compared with zero in check_pseudo_btf_id

2020-11-10 Thread Denis Kirjanov
On 11/10/20, xiakaixu1...@gmail.com wrote: > From: Kaixu Xia > > The unsigned variable datasec_id is assigned a return value from the call > to check_pseudo_btf_id(), which may return negative error code. > > Fixes coccicheck warning: > > ./kernel/bpf/verifier.c:9616:5-15: WARNING: Unsigned expre

Re: [PATCH v2 06/11] sundance: use generic power management

2020-07-08 Thread Denis Kirjanov
On 7/3/20, Denis Kirjanov wrote: > On 7/1/20, Vaibhav Gupta wrote: >> With legacy PM, drivers themselves were responsible for managing the >> device's power states and takes care of register states. >> >> After upgrading to the generic structure, PCI core will ta

Re: [PATCH v2 06/11] sundance: use generic power management

2020-07-03 Thread Denis Kirjanov
On 7/1/20, Vaibhav Gupta wrote: > With legacy PM, drivers themselves were responsible for managing the > device's power states and takes care of register states. > > After upgrading to the generic structure, PCI core will take care of > required tasks and drivers should do only device-specific ope

Re: [PATCH] staging: fsl-dpaa2: replace simple switch case by if statement

2018-03-21 Thread Denis Kirjanov
On 3/21/18, David Laight wrote: > From: > hariprasath.ela...@gmail.com >> Sent: 21 March 2018 11:16 >> From: HariPrasath Elango >> >> Replace a couple of simple switch cases by if condition > > Why? > In principle extra 'case' might be needed in the future. I had the same question when saw it. I

Re: KASAN: use-after-free Read in sctp_packet_transmit

2018-01-06 Thread Denis Kirjanov
On 1/5/18, syzbot wrote: > Hello, > > syzkaller hit the following crash on > 8a4816cad00bf14642f0ed6043b32d29a05006ce > git://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git/master > compiler: gcc (GCC) 7.1.1 20170620 > .config is attached > Raw console output is attached. > Unfortunate

Re: [PATCH] drivers/net: dlink: Convert timers to use timer_setup()

2017-10-27 Thread Denis Kirjanov
On 10/27/17, Kees Cook wrote: > In preparation for unconditionally passing the struct timer_list pointer to > all timer callbacks, switch to using the new timer_setup() and from_timer() > to pass the timer pointer explicitly. > > Cc: Denis Kirjanov > Cc: net...@vger.kernel.o

Re: [PowerPC][next-20170324][kselftest] kernel Oops when running tm/tm-signal-context-chk-vsx

2017-05-25 Thread Denis Kirjanov
[ 283.516559] Kernel BUG at c191c160 [verbose debug info unavailable] [ 283.516573] Unexpected TM Bad Thing exception at c191c160 (msr 0x2a03030) cpu 0x19: Vector: 700 (Program Check) at [c007d1a37920] pc: c191c160: fast_exception_return+0xac/0xb4 lr: c

Re: [PATCH] tty/hvc_console: fix console lock ordering with spinlock

2017-04-04 Thread Denis Kirjanov
On 4/4/17, Michael Ellerman wrote: > Denis Kirjanov writes: > >> hvc_remove() takes a spin lock first then acquires the console >> semaphore. This situation can easily lead to a deadlock scenario >> where we call scheduler with spin lock held. > > Have you actually

[PATCH] tty/hvc_console: fix console lock ordering with spinlock

2017-03-30 Thread Denis Kirjanov
hvc_remove() takes a spin lock first then acquires the console semaphore. This situation can easily lead to a deadlock scenario where we call scheduler with spin lock held. Signed-off-by: Denis Kirjanov --- drivers/tty/hvc/hvc_console.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions

Re: __link_block_group uses GFP_KERNEL

2017-03-28 Thread Denis Kirjanov
On 3/27/17, David Sterba wrote: > On Sat, Mar 25, 2017 at 09:48:28AM +0300, Denis Kirjanov wrote: >> On 3/25/17, Jeff Mahoney wrote: >> > On 3/24/17 5:02 AM, Denis Kirjanov wrote: >> >> Hi guys, >> >> >> >> Looks like that current code does

Re: __link_block_group uses GFP_KERNEL

2017-03-24 Thread Denis Kirjanov
On 3/25/17, Jeff Mahoney wrote: > On 3/24/17 5:02 AM, Denis Kirjanov wrote: >> Hi guys, >> >> Looks like that current code does GFP_KERNEL allocation inside >> __link_block_group. >> the function invokes kobject_add and internally creates sysfs files >>

__link_block_group uses GFP_KERNEL

2017-03-24 Thread Denis Kirjanov
Hi guys, Looks like that current code does GFP_KERNEL allocation inside __link_block_group. the function invokes kobject_add and internally creates sysfs files with the GFP_KERNEL flag set. But since do_chunk_alloc executes insides the btrfs transaction it's not allowed to sleep. Thanks!

Re: [PATCH 0/2] powerpc: stack protector (-fstack-protector) support

2016-11-18 Thread Denis Kirjanov
On 11/17/16, Michael Ellerman wrote: > Denis Kirjanov writes: > >> On Friday, September 30, 2016, Christophe Leroy >> wrote: >> >>> Add HAVE_CC_STACKPROTECTOR to powerpc. This is copied from ARM. >>> >>> Not tested on PPC64, compile ok with pp

Re: [PATCH net-next 09/15] ethernet/dlink: use core min/max MTU checking

2016-10-18 Thread Denis Kirjanov
On 10/17/16, Jarod Wilson wrote: > dl2k: min_mtu 68, max_mtu 1536 or 8000, depending on hardware > - Removed change_mtu, does nothing productive anymore > > sundance: min_mtu 68, max_mtu 8191 > > CC: net...@vger.kernel.org > CC: Denis Kirjanov > Signed-off-by: Jarod Wils

Re: [PATCHv2 0/7] eBPF JIT for PPC64

2016-06-30 Thread Denis Kirjanov
On 6/30/16, Andreas Ziegler wrote: > Hi Naveen, > > this patchset makes a change to arch/powerpc/net/Makefile in order to only > compile the previously existing bpf_jit_comp.c if !CONFIG_PPC64, and use > bpf_jit_comp64.c if CONFIG_PPC64 is enabled. > > Inside arch/powerpc/net/bpf_jit_comp.c, howev

Re: [PATCH V10 03/28] powerpc, ptrace: Enable in transaction NT_PRFPREG ptrace requests

2016-02-16 Thread Denis Kirjanov
On 2/16/16, Anshuman Khandual wrote: > This patch enables in transaction NT_PRFPREG ptrace requests. > The function fpr_get which gets the running value of all FPR > registers and the function fpr_set which sets the running > value of of all FPR registers work on the running set of FPR > registers

Re: [PATCH 1/2] tracing/mm: don't trace kfree on offline CPUs

2016-02-15 Thread Denis Kirjanov
On 2/15/16, Steven Rostedt wrote: > On Sun, 14 Feb 2016 23:19:42 +0300 > Denis Kirjanov wrote: > > >> >> TP_PROTO(unsigned long call_site, const void *ptr), >> >> >> >> - TP_ARGS(call_site, ptr) >> >> + TP_ARGS(call_site, ptr), >&g

Re: [PATCH v5] powerpc32: provide VIRT_CPU_ACCOUNTING

2016-02-14 Thread Denis Kirjanov
On 2/11/16, Christophe Leroy wrote: > This patch provides VIRT_CPU_ACCOUTING to PPC32 architecture. > PPC32 doesn't have the PACA structure, so we use the task_info > structure to store the accounting data. > > In order to reuse on PPC32 the PPC64 functions, all u64 data has > been replaced by 'un

Re: [PATCH 1/2] tracing/mm: don't trace kfree on offline CPUs

2016-02-14 Thread Denis Kirjanov
On 2/14/16, Steven Rostedt wrote: > On Sat, 13 Feb 2016 21:22:52 +0300 > Denis Kirjanov wrote: > >> -DEFINE_EVENT(kmem_free, kfree, >> +DEFINE_EVENT_CONDITION(kmem_free, kfree, >> >> TP_PROTO(unsigned long call_site, const void *ptr), >> >>

Re: [PATCH 1/2] tracing/mm: don't trace kfree on offline CPUs

2016-02-14 Thread Denis Kirjanov
On 2/14/16, Steven Rostedt wrote: > On Sat, 13 Feb 2016 21:22:52 +0300 > Denis Kirjanov wrote: > >> -DEFINE_EVENT(kmem_free, kfree, >> +DEFINE_EVENT_CONDITION(kmem_free, kfree, >> >> TP_PROTO(unsigned long call_site, const void *ptr), >> >>

Re: [PATCH 2/2] tracing/rcu: don't trace rcu_callback on offline CPUs

2016-02-14 Thread Denis Kirjanov
On 2/14/16, Steven Rostedt wrote: > On Sat, 13 Feb 2016 21:22:53 +0300 > Denis Kirjanov wrote: > >> >> diff --git a/include/trace/events/rcu.h b/include/trace/events/rcu.h >> index ef72c4a..5470f2f 100644 >> --- a/include/trace/events/rcu.h >> +++ b/include

[PATCH v2 1/2] tracing/mm: don't trace kfree on offline CPUs

2016-02-13 Thread Denis Kirjanov
] .cpu_startup_entry+0x50c/0x560 [ 99.749428] [c005b76c7ed0] [c0043bd8] .start_secondary+0x328/0x360 [ 99.749431] [c005b76c7f90] [c0008a6c] start_secondary_prolog+0x10/0x14 Signed-off-by: Denis Kirjanov --- include/trace/events/kmem.h | 15 +-- 1 file changed, 13

[PATCH v2 2/2] tracing/rcu: don't trace rcu_callback on offline CPUs

2016-02-13 Thread Denis Kirjanov
: Denis Kirjanov --- v2: Fix the build error that was made while sending the pacthes from another machine include/trace/events/rcu.h | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/include/trace/events/rcu.h b/include/trace/events/rcu.h index ef72c4a..793d306b 100644 --- a

[PATCH 2/2] tracing/rcu: don't trace rcu_callback on offline CPUs

2016-02-13 Thread Denis Kirjanov
: Denis Kirjanov --- include/trace/events/rcu.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/include/trace/events/rcu.h b/include/trace/events/rcu.h index ef72c4a..5470f2f 100644 --- a/include/trace/events/rcu.h +++ b/include/trace/events/rcu.h @@ -435,6 +435,8 @@ TRACE_EVENT(rcu_callback

[PATCH 1/2] tracing/mm: don't trace kfree on offline CPUs

2016-02-13 Thread Denis Kirjanov
] .cpu_startup_entry+0x50c/0x560 [ 99.749428] [c005b76c7ed0] [c0043bd8] .start_secondary+0x328/0x360 [ 99.749431] [c005b76c7f90] [c0008a6c] start_secondary_prolog+0x10/0x14 Signed-off-by: Denis Kirjanov --- include/trace/events/kmem.h | 15 +-- 1 file changed, 13

Re: [PATCH v5] powerpc32: provide VIRT_CPU_ACCOUNTING

2016-02-12 Thread Denis Kirjanov
On 2/11/16, Christophe Leroy wrote: > This patch provides VIRT_CPU_ACCOUTING to PPC32 architecture. > PPC32 doesn't have the PACA structure, so we use the task_info > structure to store the accounting data. > > In order to reuse on PPC32 the PPC64 functions, all u64 data has > been replaced by 'un

Re: [PATCH v2 1/1] powerpc/86xx: Consolidate common platform code

2016-02-11 Thread Denis Kirjanov
On 2/11/16, Alessio Igor Bogani wrote: > Signed-off-by: Alessio Igor Bogani > --- > v1 -> v2 > Use appropriate [PATCH] prefix > > arch/powerpc/platforms/86xx/Makefile | 2 +- > arch/powerpc/platforms/86xx/common.c | 42 > ++ > arch/powerpc/platforms

Re: [PATCH v4] powerpc32: provide VIRT_CPU_ACCOUNTING

2016-02-10 Thread Denis Kirjanov
On 2/11/16, Christophe Leroy wrote: > This patch provides VIRT_CPU_ACCOUTING to PPC32 architecture. > PPC32 doesn't have the PACA structure, so we use the task_info > structure to store the accounting data. > > In order to reuse on PPC32 the PPC64 functions, all u64 data has > been replaced by 'un

Re: [PATCH v3 2/2] powerpc: tracing: don't trace hcalls on offline CPUs

2016-02-05 Thread Denis Kirjanov
On 2/5/16, Steven Rostedt wrote: > On Fri, 5 Feb 2016 14:20:17 +0300 > Denis Kirjanov wrote: > >> >>> Signed-off-by: Denis Kirjanov >> > >> > Hi Steven, >> > >> > please apply with Michael's acked-by tag. >&g

Re: [PATCH v3 2/2] powerpc: tracing: don't trace hcalls on offline CPUs

2016-02-05 Thread Denis Kirjanov
On 1/19/16, Denis Kirjanov wrote: > On 1/12/16, Michael Ellerman wrote: >> On Mon, 2015-12-14 at 23:18 +0300, Denis Kirjanov wrote: >> >>> ./drmgr -c cpu -a -r gives the following warning: >>> >>> [ 2327.035563] >>> RCU used illegally from off

Re: [PATCH v5 21/23] powerpc: Simplify test in __dma_sync()

2016-02-04 Thread Denis Kirjanov
On 2/4/16, Christophe Leroy wrote: > > > Le 04/02/2016 12:37, Denis Kirjanov a écrit : >> On 2/4/16, Christophe Leroy wrote: >>> This simplification helps the compiler. We now have only one test >>> instead of two, so it reduces the number of branches. >&g

Re: [PATCH v5 21/23] powerpc: Simplify test in __dma_sync()

2016-02-04 Thread Denis Kirjanov
On 2/4/16, Christophe Leroy wrote: > This simplification helps the compiler. We now have only one test > instead of two, so it reduces the number of branches. > > Signed-off-by: Christophe Leroy > --- > v2: new > v3: no change > v4: no change > v5: no change > > arch/powerpc/mm/dma-noncoherent.c

Re: [PATCH v6 8/9] Implement kernel live patching for ppc64le (ABIv2)

2016-02-02 Thread Denis Kirjanov
On 1/25/16, Torsten Duwe wrote: > * create the appropriate files+functions > arch/powerpc/include/asm/livepatch.h > klp_check_compiler_support, > klp_arch_set_pc > arch/powerpc/kernel/livepatch.c with a stub for > klp_write_module_reloc > This is architecture-

Re: [PATCH 1/1] powerpc/irq: tidy up inconsistent context in migrate_irqs()

2015-12-23 Thread Denis Kirjanov
u > >> -Original Message- >> From: Zhang Zhuoyu [mailto:zhangzhu...@cmss.chinamobile.com] >> Sent: Wednesday, December 16, 2015 10:46 PM >> To: 'Denis Kirjanov'; 'Michael Ellerman' >> Cc: 'Daniel Axtens'; 'Zhang

Re: [PATCH 1/1] powerpc/irq: tidy up inconsistent context in migrate_irqs()

2015-12-16 Thread Denis Kirjanov
On 12/16/15, Michael Ellerman wrote: > On Wed, 2015-12-16 at 17:08 +1100, Daniel Axtens wrote: >> Hi, >> >> A couple of things. >> >> Firstly, your two email addresses don't match: >> >> Zhang Zhuoyu writes: > >> > From: Zhang Zhuoyu >> >> These lines do seem odd! Are they causing a problem? >>

[PATCH v3 1/2] tracing: introduce TRACE_EVENT_FN_COND macro

2015-12-14 Thread Denis Kirjanov
TRACE_EVENT_FN can't be used in some circumstances like invoking trace functions from offlined CPU due to RCU usage. This patch adds the TRACE_EVENT_FN_COND macro to make such trace points conditional. Signed-off-by: Denis Kirjanov --- include/linux/tracepoint.h | 4 include/

[PATCH v3 2/2] powerpc: tracing: don't trace hcalls on offline CPUs

2015-12-14 Thread Denis Kirjanov
die... [ 2327.403599] cpu 15 (hwid 15) Ready to die... Make the hypervisor tracepoints conditional by using TRACE_EVENT_FN_COND Signed-off-by: Denis Kirjanov v2 changes: - Use raw_smp_processor_id as suggested by BenH since since hcalls can be called from preemptable sections v3 changes

Re: [PATCH v2 2/2] ./drmgr -c cpu -a -r gives the following warning:

2015-12-14 Thread Denis Kirjanov
On 12/14/15, Denis Kirjanov wrote: > [ 2327.035563] > RCU used illegally from offline CPU! > rcu_scheduler_active = 1, debug_locks = 1 > [ 2327.035564] no locks held by swapper/12/0. > [ 2327.035565] > stack backtrace: > [ 2327.035567] CPU: 12 PID: 0 Comm: swapper/12 Tai

[PATCH v2 2/2] ./drmgr -c cpu -a -r gives the following warning:

2015-12-14 Thread Denis Kirjanov
die... Make the hypervisor tracepoints conditional by using TRACE_EVENT_FN_COND Signed-off-by: Denis Kirjanov v2 changes: - Use raw_smp_processor_id as suggested by BenH since since hcalls can be called from preemptable sections --- arch/powerpc/include/asm/trace.h | 8 ++-- 1 file changed

[PATCH v2 1/2] tracing: introduce TRACE_EVENT_FN_COND macro

2015-12-14 Thread Denis Kirjanov
TRACE_EVENT_FN can't be used in some circumstances like invoking trace functions from offlined CPU due to RCU usage. This patch adds the TRACE_EVENT_FN_COND macro to make such trace points conditional. Signed-off-by: Denis Kirjanov --- include/linux/tracepoint.h | 4 include/

Re: [PATCH 2/2] powerpc: tracing: don't trace hcalls on offline CPUs

2015-12-14 Thread Denis Kirjanov
On 12/14/15, Michael Ellerman wrote: > On Mon, 2015-12-07 at 16:33 -0500, Steven Rostedt wrote: >> On Tue, 08 Dec 2015 08:02:15 +1100 >> Benjamin Herrenschmidt wrote: >> > On Mon, 2015-12-07 at 15:52 -0500, Steven Rostedt wrote: >> > > > + TP_CONDITION(cpu_online(smp_processor_id())), >> > >

Re: [PATCH 1/2] tracing: introduce TRACE_EVENT_FN_COND macro

2015-12-07 Thread Denis Kirjanov
On 11/24/15, Denis Kirjanov wrote: > TRACE_EVENT_FN can't be used in some circumstances > like invoking trace functions from offlined CPU due > to RCU usage. > > This patch adds the TRACE_EVENT_FN_COND macro > to make such trace points conditional. > > Signed-off-b

Re: [PATCH 2/2] powerpc: tracing: don't trace hcalls on offline CPUs

2015-11-26 Thread Denis Kirjanov
On 11/26/15, Michael Ellerman wrote: > On Thu, 2015-11-26 at 11:15 +0300, Denis Kirjanov wrote: >> On 11/26/15, Michael Ellerman wrote: >> > On Tue, 2015-11-24 at 21:23 +0300, Denis Kirjanov wrote: >> > I can't get this to hit. >> > >> > I&#x

Re: [PATCH v4 1/9] ppc64 (le): prepare for -mprofile-kernel

2015-11-26 Thread Denis Kirjanov
On 11/25/15, Torsten Duwe wrote: > The gcc switch -mprofile-kernel, available for ppc64 on gcc > 4.8.5, > allows to call _mcount very early in the function, which low-level > ASM code and code patching functions need to consider. > Especially the link register and the parameter registers are still

Re: [PATCH v4 2/9] ppc64le FTRACE_WITH_REGS implementation

2015-11-26 Thread Denis Kirjanov
On 11/25/15, Torsten Duwe wrote: > Implement FTRACE_WITH_REGS for powerpc64, on ELF ABI v2. > Initial work started by Vojtech Pavlik, used with permission. > > * arch/powerpc/kernel/entry_64.S: > - Implement an effective ftrace_caller that works from > within the kernel binary as well

Re: [PATCH 2/2] powerpc: tracing: don't trace hcalls on offline CPUs

2015-11-26 Thread Denis Kirjanov
On 11/26/15, Michael Ellerman wrote: > On Tue, 2015-11-24 at 21:23 +0300, Denis Kirjanov wrote: > >> ./drmgr -c cpu -a -r gives the following warning: >> >> [ 2327.035563] RCU used illegally from offline CPU! >> rcu_scheduler_active = 1, debug_locks = 1 >> [ 2

[PATCH 2/2] powerpc: tracing: don't trace hcalls on offline CPUs

2015-11-24 Thread Denis Kirjanov
die... [ 2327.294180] cpu 14 (hwid 14) Ready to die... [ 2327.403599] cpu 15 (hwid 15) Ready to die... Make the hypervisor tracepoints conditional by using TRACE_EVENT_FN_COND Signed-off-by: Denis Kirjanov --- arch/powerpc/include/asm/trace.h | 8 ++-- 1 file changed, 6 insertions

[PATCH 1/2] tracing: introduce TRACE_EVENT_FN_COND macro

2015-11-24 Thread Denis Kirjanov
TRACE_EVENT_FN can't be used in some circumstances like invoking trace functions from offlined CPU due to RCU usage. This patch adds the TRACE_EVENT_FN_COND macro to make such trace points conditional. Signed-off-by: Denis Kirjanov --- include/linux/tracepoint.h | 4 include/

Re: [PATCH] powerpc: tracing: don't trace hcalls on offline CPUs

2015-11-23 Thread Denis Kirjanov
On 11/23/15, Michael Ellerman wrote: > On Fri, 2015-11-20 at 15:22 +0300, Denis Kirjanov wrote: >> On 11/3/15, Denis Kirjanov wrote: >> > On 11/3/15, Michael Ellerman wrote: >> > > On Thu, 2015-10-29 at 22:10 +0300, Denis Kirjanov wrote: >> > > > ./d

Re: Future of Lustre in staging

2015-11-20 Thread Denis Kirjanov
On 11/20/15, Xose Vazquez Perez wrote: > Hi, > > From https://lwn.net/Articles/662979/ > > --cut-- > Christoph complained a bit about the staging tree. He said that it > breaks allmodconfig builds, but that problem was evidently fixed a while > ago. He also dislikes the Lustre filesystem, which ha

Re: [PATCH] powerpc: tracing: don't trace hcalls on offline CPUs

2015-11-20 Thread Denis Kirjanov
On 11/3/15, Denis Kirjanov wrote: > On 11/3/15, Michael Ellerman wrote: >> On Thu, 2015-10-29 at 22:10 +0300, Denis Kirjanov wrote: >> >>> ./drmgr -c cpu -a -r gives the following warning: >>> >>> [ 2327.035563] RCU used illegally from offline CPU! >

Re: [PATCH] selftests/powerpc: Add script to test HMI functionality

2015-11-18 Thread Denis Kirjanov
On 11/18/15, Daniel Axtens wrote: > HMIs (Hypervisor Management|Maintenance Interrupts) are a class of interrupt > on POWER systems. > > HMI support has traditionally been exceptionally difficult to test. However > Skiboot ships a tool that, with the correct magic numbers, will inject them. > > Th

Re: Section mismatches in arch/powerpc/kernel/head_64.S

2015-11-16 Thread Denis Kirjanov
On 11/13/15, Laura Abbott wrote: > Hi, > > There seem to be section mismatches coming from head_64.S > > WARNING: vmlinux.o(.text+0x8994): Section mismatch in reference from the > variable __boot_from_prom to the function .init.text:prom_init() > The function __boot_from_prom() references > the fu

Re: x86/mm: Found insecure W+X mapping

2015-11-07 Thread Denis Kirjanov
On 11/7/15, Denis Kirjanov wrote: > Hi, > > kernel v4.3-3155-g1b1050c, > found the following WARNING at boot time: > > [ 15.363908] Freeing unused kernel memory: 628K (880001963000 - > 880001a0) > [ 15.370510] Freeing unused kernel memory:

[no subject]

2015-11-07 Thread Denis Kirjanov
Hi, kernel v4.3-3155-g1b1050c, found the following WARNING at boot time: [ 15.363908] Freeing unused kernel memory: 628K (880001963000 - 880001a0) [ 15.370510] Freeing unused kernel memory: 1744K (880001e4c000 - 88000200) [ 15.380507] [ cut here ]

Re: [PATCH V3 0/3] perf/powerpc:Add ability to sample intr machine state in powerpc

2015-11-05 Thread Denis Kirjanov
On 11/6/15, Anju T wrote: > Hi Denis, > > On Wednesday 04 November 2015 02:26 PM, Denis Kirjanov wrote: >> On 11/3/15, Anju T wrote: >>> This short patch series adds the ability to sample the interrupted >>> machine state for each hardware sample. >

Re: [PATCH V3 0/3] perf/powerpc:Add ability to sample intr machine state in powerpc

2015-11-04 Thread Denis Kirjanov
On 11/3/15, Anju T wrote: > This short patch series adds the ability to sample the interrupted > machine state for each hardware sample. > > To test this patchset, > Eg: > > $perf record -I ls // record machine state at interrupt > $perf script -D //read the perf.data file Uncovered the fo

Re: [PATCH] powerpc: tracing: don't trace hcalls on offline CPUs

2015-11-03 Thread Denis Kirjanov
On 11/3/15, Michael Ellerman wrote: > On Thu, 2015-10-29 at 22:10 +0300, Denis Kirjanov wrote: > >> ./drmgr -c cpu -a -r gives the following warning: >> >> [ 2327.035563] RCU used illegally from offline CPU! rcu_scheduler_active >> = 1, debug_locks = 1 >> [ 2

[PATCH] powerpc: tracing: don't trace hcalls on offline CPUs

2015-10-29 Thread Denis Kirjanov
... [ 2327.403599] cpu 15 (hwid 15) Ready to die... Make the hypervisor tracepoints conditional by introducing TRACE_EVENT_FN_COND similar to TRACE_EVENT_FN Signed-off-by: Denis Kirjanov --- arch/powerpc/include/asm/trace.h | 8 ++-- include/linux/tracepoint.h | 4 include/trace

Re: [PATCH V2 0/3] perf/powerpc:Add ability to sample intr machine state in powerpc

2015-10-26 Thread Denis Kirjanov
On 10/26/15, Anju T wrote: > This short patch series add the ability to sample the interrupted > machine state for each hardware sample Hi, how can we check your patch series without testing details? > > Anju (3): > perf/powerpc:add ability to sample intr machine state in power > tools/perf:

Re: Missing operand for tlbie instruction on Power7

2015-10-02 Thread Denis Kirjanov
On 10/2/15, Peter Bergner wrote: > On Fri, 2015-10-02 at 22:03 +0300, Denis Kirjanov wrote: >> arch/powerpc/kernel/swsusp_asm64.S: Assembler messages: >>> arch/powerpc/kernel/swsusp_asm64.S:188: Error: missing operand >>> scripts/Makefile.build:294: recipe for targ

Re: Missing operand for tlbie instruction on Power7

2015-10-02 Thread Denis Kirjanov
On 10/2/15, Laura Abbott wrote: > Hi, > > We received a report (https://bugzilla.redhat.com/show_bug.cgi?id=1267395) > of bad assembly > when compiling on powerpc with little endian > > [labbott@labbott-redhat-machine linux_upstream]$ make ARCH=powerpc > CROSS_COMPILE=powerpc64-linux-gnu- >CHK

Re: [PATCH RFC 0/5] powerpc:numa Add serial nid support

2015-09-29 Thread Denis Kirjanov
On 9/29/15, Raghavendra K T wrote: > On 09/28/2015 10:34 PM, Nishanth Aravamudan wrote: >> On 28.09.2015 [13:44:42 +0300], Denis Kirjanov wrote: >>> On 9/27/15, Raghavendra K T wrote: >>>> Problem description: >>>> Powerpc has sparse node nu

Re: [PATCH RFC 0/5] powerpc:numa Add serial nid support

2015-09-28 Thread Denis Kirjanov
On 9/27/15, Raghavendra K T wrote: > Problem description: > Powerpc has sparse node numbering, i.e. on a 4 node system nodes are > numbered (possibly) as 0,1,16,17. At a lower level, we map the chipid > got from device tree is naturally mapped (directly) to nid. Interesting thing to play with, I'

Re: [PATCH 4/9] powerpc: inline ip_fast_csum()

2015-09-22 Thread Denis Kirjanov
On 9/22/15, Christophe Leroy wrote: > In several architectures, ip_fast_csum() is inlined > There are functions like ip_send_check() which do nothing > much more than calling ip_fast_csum(). > Inlining ip_fast_csum() allows the compiler to optimise better Hi Christophe, I did try it and see no di

[PATCH] mm: slab: convert slab_is_available to boolean

2015-09-15 Thread Denis Kirjanov
A good one candidate to return a boolean result Signed-off-by: Denis Kirjanov --- include/linux/slab.h | 2 +- mm/slab_common.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/include/linux/slab.h b/include/linux/slab.h index 7e37d44..7c82e3b 100644 --- a/include

Re: 4.1-rc6: ATA link is slow to respond, please be patient

2015-08-08 Thread Denis Kirjanov
On 8/7/15, Christian Kujau wrote: > Hi, > > this PowerBook G4 was running 3.16 for a while but now I wanted to upgrade > to latest mainline. However, during bootup the following happens: > > === > [2.237102] ata1: PATA max UDMA/100 irq 39 > [2.401708] ata1.00: A

Re: 4.1-rc6: ATA link is slow to respond, please be patient

2015-08-07 Thread Denis Kirjanov
On 8/7/15, Christian Kujau wrote: > Hi, > > this PowerBook G4 was running 3.16 for a while but now I wanted to upgrade > to latest mainline. However, during bootup the following happens: > > === > [2.237102] ata1: PATA max UDMA/100 irq 39 > [2.401708] ata1.00: A

Re: [RESEND PATCH 0/4] ppc64 LE ABI v2 ftrace-with-regs implementation

2015-06-19 Thread Denis Kirjanov
On 6/18/15, Torsten Duwe wrote: > Did I miss anything else? I have the notrace optimisations and > kernel live patching in the queue, which depends on this, so I'd > really appreciate a comment whether it is acceptable in this form > or not. Thanks in advance! Hi Torsten, could you provide a des

Re: [PATCH v2] net: sysctl for RA default route MTU

2015-03-25 Thread Denis Kirjanov
On 3/25/15, Roman Gushchin wrote: > This patch introduces new ipv6 sysctl: ra_default_route_mtu. > If it's set (> 0), it defines per-route MTU for any new default route > received by RA. > > This sysctl will help in the following configuration: we want to use > jumbo-frames for internal networks a

Re: [PATCH] ipv4: ip_check_defrag should correctly check return value of skb_copy_bits

2015-02-17 Thread Denis Kirjanov
On 2/17/15, Alexander Drozdov wrote: > skb_copy_bits() returns zero on success and negative value on error, > so it is needed to invert the condition in ip_check_defrag(). > Nice. Grepping through the net directory shows that the skb_copy_bits() return value is completely ignored in net/wireless

Re: [PATCH 2/2] gianfar: handle map error in gfar_start_xmit()

2014-12-05 Thread Denis Kirjanov
On 12/5/14, Arseny Solokha wrote: > From: Arseny Solokha > > When DMA-API debugging is enabled in the kernel, it spews the following > upon upping the link: > > WARNING: at lib/dma-debug.c:1135 > Modules linked in: > CPU: 0 PID: 0 Comm: swapper/0 Tainted: GW O 3.18.0-rc7 #1 > task: c07

Re: [PATCH V4 7/8] powerpc, ptrace: Enable support for miscellaneous debug registers

2014-11-24 Thread Denis Kirjanov
On 11/21/14, Anshuman Khandual wrote: > On 11/14/2014 03:30 PM, Denis Kirjanov wrote: >> On 11/13/14, Anshuman Khandual wrote: >>> > On 11/11/2014 10:56 AM, Anshuman Khandual wrote: >>>> >> This patch enables get and set of miscellaneous debug r

Re: [PATCH V4 7/8] powerpc, ptrace: Enable support for miscellaneous debug registers

2014-11-14 Thread Denis Kirjanov
On 11/13/14, Anshuman Khandual wrote: > On 11/11/2014 10:56 AM, Anshuman Khandual wrote: >> This patch enables get and set of miscellaneous debug registers through >> ptrace PTRACE_GETREGSET-PTRACE_SETREGSET interface by implementing new >> powerpc specific register set REGSET_MISC support corresp

Re: powerpc: Wire up sys_bpf() syscall

2014-10-20 Thread Denis Kirjanov
I don't see any problems with it On 10/21/14, Michael Ellerman wrote: > On Tue, 2014-10-21 at 08:52 +0400, Denis Kirjanov wrote: >> We have a test suite under samples/bpf/ > > Thanks. > > I looked under tools/testing/selftests, could it move in there? > > cheers

Re: powerpc: Wire up sys_bpf() syscall

2014-10-20 Thread Denis Kirjanov
I don't see any problems with it On 10/21/14, Michael Ellerman wrote: > On Tue, 2014-10-21 at 08:52 +0400, Denis Kirjanov wrote: >> We have a test suite under samples/bpf/ > > Thanks. > > I looked under tools/testing/selftests, could it move in there? > > cheers

Re: powerpc: Wire up sys_bpf() syscall

2014-10-20 Thread Denis Kirjanov
We have a test suite under samples/bpf/ On 10/21/14, Michael Ellerman wrote: > On Fri, 2014-10-10 at 05:53:45 UTC, Pranith Kumar wrote: >> This patch wires up the new syscall sys_bpf() on powerpc. > > Is there a test suite we can run to verify it works? > > cheers > _

Re: [PATCH] staging: rtl8188eu: coding style fixup

2014-10-08 Thread Denis Kirjanov
But you haven't CCed people in the CC list On 10/9/14, Igor Bogomazov wrote: > checkpatch.pl tiny fix > get rid of 2 warnings and 2 errors for hal/fw.c > > Signed-off-by: Igor Bogomazov > Cc: Greg Kroah-Hartman > Cc: navin patidar > Cc: Stephen Rothwell > --- > for linux-next 3.17.0 > > this

Re: [rt2x00-users] [PATCH] wireless: Remove unnessary write over of register 11 in rt2800lib.c

2014-09-28 Thread Denis Kirjanov
Or someone with the hardware has to test and check that... On 9/28/14, Stanislaw Gruszka wrote: > On Sat, Sep 27, 2014 at 05:11:41PM -0400, Nicholas Krause wrote: >> This removes the unnecessary overwrite of register 11 in the function, >> rt2800_config_channel as we are already writing a correc

Re: Eudyptula Challenge (Task 10)

2014-07-28 Thread Denis Kirjanov
On 7/28/14, Lucas Tanure wrote: > Hi Christoph, > > What kind of things that you think a newbie can fix ? You can start working on fixing the pci_map_* and dma_map_* return value checks with CONFIG_DMA_API_DEBUG enabled. A lot of drivers still missing that... > Thanks > -- > Lucas Tanure > +55 (

Re: kmemleak: Unable to handle kernel paging request

2014-06-13 Thread Denis Kirjanov
On 6/13/14, Catalin Marinas wrote: > On Fri, Jun 13, 2014 at 08:12:08AM +0100, Denis Kirjanov wrote: >> On 6/12/14, Catalin Marinas wrote: >> > On Thu, Jun 12, 2014 at 01:00:57PM +0100, Denis Kirjanov wrote: >> >> On 6/12/14, Denis Kirjanov wrote: >> >

Re: kmemleak: Unable to handle kernel paging request

2014-06-13 Thread Denis Kirjanov
On 6/12/14, Catalin Marinas wrote: > On Thu, Jun 12, 2014 at 01:00:57PM +0100, Denis Kirjanov wrote: >> On 6/12/14, Denis Kirjanov wrote: >> > On 6/12/14, Catalin Marinas wrote: >> >> On 11 Jun 2014, at 21:04, Denis Kirjanov >> >> wrote: >> &g

Re: kmemleak: Unable to handle kernel paging request

2014-06-12 Thread Denis Kirjanov
On 6/12/14, Naoya Horiguchi wrote: > Hi Denis, > > On Thu, Jun 12, 2014 at 04:00:57PM +0400, Denis Kirjanov wrote: >> On 6/12/14, Denis Kirjanov wrote: >> > On 6/12/14, Catalin Marinas wrote: >> >> On 11 Jun 2014, at 21:04, Denis Kirjanov >> >>

Re: kmemleak: Unable to handle kernel paging request

2014-06-12 Thread Denis Kirjanov
On 6/12/14, Denis Kirjanov wrote: > On 6/12/14, Catalin Marinas wrote: >> On 11 Jun 2014, at 21:04, Denis Kirjanov wrote: >>> On 6/11/14, Catalin Marinas wrote: >>>> On Wed, Jun 11, 2014 at 04:13:07PM +0400, Denis Kirjanov wrote: >>>>> I go

Re: kmemleak: Unable to handle kernel paging request

2014-06-12 Thread Denis Kirjanov
On 6/12/14, Catalin Marinas wrote: > On 11 Jun 2014, at 21:04, Denis Kirjanov wrote: >> On 6/11/14, Catalin Marinas wrote: >>> On Wed, Jun 11, 2014 at 04:13:07PM +0400, Denis Kirjanov wrote: >>>> I got a trace while running 3.15.0-08556-gdfb9454: >>>> &

Re: kmemleak: Unable to handle kernel paging request

2014-06-11 Thread Denis Kirjanov
On 6/11/14, Catalin Marinas wrote: > On Wed, Jun 11, 2014 at 04:13:07PM +0400, Denis Kirjanov wrote: >> I got a trace while running 3.15.0-08556-gdfb9454: >> >> [ 104.534026] Unable to handle kernel paging request for data at >> address 0xc0007f00 > >

kmemleak: Unable to handle kernel paging request

2014-06-11 Thread Denis Kirjanov
Hi, I got a trace while running 3.15.0-08556-gdfb9454: [ 104.534026] Unable to handle kernel paging request for data at address 0xc0007f00 [ 104.534197] Faulting instruction address: 0xc019cb50 [ 104.534204] Oops: Kernel access of bad area, sig: 11 [#1] [ 104.534891] PREEMPT S

Re: [PATCH] drivers: staging: cxt1e1: hwprobe Fix different address spaces

2014-03-21 Thread Denis Kirjanov
On 3/21/14, Matei Oprea wrote: > Fix different address spaces when unmapping IO. hi->addr_mapped[0] > and hi->addr_mapped[1] should be tagged __iomem. > > Signed-off-by: Matei Oprea > Cc: ROSEdu Kernel Community > --- > drivers/staging/cxt1e1/hwprobe.c |4 ++-- > 1 file changed, 2 insertion

Re: [PATCH v3 2/5] staging: et131x: drop packet when error occurs in et131x_tx

2013-11-22 Thread Denis Kirjanov
22/13, ZHAO Gang wrote: > On Fri, Nov 22, 2013 at 5:17 PM, Denis Kirjanov wrote: >> On 11/22/13, Mark Einon wrote: >>> On Wed, Nov 20, 2013 at 03:55:27PM +0800, ZHAO Gang wrote: >>>> As TODO file suggested, drop packet instead of return NETDEV_TX_BUSY >>>

Re: [PATCH v3 2/5] staging: et131x: drop packet when error occurs in et131x_tx

2013-11-22 Thread Denis Kirjanov
On 11/22/13, Mark Einon wrote: > On Wed, Nov 20, 2013 at 03:55:27PM +0800, ZHAO Gang wrote: >> As TODO file suggested, drop packet instead of return NETDEV_TX_BUSY >> when tx failed. >> >> et131x_tx calls function et131x_send_packets, I put the work of >> et131x_send_packets directly into et131x_t

  1   2   >