- all good. Also the last patch
which removes the shift and makes it obsolete. Thanks!
Feel free to add to all patches:
Reviewed-by: Lukasz Luba
Tested-by: Lukasz Luba
Regards,
Lukasz
On 12/6/18 8:18 PM, Lukasz Luba wrote:
> Hi Rui,
>
> On 12/5/18 4:09 PM, Zhang Rui wrote:
>> On 三, 2018-11-07 at 18:09 +0100, Lukasz Luba wrote:
>>> This patch adds support irq mode in trip point.
>>> When that flag is set in DT, there is no need for polling
&
Hi Rui,
On 12/5/18 4:09 PM, Zhang Rui wrote:
> On 三, 2018-11-07 at 18:09 +0100, Lukasz Luba wrote:
>> This patch adds support irq mode in trip point.
>> When that flag is set in DT, there is no need for polling
>> in thermal framework. Crossing the trip point will rise
Hi Rui,
On 12/5/18 4:08 PM, Zhang Rui wrote:
> On 三, 2018-11-07 at 18:09 +0100, Lukasz Luba wrote:
>> Hi all,
>>
>> This patch set adds a new flag and mechanism in thermal trip points
>> in
>> DT. The old implementation in thermal zone in DT sets the same
>&
Hi Rob,
On 11/12/18 8:09 PM, Rob Herring wrote:
> On Wed, Nov 07, 2018 at 06:09:47PM +0100, Lukasz Luba wrote:
>> Thermal trip point gets new flag in DT: irq-mode.
>> Trip point may have a new explicit flag which indicate
>> IRQ support when the temperature is met (so
Hi Krzysztof,
On 11/12/18 10:00 AM, Krzysztof Kozlowski wrote:
> Thanks Lukasz for patches. I like your work!
>
> I have few more comments which will probably apply for all the DTS commits.
>
> On Wed, 7 Nov 2018 at 18:10, Lukasz Luba wrote:
>>
>> This patch adds
Hi Krzysztof,
Thanks for the comments.
On 11/12/18 9:51 AM, Krzysztof Kozlowski wrote:
> On Wed, 7 Nov 2018 at 18:10, Lukasz Luba wrote:
>>
>
> Subject prefix:
> dt-bindings: thermal:
>
>> Thermal trip point gets new flag in DT: irq-mode.
>> Trip point m
ight be interpretted wrongly.
This mechanism prevents from missue and adds explicit setting
for hardware which support interrupts for pre-configured temperature
threshold.
Cc: Zhang Rui
Cc: Eduardo Valentin
Cc: Daniel Lezcano
Signed-off-by: Lukasz Luba
---
drivers/thermal/of-thermal.c | 17 ++
lowski
Cc: devicet...@vger.kernel.org
Cc: linux-arm-ker...@lists.infradead.org
Cc: linux-samsung-...@vger.kernel.org
Signed-off-by: Lukasz Luba
---
arch/arm64/boot/dts/exynos/exynos5433-tmu.dtsi | 105 -
1 file changed, 70 insertions(+), 35 deletions(-)
diff --git a/arch/arm6
: linux-samsung-...@vger.kernel.org
Signed-off-by: Lukasz Luba
---
arch/arm64/boot/dts/exynos/exynos7-trip-points.dtsi | 8
1 file changed, 8 insertions(+)
diff --git a/arch/arm64/boot/dts/exynos/exynos7-trip-points.dtsi
b/arch/arm64/boot/dts/exynos/exynos7-trip-points.dtsi
index d3301b8
Patch adds show functions for irq-mode feature.
It allocates new attributes and extends the old list.
Cc: Zhang Rui
Cc: Eduardo Valentin
Cc: Daniel Lezcano
Signed-off-by: Lukasz Luba
---
drivers/thermal/thermal_sysfs.c | 53 +++--
1 file changed, 51
or polling the temperature.
Update documentation about irq-mode for trip points.
Cc: Zhang Rui
Cc: Eduardo Valentin
Cc: Daniel Lezcano
Cc: Rob Herring
Cc: Mark Rutland
Cc: devicet...@vger.kernel.org
Signed-off-by: Lukasz Luba
---
Documentation/devicetree/bindings/thermal/thermal.txt | 7 +
: linux-samsung-...@vger.kernel.org
Signed-off-by: Lukasz Luba
---
arch/arm/boot/dts/exynos4-cpu-thermal.dtsi | 10 +++---
1 file changed, 7 insertions(+), 3 deletions(-)
diff --git a/arch/arm/boot/dts/exynos4-cpu-thermal.dtsi
b/arch/arm/boot/dts/exynos4-cpu-thermal.dtsi
index 021d9fc..5e07289
or polling the temperature.
Update documentation about irq-mode for trip points.
The new sysfs file shows 1 if the trip point supports IRQ.
Cc: Jonathan Corbet
Cc: Zhang Rui
Cc: linux-doc@vger.kernel.org
Signed-off-by: Lukasz Luba
---
Documentation/thermal/sysfs-api.txt | 9 +
1 file
c: devicet...@vger.kernel.org
Cc: linux-arm-ker...@lists.infradead.org
Cc: linux-samsung-...@vger.kernel.org
Signed-off-by: Lukasz Luba
---
arch/arm/boot/dts/exynos5422-odroidxu3-common.dtsi | 40 +++---
1 file changed, 28 insertions(+), 12 deletions(-)
diff --git a/arch/arm/boot/dts/
ed trip points and there is a need of 6. The rest 2 are
declared as 'passive' without 'irq-mode;' flag, which means polling
mode needed for them.
Patch #1 is a small cleanup in thermal framework.
Change log:
v2
- changed description in cover letter
- change commit messages acco
: linux-samsung-...@vger.kernel.org
Signed-off-by: Lukasz Luba
---
arch/arm/boot/dts/exynos5410-odroidxu.dts | 10 +++---
1 file changed, 7 insertions(+), 3 deletions(-)
diff --git a/arch/arm/boot/dts/exynos5410-odroidxu.dts
b/arch/arm/boot/dts/exynos5410-odroidxu.dts
index 434a759..e85a5d6
: linux-samsung-...@vger.kernel.org
Signed-off-by: Lukasz Luba
---
arch/arm/boot/dts/exynos5420-trip-points.dtsi | 10 +++---
1 file changed, 7 insertions(+), 3 deletions(-)
diff --git a/arch/arm/boot/dts/exynos5420-trip-points.dtsi
b/arch/arm/boot/dts/exynos5420-trip-points.dtsi
index a67a3807
Clean unused parameter from internal framework function.
Cc: Zhang Rui
Cc: Eduardo Valentin
Cc: Daniel Lezcano
Signed-off-by: Lukasz Luba
---
drivers/thermal/thermal_core.c | 6 ++
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/thermal/thermal_core.c b/drivers
On 10/17/2018 09:52 AM, Krzysztof Kozlowski wrote:
> On Wed, 17 Oct 2018 at 09:42, Lukasz Luba wrote:
>>
>> Hi Krzysztof,
>>
>> On 10/17/2018 09:03 AM, Krzysztof Kozłowski wrote:
>>> On Tue, 16 Oct 2018 at 16:56, Lukasz Luba
>>> wrote:
>>>
Hi Krzysztof,
On 10/17/2018 09:03 AM, Krzysztof Kozłowski wrote:
> On Tue, 16 Oct 2018 at 16:56, Lukasz Luba wrote:
>>
>> Hi all,
>>
>> This patch set adds new flag and mechanism in thermal trip point in DT.
>> The current situation with 'passive' (pa
On 10/16/2018 05:13 PM, Krzysztof Kozlowski wrote:
> On Tue, 16 Oct 2018 at 16:56, Lukasz Luba wrote:
>>
>> This patch adds support for new flash which indicates
>> that trip point triggers irq when temperature is met.
>> Exynos5433 supports 8 trip point which will t
Hi Krzysztof,
On 10/16/2018 05:09 PM, Krzysztof Kozlowski wrote:
> On Tue, 16 Oct 2018 at 16:56, Lukasz Luba wrote:
>>
>
> Hi Lukasz,
>
> Thanks for patches.
>
> I did not receive the first patches in the series. It is okay (depends
> on the context) but in suc
k to start polling
the temperature sensor under configured conditions and
handle the trip point.
Cc: Kukjin Kim
Cc: Krzysztof Kozlowski
Cc: devicet...@vger.kernel.org
Cc: linux-arm-ker...@lists.infradead.org
Signed-off-by: Lukasz Luba
---
arch/arm64/boot/dts/exynos/exynos5433-tmu.
k to start polling
the temperature sensor under configured conditions and
handle the trip point.
Cc: Kukjin Kim
Cc: Krzysztof Kozlowski
Cc: devicet...@vger.kernel.org
Cc: linux-arm-ker...@lists.infradead.org
Signed-off-by: Lukasz Luba
---
arch/arm/boot/dts/exynos5420-trip-points.dtsi | 10 +++-
ight be interpretted wrongly.
This mechanism prevents from missue and adds explicit setting
for hardware which support interrupts for pre-configured temperature
threshold.
Cc: Zhang Rui
Cc: Eduardo Valentin
Cc: Daniel Lezcano
Signed-off-by: Lukasz Luba
---
drivers/thermal
olling the temperature.
Update documentation about irq-mode for trip points.
Cc: Zhang Rui
Cc: Eduardo Valentin
Cc: Daniel Lezcano
Cc: Rob Herring
Cc: Mark Rutland
Cc: devicet...@vger.kernel.org
Signed-off-by: Lukasz Luba
---
Documentation/devicetree/bindings/thermal/thermal.txt | 7 +
Patch adds show functions for irq-mode feature.
It allocates new attributes and extends the old list.
Cc: Zhang Rui
Cc: Eduardo Valentin
Cc: Daniel Lezcano
Signed-off-by: Lukasz Luba
---
drivers/thermal/thermal_sysfs.c | 53 +++--
1 file changed, 51
or polling the temperature.
Update documentation about irq-mode for trip points.
The new sysfs file shows 1 if the trip point supports irq.
Cc: Jonathan Corbet
Cc: Zhang Rui
Cc: linux-doc@vger.kernel.org
Signed-off-by: Lukasz Luba
---
Documentation/thermal/sysfs-api.txt | 9 +
1 file
k to start polling
the temperature sensor under configured conditions and
handle the trip point.
Cc: Kukjin Kim
Cc: Krzysztof Kozlowski
Cc: devicet...@vger.kernel.org
Cc: linux-arm-ker...@lists.infradead.org
Signed-off-by: Lukasz Luba
---
arch/arm/boot/dts/exynos5410-odroidxu.dts | 10 +++-
k to start polling
the temperature sensor under configured conditions and
handle the trip point.
Cc: Kukjin Kim
Cc: Krzysztof Kozlowski
Cc: devicet...@vger.kernel.org
Cc: linux-arm-ker...@lists.infradead.org
Signed-off-by: Lukasz Luba
---
arch/arm/boot/dts/exynos5422-odroidxu3-common
k to start polling
the temperature sensor under configured conditions and
handle the trip point.
Cc: Kukjin Kim
Cc: Krzysztof Kozlowski
Cc: devicet...@vger.kernel.org
Cc: linux-arm-ker...@lists.infradead.org
Signed-off-by: Lukasz Luba
---
arch/arm/boot/dts/exynos4-cpu-thermal.dtsi | 10 +++-
k to start polling
the temperature sensor under configured conditions and
handle the trip point.
Cc: Kukjin Kim
Cc: Krzysztof Kozlowski
Cc: devicet...@vger.kernel.org
Cc: linux-arm-ker...@lists.infradead.org
Signed-off-by: Lukasz Luba
---
arch/arm64/boot/dts/exynos/exynos7-trip-points.dtsi | 8 +
olling needed.
It does not break existing design for trip points which do not have 'irq-mode'
flag - they will use polling.
For consistency this flag should be added to all trip point types('active',
'passive', 'hot', 'critical') when need (meaning,
Clean unused parameter from internal framework function.
Cc: Zhang Rui
Cc: Eduardo Valentin
Cc: Daniel Lezcano
Signed-off-by: Lukasz Luba
---
drivers/thermal/thermal_core.c | 6 ++
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/thermal/thermal_core.c b/drivers
35 matches
Mail list logo