Hi Rob, On 11/12/18 8:09 PM, Rob Herring wrote: > On Wed, Nov 07, 2018 at 06:09:47PM +0100, Lukasz Luba wrote: >> Thermal trip point gets new flag in DT: irq-mode. >> Trip point may have a new explicit flag which indicate >> IRQ support when the temperature is met (so the thermal framework >> deos not need to set polling for it). >> It is useful for 'passive' cooling trip point, >> which now will not register for polling the temperature. >> >> Update documentation about irq-mode for trip points. > > This patch should come before you use it. OK, I will re-order the patch set in v3. > >> >> Cc: Zhang Rui <rui.zh...@intel.com> >> Cc: Eduardo Valentin <edubez...@gmail.com> >> Cc: Daniel Lezcano <daniel.lezc...@linaro.org> >> Cc: Rob Herring <robh...@kernel.org> >> Cc: Mark Rutland <mark.rutl...@arm.com> >> Cc: devicet...@vger.kernel.org >> Signed-off-by: Lukasz Luba <l.l...@partner.samsung.com> >> --- >> Documentation/devicetree/bindings/thermal/thermal.txt | 7 +++++++ >> 1 file changed, 7 insertions(+) >> >> diff --git a/Documentation/devicetree/bindings/thermal/thermal.txt >> b/Documentation/devicetree/bindings/thermal/thermal.txt >> index ca14ba9..bee21e3 100644 >> --- a/Documentation/devicetree/bindings/thermal/thermal.txt >> +++ b/Documentation/devicetree/bindings/thermal/thermal.txt >> @@ -90,6 +90,10 @@ Required properties: >> "critical": Hardware not reliable. >> Type: string >> >> +- irq-mode: A flag indicating that trip rises irq, so there is no >> + Type: bool need of polling in thermal framework. >> + Size: one cell > > Should be optional, right? Yes, it is optional. I will mention about it in change v3.
Thank you for the review. Regards, Lukasz
