Re: clutk status update 2010/09/14

2010-09-18 Thread Jammy Zhou
Hi Alexandros, I think this patch is upstreamable. Regards, Jammy On Fri, Sep 17, 2010 at 3:19 PM, Alexandros Frantzis < alexandros.frant...@linaro.org> wrote: > On Thu, Sep 16, 2010 at 01:25:26PM +0800, Jammy Zhou wrote: > > I have found the point in cogl gles2 driver for this GL_INVALID_OPERA

Re: clutk status update 2010/09/14

2010-09-17 Thread Alexandros Frantzis
On Thu, Sep 16, 2010 at 01:25:26PM +0800, Jammy Zhou wrote: > I have found the point in cogl gles2 driver for this GL_INVALID_OPERATION > error. Because our shader program and cogl shader program are used > sequentially, we must make sure in _cogl_wrap_prepare_for_draw function that > the correct c

Re: clutk status update 2010/09/14

2010-09-15 Thread Jammy Zhou
I have found the point in cogl gles2 driver for this GL_INVALID_OPERATION error. Because our shader program and cogl shader program are used sequentially, we must make sure in _cogl_wrap_prepare_for_draw function that the correct cogl shader program is used to avoid invalid operation. I have prepar

Re: clutk status update 2010/09/14

2010-09-15 Thread Jammy Zhou
Yes. Normally the GL error should be retrieved by call glGetError. In cogl of clutter, "GE" macro definition is used to check the GL error. But only when COGL_GL_DEBUG is defined, glGetError is called in GE. Regards, Jammy On Wed, Sep 15, 2010 at 10:10 PM, Jesse Barker wrote: > On Wed, 2010-09-

Re: clutk status update 2010/09/14

2010-09-15 Thread Jesse Barker
On Wed, 2010-09-15 at 20:58 +0800, Jammy Zhou wrote: > After debugging into glBindFramebuffer, the error is not for this API > call. And the GL_INVALID_OPERATION error should be caused by previous > opengl call, for which CheckGLError is not called. Glad to hear it. It would otherwise have sugges

Re: clutk status update 2010/09/14

2010-09-15 Thread Jammy Zhou
After debugging into glBindFramebuffer, the error is not for this API call. And the GL_INVALID_OPERATION error should be caused by previous opengl call, for which CheckGLError is not called. Regards, Jammy On Wed, Sep 15, 2010 at 9:19 AM, Jammy Zhou wrote: > Hi Jesse, > > Thanks for your point.

Re: clutk status update 2010/09/14

2010-09-14 Thread Jammy Zhou
Hi Jesse, Thanks for your point. I can confirm that the fbo extension is available there for this functionality, and there is no such error messages when call the same function in other clutk test cases. And yes, the run-time check for the fbo capability is not implemented, it is assumed that thi

Re: clutk status update 2010/09/14

2010-09-14 Thread Jesse Barker
Jammy, With respect to the CheckGLError assertion in test-clutk-perf, assuming that glGetError is called per OpenGL entry point (i.e. you are not seeing an error triggered by another call), the only way you should be seeing an invalid operation when setting framebuffer binding(s) back to the defau

Re: clutk status update 2010/09/14

2010-09-14 Thread Jammy Zhou
Hi Alexander, On Tue, Sep 14, 2010 at 4:31 PM, Alexander Sack wrote: > On Tue, Sep 14, 2010 at 9:38 AM, Jammy Zhou wrote: > > > > Issues Fixed: > > + Normalize clutter vetex positions to adapt to the vertex shader > > + Use GL_TRIANGLE_FAN to implement original used GL_QUADS primitive, > which

Re: clutk status update 2010/09/14

2010-09-14 Thread Alexander Sack
On Tue, Sep 14, 2010 at 9:38 AM, Jammy Zhou wrote: > > Issues Fixed: > + Normalize clutter vetex positions to adapt to the vertex shader > + Use GL_TRIANGLE_FAN to implement original used GL_QUADS primitive, which > is not supported by gles2 > + Comment out cogl_flush() call in some functions (suc