Re: [PATCH-Android] [android/system/media] File renamed to avoid build errors using GCC 4.5/4.6.

2011-03-15 Thread Sachin Kamat
Thanks Jassi.. Resending the patch (created using -M) Signed-off-by: Sachin Kamat Change-Id: I39652f14b362c42ebc2ceb37952d8e57cf89692c --- opensles/libopensles/Android.mk|2 +- .../{IAndroidEffect.c => IAndroidEffect.cpp} |0 2

Re: [PATCH-Android] [android/system/media] File renamed to avoid build errors using GCC 4.5/4.6.

2011-03-15 Thread Jassi Brar
On Wed, Mar 16, 2011 at 10:46 AM, Sachin Kamat wrote: >  Signed-off-by: Sachin Kamat > > Change-Id: I39652f14b362c42ebc2ceb37952d8e57cf89692c > --- >  opensles/libopensles/Android.mk         |    2 +- >  opensles/libopensles/IAndroidEffect.c   |  130 > --- >  opensles

[PATCH-Android] [android/external/skia] Modified to avoid build errors using GCC 4.5/4.6.

2011-03-15 Thread Sachin Kamat
Signed-off-by: Sachin Kamat Change-Id: Ibebec39dfd1e083a052870927a4129fdeca7cf8a --- src/images/SkFlipPixelRef.cpp|2 +- src/images/SkImageRef_GlobalPool.cpp |2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/images/SkFlipPixelRef.cpp b/src/images/SkFlipPi

[PATCH-Android] [android/build] Disable Werror option to avoid build errors using GCC 4.5/4.6.

2011-03-15 Thread Sachin Kamat
Signed-off-by: Sachin Kamat Change-Id: I471e831d569b37345752d788f5a213ffd6616690 --- core/config.mk |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/core/config.mk b/core/config.mk index a76aec8..45100fb 100644 --- a/core/config.mk +++ b/core/config.mk @@ -98,7 +98,7 @@

[PATCH-Android] [android/system/media] File renamed to avoid build errors using GCC 4.5/4.6.

2011-03-15 Thread Sachin Kamat
Signed-off-by: Sachin Kamat Change-Id: I39652f14b362c42ebc2ceb37952d8e57cf89692c --- opensles/libopensles/Android.mk |2 +- opensles/libopensles/IAndroidEffect.c | 130 --- opensles/libopensles/IAndroidEffect.cpp | 130 +++

[PATCH-Android] [android/external/webkit] Modified to avoid build errors using GCC 4.5/4.6.

2011-03-15 Thread Sachin Kamat
Signed-off-by: Sachin Kamat Change-Id: I2cd4ccdf7edc39b025ef39bd5db0154c616aa5a9 --- WebKit/android/nav/FindCanvas.cpp |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/WebKit/android/nav/FindCanvas.cpp b/WebKit/android/nav/FindCanvas.cpp index d8e908b..15cce43 100644 -

[PATCH-Android] Patches to build Android using GCC 4.5/4.6.

2011-03-15 Thread Sachin Kamat
Hi, The next set of patches will help in building Android source code out of the box using Linaro GCC 4.5/4.6 toolchains. The patches basically try to circumvent the build problem caused by stricter GCC 4.5/4.6. These patches are based on remotes/m/linaro_android_2.3.2 branch. Regards, Sachin

[PATCH-Android] [android/frameworks/base] Modified to eliminate build errors using GCC 4.5/4.6.

2011-03-15 Thread Sachin Kamat
Signed-off-by: Sachin Kamat Change-Id: Id31f863427cd3a7d5d5abced71de78a76ae3d028 --- libs/utils/RefBase.cpp |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/libs/utils/RefBase.cpp b/libs/utils/RefBase.cpp index 0bd1af4..d28b751 100644 --- a/libs/utils/RefBase.cpp +++ b/

[PATCH-Android] [android/libcore] Disable Werror option to avoid build errors using GCC 4.5/4.6.

2011-03-15 Thread Sachin Kamat
Signed-off-by: Sachin Kamat Change-Id: I2c4699686ada362b43b836ace61636fc000720d3 --- NativeCode.mk |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/NativeCode.mk b/NativeCode.mk index 4c6ffa5..7b56aef 100644 --- a/NativeCode.mk +++ b/NativeCode.mk @@ -85,7 +85,7 @@ core

[PATCH-Android] [android/external/elfcopy] Modified to eliminate build errors using GCC 4.5/4.6.

2011-03-15 Thread Sachin Kamat
Signed-off-by: Sachin Kamat Change-Id: I01286388a1bef915cb06adae862d9f3a0397b059 --- elfcopy.c |1 - 1 files changed, 0 insertions(+), 1 deletions(-) diff --git a/elfcopy.c b/elfcopy.c index ed1e6ce..da054c7 100644 --- a/elfcopy.c +++ b/elfcopy.c @@ -2456,7 +2456,6 @@ update_symbol_values(

[PATCH-Android] [android/frameworks/opt/emoji] Disable Werror option to avoid build errors using GCC 4.5/4.6.

2011-03-15 Thread Sachin Kamat
Signed-off-by: Sachin Kamat Change-Id: I61a9d5c9b5aef8358a04d0e1ac8964f905f0970a --- Android.mk |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/Android.mk b/Android.mk index 331d794..181f115 100644 --- a/Android.mk +++ b/Android.mk @@ -32,7 +32,7 @@ ifneq ($(TARGET_SIM

[PATCH-Android] [android/dalvik] Disable Werror option to avoid build errors using GCC 4.5/4.6.

2011-03-15 Thread Sachin Kamat
Signed-off-by: Sachin Kamat Change-Id: I8fa29112df35fea05d034ef4d08559135c5e327a --- vm/Dvm.mk |1 - 1 files changed, 0 insertions(+), 1 deletions(-) diff --git a/vm/Dvm.mk b/vm/Dvm.mk index 0867ffa..7b8a39d 100644 --- a/vm/Dvm.mk +++ b/vm/Dvm.mk @@ -264,7 +264,6 @@ MTERP_ARCH_KNOWN := fal

Re: LAVA integration effort for Android validation

2011-03-15 Thread Sachin Kamat
On 16 March 2011 10:03, Michael Hudson-Doyle wrote: > On Tue, 15 Mar 2011 11:17:14 -0500, Paul Larson > wrote: > > > I like statically IP. How do we know which board would get which IP? > > > One idea would be to set up a DNS for internal board names. e.g. > > > panda01.internal.network would res

Re: [PATCH V4 1/5] arm/dt: add basic mx51 device tree support

2011-03-15 Thread Grant Likely
On Tue, Mar 15, 2011 at 9:34 PM, Jason Hui wrote: > Hi, Grant, > > On Tue, Mar 15, 2011 at 3:03 PM, Grant Likely > wrote: >> Hi Jason, >> >> Minor comments below. >> >> On Thu, Mar 10, 2011 at 12:59:41PM +0800, Jason Liu wrote: >>> Signed-off-by: Jason Liu >>> Signed-off-by: Jason Liu >> >> Th

Re: LAVA integration effort for Android validation

2011-03-15 Thread Paul Larson
> How would you do this? Most boards don't have a fixed MAC address. You > can set up a dhcp-name but that (AIUI) means a different rootfs for each > board and then you might as well just allocate a static IP... I know this is a problem on some boards, but I thought it had been fixed on some, an

Re: LAVA integration effort for Android validation

2011-03-15 Thread Michael Hudson-Doyle
On Tue, 15 Mar 2011 11:17:14 -0500, Paul Larson wrote: > > I like statically IP. How do we know which board would get which IP? > > One idea would be to set up a DNS for internal board names. e.g. > > panda01.internal.network would resolve to our preallocated static IP > > for board "panda01". > >

Re: [PATCH V4 1/5] arm/dt: add basic mx51 device tree support

2011-03-15 Thread Jason Hui
Hi, Grant, On Tue, Mar 15, 2011 at 3:03 PM, Grant Likely wrote: > Hi Jason, > > Minor comments below. > > On Thu, Mar 10, 2011 at 12:59:41PM +0800, Jason Liu wrote: >> Signed-off-by: Jason Liu >> Signed-off-by: Jason Liu > > This looks wrong.  You should only have one s-o-b line.  Use one email

Re: [PATCH V4 5/5] net/fec: add device tree matching support

2011-03-15 Thread Jason Hui
Hi, Grant, On Tue, Mar 15, 2011 at 3:14 PM, Grant Likely wrote: > On Thu, Mar 10, 2011 at 12:59:45PM +0800, Jason Liu wrote: >> Signed-off-by: Jason Liu >> Signed-off-by: Jason Liu >> --- >>  drivers/net/fec.c |   13 + >>  1 files changed, 13 insertions(+), 0 deletions(-) >> >> diff

Re: [PATCH V4 3/5] serial/imx: parse from device tree support

2011-03-15 Thread Jason Hui
Hi, Grant, On Tue, Mar 15, 2011 at 3:07 PM, Grant Likely wrote: > Minor comments, but otherwise goes first. > > On Thu, Mar 10, 2011 at 12:59:43PM +0800, Jason Liu wrote: >> Signed-off-by: Jason Liu >> Signed-off-by: Jason Liu >> Signed-off-by: Jeremy Kerr > > Jeremy's s-o-b should go at the t

Re: Better reviews for the same cost in gcc-linaro

2011-03-15 Thread Martin Pool
On 15 March 2011 22:44, Loïc Minier wrote: >> >   7) merge to trunk (with the inevitable ChangeLog merge failure >> >      that you mentioned). > >  bzr has plugins to merge changelog entries for some types of >  changelogs; I wonder whether we could use these here.  Another option >  would be to

Re: linaro android build system issues

2011-03-15 Thread Michael Hudson-Doyle
On Fri, 11 Mar 2011 17:23:45 +1300, Michael Hudson-Doyle wrote: > Hi all, > > For some reason the jenkins instance that powers the android build > system isn't auto provisioning slaves from ec2, so builds are being > queued but not executed. If you notice this happen and it's blocking > you, ge

Re: Better reviews for the same cost in gcc-linaro

2011-03-15 Thread Michael Hope
On Tue, Mar 15, 2011 at 11:53 PM, Andrew Stubbs wrote: > Richard may know all this, but I'm just going to post anyway in case some > people reading can benefit from some tips. > > I find that bzr is slow - there's no getting around it, but there are some > tricks that can help. > > On 14/03/11 11:

Re: [PATCH 5/7] mmc: support sdhci-esdhc-imx as an OF device

2011-03-15 Thread Grant Likely
On Mon, Mar 14, 2011 at 10:25:57PM +0800, Shawn Guo wrote: > Signed-off-by: Shawn Guo dt support can be added directly to sdchi-pltfm.c drivers now. There is no longer any need to use sdhci-of-core.c any more. For an example, see the patch titled "of/tegra: add sdhci device tree handling" in my

Re: [PATCH 4/7] mmc: consolidate sdhci_pltfm_data and sdhci_of_data into one

2011-03-15 Thread Grant Likely
On Mon, Mar 14, 2011 at 10:25:56PM +0800, Shawn Guo wrote: > This patch is motivated by the work of supporting sdhci-esdhc-imx as > an OF device. The sdhci-esdhc-imx driver was well designed to be > able to work with either platform or OF bus, with a little effort to > decouple the driver from sdh

Re: Yet another memory provider: can linaro organize a meeting?

2011-03-15 Thread Alex Deucher
On Tue, Mar 15, 2011 at 12:07 PM, Robert Fekete wrote: > On 8 March 2011 20:23, Laurent Pinchart > wrote: >> Hi Andy, >> >> On Tuesday 08 March 2011 20:12:45 Andy Walls wrote: >>> On Tue, 2011-03-08 at 16:52 +0100, Laurent Pinchart wrote: >>> >>> [snip] >>> >>> > > > It really shouldn't be that h

Re: Yet another memory provider: can linaro organize a meeting?

2011-03-15 Thread Jesse Barker
On Tue, Mar 15, 2011 at 9:07 AM, Robert Fekete wrote: > On 8 March 2011 20:23, Laurent Pinchart > wrote: > > Hi Andy, > > > > On Tuesday 08 March 2011 20:12:45 Andy Walls wrote: > >> On Tue, 2011-03-08 at 16:52 +0100, Laurent Pinchart wrote: > >> > >> [snip] > >> > >> > > > It really shouldn't be

Re: LAVA integration effort for Android validation

2011-03-15 Thread Paul Larson
> I like statically IP. How do we know which board would get which IP? > One idea would be to set up a DNS for internal board names. e.g. > panda01.internal.network would resolve to our preallocated static IP > for board "panda01". > > This could then be used by the dispatcher to resolve the IP and

Re: Getting rid of update-alternative in cross toolchain packages

2011-03-15 Thread Steve Langasek
On Tue, Mar 15, 2011 at 01:00:04PM +0100, Marcin Juszkiewicz wrote: > Some time ago I looked at cross toolchain packages to find how they > handle installation of several versions at same time. It was done by > using 'update-alternatives' tool and was broken. We fixed it during > Ubuntu/Maverick cy

Re: Yet another memory provider: can linaro organize a meeting?

2011-03-15 Thread Robert Fekete
On 8 March 2011 20:23, Laurent Pinchart wrote: > Hi Andy, > > On Tuesday 08 March 2011 20:12:45 Andy Walls wrote: >> On Tue, 2011-03-08 at 16:52 +0100, Laurent Pinchart wrote: >> >> [snip] >> >> > > > It really shouldn't be that hard to get everyone involved together >> > > > and settle on a singl

Re: LAVA integration effort for Android validation

2011-03-15 Thread Alexander Sack
On Tue, Mar 15, 2011 at 4:09 PM, Paul Larson wrote: > On Mon, Mar 14, 2011 at 11:22 AM, Jeremy Chang > wrote: >> >> Hi, list: >>    I am working on Validation part for Android, in which mainly >> inclusive of integrating existing benchmark and testing suites into >> abrek, like 0xbench and androi

Re: gcc: Thumb interworking and weakly linked functions

2011-03-15 Thread Ulrich Weigand
Aneesh V wrote: > I was trying to build u-boot in Thumb2 for OMAP4. Everything was fine > until I added some patches recently. One of these patches introduced an > API (let's say foo()) that has a weakly linked alias(let's say > __foo()) and a strongly linked implementation(the real foo()) in an

Re: LAVA integration effort for Android validation

2011-03-15 Thread Paul Larson
On Mon, Mar 14, 2011 at 11:22 AM, Jeremy Chang wrote: > Hi, list: >I am working on Validation part for Android, in which mainly > inclusive of integrating existing benchmark and testing suites into > abrek, like 0xbench and android CTS. For now in my thought, if these > benchmark/testing can i

Re: [PATCH] [android/devices/linaro/common] Correct permission, owner and group on files in the root tarball

2011-03-15 Thread Alexander Sack
On Tue, Mar 15, 2011 at 2:35 PM, Patrik Ryd wrote: > On 15 March 2011 12:28, Alexander Sack wrote: >> >> would be great to have a more verbose git comment as of why we are >> doing this. e.g. what was the problem and what was the solution. also >> why do we need to have a copy of mktarball.sh rat

Re: [PATCH] [android/devices/linaro/common] Correct permission, owner and group on files in the root tarball

2011-03-15 Thread Patrik Ryd
On 15 March 2011 12:28, Alexander Sack wrote: > would be great to have a more verbose git comment as of why we are > doing this. e.g. what was the problem and what was the solution. also > why do we need to have a copy of mktarball.sh rather than fixing that > one directly. > This patch fixes th

Getting rid of update-alternative in cross toolchain packages

2011-03-15 Thread Marcin Juszkiewicz
Some time ago I looked at cross toolchain packages to find how they handle installation of several versions at same time. It was done by using 'update-alternatives' tool and was broken. We fixed it during Ubuntu/Maverick cycle but "u-a" is still in use (just versions are used now to take care of pr

Re: [PATCH] arm/dt: Add dtb make rule

2011-03-15 Thread Jason Liu
2011/3/15 Rob Herring : > Grant, > > On 03/10/2011 01:46 PM, Rob Herring wrote: >> >> From: Rob Herring >> >> Add a make rule to compile dt blobs for ARM. >> >> Signed-off-by: Rob Herring > > Can you pick this one up in your ARM tree. Test result on i.MX51 babbage board: gcl/linux-2.6$ make babba

Re: Better reviews for the same cost in gcc-linaro

2011-03-15 Thread Loïc Minier
On Tue, Mar 15, 2011, Andrew Stubbs wrote: > I find that bzr is slow - there's no getting around it, but there > are some tricks that can help. Thanks for sharing your tips; also noteworthy, this tip by Martin Pool: http://lists.linaro.org/pipermail/linaro-dev/2011-March/003282.html > I find

Re: [PATCH] [android/devices/linaro/common] Correct permission, owner and group on files in the root tarball

2011-03-15 Thread Alexander Sack
would be great to have a more verbose git comment as of why we are doing this. e.g. what was the problem and what was the solution. also why do we need to have a copy of mktarball.sh rather than fixing that one directly. On Fri, Mar 11, 2011 at 4:05 PM, Patrik Ryd wrote: > Fix for LP #731780. > -

Re: Better reviews for the same cost in gcc-linaro

2011-03-15 Thread Andrew Stubbs
Richard may know all this, but I'm just going to post anyway in case some people reading can benefit from some tips. I find that bzr is slow - there's no getting around it, but there are some tricks that can help. On 14/03/11 11:12, Richard Sandiford wrote: My concern was that, again with my

Re: [PATCH 2/2 android/device/linaro/common] mount mmc partitions instead of mtd partitions

2011-03-15 Thread Alexander Sack
On Tue, Mar 15, 2011 at 10:17 AM, Jim Huang wrote: > On 15 March 2011 16:29, Alexander Sack wrote: >> On Mon, Mar 14, 2011 at 3:37 PM, Jeremy Chang >> wrote: >>> All partitions from mmc is expected. >>> This depends on Jim Huang's patch "init: support mmc device mount" in >>> android/system/cor

Re: [PATCH 2/2 android/device/linaro/common] mount mmc partitions instead of mtd partitions

2011-03-15 Thread Jim Huang
On 15 March 2011 16:29, Alexander Sack wrote: > On Mon, Mar 14, 2011 at 3:37 PM, Jeremy Chang wrote: >> All partitions from mmc is expected. >> This depends on Jim Huang's patch "init: support mmc device mount" in >> android/system/core to work. > > what happened with the "by-name" approach? Is t

Re: [PATCH 2/2 android/device/linaro/common] mount mmc partitions instead of mtd partitions

2011-03-15 Thread Alexander Sack
On Mon, Mar 14, 2011 at 3:37 PM, Jeremy Chang wrote: > All partitions from mmc is expected. > > This depends on Jim Huang's patch "init: support mmc device mount" in > android/system/core to work. > > Signed-off-by: Jeremy Chang > --- >  init.rc |   12 ++-- >  1 files changed, 6 insertion

Re: [PATCH 2/5] arm/mxc: add clk members to ease dt clock support

2011-03-15 Thread Shawn Guo
On Tue, Mar 15, 2011 at 02:02:56AM -0600, Grant Likely wrote: > On Tue, Mar 15, 2011 at 03:50:29PM +0800, Shawn Guo wrote: > > On Tue, Mar 15, 2011 at 01:41:01AM -0600, Grant Likely wrote: > > > On Tue, Mar 08, 2011 at 11:56:34AM +0800, Shawn Guo wrote: > > > > On Mon, Mar 07, 2011 at 10:53:37AM -0

Re: [PATCH 5/5] of/clock: eliminate function __of_clk_get_from_provider

2011-03-15 Thread Grant Likely
On Tue, Mar 15, 2011 at 03:59:16PM +0800, Shawn Guo wrote: > On Tue, Mar 15, 2011 at 01:54:05AM -0600, Grant Likely wrote: > > On Mon, Mar 14, 2011 at 09:18:42PM +0800, Shawn Guo wrote: > > > With the platform clock support, the 'struct clk' should have been > > > associated with device_node->data.

Re: [PATCH 2/5] arm/mxc: add clk members to ease dt clock support

2011-03-15 Thread Grant Likely
On Tue, Mar 15, 2011 at 03:50:29PM +0800, Shawn Guo wrote: > On Tue, Mar 15, 2011 at 01:41:01AM -0600, Grant Likely wrote: > > On Tue, Mar 08, 2011 at 11:56:34AM +0800, Shawn Guo wrote: > > > On Mon, Mar 07, 2011 at 10:53:37AM -0700, Grant Likely wrote: > > > > On Mon, Mar 7, 2011 at 9:22 AM, Shawn

Re: [PATCH 3/7] mmc: make the reference to sdhci_tegra_dt_pdata conditional

2011-03-15 Thread Grant Likely
On Mon, Mar 14, 2011 at 10:25:55PM +0800, Shawn Guo wrote: > Wrap tegra dt_id with CONFIG_MMC_SDHCI_TEGRA to make the reference to > sdhci_tegra_dt_pdata conditional, otherwise it will stop build for > other mmc driver when OF is enabled. > > Signed-off-by: Shawn Guo Looks right to me. g. > --

Re: [PATCH 5/5] of/clock: eliminate function __of_clk_get_from_provider

2011-03-15 Thread Shawn Guo
On Tue, Mar 15, 2011 at 01:54:05AM -0600, Grant Likely wrote: > On Mon, Mar 14, 2011 at 09:18:42PM +0800, Shawn Guo wrote: > > With the platform clock support, the 'struct clk' should have been > > associated with device_node->data. So the use of function > > __of_clk_get_from_provider can be elim

Re: [PATCH 2/7] arm/dt: add pad configurations for mx51 babbage

2011-03-15 Thread Grant Likely
On Mon, Mar 14, 2011 at 10:20:16AM -0500, Rob Herring wrote: > Shawn, > > On 03/14/2011 09:25 AM, Shawn Guo wrote: > >The pad configuration is something common between dt and non-dt > >kernel, so it can be copied from non-dt code directly. > > > >Signed-off-by: Shawn Guo > >--- > > arch/arm/mach-

Re: [PATCH 5/5] of/clock: eliminate function __of_clk_get_from_provider

2011-03-15 Thread Grant Likely
On Mon, Mar 14, 2011 at 09:18:42PM +0800, Shawn Guo wrote: > With the platform clock support, the 'struct clk' should have been > associated with device_node->data. So the use of function > __of_clk_get_from_provider can be eliminated. > > Signed-off-by: Shawn Guo > --- > drivers/of/clock.c |

Re: [PATCH 2/5] arm/mxc: add clk members to ease dt clock support

2011-03-15 Thread Shawn Guo
On Tue, Mar 15, 2011 at 01:41:01AM -0600, Grant Likely wrote: > On Tue, Mar 08, 2011 at 11:56:34AM +0800, Shawn Guo wrote: > > On Mon, Mar 07, 2011 at 10:53:37AM -0700, Grant Likely wrote: > > > On Mon, Mar 7, 2011 at 9:22 AM, Shawn Guo wrote: > > > > The 'rate' is added for fixed-clock support, w

Re: [PATCH 3/5] arm/dt: mx51: dynamically add clocks per dt nodes

2011-03-15 Thread Grant Likely
On Mon, Mar 14, 2011 at 09:18:40PM +0800, Shawn Guo wrote: > This patch is to change the static clock creating and registering to > the dynamic way, which scans dt clock nodes, associate clk with > device_node, and then add them to clkdev accordingly. > > It's a pretty straight translation from no

Re: [PATCH 2/5] arm/mxc: add clk members to ease dt clock support

2011-03-15 Thread Grant Likely
On Tue, Mar 08, 2011 at 11:56:34AM +0800, Shawn Guo wrote: > On Mon, Mar 07, 2011 at 10:53:37AM -0700, Grant Likely wrote: > > On Mon, Mar 7, 2011 at 9:22 AM, Shawn Guo wrote: > > > The 'rate' is added for fixed-clock support, while 'pll_base' is for > > > pll clock.  These two particular type of

Re: [PATCH 3/5] arm/dt: mx51: dynamically add gpt and uart related clocks per dt nodes

2011-03-15 Thread Grant Likely
On Tue, Mar 08, 2011 at 12:22:10AM +0800, Shawn Guo wrote: > This patch is to change the static clock creating and registering to > the dynamic way, which scans dt clock nodes, associate clk with > device_node, and then add them to clkdev accordingly. > > Signed-off-by: Shawn Guo > --- > arch/ar

Re: [PATCH V4 5/5] net/fec: add device tree matching support

2011-03-15 Thread Grant Likely
On Thu, Mar 10, 2011 at 12:59:45PM +0800, Jason Liu wrote: > Signed-off-by: Jason Liu > Signed-off-by: Jason Liu > --- > drivers/net/fec.c | 13 + > 1 files changed, 13 insertions(+), 0 deletions(-) > > diff --git a/drivers/net/fec.c b/drivers/net/fec.c > index 02cdd71..fcb9768 10

Re: [PATCH V4 4/5] net/fec: check id_entry pointer before using it

2011-03-15 Thread Grant Likely
On Thu, Mar 10, 2011 at 12:59:44PM +0800, Jason Liu wrote: > The id_entry will possibly be NULL, So, need check > id_entry and make sure it not NULL before using it. > > Signed-off-by: Jason Liu > Signed-off-by: Jason Liu Other than the double s-o-b lines, this patch looks good to me. Acked-by

Re: [PATCH V4 3/5] serial/imx: parse from device tree support

2011-03-15 Thread Grant Likely
Minor comments, but otherwise goes first. On Thu, Mar 10, 2011 at 12:59:43PM +0800, Jason Liu wrote: > Signed-off-by: Jason Liu > Signed-off-by: Jason Liu > Signed-off-by: Jeremy Kerr Jeremy's s-o-b should go at the top of the list. He started it, and then you took over. s-o-b lines is the c

Re: [PATCH V4 1/5] arm/dt: add basic mx51 device tree support

2011-03-15 Thread Grant Likely
Hi Jason, Minor comments below. On Thu, Mar 10, 2011 at 12:59:41PM +0800, Jason Liu wrote: > Signed-off-by: Jason Liu > Signed-off-by: Jason Liu This looks wrong. You should only have one s-o-b line. Use one email addr or the other. Not both. > --- > arch/arm/mach-mx5/Kconfig