Hi Phil
On Fri, Mar 29, 2013 at 12:04 AM, Phil Hézaine wrote:
> Le 28/03/2013 21:44, Janek Warchoł a écrit :
>>
>> On Thu, Mar 28, 2013 at 8:09 PM, Phil Hézaine
>> wrote:
>>> Yes, I need help. I don't know how to write a patch git-formatted.
>>
>>
>> ok. A few questions:
>> - what operating sys
https://codereview.appspot.com/7518047/diff/4004/Documentation/learning/common-notation.itely
File Documentation/learning/common-notation.itely (right):
https://codereview.appspot.com/7518047/diff/4004/Documentation/learning/common-notation.itely#newcode1330
Documentation/learning/common-notatio
On 2013/03/29 04:52:29, MikeSol wrote:
On 2013/03/27 21:50:02, janek wrote:
> I see that these overrides solve the problem, but it would be nice
to know why
> this works. Can you write an explanation? What was wrong with the
skylines
> that caused this bug? Maybe this is just one instance
On 29 mars 2013, at 12:57, janek.lilyp...@gmail.com wrote:
> On 2013/03/29 04:52:29, MikeSol wrote:
>> On 2013/03/27 21:50:02, janek wrote:
>>> I see that these overrides solve the problem, but it would be nice
> to know why
>>> this works. Can you write an explanation? What was wrong with the
On 29 mars 2013, at 18:48, Phil Holmes wrote:
> I've been comparing the result of my push of my pixel-based regtest
> comparator (b4fe233aec83383bd2e6b6170fca67a31a8c492d) with current master
> (6e4e69f2735a764eab2e6f70f83546461da0203b). There are 2 changes that concern
> me. The first is th
Hi,
On Fri, Mar 29, 2013 at 5:48 PM, Phil Holmes wrote:
> I've been comparing the result of my push of my pixel-based regtest
> comparator (b4fe233aec83383bd2e6b6170fca67a31a8c492d) with current master
> (6e4e69f2735a764eab2e6f70f83546461da0203b). There are 2 changes that
> concern me. The firs
I've taken the liberty of writing some instructions on how to use my
pixel-comparator script and pushing them directly to staging. I've
patchy-ed them into master. If anyone wants to try using this script, the
instructions are now there.
--
Phil Holmes
2013/3/29 Phil Holmes
> - Original Message - From: "Janek Warchoł" <
> janek.lilyp...@gmail.com>
> To: "Phil Holmes" ; "Mike Solomon" <
> m...@mikesolomon.org>
> Cc: "Devel"
> Sent: Friday, March 29, 2013 5:38 PM
> Subject: Re: More regtest differences
>
>
>
> Hi,
>>
>> On Fri, Mar 29,
On Fri, Mar 29, 2013 at 7:04 PM, Phil Holmes wrote:
> - Original Message - From: "Janek Warchoł"
>
>
>> On Fri, Mar 29, 2013 at 5:48 PM, Phil Holmes wrote:
>>> it seems that all system start braces have
>>> been pushed a little bit further from the initial system clef.
>>
>> Isn't this a
On Fri, Mar 29, 2013 at 1:58 PM, wrote:
> Not sure - I haven't had a chance to investigate why it was wrong.
> I just spotted the problem and fixed it.
>
> It is true that knowing what's going on internally would help,
> but that's worth filing another issue for to the tune perhaps
> of "outside-
Hi Phil,
thanks for uploading your patch! There are some minor style improvements
needed.
Janek
https://codereview.appspot.com/8165043/diff/2001/ly/event-listener.ly
File ly/event-listener.ly (right):
https://codereview.appspot.com/8165043/diff/2001/ly/event-listener.ly#newcode69
ly/event-lis
https://codereview.appspot.com/8165043/diff/2001/ly/event-listener.ly
File ly/event-listener.ly (right):
https://codereview.appspot.com/8165043/diff/2001/ly/event-listener.ly#newcode69
ly/event-listener.ly:69: (eq? 0 (ly:moment-grace-numerator moment))
On 2013/03/29 19:21:31, janek wrote:
Out o
On 29 mars 2013, at 20:36, Janek Warchoł wrote:
> On Fri, Mar 29, 2013 at 7:04 PM, Phil Holmes wrote:
>> - Original Message - From: "Janek Warchoł"
>>
>>
>>> On Fri, Mar 29, 2013 at 5:48 PM, Phil Holmes wrote:
it seems that all system start braces have
been pushed a little
The commit message could be clearer (maybe-x-aligned-side's docstring is
a good explanation), but otherwise LGTM.
https://codereview.appspot.com/8171043/
___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lily
I'm happy with these changes. Thanks David.
LGTM.
Trevor
https://codereview.appspot.com/7518047/
___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel
https://codereview.appspot.com/8165043/diff/1002/ly/event-listener.ly
File ly/event-listener.ly (right):
https://codereview.appspot.com/8165043/diff/1002/ly/event-listener.ly#newcode140
ly/event-listener.ly:140: #(define (format-drumnote engraver event)
Why is this a separate function? can't it
On 2013/03/27 21:50:02, janek wrote:
What was wrong with the skylines
that caused this bug? Maybe this is just one instance of a more
general problem.
The skylines themselves were fine, but objects above a Staff are not
checked for collisions with objects below a Staff.
In the example a Dyna
Phil Holmes philholmes.net> writes:
> The second is the substantial change in the Les Nereides system
> spacing. Deliberate?
The second change is from the commit immediately before yours,
"Uses special X alignment for instrument names."
Text in a Dynamics line now has its baseline on the refe
https://codereview.appspot.com/7516048/diff/13001/lily/side-position-interface.cc
File lily/side-position-interface.cc (left):
https://codereview.appspot.com/7516048/diff/13001/lily/side-position-interface.cc#oldcode317
lily/side-position-interface.cc:317: // this seems kinda kludgy, as
there is
> On 2013/03/27 21:50:02, janek wrote:
>> What was wrong with the skylines
>> that caused this bug? Maybe this is just one instance of a more
>> general problem.
>
>
> The skylines themselves were fine, but objects above a Staff are not
> checked for collisions with objects below a Staff.
>
>
On 30 mars 2013, at 06:42, Keith OHara wrote:
> Phil Holmes philholmes.net> writes:
>
>> The second is the substantial change in the Les Nereides system
>> spacing. Deliberate?
>
> The second change is from the commit immediately before yours,
> "Uses special X alignment for instrument names
On 30 mars 2013, at 07:08, m...@mikesolomon.org wrote:
> On 30 mars 2013, at 06:42, Keith OHara wrote:
>
>> Phil Holmes philholmes.net> writes:
>>
>>> The second is the substantial change in the Les Nereides system
>>> spacing. Deliberate?
>>
>> The second change is from the commit immediat
Why not use the flat-line for empty VerticalAxisGroups specifically in
side-position-interface.cc when placing something against the staff (in
the clause if (include_staff) {} ) ?
If you make each empty VerticalAxisGroup into a line, wouldn't that
prevent interleaving beteen left- and right-hand
23 matches
Mail list logo
