Hi Phil, thanks for uploading your patch! There are some minor style improvements needed.
Janek https://codereview.appspot.com/8165043/diff/2001/ly/event-listener.ly File ly/event-listener.ly (right): https://codereview.appspot.com/8165043/diff/2001/ly/event-listener.ly#newcode69 ly/event-listener.ly:69: (eq? 0 (ly:moment-grace-numerator moment)) Out of curiosity (my knowledge about Scheme is poor): what's the difference between 'zero?' and 'eq? 0' ? Is 'eq? 0'? better in some way? https://codereview.appspot.com/8165043/diff/2001/ly/event-listener.ly#newcode140 ly/event-listener.ly:140: %%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%% ADDED %%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%% please remove %%%%%%%%%ADDED%%%%%%%%%%% lines, here and below. https://codereview.appspot.com/8165043/diff/2001/ly/event-listener.ly#newcode148 ly/event-listener.ly:148: ;; but with a DrumVoice I get: I understand that the lines below are about some problem that you have with the code. In that case, please mark it clearly with 'TODO'. https://codereview.appspot.com/8165043/diff/2001/ly/event-listener.ly#newcode295 ly/event-listener.ly:295: ; Added: chord-event please remove these '; Added: ...' comments as well. https://codereview.appspot.com/8165043/ _______________________________________________ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
