custom engraver in scheme: accessing nested Music object

2011-08-10 Thread Ricardo Wurmus
Hello, I'm currently attempting to write a custom engraver in scheme. This is the shortened code: ;; global variables to be used in `do-something' #(define g_filled #f) #(define g_direction 0) #(define g_finger 0) #(define g_string-number 0) ;; #(define-public (

Re: GOP-PROP 8: issue priorities (radical update)

2011-08-10 Thread Graham Percival
On Tue, Aug 09, 2011 at 09:27:07AM +0100, Trevor Daniels wrote: > > Jan Warchoł wrote Tuesday, August 09, 2011 12:27 AM > >Because having some issue officially block stable release is the > >only > >way of seriously pushing developers to fix it? > > Wouldn't work. Few, if any, developers use lil

Re: GOP-PROP 5: build system output (final)

2011-08-10 Thread Matthias Kilian
On Tue, Aug 09, 2011 at 04:34:57PM +0100, Phil Holmes wrote: > >I'm afraid I'm with Reinhold. As a *programmer*, I consider it very bad > >practice to ignore warnings. For the system to hide them from me, well !!! > > > They're not being ignored. They're not even being seen. Please address my

Re: GOP-PROP 5: build system output (final)

2011-08-10 Thread Matthias Kilian
On Tue, Aug 09, 2011 at 04:26:00PM +0100, Wols Lists wrote: > > out/parser.cc:2392: warning: conversion to 'short int' from 'int' may > > alter its value [...] > [...] That "out/parser" is a perfect example - it *may* > be innocuous, or it *may* be a serious problem. It really ought to be > checked

Re: GOP-PROP 9: behavior of make doc

2011-08-10 Thread Jean-Charles Malahieude
Le 10/08/2011 05:40, Graham Percival disait : This new proposal focuses on "make doc" specifically. http://lilypond.org/~graham/gop/gop_9.html ** Proposal summary If there are build problems, then it should be easier to find out why it’s failing. This will be achieved with log files, as well

Re: Progress on loose columns. (issue4841052)

2011-08-10 Thread mtsolo
I think I've hit loose column nirvana with this most recent patch set. The only thing that I know I need to work on is the magic left_padding number of 0.15 in spacing-loose-columns.cc . I know this should be made a property but I don't know where (I can implement it like it was implemented in pr

Re: GOP-PROP 8: issue priorities (radical update)

2011-08-10 Thread Trevor Daniels
Graham Percival wrote Wednesday, August 10, 2011 9:09 AM On Tue, Aug 09, 2011 at 09:27:07AM +0100, Trevor Daniels wrote: Wouldn't work. Few, if any, developers use lily-git.tcl so are unlikely to be in a position to fix it. Using lily-git.tcl and being able to fix it are completely differ

Re: custom engraver in scheme: accessing nested Music object

2011-08-10 Thread Reinhold Kainhofer
Am Wednesday, 10. August 2011, 09:44:00 schrieb Ricardo Wurmus: > Hello, > > I'm currently attempting to write a custom engraver in scheme. > This is the shortened code: It will increase the chances for a useful answer dramatically if you could attach a working example that one just has to run t

Re: custom engraver in scheme: accessing nested Music object

2011-08-10 Thread Ricardo Wurmus
On Aug 10, Reinhold Kainhofer wrote: > Am Wednesday, 10. August 2011, 09:44:00 schrieb Ricardo Wurmus: > > Hello, > > > > I'm currently attempting to write a custom engraver in scheme. > > This is the shortened code: > > It will increase the chances for a useful answer dramatically if you could > a

Re: custom engraver in scheme: accessing nested Music object

2011-08-10 Thread Reinhold Kainhofer
Am Wednesday, 10. August 2011, 13:55:49 schrieb Ricardo Wurmus: > On Aug 10, Reinhold Kainhofer wrote: > > > This is the shortened code: > > It will increase the chances for a useful answer dramatically if you > > could attach a working example that one just has to run through > > lilypond, > > I

Does better polynomial calculations for avoid objects. (issue4860042)

2011-08-10 Thread mtsolo
Reviewers: , Message: Hey all, My summer of Lily plugs along with a fix for Issue 1328. It also generally cleans up a lot of little collisions in the regtests between slurs and articulations. Passes regtests. Cheers, MS Description: Does better polynomial calculations for avoid objects. Ple

Re: custom engraver in scheme: accessing nested Music object

2011-08-10 Thread Ricardo Wurmus
> I have now spent ~25 minutes trying to strip down the engraver and adding what > you had in your first mail, but I can't reproduce anything. The music-cause > simply does not have any articulations here. > So, I now wasted almost half an hour for what? Oh shoot, I confused my example scores. I j

Re: Fix 1214: cueDuring and quoteDuring should also quote voices that create subvoices (issue4816044)

2011-08-10 Thread reinhold . kainhofer
On 2011/07/29 04:39:27, Keith wrote: On Thu, 28 Jul 2011 05:46:29 -0700, wrote: > Message: > On 2011/07/26 02:17:28, Keith wrote: >> I like it, although I can still get the error if I put a new voice in > the quoted >> expression like this: >>quoteMe

Re: custom engraver in scheme: accessing nested Music object

2011-08-10 Thread Neil Puttock
On 10 August 2011 15:00, Ricardo Wurmus wrote: > Is there a way to change that order, or call the note-head-interface > function again at the very end for processing a grob? Acknowledger order depends on the order engravers are \consist-ed (the only exception is if you set must-be-last to #t) I

Re: GOP-PROP 9: behavior of make doc

2011-08-10 Thread Phil Holmes
- Original Message - From: "Keith OHara" Have I said recently how much I really really like `make bin` ? Have you tried make -s website? -- Phil Holmes ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman

Re: GOP-PROP 9: behavior of make doc

2011-08-10 Thread Phil Holmes
- Original Message - From: "Graham Percival" There's a lot of awesome stuff there. "make bin" only needed two lines of "syntactic sugar". Compiling an individual manual is something that doc people have been requesting for *years*. I've known that it was possible for years, and always

Re: custom engraver in scheme: accessing nested Music object

2011-08-10 Thread Ricardo Wurmus
On Aug 10, Neil Puttock wrote: > On 10 August 2011 15:00, Ricardo Wurmus wrote: > > > Is there a way to change that order, or call the note-head-interface > > function again at the very end for processing a grob? > > Acknowledger order depends on the order engravers are \consist-ed (the > only exc

Re: GOP-PROP 9: behavior of make doc

2011-08-10 Thread Graham Percival
On Wed, Aug 10, 2011 at 03:51:15PM +0100, Phil Holmes wrote: > So I nuked build, started again, and make doc > failed. I've just nuked build, pulled and am running make. I'll > let you know... If that happens again, please keep it and report any error messages you can find -- although we're stil

Re: Adds a glyph for tied lyrics. (issue4808074)

2011-08-10 Thread Francisco Vila
2011/8/9 : > I'd make the tie slightly shorter.  I find it awkward that two adjacent > ties collide so easily, for example here > { >  \time 3/4 >  \relative c' { c2 e4 g2 e4 } >  \addlyrics { gran- de_a- mi- go } >  \addlyrics { pu- "ro y ho-" nes- to } >  \addlyrics { pu- ro~y~ho- nes- to } > }

Re: custom engraver in scheme: accessing nested Music object

2011-08-10 Thread Reinhold Kainhofer
Am Mittwoch, 10. August 2011, 17:11:44 schrieb Ricardo Wurmus: > On Aug 10, Neil Puttock wrote: > > BTW, if you're prepared to wrap the notes in a chord (so you have > > access to 'articulations), you won't even need a scheme engraver (all > > the processing can take place in the NoteHead's stencil

Re: Treats multi measure rest staff position like rest staff position. (issue4822046)

2011-08-10 Thread n . puttock
LGTM. http://codereview.appspot.com/4822046/diff/4001/input/regression/multi-measure-rest-staff-position.ly File input/regression/multi-measure-rest-staff-position.ly (right): http://codereview.appspot.com/4822046/diff/4001/input/regression/multi-measure-rest-staff-position.ly#newcode1 input/re

Better pure height approximations for beamed rests. (issue4860043)

2011-08-10 Thread mtsolo
Reviewers: , Description: Better pure height approximations for beamed rests. Please review this at http://codereview.appspot.com/4860043/ Affected files: A input/regression/beam-rest-extreme.ly M lily/rest.cc Index: input/regression/beam-rest-extreme.ly diff --git a/input/regression/beam

Re: Treats multi measure rest staff position like rest staff position. (issue4822046)

2011-08-10 Thread reinhold . kainhofer
LGTM. I wonder why we use get_positino in the first place, which uses the "staff-position" property only as a fall-back... http://codereview.appspot.com/4822046/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listi

Re: Creates a glissando stem grob that uses stems' functionality. (issue4777044)

2011-08-10 Thread mtsolo
New patch set up that gets Y-offset right for glissando stem scripts. Cheers, MS http://codereview.appspot.com/4777044/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: GOP-PROP 5: build system output (final)

2011-08-10 Thread Phil Holmes
- Original Message - From: "Graham Percival" To: Sent: Friday, August 05, 2011 4:32 AM Subject: GOP-PROP 5: build system output (final) Well, we can't pretend that there's unanimous support for this, and of course there will always be concerns about specific technical details... but

Re: Better pure height approximations for beamed rests. (issue4860043)

2011-08-10 Thread reinhold . kainhofer
I haven't actually tested it, but from reading the code it LGTM in general. Please observe the comments, though. http://codereview.appspot.com/4860043/diff/1/lily/rest.cc File lily/rest.cc (right): http://codereview.appspot.com/4860043/diff/1/lily/rest.cc#newcode239 lily/rest.cc:239: Interval y

Re: Better pure height approximations for beamed rests. (issue4860043)

2011-08-10 Thread n . puttock
http://codereview.appspot.com/4860043/diff/1/lily/rest.cc File lily/rest.cc (right): http://codereview.appspot.com/4860043/diff/1/lily/rest.cc#newcode238 lily/rest.cc:238: // Wont play nicely with weird staves where individual line positions are set... Don't use line_count then :) (see Breathin

GOP-PROP 8: issue priorities (probable decision)

2011-08-10 Thread Graham Percival
I'm feeling pretty good about this one, with the exception of whether we should have a Type-ignorance or not. In case you're wondering: yes, I am serious proposing that we elminiate priorities completely, and this is not a joke. Nobody has objected yet, but if you don't think this is a good idea,

Re: GOP-PROP 8: issue priorities (radical update)

2011-08-10 Thread Graham Percival
On Wed, Aug 10, 2011 at 10:32:01AM +0100, Trevor Daniels wrote: > > Graham Percival wrote Wednesday, August 10, 2011 9:09 AM > > >Using lily-git.tcl and being able to fix it are completely > >different things. IIRC the only people who have worked on > >lily-git.tcl are the original author of it,

Re: Lilypond-book: Implement musicxml support in lilypond-book (issue1659041)

2011-08-10 Thread reinhold . kainhofer
On 2011/07/26 21:38:00, J_lowe wrote: A few minor syntax and doc policy issues I have now also changed the documentation and uploaded a new patch. http://codereview.appspot.com/1659041/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://

Re: Fix 1214: cueDuring and quoteDuring should also quote voices that create subvoices (issue4816044)

2011-08-10 Thread n . puttock
LGTM. http://codereview.appspot.com/4816044/diff/15001/input/regression/quote-during-subvoice.ly File input/regression/quote-during-subvoice.ly (right): http://codereview.appspot.com/4816044/diff/15001/input/regression/quote-during-subvoice.ly#newcode1 input/regression/quote-during-subvoice.ly:

Re: GOP-PROP 9: behavior of make doc

2011-08-10 Thread Phil Holmes
- Original Message - From: "Graham Percival" To: "Phil Holmes" Cc: "Keith OHara" ; Sent: Wednesday, August 10, 2011 4:25 PM Subject: Re: GOP-PROP 9: behavior of make doc On Wed, Aug 10, 2011 at 03:51:15PM +0100, Phil Holmes wrote: So I nuked build, started again, and make doc faile

Re: GOP-PROP 8: issue priorities (radical update)

2011-08-10 Thread Trevor Daniels
Graham, you wrote Wednesday, August 10, 2011 5:48 PM On Wed, Aug 10, 2011 at 10:32:01AM +0100, Trevor Daniels wrote: Don't get me wrong. Whether we place these issues in a critical category or not is hardly a vital decision, but here we're talking about deciding Policy. Policy decisions mu

Re: Adds a glyph for tied lyrics. (issue4808074)

2011-08-10 Thread bordage . bertrand
Secondly, it does not follow the policy for syllable separator, which is '[space]--[space]', not '-[space]'. I already fixed it in this patch (for every language). Finally, 2nd and 3rd stanzas look _very_ improbable to me in that it has three syllables on a single note, which requires two lyri

Re: GOP-PROP 8: issue priorities (radical update)

2011-08-10 Thread Graham Percival
On Wed, Aug 10, 2011 at 06:44:51PM +0100, Trevor Daniels wrote: > > Graham, you wrote Wednesday, August 10, 2011 5:48 PM > > >Completely agreed! I've taken a stab at this with the "stamp of > >approval" concept of a release -- please take a look at the > >updated GOP-PROP 8...(probable decision)

New German PO file for 'lilypond' (version 2.15.9)

2011-08-10 Thread Translation Project Robot
Hello, gentle maintainer. This is a message from the Translation Project robot. A revised PO file for textual domain 'lilypond' has been submitted by the German team of translators. The file is available at: http://translationproject.org/latest/lilypond/de.po (We can arrange things so that

Re: Better pure height approximations for beamed rests. (issue4860043)

2011-08-10 Thread mtsolo
All comments have been addressed and a new patchset's uploaded. Cheers, MS http://codereview.appspot.com/4860043/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: GOP-PROP 8: issue priorities (probable decision)

2011-08-10 Thread Carl Sorensen
On 8/10/11 10:46 AM, "Graham Percival" wrote: > I'm feeling pretty good about this one, with the exception of > whether we should have a Type-ignorance or not. > > In case you're wondering: yes, I am serious proposing that we > elminiate priorities completely, and this is not a joke. Nobody

Re: Better pure height approximations for beamed rests. (issue4860043)

2011-08-10 Thread n . puttock
http://codereview.appspot.com/4860043/diff/4002/lily/rest.cc File lily/rest.cc (right): http://codereview.appspot.com/4860043/diff/4002/lily/rest.cc#newcode251 lily/rest.cc:251: Interval rest_max_pos = Staff_symbol::line_span (Staff_symbol_referencer::get_staff_symbol (me)); unsafe with \stopSta

Re: Adds a glyph for tied lyrics. (issue4808074)

2011-08-10 Thread Reinhold Kainhofer
Am Mittwoch, 10. August 2011, 19:54:52 schrieb bordage.bertr...@gmail.com: > > Finally, 2nd and 3rd stanzas look _very_ improbable to me in that it > > has three syllables on a single note, which requires two lyric ties. > > o~y is a synalepha and it could be a in-word diphthong, y~ho is > > anothe

Re: Does better polynomial calculations for avoid objects. (issue4860042)

2011-08-10 Thread pkx166h
Passes Make and there are some reg test differences - see http://code.google.com/p/lilypond/issues/detail?id=1328#c2 http://codereview.appspot.com/4860042/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/l

Re: Better pure height approximations for beamed rests. (issue4860043)

2011-08-10 Thread pkx166h
Passes make and reg tests http://codereview.appspot.com/4860043/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Get rid of some compiler warnings (issue4854049)

2011-08-10 Thread pkx166h
Passes make but there are some reg test differences see http://code.google.com/p/lilypond/issues/detail?id=804#c6 http://codereview.appspot.com/4854049/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lil

Re: Adds a glyph for tied lyrics. (issue4808074)

2011-08-10 Thread Werner LEMBERG
> I can't find it now, but I definitely remember having seen three > syllables in a soprano aria (I think it was Italian). It was > something like "-- to e in". An example is the second aria of Susanna in Mozart's `Le Nozze di Figaro', bar 16: f2 f8 e8 g8c8 fin -- chè l'a

Re: Adds a glyph for tied lyrics. (issue4808074)

2011-08-10 Thread Werner LEMBERG
> An example is the second aria of Susanna in Mozart's `Le Nozze di > Figaro', bar 16: > >f2 f8 e8 g8c8 > > fin -- chè l'a -- "ria è an" -- cor BTW, the next bar is a8[ d8] f8 g,8[ b8] d8 bru -- "na, e il" mon -- do :-) Werner __

Re: Lets auto numbering of footnotes kick in from commands alone. (issue4837047)

2011-08-10 Thread reinhold . kainhofer
That's exactly as I envisioned it. Numbering works fine, except in staff systems. the example that I sent a while ago still has some apparently random order of the numbering. http://codereview.appspot.com/4837047/diff/1017/lily/page-layout-problem.cc File lily/page-layout-problem.cc (right): ht

Re: Lilypond-book: Implement musicxml support in lilypond-book (issue1659041)

2011-08-10 Thread pkx166h
minor stuff. http://codereview.appspot.com/1659041/diff/16001/Documentation/usage/lilypond-book.itely File Documentation/usage/lilypond-book.itely (right): http://codereview.appspot.com/1659041/diff/16001/Documentation/usage/lilypond-book.itely#newcode225 Documentation/usage/lilypond-book.itely

Re: Doc: NR Warning added to para for cueduring (issue4850051)

2011-08-10 Thread pkx166h
Reviewers: Trevor Daniels, Message: Second draft, James http://codereview.appspot.com/4850051/diff/1/Documentation/notation/staff.itely File Documentation/notation/staff.itely (right): http://codereview.appspot.com/4850051/diff/1/Documentation/notation/staff.itely#newcode1304 Documentation/no

Re: Lilypond-book: Implement musicxml support in lilypond-book (issue1659041)

2011-08-10 Thread Carl . D . Sorensen
LGTM. Thanks! Carl http://codereview.appspot.com/1659041/diff/16001/Documentation/usage/lilypond-book.itely File Documentation/usage/lilypond-book.itely (right): http://codereview.appspot.com/1659041/diff/16001/Documentation/usage/lilypond-book.itely#newcode225 Documentation/usage/lilypond-b

Bezier curves in the NR

2011-08-10 Thread Trevor Daniels
James I've just noticed commit 854c9519c4d2aef9a2541c7a1684340b6c75d0f4 which you pushed recently. In it you changed my wording which describe how a Bezier curve is drawn. Your changed version is wrong. The curve does *not* go through the two intermediate control points. Could you please

Re: Adds a glyph for tied lyrics. (issue4808074)

2011-08-10 Thread Francisco Vila
2011/8/10 Werner LEMBERG : >> I can't find it now, but I definitely remember having seen three >> syllables in a soprano aria (I think it was Italian). It was >> something like "-- to e in". > > An example is the second aria of Susanna in Mozart's `Le Nozze di > Figaro', bar 16: > >   f2     f8  e8

Re: Better pure height approximations for beamed rests. (issue4860043)

2011-08-10 Thread n . puttock
LGTM. http://codereview.appspot.com/4860043/diff/11001/lily/beam.cc File lily/beam.cc (right): http://codereview.appspot.com/4860043/diff/11001/lily/beam.cc#newcode1736 lily/beam.cc:1736: Below, the prev_offset parameter is intentionally unused. This is comment it out then :) http://codereview

Re: Adds a glyph for tied lyrics. (issue4808074)

2011-08-10 Thread Francisco Vila
2011/8/10 Werner LEMBERG : >> An example is the second aria of Susanna in Mozart's `Le Nozze di >> Figaro', bar 16: >> >>    f2     f8  e8       g8        c8 >> >>   fin -- chè l'a -- "ria è an" -- cor > > BTW, the next bar is > >  a8[ d8]     f8     g,8[ b8] d8 > >  bru --  "na, e il" mon --   do

RE: Bezier curves in the NR

2011-08-10 Thread James Lowe
commit 57bf28a9c6ba1059c368214171be8f4b571533d1 From: Trevor Daniels [t.dani...@treda.co.uk] Sent: 10 August 2011 23:05 To: James Lowe Cc: Lily-Devel List Subject: Bezier curves in the NR James I've just noticed commit 854c9519c4d2aef9a2541c7a1684340b6c75

Doc: NR remove 5.1.7 (issue4839061)

2011-08-10 Thread tdanielsmusic
James My suggestion was to remove the *material* in 5.1.7 and replace it with material from 5.4.3, removing 5.4.3 as a section. The reference at the end of the material from 5.4.3 will need to be removed. Also, following Neil's reminder, we need to expand the documentation of the use of \accepts

Re: Bezier curves in the NR

2011-08-10 Thread Trevor Daniels
Thanks James - that's fine now. Trevor - Original Message - From: "James Lowe" To: "Trevor Daniels" Cc: "Lily-Devel List" Sent: Wednesday, August 10, 2011 11:28 PM Subject: RE: Bezier curves in the NR commit 57bf28a9c6ba1059c368214171be8f4b571533d1

T1349 - Fix load order for running with Guile V2 (issue4849054)

2011-08-10 Thread ianhulin44
Reviewers: , Message: This patch adjusts the load order to one which works for both Guile V1.8.7 and Guile V2.0. The markup syntax macros have been moved from markup.scm to a new file markup-macros.scm, so these can be loaded before markup.scm. Attempting to move markup.scm without doing this ca

Re: T1349 - Fix load order for running with Guile V2 (issue4849054)

2011-08-10 Thread Carl . D . Sorensen
Thanks for tackling this. Your tab to space conversion on lily.scm has lots of errors. Please either revert those changes or get them right. markup.scm should continue to use interval-length, rather than car. Thanks, Carl http://codereview.appspot.com/4849054/diff/1/scm/lily.scm File scm/li

Re: GOP-PROP 8: issue priorities (probable decision)

2011-08-10 Thread Colin Campbell
On 11-08-10 10:46 AM, Graham Percival wrote: * Type-ignorance: (fixme name?) it is not clear what the correct output should look like. We need scans, references, examples, etc. Perhaps more diplomatically as "Type- ambiguous"? Colin -- The human race has one really effecti

Re: GOP-PROP 8: issue priorities (probable decision)

2011-08-10 Thread Keith OHara
Graham Percival percival-music.ca> writes: > Type-critical: > You might want to split this into two: regressions to the output of Lilypond, and critical impediments to development > * Type-ignorance: (fixme name?) it is not clear what the > correct output should look like. In a cl

Re: GOP-PROP 8: issue priorities (probable decision)

2011-08-10 Thread Graham Percival
On Thu, Aug 11, 2011 at 04:59:02AM +, Keith OHara wrote: > Graham Percival percival-music.ca> writes: > > > Type-critical: > > > You might want to split this into two: > regressions to the output of Lilypond, and > critical impediments to development Why bother splitting it? I forsee an

Re: Adds a glyph for tied lyrics. (issue4808074)

2011-08-10 Thread Werner LEMBERG
>> An example is the second aria of Susanna in Mozart's `Le Nozze di >> Figaro', bar 16: >> >>   f2     f8  e8       g8        c8 >> >>  fin -- chè l'a -- "ria è an" -- cor >> >> Almost all singers I've met during my work as a coach have problems >> if they sing it the first time :-) > > That mak