This patch is a bit too complex for me to understand after just reading,
sorry :(
But i didn't spot anything wrong.
Janek
http://codereview.appspot.com/6584045/diff/27001/scm/output-lib.scm
File scm/output-lib.scm (right):
http://codereview.appspot.com/6584045/diff/27001/scm/output-lib.scm#newc
On 2012/11/07 07:52:33, mike7 wrote:
On 7 nov. 2012, at 09:50, mailto:d...@gnu.org wrote:
> On 2012/11/07 05:32:40, mike7 wrote:
>> On 7 nov. 2012, at 00:50, mailto:d...@gnu.org wrote:
>
>> >
>> >
>
>
http://codereview.appspot.com/6584045/diff/13014/input/regression/note-head-style.ly#newcod
On 7 nov. 2012, at 09:50, d...@gnu.org wrote:
> On 2012/11/07 05:32:40, mike7 wrote:
>> On 7 nov. 2012, at 00:50, mailto:d...@gnu.org wrote:
>
>> >
>> >
>
> http://codereview.appspot.com/6584045/diff/13014/input/regression/note-head-style.ly#newcode108
>> >> > input/regression/note-head-style.l
On 2012/11/07 05:32:40, mike7 wrote:
On 7 nov. 2012, at 00:50, mailto:d...@gnu.org wrote:
>
>
http://codereview.appspot.com/6584045/diff/13014/input/regression/note-head-style.ly#newcode108
>> > input/regression/note-head-style.ly:108: \override
Staff.Dots.style
> =
>> > #'kievan
>> > Why
http://codereview.appspot.com/6584045/diff/13015/input/regression/kievan-notation.ly
File input/regression/kievan-notation.ly (right):
http://codereview.appspot.com/6584045/diff/13015/input/regression/kievan-notation.ly#newcode13
input/regression/kievan-notation.ly:13: \bar "kievan"
This needs t
On 7 nov. 2012, at 00:50, d...@gnu.org wrote:
>
> http://codereview.appspot.com/6584045/diff/13014/input/regression/note-head-style.ly#newcode108
>> > input/regression/note-head-style.ly:108: \override Staff.Dots.style
> =
>> > #'kievan
>> > Why can't we use the new function here, e.g.,
>> >
>>
http://codereview.appspot.com/6584045/diff/13014/input/regression/note-head-style.ly#newcode108
> input/regression/note-head-style.ly:108: \override Staff.Dots.style
=
> #'kievan
> Why can't we use the new function here, e.g.,
>
> \kievanOn
>
\kievenOn only works on the voice level and the
On 5 nov. 2012, at 00:40, aleksandr.andr...@gmail.com wrote:
>
> http://codereview.appspot.com/6584045/diff/13014/input/regression/kievan-notation.ly
> File input/regression/kievan-notation.ly (right):
>
> http://codereview.appspot.com/6584045/diff/13014/input/regression/kievan-notation.ly#newco
http://codereview.appspot.com/6584045/diff/13014/input/regression/kievan-notation.ly
File input/regression/kievan-notation.ly (right):
http://codereview.appspot.com/6584045/diff/13014/input/regression/kievan-notation.ly#newcode13
input/regression/kievan-notation.ly:13: \bar "kievan"
Sorry, I mis
On 2012/11/03 18:21:09, mike7 wrote:
On 3 nov. 2012, at 12:26, mailto:d...@gnu.org wrote:
>
http://codereview.appspot.com/6584045/diff/1/scm/output-lib.scm#newcode85
> scm/output-lib.scm:85: (left-height (if (= direction DOWN)
> Is direction sure to be non-null?
>
Thanks again for the rev
http://codereview.appspot.com/6584045/diff/13014/input/regression/kievan-notation.ly
File input/regression/kievan-notation.ly (right):
http://codereview.appspot.com/6584045/diff/13014/input/regression/kievan-notation.ly#newcode12
input/regression/kievan-notation.ly:12: c4 c4 c8 [ d8 ] c4 c2 b,\l
On 4 nov. 2012, at 08:22, m...@hohlart.de wrote:
>
> http://codereview.appspot.com/6584045/diff/14002/input/regression/note-head-style.ly
> File input/regression/note-head-style.ly (right):
>
> http://codereview.appspot.com/6584045/diff/14002/input/regression/note-head-style.ly#newcode106
> inp
http://codereview.appspot.com/6584045/diff/14002/input/regression/note-head-style.ly
File input/regression/note-head-style.ly (right):
http://codereview.appspot.com/6584045/diff/14002/input/regression/note-head-style.ly#newcode106
input/regression/note-head-style.ly:106: \override Staff.Stem.ste
On 3 nov. 2012, at 12:26, d...@gnu.org wrote:
> http://codereview.appspot.com/6584045/diff/1/scm/output-lib.scm#newcode85
> scm/output-lib.scm:85: (left-height (if (= direction DOWN)
> Is direction sure to be non-null?
>
Thanks again for the review. Aleksandr can respond to this better than I
On 3 nov. 2012, at 12:26, d...@gnu.org wrote:
> http://codereview.appspot.com/6584045/diff/12001/lily/stem.cc#newcode812
> lily/stem.cc:812: Real beg = robust_scm2double (me->get_pure_property
> ("stem-begin-position", 0, INT_MAX), 0.0);
> Using robust_scm2double does not help when me is 0. This
On 2012/11/03 11:37:08, mike7 wrote:
On 3 nov. 2012, at 12:26, mailto:d...@gnu.org wrote:
>
> http://codereview.appspot.com/6584045/diff/1/lily/beam.cc
> File lily/beam.cc (right):
>
> http://codereview.appspot.com/6584045/diff/1/lily/beam.cc#newcode197
> lily/beam.cc:197: Grob *me = unsmob_gr
On 3 nov. 2012, at 12:26, d...@gnu.org wrote:
>
> http://codereview.appspot.com/6584045/diff/1/lily/beam.cc
> File lily/beam.cc (right):
>
> http://codereview.appspot.com/6584045/diff/1/lily/beam.cc#newcode197
> lily/beam.cc:197: Grob *me = unsmob_grob (smob);
> Looking at the combination of thi
http://codereview.appspot.com/6584045/diff/1/lily/beam.cc
File lily/beam.cc (right):
http://codereview.appspot.com/6584045/diff/1/lily/beam.cc#newcode197
lily/beam.cc:197: Grob *me = unsmob_grob (smob);
Looking at the combination of this and is_kievan, it would appear that
the expected response
On 2 oct. 2012, at 17:38, aleksandr.andr...@gmail.com wrote:
> On 2012/10/02 14:56:28, mike7 wrote:
>> On 2 oct. 2012, at 16:42, mailto:aleksandr.andr...@gmail.com wrote:
>
>> > What I mean is that if something like
>> >
>> > {
>> > \override NoteHead #'style = #'kievan
>> > c'8
>> > }
>> >
>> >
On 2012/10/02 14:56:28, mike7 wrote:
On 2 oct. 2012, at 16:42, mailto:aleksandr.andr...@gmail.com wrote:
> What I mean is that if something like
>
> {
> \override NoteHead #'style = #'kievan
> c'8
> }
>
> produces a quarter note in the output, the user is likely to be
> thoroughly confused.
Am 02.10.2012 16:56, schrieb m...@mikesolomon.org:
On 2 oct. 2012, at 16:42, aleksandr.andr...@gmail.com wrote:
What I mean is that if something like
{
\override NoteHead #'style = #'kievan
c'8
}
produces a quarter note in the output, the user is likely to be
thoroughly confused.
Is this bec
On 2 oct. 2012, at 16:42, aleksandr.andr...@gmail.com wrote:
> What I mean is that if something like
>
> {
> \override NoteHead #'style = #'kievan
> c'8
> }
>
> produces a quarter note in the output, the user is likely to be
> thoroughly confused.
Is this because of the duration-log override?
On 2012/10/02 07:28:10, J_lowe wrote:
If you are talking about the Documentation in the Notation Reference,
the
Ancient Notation doesn't follow (mostly) the standard Policies at all
- indeed
there is a while tracker to tidy this section up, I started but I
don't have any
knowlegde of Ancien
On 2 oct. 2012, at 05:02, aleksandr.andr...@gmail.com wrote:
> On 2012/10/01 23:34:39, MikeSol wrote:
>> I think a user should be able to use Kievan notation and normal
>> stems/flags/beams if she so chooses. I'll define something like
>
>> [snip]
>
>> and then use it in the documentation.
>
>
On 2012/10/02 03:02:15, aleksandr.andreev wrote:
...
If we implement the patch as written, Kievan note heads outside of the
KievanVoice context wouldn't make sense. I'm not altogether opposed to
that (I
see no real reason to not use KievanVoice), but it seems like a
"policy" issue,
as it wou
On 2012/10/01 23:34:39, MikeSol wrote:
I think a user should be able to use Kievan notation and normal
stems/flags/beams if she so chooses. I'll define something like
[snip]
and then use it in the documentation.
I still see some issues with this. As written now in stem.cc, when the
style
Reviewers: aleksandr.andreev,
Message:
I think a user should be able to use Kievan notation and normal
stems/flags/beams if she so chooses. I'll define something like
startKievanNotation = {
%% Set glyph styles.
\override NoteHead #'style = #'kievan
\override Rest #'style = #'mensural
\ove
27 matches
Mail list logo
