Re: [PATCH] Add showFirstLength property

2008-10-19 Thread Valentin Villenave
2008/10/10 Han-Wen Nienhuys <[EMAIL PROTECTED]>: > I would do this Q&D by overwriting the 'length property of the top > music expression, which will be still a lot faster. OK, here's (yet) one more (last?) version of my patch. Let's recap: - supports both showLastLength and showFirstLength (even

Re: [PATCH] Add showFirstLength property

2008-10-19 Thread Valentin Villenave
2008/10/19 Nicolas Sceaux <[EMAIL PROTECTED]>: > Have you tried something like (supposing your work is in `mybranch'): > git checkout mybranch > git-cl upload master..mybranch No luck: [EMAIL PROTECTED] git]$ git cl upload master..firstLength fatal: ambiguous argument 'master..firstLength..': un

Re: [PATCH] Add showFirstLength property

2008-10-19 Thread Nicolas Sceaux
Le 18 oct. 08 à 23:24, Valentin Villenave a écrit : PS. for the n-th time I tried to upload it to the online codereview, but it miserably fails: [EMAIL PROTECTED] git]$ git cl upload Command "git config branch.master.merge" failed. Unable to determine default branch to diff against. Either pass

Re: [PATCH] Add showFirstLength property

2008-10-18 Thread Valentin Villenave
2008/10/15 Valentin Villenave <[EMAIL PROTECTED]>: > I like the idea, and this would indeed make compiling a lot faster, > but it you overwrite the 'length property, then you loose the ability > to use both showLastLength and showFirstLength (i.e. process *both* > the beginning and the end of the

Re: [PATCH] Add showFirstLength property

2008-10-15 Thread Valentin Villenave
2008/10/10 Han-Wen Nienhuys <[EMAIL PROTECTED]>: > I would do this Q&D by overwriting the 'length property of the top > music expression, which will be still a lot faster. Greetings Han-Wen, If I understand correctly, it would make LilyPond "think" that the score is shorter than what it really i

Re: [PATCH] Add showFirstLength property

2008-10-10 Thread Valentin Villenave
2008/10/10 Han-Wen Nienhuys <[EMAIL PROTECTED]>: > void > Global_context::run_iterator_on_me (Music_iterator *iter) > { > prev_mom_.set_infinite (-1); > now_mom_.set_infinite (-1); > Moment final_mom = iter->get_music ()->get_length (); > > I would do this Q&D by overwriting the 'length property

Re: [PATCH] Add showFirstLength property

2008-10-09 Thread Han-Wen Nienhuys
void Global_context::run_iterator_on_me (Music_iterator *iter) { prev_mom_.set_infinite (-1); now_mom_.set_infinite (-1); Moment final_mom = iter->get_music ()->get_length (); I would do this Q&D by overwriting the 'length property of the top music expression, which will be still a lot fast

Re: [PATCH] Add showFirstLength property

2008-10-09 Thread Neil Puttock
2008/10/9 Valentin Villenave <[EMAIL PROTECTED]>: > Here's a better version of the same patch, as it allows both > showLastLength and showFirstLength to be set at the same time (in case > you'd want to check both the beginning and the end of your score :-) Cool. :) I was just about to reply to y

Re: [PATCH] Add showFirstLength property

2008-10-09 Thread Valentin Villenave
2008/10/8 Valentin Villenave <[EMAIL PROTECTED]>: > Here's a patch to music-functions.scm in order to add the > showFirstLength property that many LilyPonders (well, myself at least > :-) need. It also updates the documentation, and the relevant regtest. Here's a better version of the same patch,

[PATCH] Add showFirstLength property

2008-10-08 Thread Valentin Villenave
Greetings, (some day I *may* figure out how to use the online patch reviewer thingy; I can't understand why it keeps asking me for a SVN repository when we're using an external git repo) Here's a patch to music-functions.scm in order to add the showFirstLength property that many LilyPonders (well