Re: GOP-PROP 5: build system output (probable 2?)

On Thu, Jul 28, 2011 at 08:25:25AM +0200, Jan Nieuwenhuizen wrote: > Graham Percival writes: > > > You mean, like > > 23cdda9506931d5b9a1e75ee8be8b74f9084a7c0 > > ? > > Yes (I would have called the option --log). IMO a long descriptive name is better than a short name that's open to interpreta

Re: GOP-PROP 5: build system output (probable 2?)

Graham Percival writes: > You mean, like > 23cdda9506931d5b9a1e75ee8be8b74f9084a7c0 > ? Yes (I would have called the option --log). > I'd call it 20% rather than 90%, but yes, Phil's work on > lilypond-book will certainly be valuable! Assuming that --redirect-lilypond-output is used during bu

Re: review process not working

I agree with Graham that it's a matter of bad luck (i.e. "stuff happens"). If i understand Graham correctly, the idea of countdown is not to add some beaurocratic order, but to force us to "speak now, or forever be silent" (tongue-in-cheek, of course). In other words, a patch without reviews is n

Re: GOP-PROP 5: build system output (probable 2?)

Graham Percival writes: > You mean, like > 23cdda9506931d5b9a1e75ee8be8b74f9084a7c0 > ? Yes (I would have called the option --log). > I'd call it 20% rather than 90%, but yes, Phil's work on > lilypond-book will certainly be valuable! Assuming that --redirect-lilypond-output is used during bu

Re: GOP-PROP 5: build system output (probable 2?)

On Thu, Jul 28, 2011 at 07:33:04AM +0200, Jan Nieuwenhuizen wrote: > Graham Percival writes: > > > I still don't feel that we have any kind of consensus on this. > > Here's an updated proposal. > > So what if we add a --log option to lilypond-book (and probably > to lilypond), that [always in ver

Re: GOP-PROP 5: build system output (probable 2?)

Graham Percival writes: > I still don't feel that we have any kind of consensus on this. > Here's an updated proposal. Ah, great. So what if we add a --log option to lilypond-book (and probably to lilypond), that [always in verbose mode?] writes individual .log files alongside the output. Would

Re: PATCH: 48-Hour countdown to 20:00 MDT Friday July 29

On Wed, Jul 27, 2011 at 08:04:21PM -0600, Colin Campbell wrote: > The list of patches still not dealt with is rather alarming: is it because > devels are on holiday, am I missing the closed or fixed tags in Rietveld and > Google Code?  How can I help you folk keep this moving? You could check the

Re: Adds longas, maximas and non-standard tweaks to MultiMeasureRest (issue4536068)

Works good for me. On 2011/07/27 17:49:01, MikeSol wrote: Why not just an array that acts as a log table? int foo[10] = {1,2,4,8,16,32,64,128,256,512}; Bertrand already has something better, walking along the (very short) list of usable-duration-logs. http://codereview.appspot.com/453606

Re: First pass at avoiding very high slurs (fixes issue 163). (issue4817048)

as an overall comment; I would try to look at the buggy examples in more detail to understand exactly what is going wrong. It is easy to add an extra demerit, but (as you can see) hard to make it work with all the other cases that we handle. http://codereview.appspot.com/4817048/diff/15002/lily

PATCH: 48-Hour countdown to 20:00 MDT Friday July 29

New today, for Friday: Issue 621 : Dynamics should avoid cross-staff BarLines (e.g. GrandStaff, PianoStaff etc) - Rietveld Countdown done, but still open/not marked fixed: From Wednesday July 27 Issue 732

Re: Remove special case in staff-spacing (issue4188051)

http://codereview.appspot.com/4188051/diff/4001/lily/include/spacing-spanner.hh#newcode45 lily/include/spacing-spanner.hh:45: static Real cushion_; I think this should be a grob property rather than a static variable. New patch set up, simpler, no longer involves any static variable. http://c

Re: 2.15.6 regtests

> midi-volume-equaliser.log (and other midi regtests): warnings removed (I've > lost track of whether these are supposed to be there) > -warning: MIDI channel wrapped around They are not, and their appearances in regression test comparisons will disappear soon, as the patch spreads through

Re: Adds epsilon to Bezier range calculations. (issue4820048)

That's weird - the overlap looks way more than 1e-10. Are you sure it is taking the correct extent of the number into account? (I am surprised that we do tuplet number/slur collisions at all.) 2011/7/27 m...@apollinemike.com > On Jul 27, 2011, at 10:59 PM, hanw...@gmail.com wrote: > > this jus

Re: 2.15.6 regtests

Carl Sorensen writes: > On 7/27/11 9:53 AM, "David Kastrup" wrote: > >> "Phil Holmes" writes: >> >>> incompatible-stem-warning.log: lots of changed lines: a sample: >>> -/main/src/gub/target/linux-x86/src/lilypond-git.sv.gnu.org--lilypond.git-rel >>> ease-unstable/input/regression/incompatible

Re: 2.15.6 regtests

On 7/27/11 9:53 AM, "David Kastrup" wrote: > "Phil Holmes" writes: > >> incompatible-stem-warning.log: lots of changed lines: a sample: >> -/main/src/gub/target/linux-x86/src/lilypond-git.sv.gnu.org--lilypond.git-rel >> ease-unstable/input/regression/incompatible-stem-warning.ly:16:20: >> warni

Re: Adds epsilon to Bezier range calculations. (issue4820048)

On Jul 27, 2011, at 10:59 PM, hanw...@gmail.com wrote:this just moves the rounding error an epsilon away.can you post an image of the problem you're solvnig ?http://codereview.appspot.com/4820048/With my new patch, the tuplet collision right at the end of the slur is avoided (lily finds a Bezier in

Re: changing shape of the G clef (issue4664070)

Going back to replacing the clef only. Old glyph is no longer in the patch, we may discuss it separately. http://codereview.appspot.com/4664070/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-dev

Re: Postscript printer errors with rounded barlines?

On Wed, Jul 27, 2011 at 3:23 PM, Jan Warchoł wrote: >> I think this is an other issue.  Due to rounding, PDF viewers can err >> the placement of the barline by a pixel. This is insolvable, as there >> is no way to hint that the barline should coincide with the staffline, >> yet we need to go the

Re: Adds epsilon to Bezier range calculations. (issue4820048)

this just moves the rounding error an epsilon away. can you post an image of the problem you're solvnig ? http://codereview.appspot.com/4820048/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-dev

Re: Adds epsilon to Bezier range calculations. (issue4820048)

Added as http://code.google.com/p/lilypond/issues/detail?id=1784 Just in case (some people use tracker more than Rietveld or their inbox so this may get more eyes). http://codereview.appspot.com/4820048/ ___ lilypond-devel mailing list lilypond-devel

Re: Adds epsilon to Bezier range calculations. (issue4820048)

On 2011/07/27 08:37:06, MikeSol wrote: This passes regtests It does indeed :) James http://codereview.appspot.com/4820048/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: First pass at avoiding very high slurs (fixes issue 163). (issue4817048)

On 2011/07/27 19:30:41, J_lowe wrote: Passes Make and reg tests. Sorry I updated the wrong Rietveld issue. This does pass make but there are reg test differences - see http://code.google.com/p/lilypond/issues/detail?id=163#c17 http://codereview.appspot.com/4817048/ __

Re: First pass at avoiding very high slurs (fixes issue 163). (issue4817048)

Passes Make and reg tests. http://codereview.appspot.com/4817048/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: 2.15.6 regtests

On Mi., 27. Jul. 2011 17:47:42 CEST, Phil Holmes wrote: > display-lily-tests.log: lots of added lines: > > +Test 125 unequal: NOT A BUG. > +in  = \oneVoice ... That's expected. Cheers, Reinhold ___ lilypond-devel mailing list lilypond-devel@gnu.org h

Re: Fix for Issue 620. (issue4814041)

Passes Make and reg tests http://codereview.appspot.com/4814041/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Lilypond-book: Implement musicxml support in lilypond-book (issue1659041)

http://codereview.appspot.com/1659041/diff/5001/Documentation/usage/lilypond-book.itely File Documentation/usage/lilypond-book.itely (right): http://codereview.appspot.com/1659041/diff/5001/Documentation/usage/lilypond-book.itely#newcode226 Documentation/usage/lilypond-book.itely:226: @end examp

GOP-PROP 5: build system output (probable 2?)

I still don't feel that we have any kind of consensus on this. Here's an updated proposal. http://lilypond.org/~graham/gop/gop_5.html ** Proposal summary When you run make or make doc, * All output will be saved to various log files, with the exception of output directly from make(1)

Re: Postscript printer errors with rounded barlines?

2011/7/26 Han-Wen Nienhuys : > On Sat, Jul 23, 2011 at 7:45 PM, Jan Warchoł > wrote: > >> I'm not experienced with PostScript, but i have an impression that >> this may be related to an issue discussed earlier - see here >> http://lists.gnu.org/archive/html/lilypond-user/2007-07/msg00485.html >> a

Re: printed bars thickness inconsistencies

2011/7/26 Jean-Alexis Montignies : > It looks much better on screen (Preview.app: MacOS X system renderer) and on > Xerox Phaser 5400! > > Remains a little bit of smearing on the top of the staff, but this is much > less than before and could be some rounding/smoothing issue in the renderers. >

Re: Adds longas, maximas and non-standard tweaks to MultiMeasureRest (issue4536068)

http://codereview.appspot.com/4536068/diff/30001/lily/multi-measure-rest.cc File lily/multi-measure-rest.cc (right): http://codereview.appspot.com/4536068/diff/30001/lily/multi-measure-rest.cc#newcode131 lily/multi-measure-rest.cc:131: int measure_duration_log = int (ceil (duration_log)); On 201

Re: Adds longas, maximas and non-standard tweaks to MultiMeasureRest (issue4536068)

http://codereview.appspot.com/4536068/diff/30001/lily/multi-measure-rest.cc File lily/multi-measure-rest.cc (right): http://codereview.appspot.com/4536068/diff/30001/lily/multi-measure-rest.cc#newcode131 lily/multi-measure-rest.cc:131: int measure_duration_log = int (ceil (duration_log)); On 201

Re: Doc build error

On Wed, Jul 27, 2011 at 03:57:11PM +0100, Phil Holmes wrote: > Part way through making a new virtual machine with lilydev 1.1 on > it. This version does not have the lily-git.tcl script on the > desktop - I had to grab it from my older VM. These instructions: http://lilypond.org/doc/v2.15/Documen

Re: 2.15.6 regtests

On Wed, Jul 27, 2011 at 04:47:42PM +0100, Phil Holmes wrote: > event-listener-output.ly: output is spaced completely differently, > albeit it looks better to me. Yes, there was a rhythm problem in the old version. > event-listener-output.log: lots and lots more output. The format of the rest eve

Re: Adds longas, maximas and non-standard tweaks to MultiMeasureRest (issue4536068)

This is really dirty, but here's an update that does what you want (I hope). If you have ideas to clean a bit this mess... Thanks, Bertrand http://codereview.appspot.com/4536068/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu

Re: Fix for Issue 620. (issue4814041)

A new version of this patch is up w/ the name of the property changed to bound-alignment-interfaces. Cheers, MS http://codereview.appspot.com/4814041/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypo

2.14.2 regtests (vs 2.14.1)

accidental-placement.ly (and others): no naturals before other accidentals- expected change. A number of regtests are places/spaced better; e.g. fingering-cross-staff.ly midi-volume-equaliser.log (for example): -warning: MIDI channel wrapped around -warning: remapping modulo 16 BUT. midi-grace.l

Re: 2.15.6 regtests

"Phil Holmes" writes: > incompatible-stem-warning.log: lots of changed lines: a sample: > -/main/src/gub/target/linux-x86/src/lilypond-git.sv.gnu.org--lilypond.git-release-unstable/input/regression/incompatible-stem-warning.ly:16:20: > warning: adding note head to incompatible stem (type = 1/2) >

2.15.6 regtests

Results from the official regtests: event-listener-output.ly: output is spaced completely differently, albeit it looks better to me. stem-tremolo.ly: changes are shown (and with many other tremolo-containing regtests). The changes are small enough that it's not clear what they are. rest-ledge

Re: Lilypond pixel comparisons on a subset of the retests

I've never run the regtests on my VM here, but I would guess this would work if you simply edit the number of files in the regtest directory? -- Phil Holmes - Original Message - From: To: "Phil Holmes" Cc: Sent: Wednesday, July 27, 2011 4:07 PM Subject: Re: Lilypond pixel comparis

Re: Lilypond pixel comparisons on a subset of the retests

Hey Phil, Thanks for the offer! Unfortunately, I don't have Windows, and I'll be running this on several batches of PNGs. I overstated my case when I said pixel comparison: I just need to be able to selectively run certain tests and see generally if they differ. I'm sure that I could hack the

Re: Doc build error

- Original Message - From: "James Lowe" @Phil you should use the out of tree 'build' dir method, it's really convenient - see the CG. James I do - I quite often nuke it and start from scratch. My problem wasn't fixed by doing this. -- Phil Holmes __

Re: Doc build error

- Original Message - From: "Graham Percival" To: "Phil Holmes" Cc: Sent: Wednesday, July 27, 2011 12:19 AM Subject: Re: Doc build error On Tue, Jul 26, 2011 at 09:58:14PM +0100, Phil Holmes wrote: I'm _still_ running the older version of lilydev, but with all the patches. hmm.

Re: Lilypond pixel comparisons on a subset of the retests

- Original Message - From: To: Sent: Wednesday, July 27, 2011 11:38 AM Subject: Lilypond pixel comparisons on a subset of the retests Hey all, If I'm working on a patch that effects a specific set of ly files, is there anyway to do a select pixel comparison between a baseline and t

Re: Lilypond-book: Implement musicxml support in lilypond-book (issue1659041)

Of course, all comments for the docs apply to HTML/LaTeX/Texinfo as well. http://codereview.appspot.com/1659041/diff/5001/Documentation/usage/lilypond-book.itely File Documentation/usage/lilypond-book.itely (right): http://codereview.appspot.com/1659041/diff/5001/Documentation/usage/lilypond-bo

Re: First pass at avoiding very high slurs (fixes issue 163). (issue4817048)

On Jul 27, 2011, at 3:37 PM, tdanielsmu...@googlemail.com wrote: > > http://codereview.appspot.com/4817048/diff/13001/lily/include/slur-score-parameters.hh > File lily/include/slur-score-parameters.hh (right): > > http://codereview.appspot.com/4817048/diff/13001/lily/include/slur-score-paramete

Re: First pass at avoiding very high slurs (fixes issue 163). (issue4817048)

http://codereview.appspot.com/4817048/diff/13001/lily/include/slur-score-parameters.hh File lily/include/slur-score-parameters.hh (right): http://codereview.appspot.com/4817048/diff/13001/lily/include/slur-score-parameters.hh#newcode32 lily/include/slur-score-parameters.hh:32: Real max_distance_

Removes closeness-factor from the Slur details list. (issue4825051)

Reviewers: , Message: This passes regtests without any change in the visual output. After wading through slur-configuration.cc, I would like to prune the details list as much as possible so that subsequent wadings are easier to understand for everyone. In general, if the absence of a parameter

Lilypond pixel comparisons on a subset of the retests

Hey all, If I'm working on a patch that effects a specific set of ly files, is there anyway to do a select pixel comparison between a baseline and these files without running the whole regrets machine? Cheers, MS ___ lilypond-devel mailing list lilypo

RE: Produces better error messages when programmers forget to document a property. (issue4801045)

Hello, )-Original Message- )From: mts...@gmail.com [mailto:mts...@gmail.com] )Sent: 27 July 2011 09:43 )To: n.putt...@gmail.com; lemniskata.bernoull...@gmail.com; )pkx1...@gmail.com; gra...@percival-music.ca; )m...@apollinemike.com; James Lowe )Cc: lilypond-devel@gnu.org; re...@codereview.

RE: some comments do not appear in the tracker page

Janek )-Original Message- )From: lilypond-devel-bounces+james.lowe=datacore@gnu.org )[mailto:lilypond-devel-bounces+james.lowe=datacore@gnu.org] On )Behalf Of Janek Warchol )Sent: 27 July 2011 09:55 )To: lilypond-devel@gnu.org; Lilypond Bugreports )Subject: some comments do not app

Re: Treats multi measure rest staff position like rest staff position. (issue4822046)

On 2011/07/23 20:54:40, MikeSol wrote: Should fix issue 1604. Passes regtests. http://codereview.appspot.com/4822046/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

some comments do not appear in the tracker page

Hi, there is a problem with comments in the tracker. At least 2 comments didn't make it to the "changing G clef" issue page: - Trevor's comment from July 26th, containing sentence "The G clef font was changed 18 months or so ago by Carl without all this fuss" - Carls comment, perhaps from July 25

Re: Makes parameters for hairpin rotation available in Scheme (issue4809051)

On 2011/07/25 22:22:05, graham_percival-music.ca wrote: On Mon, Jul 25, 2011 at 09:17:53AM +0200, mailto:m...@apollinemike.com wrote: > > We may want to just fix issue 36 via something in the docs- ... > but as there is no clear way to > deal with these collisions, perhaps a section in the > doc

Re: Produces better error messages when programmers forget to document a property. (issue4801045)

On 2011/07/25 11:18:28, James.Lowe_datacore.com wrote: Hello, )-Original Message- )From: mailto:lilypond-devel-bounces+james.lowe=datacore@gnu.org )[mailto:lilypond-devel-bounces+james.lowe=datacore@gnu.org] On )Behalf Of mailto:m...@apollinemike.com )Sent: 24 July 2011 09:41 )

Re: Fixes note column skylines by adding a stem tremolo pure height function. (issue4754054)

On 2011/07/27 08:40:04, MikeSol wrote: On 2011/07/24 11:06:43, J_lowe wrote: > Passes make and reg tests show some differences - nothing significantly wrong > > see > http://code.google.com/p/lilypond/issues/detail?id=1768#c6 > > for screenshots > > (couldn't see where mikes attached difference

Re: Fixes note column skylines by adding a stem tremolo pure height function. (issue4754054)

On 2011/07/24 11:06:43, J_lowe wrote: Passes make and reg tests show some differences - nothing significantly wrong see http://code.google.com/p/lilypond/issues/detail?id=1768#c6 for screenshots (couldn't see where mikes attached differences were - so redid them again myself for the tr

Adds epsilon to Bezier range calculations. (issue4820048)

Reviewers: , Message: This passes regtests and adds a regtest to show it in action. As I know nothing about rounding error in C++, I'd like others who are more familiar with this to comment on the way I handle it. Cheers, MS Description: Adds epsilon to Bezier range calculations. Please revie

Re: First pass at avoiding very high slurs (fixes issue 163). (issue4817048)

On 2011/07/24 13:50:53, MikeSol wrote: New patchset uploaded with minor tweaks. I still need to think about a better way to implement the change in score_edges. The idea is that if there is a large jump right at the beginning or end of the stem, we should favor attachments points that are c