Re: Fix crash when a stencil routine is missing

2009-07-15 Thread Patrick McCarty
On Thu, Jul 16, 2009 at 05:42:25AM +, joenee...@gmail.com wrote: > lgtm > > http://codereview.appspot.com/83046 Thanks, Joe. It's applied. -Patrick ___ lilypond-devel mailing list lilypond-devel@gnu.org http://lists.gnu.org/mailman/listinfo/lilyp

Re: centering of instrument names

2009-07-15 Thread Joe Neeman
On Wed, 2009-07-15 at 22:07 +0100, Neil Puttock wrote: > 2009/5/30 Joe Neeman : > > > The sanest behaviour IMO is the behaviour of your current patch, but > > with a different meaning for 'padding. I can see two ways to do this: > > the quick&dirty way to get this is to replace > > instrument-name

New instrument name positioning in Scheme.

2009-07-15 Thread joeneeman
Just one corner case, otherwise lgtm http://codereview.appspot.com/91119/diff/1/10 File scm/output-lib.scm (right): http://codereview.appspot.com/91119/diff/1/10#newcode833 Line 833: (interval-center extent If (not (pair? live-elts)) then (interval-center extent) will be NaN, instead of 0 w

Re: Fix crash when a stencil routine is missing

2009-07-15 Thread joeneeman
lgtm http://codereview.appspot.com/83046 ___ lilypond-devel mailing list lilypond-devel@gnu.org http://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: [PATCH v3] Fix crash when a stencil routine is missing

2009-07-15 Thread Patrick McCarty
On Tue, Jul 7, 2009 at 2:44 PM, Patrick McCarty wrote: > Hello, > > The third revision of my patch set (Patch Set 5) is on Rietveld: > > http://codereview.appspot.com/83046/show > > The change from Patch Set 4 is the generalization of > -dwarning-as-error.  Note that this is a series of 8 commits t

Re: New markup commands: \left-brace & \right-brace.

2009-07-15 Thread Patrick McCarty
On Wed, Jul 15, 2009 at 8:40 PM, wrote: > > http://codereview.appspot.com/8874/diff/2201/3202 > File scm/define-markup-commands.scm (right): > > http://codereview.appspot.com/8874/diff/2201/3202#newcode2625 > Line 2625: (find-brace (binary-search 0 575 get-y-from-brace > scaled-size)) > Would Open

New markup commands: \left-brace & \right-brace.

2009-07-15 Thread pnorcks
http://codereview.appspot.com/8874/diff/2201/3202 File scm/define-markup-commands.scm (right): http://codereview.appspot.com/8874/diff/2201/3202#newcode2625 Line 2625: (find-brace (binary-search 0 575 get-y-from-brace scaled-size)) Would Open_type_font::count () return the value 575 you need her

Re: @subsection foo should get

2009-07-15 Thread Graham Percival
On Wed, Jul 15, 2009 at 01:44:03PM -0700, Mark Polesky wrote: > > Graham Percival wrote: > > I believe it should be > > @node > > @unnumberedsubsec > > > > You can use them inside an @appendicsec, and since the html pages > > are split based on numbers, we want an @unnumbered... there. > > J

Re: proposal for user view of docs

2009-07-15 Thread Graham Percival
On Wed, Jul 15, 2009 at 01:42:33PM +0200, John Mandereau wrote: > Le samedi 11 juillet 2009 à 03:13 -0700, Graham Percival a écrit : > > There are a few modifications: > > - the top menu from the website might still present (I'm not > > certain if this would be a good idea or not) > >

Re: Obsolete snippets

2009-07-15 Thread Carl Sorensen
On 7/15/09 6:30 PM, "Francisco Vila" wrote: > 2009/7/15 John Mandereau : >> Le lundi 13 juillet 2009 à 06:07 -0600, Carl Sorensen a écrit : >>> So, in order to not have broken documentation, I need to eliminate old file >>> referenes, and old in-line snippets as well. >>> >>> I guess I should j

Re: Obsolete snippets

2009-07-15 Thread Francisco Vila
2009/7/15 John Mandereau : > Le lundi 13 juillet 2009 à 06:07 -0600, Carl Sorensen a écrit : >> So, in order to not have broken documentation, I need to eliminate old file >> referenes, and old in-line snippets as well. >> >> I guess I should just edit all of the Documentation/*/user/rhythms.itely

Re: New format for autobeaming rules

2009-07-15 Thread Carl Sorensen
On 7/15/09 3:45 PM, "n.putt...@gmail.com" wrote: > > > http://codereview.appspot.com/88155/diff/2005/3086 > File scm/music-functions.scm (right): > > http://codereview.appspot.com/88155/diff/2005/3086#newcode519 > Line 519: (make-simultaneous-music output) > This breaks all the Festival reg

Re: accessing accidentals with \tweak

2009-07-15 Thread TaoCG
Mark Polesky wrote: > > Mark Polesky wrote: > Okay, I figured out a way around this -- by passing an property-alist to > the 'before-line-breaking tweak, I was able to get all the accidental > modifications done in one tweak (see "modify-accidental" below). > I just came up with something simi

Re: accessing accidentals with \tweak

2009-07-15 Thread Mark Polesky
Mark Polesky wrote: > Unfortunately this doesn't seem to work. See attached PNG and > console output below. When using this "indirect" tweaking method, > only the *last* tweak affects the typeset output. The desired > output in the example below is to have both E-naturals colored red > and reduced

Re: New format for autobeaming rules

2009-07-15 Thread n . puttock
http://codereview.appspot.com/88155/diff/2005/3086 File scm/music-functions.scm (right): http://codereview.appspot.com/88155/diff/2005/3086#newcode519 Line 519: (make-simultaneous-music output) This breaks all the Festival regression tests which use \time (song-associated-voice.ly, song-basic.ly

Re: New format for autobeaming rules

2009-07-15 Thread Neil Puttock
2009/7/15 Carl Sorensen : > I'm not sure I understand why you think it should it be in input/new instead > of just being in the docs.  It doesn't use \set or \override.  It explains > the use of a LilyPond command.  That's why I thought it should be an inline > snippet. It's positioned in the mid

Re: centering of instrument names

2009-07-15 Thread Neil Puttock
2009/5/30 Joe Neeman : > The sanest behaviour IMO is the behaviour of your current patch, but > with a different meaning for 'padding. I can see two ways to do this: > the quick&dirty way to get this is to replace > instrument-name::calc-combined-delimiters-offset with > instrument-name::calc-min-

musicxml2ly bug?

2009-07-15 Thread ArnoWaschk
Dear list, while trying to import some scores into lilypond i was given as xml export from a finale using collegue, i stumbled across some problems... by far the most common one i tried to reduce into the attached files. while the xml (correctly) contains a "Vivace" mark in the first bar, the .l

Re: @subsection foo should get

2009-07-15 Thread Mark Polesky
Graham Percival wrote: > >> Yes. You can add a menu to the Feta font > >> section and introduce each subsection with > >> > >> @node > >> @subsection ... > > > > As we're in an appendix maybe this should be > > > > @node ... > > @appendixsubsec ... ? > > I believe it should be > @node >

Re: accessing accidentals with \tweak

2009-07-15 Thread Mark Polesky
Carl Sorensen wrote: > What if a property like tweak-callback were added, whose job is > just to trigger the grob callback necessary for what you want to > do? > > Then you could have > \relative { > > } > > I think you could have multiple calls to #'tweak-callback, > because all of the tweaks a

Re: New format for autobeaming rules

2009-07-15 Thread Carl Sorensen
On 7/15/09 9:30 AM, "John Mandereau" wrote: > Le mercredi 15 juillet 2009 à 07:43 -0600, Carl Sorensen a écrit : >> On 7/14/09 3:57 PM, "n.putt...@gmail.com" wrote: >>> http://codereview.appspot.com/88155/diff/95/1147#newcode69 >>> Line 69: section 1.2.4 Beams, for more information. >>> Is it

Re: using LyricHyphens in the docs

2009-07-15 Thread Mark Polesky
Laura Conrad wrote: > Trevor> I know essentially nothing about ancient music, > Trevor> but as these examples were set by experts I assume > Trevor> they know what should be done. I doubt that > Trevor> ancient music was ever typeset using modern > Trevor> lyric spacing hyphen

Re: using LyricHyphens in the docs

2009-07-15 Thread Laura Conrad
> "Trevor" == Trevor Daniels writes: Trevor> Mark Polesky wrote Tuesday, July 14, 2009 7:38 AM >> I think the "Salve, "Regína" example in NR 2.8 "Ancient Notation" >> would be improved by using LyricHyphens. For example, instead of >> "Sal- ve, Re- gí- na," use "Sal -- ve, Re

Re: New format for autobeaming rules

2009-07-15 Thread John Mandereau
Le mercredi 15 juillet 2009 à 07:43 -0600, Carl Sorensen a écrit : > On 7/14/09 3:57 PM, "n.putt...@gmail.com" wrote: > > http://codereview.appspot.com/88155/diff/95/1147#newcode69 > > Line 69: section 1.2.4 Beams, for more information. > > Is it possible to use @ruser{} here? > > I'm not sure.

Re: Obsolete snippets

2009-07-15 Thread John Mandereau
Le lundi 13 juillet 2009 à 06:07 -0600, Carl Sorensen a écrit : > So, in order to not have broken documentation, I need to eliminate old file > referenes, and old in-line snippets as well. > > I guess I should just edit all of the Documentation/*/user/rhythms.itely and > delete the parts that have

Re: New format for autobeaming rules

2009-07-15 Thread Carl Sorensen
On 7/14/09 3:57 PM, "n.putt...@gmail.com" wrote: > Carl, I haven't commenting on them directly, but there are quite a few > indentation errors in the .scm files. Thanks for noticing. I went through and fixed them up. > > > http://codereview.appspot.com/88155/diff/95/1147 > File Documentat

[ANNOUNCE] Git User's Survey 2009 (fwd)

2009-07-15 Thread Johannes Schindelin
Hi, as every year, there is a user's survey about Git; Hopefully as every year, useful and fascinating ideas will crop up! Ciao, Johannes -- Forwarded message -- Date: Wed, 15 Jul 2009 09:22:32 +0200 From: Jakub Narebski To: g...@vger.kernel.org Subject: [ANNOUNCE] Git User's Su

Re: translation review requests -- texi2html's handling of @ignore blocks

2009-07-15 Thread Reinhold Kainhofer
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Am Montag, 13. Juli 2009 10:57:23 schrieb Jan Nieuwenhuizen: > Just talking to xorius on #lilypond about where the latest french > translations live for review... > > I realised it would be nice if texi2html would copy any @ignore @end > ignore blocks

Re: translation review requests -- texi2html's handling of @ignore blocks

2009-07-15 Thread John Mandereau
Le lundi 13 juillet 2009 à 10:57 +0200, Jan Nieuwenhuizen a écrit : > I realised it would be nice if texi2html would copy any @ignore @end > ignore blocks to html comments so that > you can easily check if the website is up to date. It would be even simpler if texi2html could even copy every comm

Re: Syntax changes in translated documentation

2009-07-15 Thread John Mandereau
Le mardi 14 juillet 2009 à 23:27 -0700, Graham Percival a écrit : > On Tue, Jul 14, 2009 at 04:23:52PM +0200, Jean-Charles Malahieude wrote: > > I'm going back to updating the "web" branch. > > I'm never certain how much translators know about the other > development stuff... just checking, you *d

Re: proposal for user view of docs

2009-07-15 Thread John Mandereau
Le samedi 11 juillet 2009 à 03:13 -0700, Graham Percival a écrit : > - the "website" is available in HTML, info, and pdf. If you type > "info lilypond", you get the website. Package managers might > create a lilypond-doc package consisting of the pdfs, or a local > copy of the HTML, or what

Re: proposal for user view of docs

2009-07-15 Thread Graham Percival
On Tue, Jul 14, 2009 at 11:29:42PM -0700, Patrick McCarty wrote: > On Sat, Jul 11, 2009 at 03:13:53AM -0700, Graham Percival wrote: > > There are a few modifications: > > - the top menu from the website might still present (I'm not > > certain if this would be a good idea or not) > >

Re: Adding note color handling to musicxml2ly

2009-07-15 Thread David Kastrup
Bret Aarden writes: >>> +def print_note_color (self, object, rgb=None): >>> +if rgb: >>> +str = ("\override %s #'color = #(rgb-color %s %s %s)" % >>> + (object, rgb[0], rgb[1], rgb[2])) >>> >> >> I suppose this should be \\override (i.e. escape the b