On 7/14/09 3:57 PM, "n.putt...@gmail.com" <n.putt...@gmail.com> wrote:
> Carl, I haven't commenting on them directly, but there are quite a few
> indentation errors in the .scm files.
Thanks for noticing. I went through and fixed them up.
>
>
> http://codereview.appspot.com/88155/diff/95/1147
> File Documentation/topdocs/NEWS.tely (right):
>
> http://codereview.appspot.com/88155/diff/95/1147#newcode69
> Line 69: section 1.2.4 Beams, for more information.
> Is it possible to use @ruser{} here?
I'm not sure. I thought NEWS was supposed to be a standalone document.
Graham, you're the source of all truth about documents; what do you think?
>
> http://codereview.appspot.com/88155/diff/95/1149
> File Documentation/user/rhythms.itely (right):
>
> http://codereview.appspot.com/88155/diff/95/1149#newcode1743
> Line 1743: Beam settings can be reverted to get back to default
> behavior. This
> This looks like it should be an input/new snippet.
I'm not sure I understand why you think it should it be in input/new instead
of just being in the docs. It doesn't use \set or \override. It explains
the use of a LilyPond command. That's why I thought it should be an inline
snippet.
>
> http://codereview.appspot.com/88155/diff/95/1155
> File input/lsr/conducting-signs,-measure-grouping-signs.ly (right):
>
> http://codereview.appspot.com/88155/diff/95/1155#newcode77
> Line 77: }
> missing %begin verbatim
>
> http://codereview.appspot.com/88155/diff/95/1155#newcode88
> Line 88: } % begin verbatim
> rogue %begin verbatim
OK, fixed -- trailing whitespace in the input/new version was confusing
makelsr.py.
Thanks again for the comments,
Carl
_______________________________________________
lilypond-devel mailing list
lilypond-devel@gnu.org
http://lists.gnu.org/mailman/listinfo/lilypond-devel
