Re: [Libreoffice] Autogen.sh pb with junit

2011-04-12 Thread Bjoern Michaelsen
On Wed, 13 Apr 2011 00:58:42 +0200 Miklos Vajna wrote: > > What improvement does the check have? You'd still fail here. The > > same as before. > > It's about giving a reasonable error message early before people try > to build with buggy junit which won't work. Which is: a) good for the LibreO

Re: [Libreoffice] Autogen.sh pb with junit

2011-04-12 Thread Miklos Vajna
On Wed, Apr 13, 2011 at 12:45:29AM +0200, Rene Engelhard wrote: > It looks OK code-wise, but TBH I don't see a sense in this. Distros should fix > their jars, we shouldn't hide problems. > And if the problem is widespread - so be it. One more reason to get distro > maintainers fix it. > > What i

Re: [Libreoffice] Autogen.sh pb with junit

2011-04-12 Thread Rene Engelhard
Hi, On Mon, Apr 11, 2011 at 11:36:39AM +0200, Miklos Vajna wrote: > On Wed, Apr 06, 2011 at 01:07:43PM +0200, Miklos Vajna > wrote: > > I'm attaching a patch that tries to implement this. > > > > I've tested with our (Frugalware) junit jar where the classpath is in > > manifest and also with up

Re: [Libreoffice] Autogen.sh pb with junit

2011-04-11 Thread Miklos Vajna
On Wed, Apr 06, 2011 at 01:07:43PM +0200, Miklos Vajna wrote: > I'm attaching a patch that tries to implement this. > > I've tested with our (Frugalware) junit jar where the classpath is in > manifest and also with upstream junit jar, which bundles hamcrest. > > OK to push to libreoffice-3-4?

Re: [Libreoffice] Autogen.sh pb with junit

2011-04-06 Thread Michael Meeks
Hi Jonathan, On Wed, 2011-04-06 at 13:35 +0200, Jonathan Aquilina wrote: > Have you tested in master before pushing it to 3-4. I think its best Please read the minutes of the last TSC meeting. Bug fixes are welcome in libreoffice-3-4 without any form of approval until further not

Re: [Libreoffice] Autogen.sh pb with junit

2011-04-06 Thread Jonathan Aquilina
On 06/04/2011 13:07, Miklos Vajna wrote: On Mon, Apr 04, 2011 at 11:22:52AM +0200, Bjoern Michaelsen wrote: On current debians (I just tried sid) and Ubuntus there is the no classpath set in the system junit jar that also does not contain hamcrest. Since this problem is widespread: How about c

Re: [Libreoffice] Autogen.sh pb with junit

2011-04-06 Thread Miklos Vajna
On Mon, Apr 04, 2011 at 11:22:52AM +0200, Bjoern Michaelsen wrote: > On current debians (I just tried sid) and Ubuntus there is the no > classpath set in the system junit jar that also does not contain > hamcrest. Since this problem is widespread: How about checking, if > either: > > - the jar

Re: [Libreoffice] Autogen.sh pb with junit

2011-04-04 Thread Bjoern Michaelsen
On Sun, 3 Apr 2011 16:54:28 +0200 Miklos Vajna wrote: > Rene also suggested that the dependency can be declared in junit's > manifest file, which is the place where this is fixed e.g. in Debian, > so my configure change turned out to be unnecessary. On current debians (I just tried sid) and Ubun

Re: [Libreoffice] Autogen.sh pb with junit

2011-04-03 Thread Miklos Vajna
[ My email address it .org, not .com. ] On Sun, Apr 03, 2011 at 08:36:45AM +0200, Julien Nabet wrote: > So for the moment, i put the hamcrest lines in comment but I'd like to > understand how the hamcrest lines could work or what is the problem with > my config. Thanks for pointing out, I jus

Re: [Libreoffice] Autogen.sh pb with junit

2011-04-03 Thread Jonathan Aquilina
On 03/04/2011 15:22, Julien Nabet wrote: Le 04/04/2011 15:14, Jonathan Aquilina a écrit : On 03/04/2011 15:07, Julien Nabet wrote: Le 04/04/2011 15:00, Jonathan Aquilina a écrit : On 03/04/2011 14:57, Julien wrote: Hello, Maybe, we can help. Could you tell us more about your config ? What's

Re: [Libreoffice] Autogen.sh pb with junit

2011-04-03 Thread Julien Nabet
Le 04/04/2011 15:14, Jonathan Aquilina a écrit : On 03/04/2011 15:07, Julien Nabet wrote: Le 04/04/2011 15:00, Jonathan Aquilina a écrit : On 03/04/2011 14:57, Julien wrote: Hello, Maybe, we can help. Could you tell us more about your config ? What's the result of this command ? which java J

Re: [Libreoffice] Autogen.sh pb with junit

2011-04-03 Thread Jonathan Aquilina
On 03/04/2011 15:07, Julien Nabet wrote: Le 04/04/2011 15:00, Jonathan Aquilina a écrit : On 03/04/2011 14:57, Julien wrote: Hello, Maybe, we can help. Could you tell us more about your config ? What's the result of this command ? which java Julien. i usually pass --without-junit switch which

Re: [Libreoffice] Autogen.sh pb with junit

2011-04-03 Thread Julien Nabet
Le 04/04/2011 15:00, Jonathan Aquilina a écrit : On 03/04/2011 14:57, Julien wrote: Hello, Maybe, we can help. Could you tell us more about your config ? What's the result of this command ? which java Julien. i usually pass --without-junit switch which it tells us we can pass and dont even co

Re: [Libreoffice] Autogen.sh pb with junit

2011-04-03 Thread Jonathan Aquilina
On 03/04/2011 14:57, Julien wrote: Hello, Maybe, we can help. Could you tell us more about your config ? What's the result of this command ? which java Julien. i usually pass --without-junit switch which it tells us we can pass and dont even compile the unit tests. As i mentioned before, is th

Re: [Libreoffice] Autogen.sh pb with junit

2011-04-03 Thread Julien
Hello, Maybe, we can help. Could you tell us more about your config ? What's the result of this command ? which java Julien. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] Autogen.sh pb with junit

2011-04-02 Thread Jonathan Aquilina
On 03/04/2011 08:36, Julien Nabet wrote: Hello, Since 2 days, i've been got this pb when I call ./autogen.sh : checking for JUnit 4... no configure: error: cannot find JUnit 4 jar; please install one in the default location (/usr/share/java), specify its pathname via --with-junit=..., or disab

[Libreoffice] Autogen.sh pb with junit

2011-04-02 Thread Julien Nabet
Hello, Since 2 days, i've been got this pb when I call ./autogen.sh : checking for JUnit 4... no configure: error: cannot find JUnit 4 jar; please install one in the default location (/usr/share/java), specify its pathname via --with-junit=..., or disable it via --without-junit On my config, the